WARNING: line length of 81 exceeds 80 columns #131: FILE: tools/testing/selftests/bpf/prog_tests/sockmap_interrupted_connect.c:105: +#define __TEST_RECONNECT_ADDR(addr_struct, mangle, mangle_s) \ CHECK: Macro argument 'addr_struct' may be better as '(addr_struct)' to avoid precedence issues #131: FILE: tools/testing/selftests/bpf/prog_tests/sockmap_interrupted_connect.c:105: +#define __TEST_RECONNECT_ADDR(addr_struct, mangle, mangle_s) \ + ({ \ + char str[MAX_TEST_NAME * 2]; \ + \ + memcpy(&ctx->bad, &ctx->addr, ctx->alen); \ + ((struct addr_struct *)&ctx->bad)->mangle; \ + \ + snprintf(str, sizeof(str), "%s %-24.24s ", ctx->str, mangle_s); \ + if (test__start_subtest(str)) \ + test_reconnect(ctx); \ + }) CHECK: Macro argument 'mangle' may be better as '(mangle)' to avoid precedence issues #131: FILE: tools/testing/selftests/bpf/prog_tests/sockmap_interrupted_connect.c:105: +#define __TEST_RECONNECT_ADDR(addr_struct, mangle, mangle_s) \ + ({ \ + char str[MAX_TEST_NAME * 2]; \ + \ + memcpy(&ctx->bad, &ctx->addr, ctx->alen); \ + ((struct addr_struct *)&ctx->bad)->mangle; \ + \ + snprintf(str, sizeof(str), "%s %-24.24s ", ctx->str, mangle_s); \ + if (test__start_subtest(str)) \ + test_reconnect(ctx); \ + }) WARNING: line length of 81 exceeds 80 columns #132: FILE: tools/testing/selftests/bpf/prog_tests/sockmap_interrupted_connect.c:106: + ({ \ WARNING: line length of 81 exceeds 80 columns #133: FILE: tools/testing/selftests/bpf/prog_tests/sockmap_interrupted_connect.c:107: + char str[MAX_TEST_NAME * 2]; \ WARNING: line length of 81 exceeds 80 columns #134: FILE: tools/testing/selftests/bpf/prog_tests/sockmap_interrupted_connect.c:108: + \ WARNING: line length of 81 exceeds 80 columns #135: FILE: tools/testing/selftests/bpf/prog_tests/sockmap_interrupted_connect.c:109: + memcpy(&ctx->bad, &ctx->addr, ctx->alen); \ WARNING: line length of 81 exceeds 80 columns #136: FILE: tools/testing/selftests/bpf/prog_tests/sockmap_interrupted_connect.c:110: + ((struct addr_struct *)&ctx->bad)->mangle; \ WARNING: line length of 81 exceeds 80 columns #137: FILE: tools/testing/selftests/bpf/prog_tests/sockmap_interrupted_connect.c:111: + \ WARNING: line length of 81 exceeds 80 columns #138: FILE: tools/testing/selftests/bpf/prog_tests/sockmap_interrupted_connect.c:112: + snprintf(str, sizeof(str), "%s %-24.24s ", ctx->str, mangle_s); \ WARNING: line length of 81 exceeds 80 columns #139: FILE: tools/testing/selftests/bpf/prog_tests/sockmap_interrupted_connect.c:113: + if (test__start_subtest(str)) \ WARNING: line length of 81 exceeds 80 columns #140: FILE: tools/testing/selftests/bpf/prog_tests/sockmap_interrupted_connect.c:114: + test_reconnect(ctx); \ WARNING: line length of 81 exceeds 80 columns #143: FILE: tools/testing/selftests/bpf/prog_tests/sockmap_interrupted_connect.c:117: +#define TEST_RECONNECT_ADDR(addr_struct, mangle) \ WARNING: line length of 87 exceeds 80 columns #186: FILE: tools/testing/selftests/bpf/prog_tests/sockmap_interrupted_connect.c:160: + // { AF_UNIX, SOCK_SEQPACKET }, /* see unix_dgram_bpf_update_proto() */ WARNING: line length of 82 exceeds 80 columns #188: FILE: tools/testing/selftests/bpf/prog_tests/sockmap_interrupted_connect.c:162: + // { AF_VSOCK, SOCK_DGRAM }, /* see vsock_bpf_update_proto() */ WARNING: line length of 81 exceeds 80 columns #192: FILE: tools/testing/selftests/bpf/prog_tests/sockmap_interrupted_connect.c:166: + ctx->map = bpf_map_create(type, NULL, sizeof(int), sizeof(int), 1, NULL); total: 0 errors, 14 warnings, 2 checks, 200 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Commit e00cd63a9414 ("selftests/bpf: Add test for connect() racing sockmap update and signal") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE FILE_PATH_CHANGES GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. total: 0 errors, 14 warnings, 2 checks, 200 lines checked