CHECK: spaces preferred around that '/' (ctx:VxV) #112: FILE: tools/testing/selftests/bpf/prog_tests/bpftool_maps_access.c:57: + for (i = 0; i < sizeof(maps)/sizeof(struct bpf_map *); i++) { ^ CHECK: Alignment should match open parenthesis #125: FILE: tools/testing/selftests/bpf/prog_tests/bpftool_maps_access.c:70: + ret = bpf_map__update_elem(skel->maps.prot_status_map, &key, + sizeof(key), &value, sizeof(value), 0); CHECK: Alignment should match open parenthesis #146: FILE: tools/testing/selftests/bpf/prog_tests/bpftool_maps_access.c:91: +static void update_test_desc(struct security_bpf_map *skel, + struct test_desc *test) WARNING: line length of 84 exceeds 80 columns #167: FILE: tools/testing/selftests/bpf/prog_tests/bpftool_maps_access.c:112: + ret = snprintf(desc->pin_path, PATH_MAX_LEN, "%s/%s", BPFFS_PIN_DIR, CHECK: Alignment should match open parenthesis #168: FILE: tools/testing/selftests/bpf/prog_tests/bpftool_maps_access.c:113: + ret = snprintf(desc->pin_path, PATH_MAX_LEN, "%s/%s", BPFFS_PIN_DIR, + desc->name); CHECK: Alignment should match open parenthesis #191: FILE: tools/testing/selftests/bpf/prog_tests/bpftool_maps_access.c:136: + ret = snprintf(cmd, MAX_BPFTOOL_CMD_LEN, "map lookup %s key 0 0 0 0", + map_handle); CHECK: Alignment should match open parenthesis #203: FILE: tools/testing/selftests/bpf/prog_tests/bpftool_maps_access.c:148: + ret = snprintf(cmd, MAX_BPFTOOL_CMD_LEN, "btf dump map %s", + map_handle); CHECK: Please don't use multiple blank lines #238: FILE: tools/testing/selftests/bpf/prog_tests/bpftool_maps_access.c:183: + + CHECK: Lines should not end with a '(' #261: FILE: tools/testing/selftests/bpf/prog_tests/bpftool_maps_access.c:206: + ret = snprintf( CHECK: Lines should not end with a '(' #275: FILE: tools/testing/selftests/bpf/prog_tests/bpftool_maps_access.c:220: + ret = snprintf( CHECK: Lines should not end with a '(' #300: FILE: tools/testing/selftests/bpf/prog_tests/bpftool_maps_access.c:245: + ret = snprintf( total: 0 errors, 1 warnings, 10 checks, 378 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Commit 36c8aef285ca ("selftests/bpf: convert test_bpftool_map_access.sh into test_progs framework") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE FILE_PATH_CHANGES GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. total: 0 errors, 1 warnings, 10 checks, 378 lines checked