CHECK: spaces preferred around that '*' (ctx:VxV) #75: FILE: tools/testing/selftests/bpf/prog_tests/bpftool_metadata.c:18: +#define MAX_BPFTOOL_OUTPUT_LEN (64*1024) ^ CHECK: Alignment should match open parenthesis #116: FILE: tools/testing/selftests/bpf/prog_tests/bpftool_metadata.c:59: + ret = snprintf(cmd, MAX_BPFTOOL_CMD_LEN, "prog load %s %s", + test->bpf_prog, test->bpffs_path); CHECK: Alignment should match open parenthesis #129: FILE: tools/testing/selftests/bpf/prog_tests/bpftool_metadata.c:72: + ret = get_bpftool_command_output(cmd, output, + MAX_BPFTOOL_OUTPUT_LEN); CHECK: Alignment should match open parenthesis #132: FILE: tools/testing/selftests/bpf/prog_tests/bpftool_metadata.c:75: + ret = check_metadata(output, test->expected_output, + ARRAY_SIZE(test->expected_output)); CHECK: Alignment should match open parenthesis #145: FILE: tools/testing/selftests/bpf/prog_tests/bpftool_metadata.c:88: + ret = check_metadata(output, test->expected_output_json, + ARRAY_SIZE(test->expected_output_json)); CHECK: Blank lines aren't necessary before a close brace '}' #149: FILE: tools/testing/selftests/bpf/prog_tests/bpftool_metadata.c:92: + +} CHECK: Please use a blank line after function/struct/union/enum declarations #177: FILE: tools/testing/selftests/bpf/prog_tests/bpftool_metadata.c:120: +}; +static const int tests_count = ARRAY_SIZE(tests); total: 0 errors, 0 warnings, 7 checks, 141 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Commit 9e7247b3901a ("selftests/bpf: convert test_bpftool_metadata.sh into test_progs framework") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE FILE_PATH_CHANGES GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. total: 0 errors, 0 warnings, 7 checks, 141 lines checked