ShellCheck - shell script analysis tool
version: 0.11.0
license: GNU General Public License, version 3
website: https://www.shellcheck.net
Redirect to /tmp/tmp.lN1J3039wP and /tmp/tmp.af71WjaC39
Tree base:
6fe2d40eebc2 ("hsr: Implement more robust duplicate discard for HSR")
Now at:
c3d35875bc29 ("selftests: hsr: Add more link fault tests for HSR")
 ====== Checking before the patch ======
Checking tools/testing/selftests/net/hsr/hsr_ping.sh - 5293a5cd9ad2d3974447f3107cee3aaec92822c2a0453c8aa65339049c431fdf


In hsr_ping.sh line 17:
		usage $0
                      ^-- SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
		usage "$0"


In hsr_ping.sh line 24:
		usage $0
                      ^-- SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
		usage "$0"


In hsr_ping.sh line 38:
	do_ping "$ns1" "100.64.$netid.2"
                 ^--^ SC2154 (warning): ns1 is referenced but not assigned.


In hsr_ping.sh line 40:
	do_ping "$ns2" "100.64.$netid.1"
                 ^--^ SC2154 (warning): ns2 is referenced but not assigned.


In hsr_ping.sh line 42:
	do_ping "$ns3" "100.64.$netid.1"
                 ^--^ SC2154 (warning): ns3 is referenced but not assigned.


In hsr_ping.sh line 62:
		if [ $? -ne 0 ]
                     ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.


In hsr_ping.sh line 67:
		let "WAIT = WAIT - 1"
                ^------------------^ SC2219 (style): Instead of 'let expr', prefer (( expr )) .

For more information:
  https://www.shellcheck.net/wiki/SC2154 -- ns1 is referenced but not assigned.
  https://www.shellcheck.net/wiki/SC2086 -- Double quote to prevent globbing ...
  https://www.shellcheck.net/wiki/SC2181 -- Check exit code directly with e.g...

Checking tools/testing/selftests/net/hsr/link_faults.sh - 77a351b1f35657858e31b0b6867e4b13a5f8a4ee9b8ea2061f02159dca6f12c9


In link_faults.sh line 46:
	ip link add vethA netns "$node1" type veth peer name vethB netns "$node2"
                                 ^----^ SC2154 (warning): node1 is referenced but not assigned (did you mean 'node'?).
                                                                          ^----^ SC2154 (warning): node2 is referenced but not assigned (did you mean 'node'?).


In link_faults.sh line 47:
	ip link add vethA netns "$node2" type veth peer name vethB netns "$node3"
                                                                          ^----^ SC2154 (warning): node3 is referenced but not assigned (did you mean 'node'?).

For more information:
  https://www.shellcheck.net/wiki/SC2154 -- node1 is referenced but not assig...

 ====== Checking the tree with the patch ======
Checking tools/testing/selftests/net/hsr/hsr_ping.sh - 5293a5cd9ad2d3974447f3107cee3aaec92822c2a0453c8aa65339049c431fdf


In hsr_ping.sh line 17:
		usage $0
                      ^-- SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
		usage "$0"


In hsr_ping.sh line 24:
		usage $0
                      ^-- SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
		usage "$0"


In hsr_ping.sh line 38:
	do_ping "$ns1" "100.64.$netid.2"
                 ^--^ SC2154 (warning): ns1 is referenced but not assigned.


In hsr_ping.sh line 40:
	do_ping "$ns2" "100.64.$netid.1"
                 ^--^ SC2154 (warning): ns2 is referenced but not assigned.


In hsr_ping.sh line 42:
	do_ping "$ns3" "100.64.$netid.1"
                 ^--^ SC2154 (warning): ns3 is referenced but not assigned.


In hsr_ping.sh line 62:
		if [ $? -ne 0 ]
                     ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.


In hsr_ping.sh line 67:
		let "WAIT = WAIT - 1"
                ^------------------^ SC2219 (style): Instead of 'let expr', prefer (( expr )) .

For more information:
  https://www.shellcheck.net/wiki/SC2154 -- ns1 is referenced but not assigned.
  https://www.shellcheck.net/wiki/SC2086 -- Double quote to prevent globbing ...
  https://www.shellcheck.net/wiki/SC2181 -- Check exit code directly with e.g...

Checking tools/testing/selftests/net/hsr/link_faults.sh - 77a351b1f35657858e31b0b6867e4b13a5f8a4ee9b8ea2061f02159dca6f12c9


In link_faults.sh line 54:
	ip link add vethA netns "$node1" type veth peer name vethB netns "$node2"
                                 ^----^ SC2154 (warning): node1 is referenced but not assigned (did you mean 'node'?).
                                                                          ^----^ SC2154 (warning): node2 is referenced but not assigned (did you mean 'node'?).


In link_faults.sh line 55:
	ip link add vethA netns "$node2" type veth peer name vethB netns "$node3"
                                                                          ^----^ SC2154 (warning): node3 is referenced but not assigned (did you mean 'node'?).

For more information:
  https://www.shellcheck.net/wiki/SC2154 -- node1 is referenced but not assig...