ShellCheck - shell script analysis tool
version: 0.11.0
license: GNU General Public License, version 3
website: https://www.shellcheck.net
Redirect to /tmp/tmp.WUHjmrCshL and /tmp/tmp.cIaN63iflp
Tree base:
77b9c4a438fc ("Merge branch 'netkit-support-for-io_uring-zero-copy-and-af_xdp'")
Now at:
f8bb20b0eed6 ("selftests: netfilter: avoid RULE_REPLACE error when zeroing rule counters")
 ====== Checking before the patch ======
Checking tools/testing/selftests/net/netfilter/rpath.sh - 390190ae7446f5837181fe7518037e7c576daaddc0357dee31847ff97387a5d7


In rpath.sh line 38:
ip netns exec "$ns2" sysctl -q net.ipv6.conf.all.keep_addr_on_down=1
               ^--^ SC2154 (warning): ns2 is referenced but not assigned.


In rpath.sh line 41:
ip -net "$ns1" link add v0 type veth peer name v0 netns "$ns2"
         ^--^ SC2154 (warning): ns1 is referenced but not assigned.


In rpath.sh line 70:
	if ! ip netns exec "$ns2" "$iptables" $common -m rpfilter;then
                                              ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	if ! ip netns exec "$ns2" "$iptables" "$common" -m rpfilter;then


In rpath.sh line 74:
	ip netns exec "$ns2" "$iptables" $common -m rpfilter --invert
                                         ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	ip netns exec "$ns2" "$iptables" "$common" -m rpfilter --invert


In rpath.sh line 79:
	if ! ip netns exec "$ns2" "$ip6tables" $common -m rpfilter;then
                                               ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	if ! ip netns exec "$ns2" "$ip6tables" "$common" -m rpfilter;then


In rpath.sh line 83:
	ip netns exec "$ns2" "$ip6tables" $common -m rpfilter --invert
                                          ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	ip netns exec "$ns2" "$ip6tables" "$common" -m rpfilter --invert

For more information:
  https://www.shellcheck.net/wiki/SC2154 -- ns1 is referenced but not assigned.
  https://www.shellcheck.net/wiki/SC2086 -- Double quote to prevent globbing ...

 ====== Checking the tree with the patch ======
Checking tools/testing/selftests/net/netfilter/rpath.sh - 390190ae7446f5837181fe7518037e7c576daaddc0357dee31847ff97387a5d7


In rpath.sh line 38:
ip netns exec "$ns2" sysctl -q net.ipv6.conf.all.keep_addr_on_down=1
               ^--^ SC2154 (warning): ns2 is referenced but not assigned.


In rpath.sh line 41:
ip -net "$ns1" link add v0 type veth peer name v0 netns "$ns2"
         ^--^ SC2154 (warning): ns1 is referenced but not assigned.


In rpath.sh line 70:
	if ! ip netns exec "$ns2" "$iptables" $common -m rpfilter;then
                                              ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	if ! ip netns exec "$ns2" "$iptables" "$common" -m rpfilter;then


In rpath.sh line 74:
	ip netns exec "$ns2" "$iptables" $common -m rpfilter --invert
                                         ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	ip netns exec "$ns2" "$iptables" "$common" -m rpfilter --invert


In rpath.sh line 79:
	if ! ip netns exec "$ns2" "$ip6tables" $common -m rpfilter;then
                                               ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	if ! ip netns exec "$ns2" "$ip6tables" "$common" -m rpfilter;then


In rpath.sh line 83:
	ip netns exec "$ns2" "$ip6tables" $common -m rpfilter --invert
                                          ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	ip netns exec "$ns2" "$ip6tables" "$common" -m rpfilter --invert


In rpath.sh line 132:
			while read rulenum; do
                              ^--^ SC2162 (info): read without -r will mangle backslashes.


In rpath.sh line 141:
			while read rulenum; do
                              ^--^ SC2162 (info): read without -r will mangle backslashes.

For more information:
  https://www.shellcheck.net/wiki/SC2154 -- ns1 is referenced but not assigned.
  https://www.shellcheck.net/wiki/SC2086 -- Double quote to prevent globbing ...
  https://www.shellcheck.net/wiki/SC2162 -- read without -r will mangle backs...