ShellCheck - shell script analysis tool
version: 0.11.0
license: GNU General Public License, version 3
website: https://www.shellcheck.net
Redirect to /tmp/tmp.iI37yoFoWG and /tmp/tmp.eiA39gCtvD
Tree base:
9120df11c80e ("selftests: net: run pmtu.sh in netns to avoid host firewall interference")
Now at:
4963dec307b1 ("selftests: net: io_uring_zerocopy: enable io_uring for the test")
 ====== Checking before the patch ======
Checking tools/testing/selftests/net/io_uring_zerocopy_tx.sh - cb032826bc8f8caf03299a53b27f95f0a5b4eaa75be1d0d991708f81e2202b7a


In io_uring_zerocopy_tx.sh line 13:
readonly RAND="$(mktemp -u XXXXXX)"
         ^--^ SC2155 (warning): Declare and assign separately to avoid masking return values.


In io_uring_zerocopy_tx.sh line 50:
readonly EXTRA_ARGS="$@"
                    ^--^ SC2124 (warning): Assigning an array to a string! Assign as array, or use * instead of @ to concatenate.


In io_uring_zerocopy_tx.sh line 116:
	local readonly ARGS="$1"
              ^------^ SC2316 (error): This applies local to the variable named readonly, which is probably not what you want. Use a separate command or the appropriate `declare` options instead.
              ^------^ SC2034 (warning): readonly appears unused. Verify use (or export if used externally).


In io_uring_zerocopy_tx.sh line 121:
	ip netns exec "${NS1}" "${BIN_TX}" "-${IP}" -t 1 -D "${DADDR}" ${ARGS} "${TXMODE}"
                                                                       ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	ip netns exec "${NS1}" "${BIN_TX}" "-${IP}" -t 1 -D "${DADDR}" "${ARGS}" "${TXMODE}"

For more information:
  https://www.shellcheck.net/wiki/SC2316 -- This applies local to the variabl...
  https://www.shellcheck.net/wiki/SC2034 -- readonly appears unused. Verify u...
  https://www.shellcheck.net/wiki/SC2124 -- Assigning an array to a string! A...

 ====== Checking the tree with the patch ======
Checking tools/testing/selftests/net/io_uring_zerocopy_tx.sh - cb032826bc8f8caf03299a53b27f95f0a5b4eaa75be1d0d991708f81e2202b7a


In io_uring_zerocopy_tx.sh line 13:
readonly RAND="$(mktemp -u XXXXXX)"
         ^--^ SC2155 (warning): Declare and assign separately to avoid masking return values.


In io_uring_zerocopy_tx.sh line 50:
readonly EXTRA_ARGS="$@"
                    ^--^ SC2124 (warning): Assigning an array to a string! Assign as array, or use * instead of @ to concatenate.


In io_uring_zerocopy_tx.sh line 120:
	local readonly ARGS="$1"
              ^------^ SC2316 (error): This applies local to the variable named readonly, which is probably not what you want. Use a separate command or the appropriate `declare` options instead.
              ^------^ SC2034 (warning): readonly appears unused. Verify use (or export if used externally).


In io_uring_zerocopy_tx.sh line 125:
	ip netns exec "${NS1}" "${BIN_TX}" "-${IP}" -t 1 -D "${DADDR}" ${ARGS} "${TXMODE}"
                                                                       ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	ip netns exec "${NS1}" "${BIN_TX}" "-${IP}" -t 1 -D "${DADDR}" "${ARGS}" "${TXMODE}"

For more information:
  https://www.shellcheck.net/wiki/SC2316 -- This applies local to the variabl...
  https://www.shellcheck.net/wiki/SC2034 -- readonly appears unused. Verify u...
  https://www.shellcheck.net/wiki/SC2124 -- Assigning an array to a string! A...