ShellCheck - shell script analysis tool version: 0.11.0 license: GNU General Public License, version 3 website: https://www.shellcheck.net Redirect to /tmp/tmp.5JJwgktDCh and /tmp/tmp.MxUtKWP8He Tree base: a2d4e9f89f89 ("selftests: forwarding: lib: add run_cmd_grep helper for feature probing") Now at: 8e6b679bb516 ("selftests: forwarding: tc_flower_cfm: skip tests if tools or feats are missing") ====== Checking before the patch ====== Checking tools/testing/selftests/net/forwarding/tc_flower_cfm.sh - 5c092ce66c0f07bbdec605badcff8a27219ba227023f9515546e63f4ecf7e9a2 In tc_flower_cfm.sh line 11: simple_if_init $h1 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: simple_if_init "$h1" In tc_flower_cfm.sh line 14: h1_destroy() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In tc_flower_cfm.sh line 16: simple_if_fini $h1 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: simple_if_fini "$h1" In tc_flower_cfm.sh line 21: simple_if_init $h2 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: simple_if_init "$h2" In tc_flower_cfm.sh line 22: tc qdisc add dev $h2 clsact ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc qdisc add dev "$h2" clsact In tc_flower_cfm.sh line 25: h2_destroy() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In tc_flower_cfm.sh line 27: tc qdisc del dev $h2 clsact ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc qdisc del dev "$h2" clsact In tc_flower_cfm.sh line 28: simple_if_fini $h2 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: simple_if_fini "$h2" In tc_flower_cfm.sh line 31: u8_to_hex() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In tc_flower_cfm.sh line 35: printf "%02x" $u8 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: printf "%02x" "$u8" In tc_flower_cfm.sh line 38: generate_cfm_hdr() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In tc_flower_cfm.sh line 45: local cfm_hdr=$(: ^-----^ SC2155 (warning): Declare and assign separately to avoid masking return values. In tc_flower_cfm.sh line 46: )"$(u8_to_hex $((mdl << 5))):"$( : MD level and Version ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them. In tc_flower_cfm.sh line 47: )"$(u8_to_hex $op):"$( : OpCode ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them. Did you mean: )"$(u8_to_hex "$op"):"$( : OpCode In tc_flower_cfm.sh line 48: )"$(u8_to_hex $flags):"$( : Flags ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them. Did you mean: )"$(u8_to_hex "$flags"):"$( : Flags In tc_flower_cfm.sh line 49: )"$(u8_to_hex $tlv_offset)"$( : TLV offset ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: )"$(u8_to_hex "$tlv_offset")"$( : TLV offset In tc_flower_cfm.sh line 52: echo $cfm_hdr ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: echo "$cfm_hdr" In tc_flower_cfm.sh line 55: match_cfm_opcode() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In tc_flower_cfm.sh line 60: tc filter add dev $h2 ingress protocol cfm pref 1 handle 101 \ ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc filter add dev "$h2" ingress protocol cfm pref 1 handle 101 \ In tc_flower_cfm.sh line 62: tc filter add dev $h2 ingress protocol cfm pref 1 handle 102 \ ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc filter add dev "$h2" ingress protocol cfm pref 1 handle 102 \ In tc_flower_cfm.sh line 66: $MZ $h1 -c 1 -p 64 -a $h1mac -b $h2mac "$pkt" -q ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: $MZ "$h1" -c 1 -p 64 -a "$h1mac" -b "$h2mac" "$pkt" -q In tc_flower_cfm.sh line 68: $MZ $h1 -c 1 -p 64 -a $h1mac -b $h2mac "$pkt" -q ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: $MZ "$h1" -c 1 -p 64 -a "$h1mac" -b "$h2mac" "$pkt" -q In tc_flower_cfm.sh line 77: $MZ $h1 -c 1 -p 64 -a $h1mac -b $h2mac "$pkt" -q ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: $MZ "$h1" -c 1 -p 64 -a "$h1mac" -b "$h2mac" "$pkt" -q In tc_flower_cfm.sh line 85: tc filter del dev $h2 ingress protocol cfm pref 1 handle 101 flower ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc filter del dev "$h2" ingress protocol cfm pref 1 handle 101 flower In tc_flower_cfm.sh line 86: tc filter del dev $h2 ingress protocol cfm pref 1 handle 102 flower ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc filter del dev "$h2" ingress protocol cfm pref 1 handle 102 flower In tc_flower_cfm.sh line 91: match_cfm_level() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In tc_flower_cfm.sh line 96: tc filter add dev $h2 ingress protocol cfm pref 1 handle 101 \ ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc filter add dev "$h2" ingress protocol cfm pref 1 handle 101 \ In tc_flower_cfm.sh line 98: tc filter add dev $h2 ingress protocol cfm pref 1 handle 102 \ ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc filter add dev "$h2" ingress protocol cfm pref 1 handle 102 \ In tc_flower_cfm.sh line 100: tc filter add dev $h2 ingress protocol cfm pref 1 handle 103 \ ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc filter add dev "$h2" ingress protocol cfm pref 1 handle 103 \ In tc_flower_cfm.sh line 104: $MZ $h1 -c 1 -p 64 -a $h1mac -b $h2mac "$pkt" -q ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: $MZ "$h1" -c 1 -p 64 -a "$h1mac" -b "$h2mac" "$pkt" -q In tc_flower_cfm.sh line 106: $MZ $h1 -c 1 -p 64 -a $h1mac -b $h2mac "$pkt" -q ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: $MZ "$h1" -c 1 -p 64 -a "$h1mac" -b "$h2mac" "$pkt" -q In tc_flower_cfm.sh line 108: $MZ $h1 -c 1 -p 64 -a $h1mac -b $h2mac "$pkt" -q ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: $MZ "$h1" -c 1 -p 64 -a "$h1mac" -b "$h2mac" "$pkt" -q In tc_flower_cfm.sh line 120: $MZ $h1 -c 1 -p 64 -a $h1mac -b $h2mac "$pkt" -q ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: $MZ "$h1" -c 1 -p 64 -a "$h1mac" -b "$h2mac" "$pkt" -q In tc_flower_cfm.sh line 131: tc filter del dev $h2 ingress protocol cfm pref 1 handle 101 flower ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc filter del dev "$h2" ingress protocol cfm pref 1 handle 101 flower In tc_flower_cfm.sh line 132: tc filter del dev $h2 ingress protocol cfm pref 1 handle 102 flower ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc filter del dev "$h2" ingress protocol cfm pref 1 handle 102 flower In tc_flower_cfm.sh line 133: tc filter del dev $h2 ingress protocol cfm pref 1 handle 103 flower ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc filter del dev "$h2" ingress protocol cfm pref 1 handle 103 flower In tc_flower_cfm.sh line 138: match_cfm_level_and_opcode() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In tc_flower_cfm.sh line 143: tc filter add dev $h2 ingress protocol cfm pref 1 handle 101 \ ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc filter add dev "$h2" ingress protocol cfm pref 1 handle 101 \ In tc_flower_cfm.sh line 145: tc filter add dev $h2 ingress protocol cfm pref 1 handle 102 \ ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc filter add dev "$h2" ingress protocol cfm pref 1 handle 102 \ In tc_flower_cfm.sh line 149: $MZ $h1 -c 1 -p 64 -a $h1mac -b $h2mac "$pkt" -q ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: $MZ "$h1" -c 1 -p 64 -a "$h1mac" -b "$h2mac" "$pkt" -q In tc_flower_cfm.sh line 151: $MZ $h1 -c 1 -p 64 -a $h1mac -b $h2mac "$pkt" -q ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: $MZ "$h1" -c 1 -p 64 -a "$h1mac" -b "$h2mac" "$pkt" -q In tc_flower_cfm.sh line 153: $MZ $h1 -c 1 -p 64 -a $h1mac -b $h2mac "$pkt" -q ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: $MZ "$h1" -c 1 -p 64 -a "$h1mac" -b "$h2mac" "$pkt" -q In tc_flower_cfm.sh line 162: $MZ $h1 -c 1 -p 64 -a $h1mac -b $h2mac "$pkt" -q ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: $MZ "$h1" -c 1 -p 64 -a "$h1mac" -b "$h2mac" "$pkt" -q In tc_flower_cfm.sh line 170: tc filter del dev $h2 ingress protocol cfm pref 1 handle 101 flower ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc filter del dev "$h2" ingress protocol cfm pref 1 handle 101 flower In tc_flower_cfm.sh line 171: tc filter del dev $h2 ingress protocol cfm pref 1 handle 102 flower ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc filter del dev "$h2" ingress protocol cfm pref 1 handle 102 flower In tc_flower_cfm.sh line 180: h1mac=$(mac_get $h1) ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: h1mac=$(mac_get "$h1") In tc_flower_cfm.sh line 181: h2mac=$(mac_get $h2) ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: h2mac=$(mac_get "$h2") In tc_flower_cfm.sh line 189: cleanup() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In tc_flower_cfm.sh line 206: exit $EXIT_STATUS ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: exit "$EXIT_STATUS" For more information: https://www.shellcheck.net/wiki/SC2027 -- The surrounding quotes actually u... https://www.shellcheck.net/wiki/SC2155 -- Declare and assign separately to ... https://www.shellcheck.net/wiki/SC2086 -- Double quote to prevent globbing ... ====== Checking the tree with the patch ====== Checking tools/testing/selftests/net/forwarding/tc_flower_cfm.sh - 5c092ce66c0f07bbdec605badcff8a27219ba227023f9515546e63f4ecf7e9a2 In tc_flower_cfm.sh line 11: simple_if_init $h1 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: simple_if_init "$h1" In tc_flower_cfm.sh line 14: h1_destroy() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In tc_flower_cfm.sh line 16: simple_if_fini $h1 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: simple_if_fini "$h1" In tc_flower_cfm.sh line 21: simple_if_init $h2 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: simple_if_init "$h2" In tc_flower_cfm.sh line 22: tc qdisc add dev $h2 clsact ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc qdisc add dev "$h2" clsact In tc_flower_cfm.sh line 25: h2_destroy() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In tc_flower_cfm.sh line 27: tc qdisc del dev $h2 clsact ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc qdisc del dev "$h2" clsact In tc_flower_cfm.sh line 28: simple_if_fini $h2 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: simple_if_fini "$h2" In tc_flower_cfm.sh line 31: u8_to_hex() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In tc_flower_cfm.sh line 35: printf "%02x" $u8 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: printf "%02x" "$u8" In tc_flower_cfm.sh line 38: generate_cfm_hdr() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In tc_flower_cfm.sh line 45: local cfm_hdr=$(: ^-----^ SC2155 (warning): Declare and assign separately to avoid masking return values. In tc_flower_cfm.sh line 46: )"$(u8_to_hex $((mdl << 5))):"$( : MD level and Version ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them. In tc_flower_cfm.sh line 47: )"$(u8_to_hex $op):"$( : OpCode ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them. Did you mean: )"$(u8_to_hex "$op"):"$( : OpCode In tc_flower_cfm.sh line 48: )"$(u8_to_hex $flags):"$( : Flags ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them. Did you mean: )"$(u8_to_hex "$flags"):"$( : Flags In tc_flower_cfm.sh line 49: )"$(u8_to_hex $tlv_offset)"$( : TLV offset ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: )"$(u8_to_hex "$tlv_offset")"$( : TLV offset In tc_flower_cfm.sh line 52: echo $cfm_hdr ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: echo "$cfm_hdr" In tc_flower_cfm.sh line 55: match_cfm_opcode() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In tc_flower_cfm.sh line 60: tc filter add dev $h2 ingress protocol cfm pref 1 handle 101 \ ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc filter add dev "$h2" ingress protocol cfm pref 1 handle 101 \ In tc_flower_cfm.sh line 62: tc filter add dev $h2 ingress protocol cfm pref 1 handle 102 \ ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc filter add dev "$h2" ingress protocol cfm pref 1 handle 102 \ In tc_flower_cfm.sh line 66: $MZ $h1 -c 1 -p 64 -a $h1mac -b $h2mac "$pkt" -q ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: $MZ "$h1" -c 1 -p 64 -a "$h1mac" -b "$h2mac" "$pkt" -q In tc_flower_cfm.sh line 68: $MZ $h1 -c 1 -p 64 -a $h1mac -b $h2mac "$pkt" -q ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: $MZ "$h1" -c 1 -p 64 -a "$h1mac" -b "$h2mac" "$pkt" -q In tc_flower_cfm.sh line 77: $MZ $h1 -c 1 -p 64 -a $h1mac -b $h2mac "$pkt" -q ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: $MZ "$h1" -c 1 -p 64 -a "$h1mac" -b "$h2mac" "$pkt" -q In tc_flower_cfm.sh line 85: tc filter del dev $h2 ingress protocol cfm pref 1 handle 101 flower ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc filter del dev "$h2" ingress protocol cfm pref 1 handle 101 flower In tc_flower_cfm.sh line 86: tc filter del dev $h2 ingress protocol cfm pref 1 handle 102 flower ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc filter del dev "$h2" ingress protocol cfm pref 1 handle 102 flower In tc_flower_cfm.sh line 91: match_cfm_level() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In tc_flower_cfm.sh line 96: tc filter add dev $h2 ingress protocol cfm pref 1 handle 101 \ ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc filter add dev "$h2" ingress protocol cfm pref 1 handle 101 \ In tc_flower_cfm.sh line 98: tc filter add dev $h2 ingress protocol cfm pref 1 handle 102 \ ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc filter add dev "$h2" ingress protocol cfm pref 1 handle 102 \ In tc_flower_cfm.sh line 100: tc filter add dev $h2 ingress protocol cfm pref 1 handle 103 \ ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc filter add dev "$h2" ingress protocol cfm pref 1 handle 103 \ In tc_flower_cfm.sh line 104: $MZ $h1 -c 1 -p 64 -a $h1mac -b $h2mac "$pkt" -q ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: $MZ "$h1" -c 1 -p 64 -a "$h1mac" -b "$h2mac" "$pkt" -q In tc_flower_cfm.sh line 106: $MZ $h1 -c 1 -p 64 -a $h1mac -b $h2mac "$pkt" -q ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: $MZ "$h1" -c 1 -p 64 -a "$h1mac" -b "$h2mac" "$pkt" -q In tc_flower_cfm.sh line 108: $MZ $h1 -c 1 -p 64 -a $h1mac -b $h2mac "$pkt" -q ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: $MZ "$h1" -c 1 -p 64 -a "$h1mac" -b "$h2mac" "$pkt" -q In tc_flower_cfm.sh line 120: $MZ $h1 -c 1 -p 64 -a $h1mac -b $h2mac "$pkt" -q ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: $MZ "$h1" -c 1 -p 64 -a "$h1mac" -b "$h2mac" "$pkt" -q In tc_flower_cfm.sh line 131: tc filter del dev $h2 ingress protocol cfm pref 1 handle 101 flower ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc filter del dev "$h2" ingress protocol cfm pref 1 handle 101 flower In tc_flower_cfm.sh line 132: tc filter del dev $h2 ingress protocol cfm pref 1 handle 102 flower ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc filter del dev "$h2" ingress protocol cfm pref 1 handle 102 flower In tc_flower_cfm.sh line 133: tc filter del dev $h2 ingress protocol cfm pref 1 handle 103 flower ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc filter del dev "$h2" ingress protocol cfm pref 1 handle 103 flower In tc_flower_cfm.sh line 138: match_cfm_level_and_opcode() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In tc_flower_cfm.sh line 143: tc filter add dev $h2 ingress protocol cfm pref 1 handle 101 \ ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc filter add dev "$h2" ingress protocol cfm pref 1 handle 101 \ In tc_flower_cfm.sh line 145: tc filter add dev $h2 ingress protocol cfm pref 1 handle 102 \ ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc filter add dev "$h2" ingress protocol cfm pref 1 handle 102 \ In tc_flower_cfm.sh line 149: $MZ $h1 -c 1 -p 64 -a $h1mac -b $h2mac "$pkt" -q ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: $MZ "$h1" -c 1 -p 64 -a "$h1mac" -b "$h2mac" "$pkt" -q In tc_flower_cfm.sh line 151: $MZ $h1 -c 1 -p 64 -a $h1mac -b $h2mac "$pkt" -q ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: $MZ "$h1" -c 1 -p 64 -a "$h1mac" -b "$h2mac" "$pkt" -q In tc_flower_cfm.sh line 153: $MZ $h1 -c 1 -p 64 -a $h1mac -b $h2mac "$pkt" -q ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: $MZ "$h1" -c 1 -p 64 -a "$h1mac" -b "$h2mac" "$pkt" -q In tc_flower_cfm.sh line 162: $MZ $h1 -c 1 -p 64 -a $h1mac -b $h2mac "$pkt" -q ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: $MZ "$h1" -c 1 -p 64 -a "$h1mac" -b "$h2mac" "$pkt" -q In tc_flower_cfm.sh line 170: tc filter del dev $h2 ingress protocol cfm pref 1 handle 101 flower ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc filter del dev "$h2" ingress protocol cfm pref 1 handle 101 flower In tc_flower_cfm.sh line 171: tc filter del dev $h2 ingress protocol cfm pref 1 handle 102 flower ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc filter del dev "$h2" ingress protocol cfm pref 1 handle 102 flower In tc_flower_cfm.sh line 180: h1mac=$(mac_get $h1) ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: h1mac=$(mac_get "$h1") In tc_flower_cfm.sh line 181: h2mac=$(mac_get $h2) ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: h2mac=$(mac_get "$h2") In tc_flower_cfm.sh line 189: cleanup() ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In tc_flower_cfm.sh line 208: exit $EXIT_STATUS ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: exit "$EXIT_STATUS" For more information: https://www.shellcheck.net/wiki/SC2027 -- The surrounding quotes actually u... https://www.shellcheck.net/wiki/SC2155 -- Declare and assign separately to ... https://www.shellcheck.net/wiki/SC2086 -- Double quote to prevent globbing ...