ShellCheck - shell script analysis tool version: 0.11.0 license: GNU General Public License, version 3 website: https://www.shellcheck.net Redirect to /tmp/tmp.OqymbYINUg and /tmp/tmp.5F2GJ5VV9v Tree base: 364cbb22d4b8 ("selftests: forwarding: lib: skip test if team driver is not supported") Now at: 61fe13652b86 ("selftests: forwarding: sch_ets: skip test if cls_basic module is missing") ====== Checking before the patch ====== Checking tools/testing/selftests/net/forwarding/sch_ets_core.sh - 91c0ef3e5c7c9ac93ca1d489ed11736ec497e2186b369d2b2b4c16148a492d69 In sch_ets_core.sh line 1: # SPDX-License-Identifier: GPL-2.0 ^-- SC2148 (error): Tips depend on target shell and yours is unknown. Add a shebang or a 'shell' directive. In sch_ets_core.sh line 63: source $lib_dir/lib.sh ^------^ SC2154 (warning): lib_dir is referenced but not assigned. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: source "$lib_dir"/lib.sh In sch_ets_core.sh line 64: source $lib_dir/sch_ets_tests.sh ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: source "$lib_dir"/sch_ets_tests.sh In sch_ets_core.sh line 82: local dst_mac=$(mac_get $h2) ^-----^ SC2155 (warning): Declare and assign separately to avoid masking return values. ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: local dst_mac=$(mac_get "$h2") In sch_ets_core.sh line 85: start_traffic $h1.1$i $(sip $i) $(dip $i) $dst_mac ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-- SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2046 (warning): Quote this to prevent word splitting. ^-- SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2046 (warning): Quote this to prevent word splitting. ^-- SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: start_traffic "$h1".1"$i" $(sip "$i") $(dip "$i") "$dst_mac" In sch_ets_core.sh line 111: local op=$(if [[ -n $QDISC_DEV ]]; then echo change; else echo add; fi) ^-- SC2155 (warning): Declare and assign separately to avoid masking return values. In sch_ets_core.sh line 113: tc qdisc $op dev $dev $PARENT handle 10: ets \ ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc qdisc "$op" dev "$dev" $PARENT handle 10: ets \ In sch_ets_core.sh line 114: $(if ((nstrict)); then echo strict $nstrict; fi) \ ^-- SC2046 (warning): Quote this to prevent word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: $(if ((nstrict)); then echo strict "$nstrict"; fi) \ In sch_ets_core.sh line 115: $(if ((${#quanta[@]})); then echo quanta ${quanta[@]}; fi) \ ^-- SC2046 (warning): Quote this to prevent word splitting. ^----------^ SC2068 (error): Double quote array expansions to avoid re-splitting elements. In sch_ets_core.sh line 116: priomap $priomap ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: priomap "$priomap" In sch_ets_core.sh line 127: local op=$(if [[ -n $QDISC_DEV ]]; then echo change; else echo add; fi) ^-- SC2155 (warning): Declare and assign separately to avoid masking return values. In sch_ets_core.sh line 129: tc qdisc $op dev $dev $PARENT handle 10: ets \ ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc qdisc "$op" dev "$dev" $PARENT handle 10: ets \ In sch_ets_core.sh line 130: $(if ((nstrict)); then echo strict $nstrict; fi) \ ^-- SC2046 (warning): Quote this to prevent word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: $(if ((nstrict)); then echo strict "$nstrict"; fi) \ In sch_ets_core.sh line 131: $(if ((${#quanta[@]})); then echo quanta ${quanta[@]}; fi) ^-- SC2046 (warning): Quote this to prevent word splitting. ^----------^ SC2068 (error): Double quote array expansions to avoid re-splitting elements. In sch_ets_core.sh line 138: tc filter add dev $dev parent 10: basic \ ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc filter add dev "$dev" parent 10: basic \ In sch_ets_core.sh line 159: tc qdisc del dev $QDISC_DEV $PARENT ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc qdisc del dev "$QDISC_DEV" $PARENT In sch_ets_core.sh line 168: adf_simple_if_init $h1 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: adf_simple_if_init "$h1" In sch_ets_core.sh line 170: mtu_set $h1 9900 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: mtu_set "$h1" 9900 In sch_ets_core.sh line 171: defer mtu_restore $h1 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer mtu_restore "$h1" In sch_ets_core.sh line 174: vlan_create $h1 1$i v$h1 $(sip $i)/28 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-- SC2086 (info): Double quote to prevent globbing and word splitting. ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2046 (warning): Quote this to prevent word splitting. ^-- SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: vlan_create "$h1" 1"$i" v"$h1" $(sip "$i")/28 In sch_ets_core.sh line 175: defer vlan_destroy $h1 1$i ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-- SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer vlan_destroy "$h1" 1"$i" In sch_ets_core.sh line 176: ip link set dev $h1.1$i type vlan egress 0:$i ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-- SC2086 (info): Double quote to prevent globbing and word splitting. ^-- SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set dev "$h1".1"$i" type vlan egress 0:"$i" In sch_ets_core.sh line 184: adf_simple_if_init $h2 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: adf_simple_if_init "$h2" In sch_ets_core.sh line 186: mtu_set $h2 9900 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: mtu_set "$h2" 9900 In sch_ets_core.sh line 187: defer mtu_restore $h2 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer mtu_restore "$h2" In sch_ets_core.sh line 190: vlan_create $h2 1$i v$h2 $(dip $i)/28 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-- SC2086 (info): Double quote to prevent globbing and word splitting. ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2046 (warning): Quote this to prevent word splitting. ^-- SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: vlan_create "$h2" 1"$i" v"$h2" $(dip "$i")/28 In sch_ets_core.sh line 191: defer vlan_destroy $h2 1$i ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-- SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer vlan_destroy "$h2" 1"$i" In sch_ets_core.sh line 199: ip link set dev $swp1 up ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set dev "$swp1" up In sch_ets_core.sh line 200: defer ip link set dev $swp1 down ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer ip link set dev "$swp1" down In sch_ets_core.sh line 202: mtu_set $swp1 9900 ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: mtu_set "$swp1" 9900 In sch_ets_core.sh line 203: defer mtu_restore $swp1 ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer mtu_restore "$swp1" In sch_ets_core.sh line 205: ip link set dev $swp2 up ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set dev "$swp2" up In sch_ets_core.sh line 206: defer ip link set dev $swp2 down ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer ip link set dev "$swp2" down In sch_ets_core.sh line 208: mtu_set $swp2 9900 ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: mtu_set "$swp2" 9900 In sch_ets_core.sh line 209: defer mtu_restore $swp2 ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer mtu_restore "$swp2" In sch_ets_core.sh line 212: vlan_create $swp1 1$i ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-- SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: vlan_create "$swp1" 1"$i" In sch_ets_core.sh line 213: defer vlan_destroy $swp1 1$i ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-- SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer vlan_destroy "$swp1" 1"$i" In sch_ets_core.sh line 214: ip link set dev $swp1.1$i type vlan ingress 0:0 1:1 2:2 ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-- SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set dev "$swp1".1"$i" type vlan ingress 0:0 1:1 2:2 In sch_ets_core.sh line 216: vlan_create $swp2 1$i ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-- SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: vlan_create "$swp2" 1"$i" In sch_ets_core.sh line 217: defer vlan_destroy $swp2 1$i ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-- SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer vlan_destroy "$swp2" 1"$i" In sch_ets_core.sh line 219: ip link add dev br1$i type bridge ^-- SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link add dev br1"$i" type bridge In sch_ets_core.sh line 220: defer ip link del dev br1$i ^-- SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer ip link del dev br1"$i" In sch_ets_core.sh line 222: ip link set dev $swp1.1$i master br1$i ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-- SC2086 (info): Double quote to prevent globbing and word splitting. ^-- SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set dev "$swp1".1"$i" master br1"$i" In sch_ets_core.sh line 223: defer ip link set dev $swp1.1$i nomaster ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-- SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer ip link set dev "$swp1".1"$i" nomaster In sch_ets_core.sh line 225: ip link set dev $swp2.1$i master br1$i ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-- SC2086 (info): Double quote to prevent globbing and word splitting. ^-- SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set dev "$swp2".1"$i" master br1"$i" In sch_ets_core.sh line 226: defer ip link set dev $swp2.1$i nomaster ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-- SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer ip link set dev "$swp2".1"$i" nomaster In sch_ets_core.sh line 228: ip link set dev br1$i up ^-- SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set dev br1"$i" up In sch_ets_core.sh line 229: defer ip link set dev br1$i down ^-- SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer ip link set dev br1"$i" down In sch_ets_core.sh line 231: ip link set dev $swp1.1$i up ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-- SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set dev "$swp1".1"$i" up In sch_ets_core.sh line 232: defer ip link set dev $swp1.1$i down ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-- SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer ip link set dev "$swp1".1"$i" down In sch_ets_core.sh line 234: ip link set dev $swp2.1$i up ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-- SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set dev "$swp2".1"$i" up In sch_ets_core.sh line 235: defer ip link set dev $swp2.1$i down ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-- SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer ip link set dev "$swp2".1"$i" down In sch_ets_core.sh line 250: hut=$h2 ^-^ SC2034 (warning): hut appears unused. Verify use (or export if used externally). In sch_ets_core.sh line 261: ping_test $h1.10 $(dip 0) " vlan 10" ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2046 (warning): Quote this to prevent word splitting. Did you mean: ping_test "$h1".10 $(dip 0) " vlan 10" In sch_ets_core.sh line 262: ping_test $h1.11 $(dip 1) " vlan 11" ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2046 (warning): Quote this to prevent word splitting. Did you mean: ping_test "$h1".11 $(dip 1) " vlan 11" In sch_ets_core.sh line 263: ping_test $h1.12 $(dip 2) " vlan 12" ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2046 (warning): Quote this to prevent word splitting. Did you mean: ping_test "$h1".12 $(dip 2) " vlan 12" In sch_ets_core.sh line 275: exit $EXIT_STATUS ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: exit "$EXIT_STATUS" For more information: https://www.shellcheck.net/wiki/SC2068 -- Double quote array expansions to ... https://www.shellcheck.net/wiki/SC2148 -- Tips depend on target shell and y... https://www.shellcheck.net/wiki/SC2034 -- hut appears unused. Verify use (o... ====== Checking the tree with the patch ====== Checking tools/testing/selftests/net/forwarding/sch_ets_core.sh - 91c0ef3e5c7c9ac93ca1d489ed11736ec497e2186b369d2b2b4c16148a492d69 In sch_ets_core.sh line 1: # SPDX-License-Identifier: GPL-2.0 ^-- SC2148 (error): Tips depend on target shell and yours is unknown. Add a shebang or a 'shell' directive. In sch_ets_core.sh line 63: source $lib_dir/lib.sh ^------^ SC2154 (warning): lib_dir is referenced but not assigned. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: source "$lib_dir"/lib.sh In sch_ets_core.sh line 64: source $lib_dir/sch_ets_tests.sh ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: source "$lib_dir"/sch_ets_tests.sh In sch_ets_core.sh line 82: local dst_mac=$(mac_get $h2) ^-----^ SC2155 (warning): Declare and assign separately to avoid masking return values. ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: local dst_mac=$(mac_get "$h2") In sch_ets_core.sh line 85: start_traffic $h1.1$i $(sip $i) $(dip $i) $dst_mac ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-- SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2046 (warning): Quote this to prevent word splitting. ^-- SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2046 (warning): Quote this to prevent word splitting. ^-- SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: start_traffic "$h1".1"$i" $(sip "$i") $(dip "$i") "$dst_mac" In sch_ets_core.sh line 112: local op=$(if [[ -n $QDISC_DEV ]]; then echo change; else echo add; fi) ^-- SC2155 (warning): Declare and assign separately to avoid masking return values. In sch_ets_core.sh line 114: tc qdisc $op dev $dev $PARENT handle 10: ets \ ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc qdisc "$op" dev "$dev" $PARENT handle 10: ets \ In sch_ets_core.sh line 115: $(if ((nstrict)); then echo strict $nstrict; fi) \ ^-- SC2046 (warning): Quote this to prevent word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: $(if ((nstrict)); then echo strict "$nstrict"; fi) \ In sch_ets_core.sh line 116: $(if ((${#quanta[@]})); then echo quanta ${quanta[@]}; fi) \ ^-- SC2046 (warning): Quote this to prevent word splitting. ^----------^ SC2068 (error): Double quote array expansions to avoid re-splitting elements. In sch_ets_core.sh line 117: priomap $priomap ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: priomap "$priomap" In sch_ets_core.sh line 128: local op=$(if [[ -n $QDISC_DEV ]]; then echo change; else echo add; fi) ^-- SC2155 (warning): Declare and assign separately to avoid masking return values. In sch_ets_core.sh line 130: tc qdisc $op dev $dev $PARENT handle 10: ets \ ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc qdisc "$op" dev "$dev" $PARENT handle 10: ets \ In sch_ets_core.sh line 131: $(if ((nstrict)); then echo strict $nstrict; fi) \ ^-- SC2046 (warning): Quote this to prevent word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: $(if ((nstrict)); then echo strict "$nstrict"; fi) \ In sch_ets_core.sh line 132: $(if ((${#quanta[@]})); then echo quanta ${quanta[@]}; fi) ^-- SC2046 (warning): Quote this to prevent word splitting. ^----------^ SC2068 (error): Double quote array expansions to avoid re-splitting elements. In sch_ets_core.sh line 139: tc filter add dev $dev parent 10: basic \ ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc filter add dev "$dev" parent 10: basic \ In sch_ets_core.sh line 160: tc qdisc del dev $QDISC_DEV $PARENT ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc qdisc del dev "$QDISC_DEV" $PARENT In sch_ets_core.sh line 169: adf_simple_if_init $h1 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: adf_simple_if_init "$h1" In sch_ets_core.sh line 171: mtu_set $h1 9900 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: mtu_set "$h1" 9900 In sch_ets_core.sh line 172: defer mtu_restore $h1 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer mtu_restore "$h1" In sch_ets_core.sh line 175: vlan_create $h1 1$i v$h1 $(sip $i)/28 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-- SC2086 (info): Double quote to prevent globbing and word splitting. ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2046 (warning): Quote this to prevent word splitting. ^-- SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: vlan_create "$h1" 1"$i" v"$h1" $(sip "$i")/28 In sch_ets_core.sh line 176: defer vlan_destroy $h1 1$i ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-- SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer vlan_destroy "$h1" 1"$i" In sch_ets_core.sh line 177: ip link set dev $h1.1$i type vlan egress 0:$i ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-- SC2086 (info): Double quote to prevent globbing and word splitting. ^-- SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set dev "$h1".1"$i" type vlan egress 0:"$i" In sch_ets_core.sh line 185: adf_simple_if_init $h2 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: adf_simple_if_init "$h2" In sch_ets_core.sh line 187: mtu_set $h2 9900 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: mtu_set "$h2" 9900 In sch_ets_core.sh line 188: defer mtu_restore $h2 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer mtu_restore "$h2" In sch_ets_core.sh line 191: vlan_create $h2 1$i v$h2 $(dip $i)/28 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-- SC2086 (info): Double quote to prevent globbing and word splitting. ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2046 (warning): Quote this to prevent word splitting. ^-- SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: vlan_create "$h2" 1"$i" v"$h2" $(dip "$i")/28 In sch_ets_core.sh line 192: defer vlan_destroy $h2 1$i ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-- SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer vlan_destroy "$h2" 1"$i" In sch_ets_core.sh line 200: ip link set dev $swp1 up ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set dev "$swp1" up In sch_ets_core.sh line 201: defer ip link set dev $swp1 down ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer ip link set dev "$swp1" down In sch_ets_core.sh line 203: mtu_set $swp1 9900 ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: mtu_set "$swp1" 9900 In sch_ets_core.sh line 204: defer mtu_restore $swp1 ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer mtu_restore "$swp1" In sch_ets_core.sh line 206: ip link set dev $swp2 up ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set dev "$swp2" up In sch_ets_core.sh line 207: defer ip link set dev $swp2 down ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer ip link set dev "$swp2" down In sch_ets_core.sh line 209: mtu_set $swp2 9900 ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: mtu_set "$swp2" 9900 In sch_ets_core.sh line 210: defer mtu_restore $swp2 ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer mtu_restore "$swp2" In sch_ets_core.sh line 213: vlan_create $swp1 1$i ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-- SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: vlan_create "$swp1" 1"$i" In sch_ets_core.sh line 214: defer vlan_destroy $swp1 1$i ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-- SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer vlan_destroy "$swp1" 1"$i" In sch_ets_core.sh line 215: ip link set dev $swp1.1$i type vlan ingress 0:0 1:1 2:2 ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-- SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set dev "$swp1".1"$i" type vlan ingress 0:0 1:1 2:2 In sch_ets_core.sh line 217: vlan_create $swp2 1$i ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-- SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: vlan_create "$swp2" 1"$i" In sch_ets_core.sh line 218: defer vlan_destroy $swp2 1$i ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-- SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer vlan_destroy "$swp2" 1"$i" In sch_ets_core.sh line 220: ip link add dev br1$i type bridge ^-- SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link add dev br1"$i" type bridge In sch_ets_core.sh line 221: defer ip link del dev br1$i ^-- SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer ip link del dev br1"$i" In sch_ets_core.sh line 223: ip link set dev $swp1.1$i master br1$i ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-- SC2086 (info): Double quote to prevent globbing and word splitting. ^-- SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set dev "$swp1".1"$i" master br1"$i" In sch_ets_core.sh line 224: defer ip link set dev $swp1.1$i nomaster ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-- SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer ip link set dev "$swp1".1"$i" nomaster In sch_ets_core.sh line 226: ip link set dev $swp2.1$i master br1$i ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-- SC2086 (info): Double quote to prevent globbing and word splitting. ^-- SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set dev "$swp2".1"$i" master br1"$i" In sch_ets_core.sh line 227: defer ip link set dev $swp2.1$i nomaster ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-- SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer ip link set dev "$swp2".1"$i" nomaster In sch_ets_core.sh line 229: ip link set dev br1$i up ^-- SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set dev br1"$i" up In sch_ets_core.sh line 230: defer ip link set dev br1$i down ^-- SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer ip link set dev br1"$i" down In sch_ets_core.sh line 232: ip link set dev $swp1.1$i up ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-- SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set dev "$swp1".1"$i" up In sch_ets_core.sh line 233: defer ip link set dev $swp1.1$i down ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-- SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer ip link set dev "$swp1".1"$i" down In sch_ets_core.sh line 235: ip link set dev $swp2.1$i up ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-- SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set dev "$swp2".1"$i" up In sch_ets_core.sh line 236: defer ip link set dev $swp2.1$i down ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-- SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer ip link set dev "$swp2".1"$i" down In sch_ets_core.sh line 251: hut=$h2 ^-^ SC2034 (warning): hut appears unused. Verify use (or export if used externally). In sch_ets_core.sh line 262: ping_test $h1.10 $(dip 0) " vlan 10" ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2046 (warning): Quote this to prevent word splitting. Did you mean: ping_test "$h1".10 $(dip 0) " vlan 10" In sch_ets_core.sh line 263: ping_test $h1.11 $(dip 1) " vlan 11" ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2046 (warning): Quote this to prevent word splitting. Did you mean: ping_test "$h1".11 $(dip 1) " vlan 11" In sch_ets_core.sh line 264: ping_test $h1.12 $(dip 2) " vlan 12" ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2046 (warning): Quote this to prevent word splitting. Did you mean: ping_test "$h1".12 $(dip 2) " vlan 12" In sch_ets_core.sh line 276: exit $EXIT_STATUS ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: exit "$EXIT_STATUS" For more information: https://www.shellcheck.net/wiki/SC2068 -- Double quote array expansions to ... https://www.shellcheck.net/wiki/SC2148 -- Tips depend on target shell and y... https://www.shellcheck.net/wiki/SC2034 -- hut appears unused. Verify use (o...