========== pylint - FAILED ====== Checking before the patch ====== ====== Checking the tree with the patch ====== New errors added --- /tmp/tmp.PkHpgZ541K 2026-01-19 13:59:09.850986447 -0500 +++ /tmp/tmp.oE0DbUGerd 2026-01-19 13:59:11.038980774 -0500 @@ -0,0 +1,18 @@ +************* Module rds_basic +tools/testing/selftests/net/rds/rds_basic.py:1:0: C0114: Missing module docstring (missing-module-docstring) +tools/testing/selftests/net/rds/rds_basic.py:15:0: E0401: Unable to import 'lib.py.utils' (import-error) +tools/testing/selftests/net/rds/rds_basic.py:15:0: C0413: Import "from lib.py.utils import ip" should be placed at the top of the module (wrong-import-position) +tools/testing/selftests/net/rds/rds_basic.py:24:0: C0116: Missing function or method docstring (missing-function-docstring) +tools/testing/selftests/net/rds/rds_basic.py:30:13: W1514: Using open without explicitly specifying an encoding (unspecified-encoding) +tools/testing/selftests/net/rds/rds_basic.py:32:16: W0612: Unused variable 'ret' (unused-variable) +tools/testing/selftests/net/rds/rds_basic.py:52:0: R0914: Too many local variables (31/15) (too-many-locals) +tools/testing/selftests/net/rds/rds_basic.py:75:21: R1721: Unnecessary use of a comprehension, use dict(zip(addrs, sockets)) instead. (unnecessary-comprehension) +tools/testing/selftests/net/rds/rds_basic.py:144:4: C0103: Variable name "RDS_INFO_FIRST" doesn't conform to snake_case naming style (invalid-name) +tools/testing/selftests/net/rds/rds_basic.py:145:4: C0103: Variable name "RDS_INFO_LAST" doesn't conform to snake_case naming style (invalid-name) +tools/testing/selftests/net/rds/rds_basic.py:52:0: R0912: Too many branches (20/12) (too-many-branches) +tools/testing/selftests/net/rds/rds_basic.py:52:0: R0915: Too many statements (65/50) (too-many-statements) +tools/testing/selftests/net/rds/rds_basic.py:111:12: W0612: Unused variable 'e' (unused-variable) + +----------------------------------- +Your code has been rated at 8.43/10 + @@ -3,30 +21,14 @@ -tools/testing/selftests/net/rds/test.py:21:0: E0401: Unable to import 'lib.py.utils' (import-error) -tools/testing/selftests/net/rds/test.py:21:0: C0413: Import "from lib.py.utils import ip" should be placed at the top of the module (wrong-import-position) -tools/testing/selftests/net/rds/test.py:26:0: C0103: Constant name "net0" doesn't conform to UPPER_CASE naming style (invalid-name) -tools/testing/selftests/net/rds/test.py:27:0: C0103: Constant name "net1" doesn't conform to UPPER_CASE naming style (invalid-name) -tools/testing/selftests/net/rds/test.py:29:0: C0103: Constant name "veth0" doesn't conform to UPPER_CASE naming style (invalid-name) -tools/testing/selftests/net/rds/test.py:30:0: C0103: Constant name "veth1" doesn't conform to UPPER_CASE naming style (invalid-name) -tools/testing/selftests/net/rds/test.py:36:0: C0116: Missing function or method docstring (missing-function-docstring) -tools/testing/selftests/net/rds/test.py:36:0: W0621: Redefining name 'args' from outer scope (line 82) (redefined-outer-name) -tools/testing/selftests/net/rds/test.py:50:8: W0621: Redefining name 's' from outer scope (line 145) (redefined-outer-name) -tools/testing/selftests/net/rds/test.py:42:13: W1514: Using open without explicitly specifying an encoding (unspecified-encoding) -tools/testing/selftests/net/rds/test.py:44:16: W0612: Unused variable 'ret' (unused-variable) -tools/testing/selftests/net/rds/test.py:64:0: C0116: Missing function or method docstring (missing-function-docstring) -tools/testing/selftests/net/rds/test.py:64:19: W0613: Unused argument 'sig' (unused-argument) -tools/testing/selftests/net/rds/test.py:64:24: W0613: Unused argument 'frame' (unused-argument) -tools/testing/selftests/net/rds/test.py:84:0: C0103: Constant name "packet_loss" doesn't conform to UPPER_CASE naming style (invalid-name) -tools/testing/selftests/net/rds/test.py:85:0: C0103: Constant name "packet_corruption" doesn't conform to UPPER_CASE naming style (invalid-name) -tools/testing/selftests/net/rds/test.py:86:0: C0103: Constant name "packet_duplicate" doesn't conform to UPPER_CASE naming style (invalid-name) -tools/testing/selftests/net/rds/test.py:90:3: W1309: Using an f-string that does not have any interpolated variables (f-string-without-interpolation) -tools/testing/selftests/net/rds/test.py:153:17: R1721: Unnecessary use of a comprehension, use dict(zip(addrs, sockets)) instead. (unnecessary-comprehension) -tools/testing/selftests/net/rds/test.py:169:0: C0103: Constant name "n" doesn't conform to UPPER_CASE naming style (invalid-name) -tools/testing/selftests/net/rds/test.py:170:0: C0103: Constant name "nr_send" doesn't conform to UPPER_CASE naming style (invalid-name) -tools/testing/selftests/net/rds/test.py:171:0: C0103: Constant name "nr_recv" doesn't conform to UPPER_CASE naming style (invalid-name) -tools/testing/selftests/net/rds/test.py:177:8: C0103: Constant name "send_data" doesn't conform to UPPER_CASE naming style (invalid-name) -tools/testing/selftests/net/rds/test.py:188:12: C0103: Constant name "nr_send" doesn't conform to UPPER_CASE naming style (invalid-name) -tools/testing/selftests/net/rds/test.py:210:24: C0103: Constant name "nr_recv" doesn't conform to UPPER_CASE naming style (invalid-name) -tools/testing/selftests/net/rds/test.py:225:0: C0103: Constant name "nr_success" doesn't conform to UPPER_CASE naming style (invalid-name) -tools/testing/selftests/net/rds/test.py:226:0: C0103: Constant name "nr_error" doesn't conform to UPPER_CASE naming style (invalid-name) -tools/testing/selftests/net/rds/test.py:235:12: C0103: Constant name "nr_success" doesn't conform to UPPER_CASE naming style (invalid-name) -tools/testing/selftests/net/rds/test.py:237:12: C0103: Constant name "nr_error" doesn't conform to UPPER_CASE naming style (invalid-name) -tools/testing/selftests/net/rds/test.py:14:0: W0611: Unused import atexit (unused-import) +tools/testing/selftests/net/rds/test.py:16:0: E0401: Unable to import 'lib.py.utils' (import-error) +tools/testing/selftests/net/rds/test.py:16:0: C0413: Import "from lib.py.utils import ip" should be placed at the top of the module (wrong-import-position) +tools/testing/selftests/net/rds/test.py:18:0: C0103: Constant name "net0" doesn't conform to UPPER_CASE naming style (invalid-name) +tools/testing/selftests/net/rds/test.py:19:0: C0103: Constant name "net1" doesn't conform to UPPER_CASE naming style (invalid-name) +tools/testing/selftests/net/rds/test.py:21:0: C0103: Constant name "veth0" doesn't conform to UPPER_CASE naming style (invalid-name) +tools/testing/selftests/net/rds/test.py:22:0: C0103: Constant name "veth1" doesn't conform to UPPER_CASE naming style (invalid-name) +tools/testing/selftests/net/rds/test.py:24:0: C0116: Missing function or method docstring (missing-function-docstring) +tools/testing/selftests/net/rds/test.py:24:19: W0613: Unused argument 'sig' (unused-argument) +tools/testing/selftests/net/rds/test.py:24:24: W0613: Unused argument 'frame' (unused-argument) +tools/testing/selftests/net/rds/test.py:44:0: C0103: Constant name "packet_loss" doesn't conform to UPPER_CASE naming style (invalid-name) +tools/testing/selftests/net/rds/test.py:45:0: C0103: Constant name "packet_corruption" doesn't conform to UPPER_CASE naming style (invalid-name) +tools/testing/selftests/net/rds/test.py:46:0: C0103: Constant name "packet_duplicate" doesn't conform to UPPER_CASE naming style (invalid-name) +tools/testing/selftests/net/rds/test.py:50:3: W1309: Using an f-string that does not have any interpolated variables (f-string-without-interpolation) +tools/testing/selftests/net/rds/test.py:105:0: C0103: Constant name "ret" doesn't conform to UPPER_CASE naming style (invalid-name) @@ -34,2 +36,2 @@ ------------------------------------ -Your code has been rated at 7.74/10 +------------------------------------------------------------------ +Your code has been rated at 6.72/10 (previous run: 7.74/10, -1.02)