WARNING: line length of 82 exceeds 80 columns #204: FILE: tools/kexec/template.c:61: + * This function ensures that the sections .rodata, .data, .rodata.str1.1 and .bss WARNING: Prefer __used over __attribute__((used)) #207: FILE: tools/kexec/template.c:64: +static const char dummy_rodata[16] __attribute__((used)) = "rodata"; WARNING: Prefer __used over __attribute__((used)) #208: FILE: tools/kexec/template.c:65: +static char dummy_data[16] __attribute__((used)) = "data"; WARNING: Prefer __used over __attribute__((used)) #209: FILE: tools/kexec/template.c:66: +static char *dummy_mergeable_str __attribute__((used)) = ".rodata.str1.1"; WARNING: Prefer __used over __attribute__((used)) #210: FILE: tools/kexec/template.c:67: +static char dummy_bss[16] __attribute__((used)); CHECK: Please don't use multiple blank lines #235: FILE: tools/kexec/zboot_parser_bpf.c:18: + + WARNING: Prefer __packed over __attribute__((packed)) #248: FILE: tools/kexec/zboot_parser_bpf.c:31: +} __attribute__((packed)); CHECK: Please don't use multiple blank lines #250: FILE: tools/kexec/zboot_parser_bpf.c:33: + + CHECK: Unnecessary parentheses around 'image_sz > MAX_RECORD_SIZE' #262: FILE: tools/kexec/zboot_parser_bpf.c:45: + if (!context->kernel || (image_sz > MAX_RECORD_SIZE)) { WARNING: line length of 87 exceeds 80 columns #263: FILE: tools/kexec/zboot_parser_bpf.c:46: + bpf_printk("Err: image size is greater than 0x%lx\n", MAX_RECORD_SIZE); WARNING: line length of 81 exceeds 80 columns #270: FILE: tools/kexec/zboot_parser_bpf.c:53: + * R2 is ARG_CONST_ALLOC_SIZE_OR_ZERO, should be decided at compling time ERROR: code indent should use tabs where possible #274: FILE: tools/kexec/zboot_parser_bpf.c:57: +^I ^Ibpf_printk("Err: fail to reserve ringbuf to parse zboot header\n");$ WARNING: please, no space before tabs #274: FILE: tools/kexec/zboot_parser_bpf.c:57: +^I ^Ibpf_printk("Err: fail to reserve ringbuf to parse zboot header\n");$ WARNING: line length of 91 exceeds 80 columns #277: FILE: tools/kexec/zboot_parser_bpf.c:60: + bpf_probe_read((void *)buf, sizeof(struct linux_pe_zboot_header), context->kernel); CHECK: Alignment should match open parenthesis #280: FILE: tools/kexec/zboot_parser_bpf.c:63: + if (!!__builtin_memcmp(&zboot_header->image_type, "zimg", + sizeof(zboot_header->image_type))) { WARNING: line length of 97 exceeds 80 columns #288: FILE: tools/kexec/zboot_parser_bpf.c:71: + bpf_printk("zboot image payload offset=0x%x, size=0x%x\n", payload_offset, payload_size); WARNING: Missing a blank line after declarations #288: FILE: tools/kexec/zboot_parser_bpf.c:71: + unsigned int payload_size = zboot_header->payload_size; + bpf_printk("zboot image payload offset=0x%x, size=0x%x\n", payload_offset, payload_size); WARNING: Missing a blank line after declarations #296: FILE: tools/kexec/zboot_parser_bpf.c:79: + unsigned int max_payload = MAX_RECORD_SIZE - sizeof(struct cmd_hdr); + if (payload_size >= max_payload) { WARNING: Missing a blank line after declarations #304: FILE: tools/kexec/zboot_parser_bpf.c:87: + struct cmd_hdr *cmd = (struct cmd_hdr *)buf; + cmd->cmd = KEXEC_BPF_CMD_DECOMPRESS; WARNING: Missing a blank line after declarations #315: FILE: tools/kexec/zboot_parser_bpf.c:98: + struct bpf_parser_context *bpf = bpf_get_parser_context(parser_id); + if (!bpf) { WARNING: line length of 85 exceeds 80 columns #320: FILE: tools/kexec/zboot_parser_bpf.c:103: + ret = bpf_buffer_parser(buf, sizeof(struct cmd_hdr) + payload_size - 4, bpf); total: 1 errors, 16 warnings, 4 checks, 265 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. NOTE: Whitespace errors detected. You may wish to use scripts/cleanpatch or scripts/cleanfile Commit 7541246f0eba ("tools/kexec: Introduce a bpf-prog to parse zboot image format") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE FILE_PATH_CHANGES GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS.