CHECK: Prefer kernel type 'u16' over 'uint16_t' #63: FILE: kernel/kexec_bpf_loader.c:91: + uint16_t cmd; CHECK: Prefer kernel type 'u16' over 'uint16_t' #64: FILE: kernel/kexec_bpf_loader.c:92: + uint16_t subcmd; CHECK: Prefer kernel type 'u32' over 'uint32_t' #65: FILE: kernel/kexec_bpf_loader.c:93: + uint32_t payload_len; CHECK: Please don't use multiple blank lines #68: FILE: kernel/kexec_bpf_loader.c:96: + + CHECK: Prefer using the BIT macro #70: FILE: kernel/kexec_bpf_loader.c:98: +#define MAX_UNCOMPRESSED_BUF_SIZE (1 << 29) CHECK: Prefer using the BIT macro #71: FILE: kernel/kexec_bpf_loader.c:99: +#define CHUNK_SIZE (1 << 23) WARNING: line length of 81 exceeds 80 columns #94: FILE: kernel/kexec_bpf_loader.c:122: + if (unlikely((a->next_idx * a->chunk_size >= MAX_UNCOMPRESSED_BUF_SIZE))) CHECK: multiple assignments should be avoided #101: FILE: kernel/kexec_bpf_loader.c:129: + a->chunk_start = a->chunk_cur = p; CHECK: Alignment should match open parenthesis #107: FILE: kernel/kexec_bpf_loader.c:135: +static int merge_decompressed_data(struct decompress_mem_allocator *a, + char **out, unsigned int *size) CHECK: multiple assignments should be avoided #115: FILE: kernel/kexec_bpf_loader.c:143: + cur_dst = dst = __vmalloc(total_sz, GFP_KERNEL | __GFP_ACCOUNT); CHECK: Lines should not end with a '(' #133: FILE: kernel/kexec_bpf_loader.c:161: +static int decompress_mem_allocator_init( WARNING: line length of 85 exceeds 80 columns #137: FILE: kernel/kexec_bpf_loader.c:165: + unsigned long sz = (MAX_UNCOMPRESSED_BUF_SIZE / chunk_size) * sizeof(void *); CHECK: multiple assignments should be avoided #151: FILE: kernel/kexec_bpf_loader.c:179: + a->chunk_start = a->chunk_cur = buf; WARNING: Do not crash the kernel unless it is absolutely unavoidable--use WARN_ON_ONCE() plus recovery code (if feasible) instead of BUG() or variants #179: FILE: kernel/kexec_bpf_loader.c:207: + BUG_ON(free < 0); CHECK: multiple assignments should be avoided #186: FILE: kernel/kexec_bpf_loader.c:214: + a->chunk_start = a->chunk_cur = allocate_chunk_memory(); CHECK: Alignment should match open parenthesis #199: FILE: kernel/kexec_bpf_loader.c:227: +static int parser_cmd_decompress(char *compressed_data, int image_gz_sz, + char **out_buf, int *out_sz, struct kexec_context *ctx) CHECK: Alignment should match open parenthesis #213: FILE: kernel/kexec_bpf_loader.c:241: + pr_debug("Find decompressing method: %s, compressed sz:0x%x\n", + name, image_gz_sz); CHECK: Alignment should match open parenthesis #215: FILE: kernel/kexec_bpf_loader.c:243: + ret = decompressor(compressed_data, image_gz_sz, NULL, flush, + NULL, NULL, NULL); CHECK: Alignment should match open parenthesis #237: FILE: kernel/kexec_bpf_loader.c:265: + pr_info("Invalid payload size:0x%x, while buffer size:0x%x\n", + cmd->payload_len, pbuf->size); WARNING: line length of 85 exceeds 80 columns #242: FILE: kernel/kexec_bpf_loader.c:270: + ret = parser_cmd_decompress(buf, cmd->payload_len, &decompressed_buf, CHECK: Alignment should match open parenthesis #243: FILE: kernel/kexec_bpf_loader.c:271: + ret = parser_cmd_decompress(buf, cmd->payload_len, &decompressed_buf, + &decompressed_sz, ctx); total: 0 errors, 4 warnings, 17 checks, 225 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Commit 1657866e28b9 ("kexec_file: Implement decompress method for parser") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE FILE_PATH_CHANGES GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. total: 0 errors, 4 warnings, 17 checks, 225 lines checked