CHECK: spaces preferred around that '/' (ctx:VxV) #99: FILE: tools/testing/selftests/bpf/bpftool_tests/bpftool_maps_access.c:58: + for (i = 0; i < sizeof(maps)/sizeof(struct bpf_map *); i++) { ^ CHECK: Alignment should match open parenthesis #112: FILE: tools/testing/selftests/bpf/bpftool_tests/bpftool_maps_access.c:71: + ret = bpf_map__update_elem(skel->maps.prot_status_map, &key, + sizeof(key), &value, sizeof(value), 0); CHECK: Alignment should match open parenthesis #133: FILE: tools/testing/selftests/bpf/bpftool_tests/bpftool_maps_access.c:92: +static void update_test_desc(struct security_bpf_map *skel, + struct test_desc *test) WARNING: line length of 84 exceeds 80 columns #154: FILE: tools/testing/selftests/bpf/bpftool_tests/bpftool_maps_access.c:113: + ret = snprintf(desc->pin_path, PATH_MAX_LEN, "%s/%s", BPFFS_PIN_DIR, CHECK: Alignment should match open parenthesis #155: FILE: tools/testing/selftests/bpf/bpftool_tests/bpftool_maps_access.c:114: + ret = snprintf(desc->pin_path, PATH_MAX_LEN, "%s/%s", BPFFS_PIN_DIR, + desc->name); CHECK: Alignment should match open parenthesis #178: FILE: tools/testing/selftests/bpf/bpftool_tests/bpftool_maps_access.c:137: + ret = snprintf(cmd, MAX_BPFTOOL_CMD_LEN, "map lookup %s key 0 0 0 0", + map_handle); CHECK: Alignment should match open parenthesis #190: FILE: tools/testing/selftests/bpf/bpftool_tests/bpftool_maps_access.c:149: + ret = snprintf(cmd, MAX_BPFTOOL_CMD_LEN, "btf dump map %s", + map_handle); CHECK: Please don't use multiple blank lines #225: FILE: tools/testing/selftests/bpf/bpftool_tests/bpftool_maps_access.c:184: + + CHECK: Lines should not end with a '(' #248: FILE: tools/testing/selftests/bpf/bpftool_tests/bpftool_maps_access.c:207: + ret = snprintf( CHECK: Lines should not end with a '(' #262: FILE: tools/testing/selftests/bpf/bpftool_tests/bpftool_maps_access.c:221: + ret = snprintf( CHECK: Lines should not end with a '(' #287: FILE: tools/testing/selftests/bpf/bpftool_tests/bpftool_maps_access.c:246: + ret = snprintf( total: 0 errors, 1 warnings, 10 checks, 370 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Commit 83e54f26e18f ("selftests/bpf: add bpftool map manipulations tests") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE FILE_PATH_CHANGES GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. total: 0 errors, 1 warnings, 10 checks, 370 lines checked