WARNING: line length of 95 exceeds 80 columns
#123: FILE: tools/testing/selftests/bpf/bpftool_helpers.c:12:
+static int run_command(char *command, bool get_output, char *output_buf, size_t output_max_len)

WARNING: line length of 88 exceeds 80 columns
#147: FILE: tools/testing/selftests/bpf/bpftool_helpers.c:36:
+	    strlen(env.bpftool_path) + 1 + strlen(args) + strlen(" > /dev/null 2>&1")) {

WARNING: line length of 83 exceeds 80 columns
#155: FILE: tools/testing/selftests/bpf/bpftool_helpers.c:44:
+int get_bpftool_command_output(char *args, char *output_buf, size_t output_max_len)

CHECK: Blank lines aren't necessary before a close brace '}'
#201: FILE: tools/testing/selftests/bpf/bpftool_helpers.c:90:
+
+}

WARNING: line length of 84 exceeds 80 columns
#246: FILE: tools/testing/selftests/bpf/bpftool_helpers.h:15:
+int get_bpftool_command_output(char *args, char *output_buf, size_t output_max_len);

CHECK: spaces preferred around that '*' (ctx:VxV)
#283: FILE: tools/testing/selftests/bpf/bpftool_tests/bpftool_metadata.c:19:
+#define MAX_BPFTOOL_OUTPUT_LEN	(100*1000)
                               	    ^

CHECK: Alignment should match open parenthesis
#324: FILE: tools/testing/selftests/bpf/bpftool_tests/bpftool_metadata.c:60:
+	snprintf(cmd, MAX_BPFTOOL_CMD_LEN, "prog load %s %s",
+			test->bpf_prog, test->bpffs_path);

CHECK: Alignment should match open parenthesis
#331: FILE: tools/testing/selftests/bpf/bpftool_tests/bpftool_metadata.c:67:
+	ret = get_bpftool_command_output("prog show name prog", output,
+			MAX_BPFTOOL_OUTPUT_LEN);

CHECK: Alignment should match open parenthesis
#334: FILE: tools/testing/selftests/bpf/bpftool_tests/bpftool_metadata.c:70:
+		ret = check_metadata(output, test->expected_output,
+				ARRAY_SIZE(test->expected_output));

CHECK: Alignment should match open parenthesis
#343: FILE: tools/testing/selftests/bpf/bpftool_tests/bpftool_metadata.c:79:
+		ret = check_metadata(output, test->expected_output_json,
+				ARRAY_SIZE(test->expected_output_json));

CHECK: Blank lines aren't necessary before a close brace '}'
#347: FILE: tools/testing/selftests/bpf/bpftool_tests/bpftool_metadata.c:83:
+
+}

CHECK: Blank lines aren't necessary before a close brace '}'
#391: FILE: tools/testing/selftests/bpf/bpftool_tests/bpftool_metadata.c:127:
+
+}

WARNING: macros should not use a trailing semicolon
#410: FILE: tools/testing/selftests/bpf/test_bpftool.c:12:
+#define DEFINE_TEST(name) extern void test_##name(void);

CHECK: Please don't use multiple blank lines
#428: FILE: tools/testing/selftests/bpf/test_bpftool.c:30:
+
+

CHECK: spaces preferred around that '+' (ctx:VxV)
#458: FILE: tools/testing/selftests/bpf/test_bpftool.c:60:
+		fprintf(stdout, "#%d/%d\t%s/%s: %s\n", test_index+1, j+1,
 		                                                 ^

CHECK: spaces preferred around that '+' (ctx:VxV)
#458: FILE: tools/testing/selftests/bpf/test_bpftool.c:60:
+		fprintf(stdout, "#%d/%d\t%s/%s: %s\n", test_index+1, j+1,
 		                                                      ^

CHECK: Alignment should match open parenthesis
#459: FILE: tools/testing/selftests/bpf/test_bpftool.c:61:
+		fprintf(stdout, "#%d/%d\t%s/%s: %s\n", test_index+1, j+1,
+				env.current_test->name,

CHECK: spaces preferred around that '|' (ctx:VxV)
#483: FILE: tools/testing/selftests/bpf/test_bpftool.c:85:
+	if (access(argv[1], R_OK|X_OK))
 	                        ^

WARNING: line length of 82 exceeds 80 columns
#493: FILE: tools/testing/selftests/bpf/test_bpftool.c:95:
+	fprintf(stdout, "\t<bpftool_path>: path to the bpftool binary to test\n");

CHECK: Please use a blank line after function/struct/union/enum declarations
#558: FILE: tools/testing/selftests/bpf/test_bpftool.h:28:
+};
+struct bpftool_runner_env {

total: 0 errors, 6 warnings, 14 checks, 458 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

Commit 35930c0b72f9 ("bpf/selftests: introduce bptool test runner and a first test") has style problems, please review.

NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE FILE_PATH_CHANGES GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.
total: 0 errors, 6 warnings, 14 checks, 458 lines checked