====== Checking before the patch ====== ====== Checking the tree with the patch ====== New warnings added --- /tmp/tmp.eHZ5KJsO6L 2026-01-13 10:42:50.648328821 -0500 +++ /tmp/tmp.Y2xespcmBf 2026-01-13 10:42:51.080325173 -0500 @@ -40,2 +40,3 @@ - addr=$(${pfx} ip -6 -br addr show dev ${dev} | \ - ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. + addr=$(${pfx} ${IP} -6 -br addr show dev ${dev} | \ + ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. + ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. @@ -44 +45 @@ - addr=$(${pfx} ip -6 -br addr show dev "${dev}" | \ + addr=$(${pfx} "${IP}" -6 -br addr show dev "${dev}" | \ @@ -55,16 +56,3 @@ -In fib-onlink-tests.sh line 186: - ip li add ${NETIFS[p1]} type veth peer name ${NETIFS[p2]} - ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting. - ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting. - -Did you mean: - ip li add "${NETIFS[p1]}" type veth peer name "${NETIFS[p2]}" - - -In fib-onlink-tests.sh line 187: - ip li add ${NETIFS[p3]} type veth peer name ${NETIFS[p4]} - ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting. - ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting. - -Did you mean: - ip li add "${NETIFS[p3]}" type veth peer name "${NETIFS[p4]}" +In fib-onlink-tests.sh line 178: + IP="ip -netns $ns1" + ^--^ SC2154 (warning): ns1 is referenced but not assigned. @@ -74,3 +62,3 @@ - ip li add ${NETIFS[p5]} type veth peer name ${NETIFS[p6]} - ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting. - ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting. + ${IP} li add ${NETIFS[p1]} type veth peer name ${NETIFS[p2]} + ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting. + ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting. @@ -79 +67 @@ - ip li add "${NETIFS[p5]}" type veth peer name "${NETIFS[p6]}" + ${IP} li add "${NETIFS[p1]}" type veth peer name "${NETIFS[p2]}" @@ -83,3 +71,3 @@ - ip li add ${NETIFS[p7]} type veth peer name ${NETIFS[p8]} - ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting. - ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting. + ${IP} li add ${NETIFS[p3]} type veth peer name ${NETIFS[p4]} + ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting. + ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting. @@ -88 +76 @@ - ip li add "${NETIFS[p7]}" type veth peer name "${NETIFS[p8]}" + ${IP} li add "${NETIFS[p3]}" type veth peer name "${NETIFS[p4]}" @@ -91,3 +79,4 @@ -In fib-onlink-tests.sh line 193: - ip li set ${NETIFS[p${n}]} vrf ${VRF} - ^--------------^ SC2086 (info): Double quote to prevent globbing and word splitting. +In fib-onlink-tests.sh line 190: + ${IP} li add ${NETIFS[p5]} type veth peer name ${NETIFS[p6]} + ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting. + ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting. @@ -96 +85 @@ - ip li set "${NETIFS[p${n}]}" vrf ${VRF} + ${IP} li add "${NETIFS[p5]}" type veth peer name "${NETIFS[p6]}" @@ -99,3 +88,4 @@ -In fib-onlink-tests.sh line 198: - ip li set ${NETIFS[p${n}]} up - ^--------------^ SC2086 (info): Double quote to prevent globbing and word splitting. +In fib-onlink-tests.sh line 191: + ${IP} li add ${NETIFS[p7]} type veth peer name ${NETIFS[p8]} + ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting. + ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting. @@ -104 +94 @@ - ip li set "${NETIFS[p${n}]}" up + ${IP} li add "${NETIFS[p7]}" type veth peer name "${NETIFS[p8]}" @@ -107,4 +97,3 @@ -In fib-onlink-tests.sh line 199: - ip addr add ${V4ADDRS[p${n}]}/24 dev ${NETIFS[p${n}]} - ^---------------^ SC2086 (info): Double quote to prevent globbing and word splitting. - ^--------------^ SC2086 (info): Double quote to prevent globbing and word splitting. +In fib-onlink-tests.sh line 195: + ${IP} li set ${NETIFS[p${n}]} vrf ${VRF} + ^--------------^ SC2086 (info): Double quote to prevent globbing and word splitting. @@ -113 +102 @@ - ip addr add "${V4ADDRS[p${n}]}"/24 dev "${NETIFS[p${n}]}" + ${IP} li set "${NETIFS[p${n}]}" vrf ${VRF} @@ -117,3 +106,2 @@ - ip addr add ${V6ADDRS[p${n}]}/64 dev ${NETIFS[p${n}]} nodad - ^---------------^ SC2086 (info): Double quote to prevent globbing and word splitting. - ^--------------^ SC2086 (info): Double quote to prevent globbing and word splitting. + ${IP} li set ${NETIFS[p${n}]} up + ^--------------^ SC2086 (info): Double quote to prevent globbing and word splitting. @@ -122 +110 @@ - ip addr add "${V6ADDRS[p${n}]}"/64 dev "${NETIFS[p${n}]}" nodad + ${IP} li set "${NETIFS[p${n}]}" up @@ -125,4 +113,4 @@ -In fib-onlink-tests.sh line 205: - ip li set ${NETIFS[p${n}]} netns ${PEER_NS} up - ^--------------^ SC2086 (info): Double quote to prevent globbing and word splitting. - ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. +In fib-onlink-tests.sh line 201: + ${IP} addr add ${V4ADDRS[p${n}]}/24 dev ${NETIFS[p${n}]} + ^---------------^ SC2086 (info): Double quote to prevent globbing and word splitting. + ^--------------^ SC2086 (info): Double quote to prevent globbing and word splitting. @@ -131 +119 @@ - ip li set "${NETIFS[p${n}]}" netns "${PEER_NS}" up + ${IP} addr add "${V4ADDRS[p${n}]}"/24 dev "${NETIFS[p${n}]}" @@ -134,5 +122,4 @@ -In fib-onlink-tests.sh line 206: - ip -netns ${PEER_NS} addr add ${V4ADDRS[p${n}]}/24 dev ${NETIFS[p${n}]} - ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. - ^---------------^ SC2086 (info): Double quote to prevent globbing and word splitting. - ^--------------^ SC2086 (info): Double quote to prevent globbing and word splitting. +In fib-onlink-tests.sh line 202: + ${IP} addr add ${V6ADDRS[p${n}]}/64 dev ${NETIFS[p${n}]} nodad + ^---------------^ SC2086 (info): Double quote to prevent globbing and word splitting. + ^--------------^ SC2086 (info): Double quote to prevent globbing and word splitting. @@ -141 +128 @@ - ip -netns "${PEER_NS}" addr add "${V4ADDRS[p${n}]}"/24 dev "${NETIFS[p${n}]}" + ${IP} addr add "${V6ADDRS[p${n}]}"/64 dev "${NETIFS[p${n}]}" nodad @@ -145,4 +132,4 @@ - ip -netns ${PEER_NS} addr add ${V6ADDRS[p${n}]}/64 dev ${NETIFS[p${n}]} nodad - ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. - ^---------------^ SC2086 (info): Double quote to prevent globbing and word splitting. - ^--------------^ SC2086 (info): Double quote to prevent globbing and word splitting. + ${IP} li set ${NETIFS[p${n}]} netns ${ns2} up + ^--------------^ SC2086 (info): Double quote to prevent globbing and word splitting. + ^----^ SC2154 (warning): ns2 is referenced but not assigned. + ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. @@ -151 +138 @@ - ip -netns "${PEER_NS}" addr add "${V6ADDRS[p${n}]}"/64 dev "${NETIFS[p${n}]}" nodad + ${IP} li set "${NETIFS[p${n}]}" netns "${ns2}" up @@ -154,3 +141,5 @@ -In fib-onlink-tests.sh line 210: - ip -6 ro add default via ${V6ADDRS[p3]/::[0-9]/::64} - ^-------------------------^ SC2086 (info): Double quote to prevent globbing and word splitting. +In fib-onlink-tests.sh line 208: + ip -netns $ns2 addr add ${V4ADDRS[p${n}]}/24 dev ${NETIFS[p${n}]} + ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. + ^---------------^ SC2086 (info): Double quote to prevent globbing and word splitting. + ^--------------^ SC2086 (info): Double quote to prevent globbing and word splitting. @@ -159 +148 @@ - ip -6 ro add default via "${V6ADDRS[p3]/::[0-9]/::64}" + ip -netns "$ns2" addr add "${V4ADDRS[p${n}]}"/24 dev "${NETIFS[p${n}]}" @@ -162,3 +151,5 @@ -In fib-onlink-tests.sh line 211: - ip -6 ro add table ${VRF_TABLE} default via ${V6ADDRS[p7]/::[0-9]/::64} - ^-------------------------^ SC2086 (info): Double quote to prevent globbing and word splitting. +In fib-onlink-tests.sh line 209: + ip -netns $ns2 addr add ${V6ADDRS[p${n}]}/64 dev ${NETIFS[p${n}]} nodad + ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. + ^---------------^ SC2086 (info): Double quote to prevent globbing and word splitting. + ^--------------^ SC2086 (info): Double quote to prevent globbing and word splitting. @@ -167 +158 @@ - ip -6 ro add table ${VRF_TABLE} default via "${V6ADDRS[p7]/::[0-9]/::64}" + ip -netns "$ns2" addr add "${V6ADDRS[p${n}]}"/64 dev "${NETIFS[p${n}]}" nodad @@ -170,3 +161,3 @@ -In fib-onlink-tests.sh line 219: - cleanup_ns ${PEER_NS} 2>/dev/null - ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. +In fib-onlink-tests.sh line 212: + ${IP} -6 ro add default via ${V6ADDRS[p3]/::[0-9]/::64} + ^-------------------------^ SC2086 (info): Double quote to prevent globbing and word splitting. @@ -175 +166 @@ - cleanup_ns "${PEER_NS}" 2>/dev/null + ${IP} -6 ro add default via "${V6ADDRS[p3]/::[0-9]/::64}" @@ -178,3 +169,3 @@ -In fib-onlink-tests.sh line 221: - ip link del ${NETIFS[p${n}]} 2>/dev/null - ^--------------^ SC2086 (info): Double quote to prevent globbing and word splitting. +In fib-onlink-tests.sh line 213: + ${IP} -6 ro add table ${VRF_TABLE} default via ${V6ADDRS[p7]/::[0-9]/::64} + ^-------------------------^ SC2086 (info): Double quote to prevent globbing and word splitting. @@ -183 +174 @@ - ip link del "${NETIFS[p${n}]}" 2>/dev/null + ${IP} -6 ro add table ${VRF_TABLE} default via "${V6ADDRS[p7]/::[0-9]/::64}" @@ -186 +177 @@ -In fib-onlink-tests.sh line 245: +In fib-onlink-tests.sh line 235: @@ -194,10 +185 @@ -In fib-onlink-tests.sh line 261: - nexthop via ${nh1} nexthop via ${nh2} - ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. - ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. - -Did you mean: - nexthop via "${nh1}" nexthop via "${nh2}" - - -In fib-onlink-tests.sh line 262: +In fib-onlink-tests.sh line 252: @@ -211 +193 @@ -In fib-onlink-tests.sh line 271: +In fib-onlink-tests.sh line 261: @@ -221 +203 @@ -In fib-onlink-tests.sh line 272: +In fib-onlink-tests.sh line 262: @@ -231 +213 @@ -In fib-onlink-tests.sh line 276: +In fib-onlink-tests.sh line 266: @@ -241 +223 @@ -In fib-onlink-tests.sh line 277: +In fib-onlink-tests.sh line 267: @@ -251 +233 @@ -In fib-onlink-tests.sh line 281: +In fib-onlink-tests.sh line 271: @@ -261 +243 @@ -In fib-onlink-tests.sh line 282: +In fib-onlink-tests.sh line 272: @@ -271 +253 @@ -In fib-onlink-tests.sh line 288: +In fib-onlink-tests.sh line 278: @@ -279 +261 @@ -In fib-onlink-tests.sh line 293: +In fib-onlink-tests.sh line 283: @@ -287 +269 @@ -In fib-onlink-tests.sh line 298: +In fib-onlink-tests.sh line 288: @@ -295 +277 @@ -In fib-onlink-tests.sh line 303: +In fib-onlink-tests.sh line 293: @@ -303 +285 @@ -In fib-onlink-tests.sh line 311: +In fib-onlink-tests.sh line 301: @@ -313 +295 @@ -In fib-onlink-tests.sh line 314: +In fib-onlink-tests.sh line 304: @@ -323 +305 @@ -In fib-onlink-tests.sh line 317: +In fib-onlink-tests.sh line 307: @@ -332 +314 @@ -In fib-onlink-tests.sh line 319: +In fib-onlink-tests.sh line 309: @@ -342 +324 @@ -In fib-onlink-tests.sh line 322: +In fib-onlink-tests.sh line 312: @@ -352 +334 @@ -In fib-onlink-tests.sh line 343: +In fib-onlink-tests.sh line 333: @@ -360,10 +342 @@ -In fib-onlink-tests.sh line 357: - nexthop via ${nh1} nexthop via ${nh2} - ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. - ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. - -Did you mean: - nexthop via "${nh1}" nexthop via "${nh2}" - - -In fib-onlink-tests.sh line 358: +In fib-onlink-tests.sh line 348: @@ -377 +350 @@ -In fib-onlink-tests.sh line 367: +In fib-onlink-tests.sh line 357: @@ -387 +360 @@ -In fib-onlink-tests.sh line 368: +In fib-onlink-tests.sh line 358: @@ -397 +370 @@ -In fib-onlink-tests.sh line 369: +In fib-onlink-tests.sh line 359: @@ -407 +380 @@ -In fib-onlink-tests.sh line 373: +In fib-onlink-tests.sh line 363: @@ -417 +390 @@ -In fib-onlink-tests.sh line 374: +In fib-onlink-tests.sh line 364: @@ -427 +400 @@ -In fib-onlink-tests.sh line 375: +In fib-onlink-tests.sh line 365: @@ -437 +410 @@ -In fib-onlink-tests.sh line 379: +In fib-onlink-tests.sh line 369: @@ -447 +420 @@ -In fib-onlink-tests.sh line 380: +In fib-onlink-tests.sh line 370: @@ -457 +430 @@ -In fib-onlink-tests.sh line 381: +In fib-onlink-tests.sh line 371: @@ -467 +440 @@ -In fib-onlink-tests.sh line 387: +In fib-onlink-tests.sh line 377: @@ -475 +448 @@ -In fib-onlink-tests.sh line 392: +In fib-onlink-tests.sh line 382: @@ -483 +456 @@ -In fib-onlink-tests.sh line 397: +In fib-onlink-tests.sh line 387: @@ -491 +464 @@ -In fib-onlink-tests.sh line 402: +In fib-onlink-tests.sh line 392: @@ -499 +472 @@ -In fib-onlink-tests.sh line 407: +In fib-onlink-tests.sh line 397: @@ -507 +480 @@ -In fib-onlink-tests.sh line 412: +In fib-onlink-tests.sh line 402: @@ -515 +488 @@ -In fib-onlink-tests.sh line 422: +In fib-onlink-tests.sh line 412: @@ -523 +496 @@ -In fib-onlink-tests.sh line 424: +In fib-onlink-tests.sh line 414: @@ -533 +506 @@ -In fib-onlink-tests.sh line 426: +In fib-onlink-tests.sh line 416: @@ -543 +516 @@ -In fib-onlink-tests.sh line 428: +In fib-onlink-tests.sh line 418: @@ -552 +525 @@ -In fib-onlink-tests.sh line 431: +In fib-onlink-tests.sh line 421: @@ -560 +533 @@ -In fib-onlink-tests.sh line 432: +In fib-onlink-tests.sh line 422: @@ -570 +543 @@ -In fib-onlink-tests.sh line 434: +In fib-onlink-tests.sh line 424: @@ -580 +553 @@ -In fib-onlink-tests.sh line 436: +In fib-onlink-tests.sh line 426: @@ -589 +562 @@ -In fib-onlink-tests.sh line 439: +In fib-onlink-tests.sh line 429: @@ -598 +571 @@ -In fib-onlink-tests.sh line 446: +In fib-onlink-tests.sh line 436: @@ -608 +581 @@ -In fib-onlink-tests.sh line 488: +In fib-onlink-tests.sh line 478: @@ -611,0 +585,9 @@ + +In fib-onlink-tests.sh line 486: +cleanup_ns ${ns1} ${ns2} + ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. + ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: +cleanup_ns "${ns1}" "${ns2}" + @@ -613,0 +596 @@ + https://www.shellcheck.net/wiki/SC2154 -- ns1 is referenced but not assigned. @@ -615 +597,0 @@ - https://www.shellcheck.net/wiki/SC2059 -- Don't use variables in the printf...