ERROR: spaces required around that '%=' (ctx:VxO) #33: FILE: tools/testing/selftests/bpf/progs/verifier_linked_scalars.c:22: + if r2 == 0 goto l0_%=; \ ^ ERROR: spaces required around that '%=' (ctx:VxO) #36: FILE: tools/testing/selftests/bpf/progs/verifier_linked_scalars.c:24: +l0_%=: \ ^ ERROR: spaces required around that ':' (ctx:OxE) #36: FILE: tools/testing/selftests/bpf/progs/verifier_linked_scalars.c:24: +l0_%=: \ ^ WARNING: Avoid unnecessary line continuations #48: FILE: tools/testing/selftests/bpf/progs/verifier_linked_scalars.c:39: + asm volatile (" \ WARNING: Avoid line continuations in quoted strings #48: FILE: tools/testing/selftests/bpf/progs/verifier_linked_scalars.c:39: + asm volatile (" \ CHECK: spaces preferred around that '%' (ctx:WxV) #49: FILE: tools/testing/selftests/bpf/progs/verifier_linked_scalars.c:40: + call %[bpf_get_prandom_u32]; \ ^ ERROR: spaces required around that '<' (ctx:VxW) #53: FILE: tools/testing/selftests/bpf/progs/verifier_linked_scalars.c:44: + if r1 s< 0 goto l0_%=; \ ^ ERROR: spaces required around that '%=' (ctx:VxO) #53: FILE: tools/testing/selftests/bpf/progs/verifier_linked_scalars.c:44: + if r1 s< 0 goto l0_%=; \ ^ ERROR: spaces required around that '%=' (ctx:VxO) #54: FILE: tools/testing/selftests/bpf/progs/verifier_linked_scalars.c:45: + if r0 != 0 goto l0_%=; \ ^ ERROR: spaces required around that '%=' (ctx:VxO) #56: FILE: tools/testing/selftests/bpf/progs/verifier_linked_scalars.c:47: +l0_%=: \ ^ ERROR: spaces required around that ':' (ctx:OxE) #56: FILE: tools/testing/selftests/bpf/progs/verifier_linked_scalars.c:47: +l0_%=: \ ^ WARNING: Avoid unnecessary line continuations #69: FILE: tools/testing/selftests/bpf/progs/verifier_linked_scalars.c:60: + asm volatile (" \ WARNING: Avoid line continuations in quoted strings #69: FILE: tools/testing/selftests/bpf/progs/verifier_linked_scalars.c:60: + asm volatile (" \ CHECK: spaces preferred around that '%' (ctx:WxV) #70: FILE: tools/testing/selftests/bpf/progs/verifier_linked_scalars.c:61: + call %[bpf_get_prandom_u32]; \ ^ ERROR: spaces required around that '<' (ctx:VxW) #74: FILE: tools/testing/selftests/bpf/progs/verifier_linked_scalars.c:65: + if r1 s< 0 goto l0_%=; \ ^ ERROR: spaces required around that '%=' (ctx:VxO) #74: FILE: tools/testing/selftests/bpf/progs/verifier_linked_scalars.c:65: + if r1 s< 0 goto l0_%=; \ ^ ERROR: spaces required around that '%=' (ctx:VxO) #75: FILE: tools/testing/selftests/bpf/progs/verifier_linked_scalars.c:66: + if r0 != 0 goto l0_%=; \ ^ ERROR: spaces required around that '%=' (ctx:VxO) #77: FILE: tools/testing/selftests/bpf/progs/verifier_linked_scalars.c:68: +l0_%=: \ ^ ERROR: spaces required around that ':' (ctx:OxE) #77: FILE: tools/testing/selftests/bpf/progs/verifier_linked_scalars.c:68: +l0_%=: \ ^ WARNING: Avoid unnecessary line continuations #90: FILE: tools/testing/selftests/bpf/progs/verifier_linked_scalars.c:81: + asm volatile (" \ WARNING: Avoid line continuations in quoted strings #90: FILE: tools/testing/selftests/bpf/progs/verifier_linked_scalars.c:81: + asm volatile (" \ CHECK: spaces preferred around that '%' (ctx:WxV) #91: FILE: tools/testing/selftests/bpf/progs/verifier_linked_scalars.c:82: + call %[bpf_get_prandom_u32]; \ ^ ERROR: spaces required around that '<' (ctx:VxW) #95: FILE: tools/testing/selftests/bpf/progs/verifier_linked_scalars.c:86: + if w1 s< 0 goto l0_%=; \ ^ ERROR: spaces required around that '%=' (ctx:VxO) #95: FILE: tools/testing/selftests/bpf/progs/verifier_linked_scalars.c:86: + if w1 s< 0 goto l0_%=; \ ^ ERROR: spaces required around that '%=' (ctx:VxO) #96: FILE: tools/testing/selftests/bpf/progs/verifier_linked_scalars.c:87: + if w0 != 0 goto l0_%=; \ ^ ERROR: spaces required around that '%=' (ctx:VxO) #98: FILE: tools/testing/selftests/bpf/progs/verifier_linked_scalars.c:89: +l0_%=: \ ^ ERROR: spaces required around that ':' (ctx:OxE) #98: FILE: tools/testing/selftests/bpf/progs/verifier_linked_scalars.c:89: +l0_%=: \ ^ WARNING: Avoid unnecessary line continuations #111: FILE: tools/testing/selftests/bpf/progs/verifier_linked_scalars.c:102: + asm volatile (" \ WARNING: Avoid line continuations in quoted strings #111: FILE: tools/testing/selftests/bpf/progs/verifier_linked_scalars.c:102: + asm volatile (" \ CHECK: spaces preferred around that '%' (ctx:WxV) #112: FILE: tools/testing/selftests/bpf/progs/verifier_linked_scalars.c:103: + call %[bpf_get_prandom_u32]; \ ^ ERROR: spaces required around that '<' (ctx:VxW) #116: FILE: tools/testing/selftests/bpf/progs/verifier_linked_scalars.c:107: + if w1 s< 0 goto l0_%=; \ ^ ERROR: spaces required around that '%=' (ctx:VxO) #116: FILE: tools/testing/selftests/bpf/progs/verifier_linked_scalars.c:107: + if w1 s< 0 goto l0_%=; \ ^ ERROR: spaces required around that '%=' (ctx:VxO) #117: FILE: tools/testing/selftests/bpf/progs/verifier_linked_scalars.c:108: + if w0 != 0 goto l0_%=; \ ^ ERROR: spaces required around that '%=' (ctx:VxO) #119: FILE: tools/testing/selftests/bpf/progs/verifier_linked_scalars.c:110: +l0_%=: \ ^ ERROR: spaces required around that ':' (ctx:OxE) #119: FILE: tools/testing/selftests/bpf/progs/verifier_linked_scalars.c:110: +l0_%=: \ ^ WARNING: Avoid unnecessary line continuations #132: FILE: tools/testing/selftests/bpf/progs/verifier_linked_scalars.c:123: + asm volatile (" \ WARNING: Avoid line continuations in quoted strings #132: FILE: tools/testing/selftests/bpf/progs/verifier_linked_scalars.c:123: + asm volatile (" \ CHECK: spaces preferred around that '%' (ctx:WxV) #133: FILE: tools/testing/selftests/bpf/progs/verifier_linked_scalars.c:124: + call %[bpf_get_prandom_u32]; \ ^ ERROR: spaces required around that '%=' (ctx:VxO) #137: FILE: tools/testing/selftests/bpf/progs/verifier_linked_scalars.c:128: + if r1 < 6 goto l0_%=; \ ^ ERROR: spaces required around that '%=' (ctx:VxO) #138: FILE: tools/testing/selftests/bpf/progs/verifier_linked_scalars.c:129: + if r0 != 0 goto l0_%=; \ ^ ERROR: spaces required around that '%=' (ctx:VxO) #140: FILE: tools/testing/selftests/bpf/progs/verifier_linked_scalars.c:131: +l0_%=: \ ^ ERROR: spaces required around that ':' (ctx:OxE) #140: FILE: tools/testing/selftests/bpf/progs/verifier_linked_scalars.c:131: +l0_%=: \ ^ WARNING: Avoid unnecessary line continuations #153: FILE: tools/testing/selftests/bpf/progs/verifier_linked_scalars.c:144: + asm volatile (" \ WARNING: Avoid line continuations in quoted strings #153: FILE: tools/testing/selftests/bpf/progs/verifier_linked_scalars.c:144: + asm volatile (" \ CHECK: spaces preferred around that '%' (ctx:WxV) #154: FILE: tools/testing/selftests/bpf/progs/verifier_linked_scalars.c:145: + call %[bpf_get_prandom_u32]; \ ^ ERROR: spaces required around that '%=' (ctx:VxO) #158: FILE: tools/testing/selftests/bpf/progs/verifier_linked_scalars.c:149: + if r1 < 6 goto l0_%=; \ ^ ERROR: spaces required around that '%=' (ctx:VxO) #159: FILE: tools/testing/selftests/bpf/progs/verifier_linked_scalars.c:150: + if r0 != 0 goto l0_%=; \ ^ ERROR: spaces required around that '%=' (ctx:VxO) #161: FILE: tools/testing/selftests/bpf/progs/verifier_linked_scalars.c:152: +l0_%=: \ ^ ERROR: spaces required around that ':' (ctx:OxE) #161: FILE: tools/testing/selftests/bpf/progs/verifier_linked_scalars.c:152: +l0_%=: \ ^ WARNING: Avoid unnecessary line continuations #175: FILE: tools/testing/selftests/bpf/progs/verifier_linked_scalars.c:166: + asm volatile (" \ WARNING: Avoid line continuations in quoted strings #175: FILE: tools/testing/selftests/bpf/progs/verifier_linked_scalars.c:166: + asm volatile (" \ CHECK: spaces preferred around that '%' (ctx:WxV) #176: FILE: tools/testing/selftests/bpf/progs/verifier_linked_scalars.c:167: + call %[bpf_get_prandom_u32]; \ ^ ERROR: spaces required around that '%=' (ctx:VxO) #181: FILE: tools/testing/selftests/bpf/progs/verifier_linked_scalars.c:172: + if r1 < 6 goto l0_%=; \ ^ ERROR: spaces required around that '%=' (ctx:VxO) #182: FILE: tools/testing/selftests/bpf/progs/verifier_linked_scalars.c:173: + if r0 != 0 goto l0_%=; \ ^ ERROR: spaces required around that '%=' (ctx:VxO) #184: FILE: tools/testing/selftests/bpf/progs/verifier_linked_scalars.c:175: +l0_%=: \ ^ ERROR: spaces required around that ':' (ctx:OxE) #184: FILE: tools/testing/selftests/bpf/progs/verifier_linked_scalars.c:175: +l0_%=: \ ^ WARNING: please, no spaces at the start of a line #193: FILE: tools/testing/selftests/bpf/progs/verifier_linked_scalars.c:184: + * Test that sync_linked_regs() correctly handles large offset differences.$ WARNING: please, no spaces at the start of a line #194: FILE: tools/testing/selftests/bpf/progs/verifier_linked_scalars.c:185: + * r1.off = S32_MIN, r2.off = 1, delta = S32_MIN - 1 requires 64-bit math.$ WARNING: please, no spaces at the start of a line #195: FILE: tools/testing/selftests/bpf/progs/verifier_linked_scalars.c:186: + */$ WARNING: Avoid unnecessary line continuations #200: FILE: tools/testing/selftests/bpf/progs/verifier_linked_scalars.c:191: + asm volatile (" \ WARNING: Avoid line continuations in quoted strings #200: FILE: tools/testing/selftests/bpf/progs/verifier_linked_scalars.c:191: + asm volatile (" \ CHECK: spaces preferred around that '%' (ctx:WxV) #201: FILE: tools/testing/selftests/bpf/progs/verifier_linked_scalars.c:192: + call %[bpf_get_prandom_u32]; \ ^ CHECK: spaces preferred around that '%' (ctx:WxV) #205: FILE: tools/testing/selftests/bpf/progs/verifier_linked_scalars.c:196: + r1 += %[s32_min]; \ ^ ERROR: spaces required around that '<' (ctx:VxW) #207: FILE: tools/testing/selftests/bpf/progs/verifier_linked_scalars.c:198: + if r2 s< 100 goto l0_%=; \ ^ ERROR: spaces required around that '%=' (ctx:VxO) #207: FILE: tools/testing/selftests/bpf/progs/verifier_linked_scalars.c:198: + if r2 s< 100 goto l0_%=; \ ^ ERROR: spaces required around that '<' (ctx:VxW) #208: FILE: tools/testing/selftests/bpf/progs/verifier_linked_scalars.c:199: + if r1 s< 0 goto l0_%=; \ ^ ERROR: spaces required around that '%=' (ctx:VxO) #208: FILE: tools/testing/selftests/bpf/progs/verifier_linked_scalars.c:199: + if r1 s< 0 goto l0_%=; \ ^ ERROR: spaces required around that '%=' (ctx:VxO) #210: FILE: tools/testing/selftests/bpf/progs/verifier_linked_scalars.c:201: +l0_%=: \ ^ ERROR: spaces required around that ':' (ctx:OxE) #210: FILE: tools/testing/selftests/bpf/progs/verifier_linked_scalars.c:201: +l0_%=: \ ^ WARNING: please, no spaces at the start of a line #220: FILE: tools/testing/selftests/bpf/progs/verifier_linked_scalars.c:211: + * Another large delta case: r1.off = S32_MAX, r2.off = -1.$ WARNING: please, no spaces at the start of a line #221: FILE: tools/testing/selftests/bpf/progs/verifier_linked_scalars.c:212: + * delta = S32_MAX - (-1) = S32_MAX + 1 requires 64-bit math.$ WARNING: please, no spaces at the start of a line #222: FILE: tools/testing/selftests/bpf/progs/verifier_linked_scalars.c:213: + */$ WARNING: Avoid unnecessary line continuations #227: FILE: tools/testing/selftests/bpf/progs/verifier_linked_scalars.c:218: + asm volatile (" \ WARNING: Avoid line continuations in quoted strings #227: FILE: tools/testing/selftests/bpf/progs/verifier_linked_scalars.c:218: + asm volatile (" \ CHECK: spaces preferred around that '%' (ctx:WxV) #228: FILE: tools/testing/selftests/bpf/progs/verifier_linked_scalars.c:219: + call %[bpf_get_prandom_u32]; \ ^ CHECK: spaces preferred around that '%' (ctx:WxV) #232: FILE: tools/testing/selftests/bpf/progs/verifier_linked_scalars.c:223: + r1 += %[s32_max]; \ ^ ERROR: spaces required around that '<' (ctx:VxW) #234: FILE: tools/testing/selftests/bpf/progs/verifier_linked_scalars.c:225: + if r2 s< 0 goto l0_%=; \ ^ ERROR: spaces required around that '%=' (ctx:VxO) #234: FILE: tools/testing/selftests/bpf/progs/verifier_linked_scalars.c:225: + if r2 s< 0 goto l0_%=; \ ^ ERROR: spaces required around that '>=' (ctx:VxW) #235: FILE: tools/testing/selftests/bpf/progs/verifier_linked_scalars.c:226: + if r1 s>= 0 goto l0_%=; \ ^ ERROR: spaces required around that '%=' (ctx:VxO) #235: FILE: tools/testing/selftests/bpf/progs/verifier_linked_scalars.c:226: + if r1 s>= 0 goto l0_%=; \ ^ ERROR: spaces required around that '%=' (ctx:VxO) #237: FILE: tools/testing/selftests/bpf/progs/verifier_linked_scalars.c:228: +l0_%=: \ ^ ERROR: spaces required around that ':' (ctx:OxE) #237: FILE: tools/testing/selftests/bpf/progs/verifier_linked_scalars.c:228: +l0_%=: \ ^ WARNING: line length of 81 exceeds 80 columns #247: FILE: tools/testing/selftests/bpf/progs/verifier_linked_scalars.c:238: + * Test linked scalar tracking with alu32 and large positive offset (0x7FFFFFFF). WARNING: please, no spaces at the start of a line #247: FILE: tools/testing/selftests/bpf/progs/verifier_linked_scalars.c:238: + * Test linked scalar tracking with alu32 and large positive offset (0x7FFFFFFF).$ WARNING: please, no spaces at the start of a line #248: FILE: tools/testing/selftests/bpf/progs/verifier_linked_scalars.c:239: + * After w1 += 0x7FFFFFFF, w1 wraps to negative for any r0 >= 1.$ WARNING: please, no spaces at the start of a line #249: FILE: tools/testing/selftests/bpf/progs/verifier_linked_scalars.c:240: + * If w1 is signed-negative, then r0 >= 1, so r0 != 0.$ WARNING: please, no spaces at the start of a line #250: FILE: tools/testing/selftests/bpf/progs/verifier_linked_scalars.c:241: + */$ WARNING: Avoid unnecessary line continuations #255: FILE: tools/testing/selftests/bpf/progs/verifier_linked_scalars.c:246: + asm volatile (" \ WARNING: Avoid line continuations in quoted strings #255: FILE: tools/testing/selftests/bpf/progs/verifier_linked_scalars.c:246: + asm volatile (" \ CHECK: spaces preferred around that '%' (ctx:WxV) #256: FILE: tools/testing/selftests/bpf/progs/verifier_linked_scalars.c:247: + call %[bpf_get_prandom_u32]; \ ^ ERROR: spaces required around that '>=' (ctx:VxW) #260: FILE: tools/testing/selftests/bpf/progs/verifier_linked_scalars.c:251: + if w1 s>= 0 goto l0_%=; \ ^ ERROR: spaces required around that '%=' (ctx:VxO) #260: FILE: tools/testing/selftests/bpf/progs/verifier_linked_scalars.c:251: + if w1 s>= 0 goto l0_%=; \ ^ ERROR: spaces required around that '%=' (ctx:VxO) #261: FILE: tools/testing/selftests/bpf/progs/verifier_linked_scalars.c:252: + if w0 != 0 goto l0_%=; \ ^ ERROR: spaces required around that '%=' (ctx:VxO) #263: FILE: tools/testing/selftests/bpf/progs/verifier_linked_scalars.c:254: +l0_%=: \ ^ ERROR: spaces required around that ':' (ctx:OxE) #263: FILE: tools/testing/selftests/bpf/progs/verifier_linked_scalars.c:254: +l0_%=: \ ^ total: 52 errors, 31 warnings, 12 checks, 249 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Commit e0c20dc83d9f ("selftests/bpf: Add tests for improved linked register tracking") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE FILE_PATH_CHANGES GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS.