====== Checking before the patch ====== ====== Checking the tree with the patch ====== New warnings added --- /tmp/tmp.213Kg3RVgh 2026-01-08 18:14:35.905878410 -0500 +++ /tmp/tmp.l5OK8mfoXz 2026-01-08 18:14:37.292866015 -0500 @@ -3 +3 @@ -tools/testing/selftests/net/lib/py/ksft.py:364:0: C0301: Line too long (126/100) (line-too-long) +tools/testing/selftests/net/lib/py/ksft.py:371:0: C0301: Line too long (126/100) (line-too-long) @@ -28,22 +28,22 @@ -tools/testing/selftests/net/lib/py/ksft.py:156:0: C0116: Missing function or method docstring (missing-function-docstring) -tools/testing/selftests/net/lib/py/ksft.py:157:4: W0603: Using the global statement (global-statement) -tools/testing/selftests/net/lib/py/ksft.py:166:15: W0718: Catching too general exception Exception (broad-exception-caught) -tools/testing/selftests/net/lib/py/ksft.py:193:0: R0903: Too few public methods (0/2) (too-few-public-methods) -tools/testing/selftests/net/lib/py/ksft.py:243:12: W0707: Consider explicitly re-raising using 'except Exception as exc' and 'raise Exception(f'failed to parse {name}') from exc' (raise-missing-from) -tools/testing/selftests/net/lib/py/ksft.py:243:12: W0719: Raising too general exception: Exception (broad-exception-raised) -tools/testing/selftests/net/lib/py/ksft.py:246:8: W0603: Using the global statement (global-statement) -tools/testing/selftests/net/lib/py/ksft.py:255:4: W0601: Global variable 'term_cnt' undefined at the module level (global-variable-undefined) -tools/testing/selftests/net/lib/py/ksft.py:256:4: E0602: Undefined variable 'term_cnt' (undefined-variable) -tools/testing/selftests/net/lib/py/ksft.py:257:4: R1720: Unnecessary "else" after "raise", remove the "else" and de-indent the code inside it (no-else-raise) -tools/testing/selftests/net/lib/py/ksft.py:252:15: W0613: Unused argument 'signum' (unused-argument) -tools/testing/selftests/net/lib/py/ksft.py:252:23: W0613: Unused argument 'frame' (unused-argument) -tools/testing/selftests/net/lib/py/ksft.py:297:0: C0116: Missing function or method docstring (missing-function-docstring) -tools/testing/selftests/net/lib/py/ksft.py:297:0: R0914: Too many local variables (16/15) (too-many-locals) -tools/testing/selftests/net/lib/py/ksft.py:300:4: W0601: Global variable 'term_cnt' undefined at the module level (global-variable-undefined) -tools/testing/selftests/net/lib/py/ksft.py:309:4: W0603: Using the global statement (global-statement) -tools/testing/selftests/net/lib/py/ksft.py:312:14: R1704: Redefining argument with the local name 'args' (redefined-argument-from-local) -tools/testing/selftests/net/lib/py/ksft.py:326:15: W0718: Catching too general exception BaseException (broad-exception-caught) -tools/testing/selftests/net/lib/py/ksft.py:338:15: W0718: Catching too general exception BaseException (broad-exception-caught) -tools/testing/selftests/net/lib/py/ksft.py:297:0: R0915: Too many statements (54/50) (too-many-statements) -tools/testing/selftests/net/lib/py/ksft.py:368:0: C0116: Missing function or method docstring (missing-function-docstring) -tools/testing/selftests/net/lib/py/ksft.py:369:4: W0602: Using global for 'KSFT_RESULT_ALL' but no assignment is done (global-variable-not-assigned) +tools/testing/selftests/net/lib/py/ksft.py:161:0: C0116: Missing function or method docstring (missing-function-docstring) +tools/testing/selftests/net/lib/py/ksft.py:162:4: W0603: Using the global statement (global-statement) +tools/testing/selftests/net/lib/py/ksft.py:171:15: W0718: Catching too general exception Exception (broad-exception-caught) +tools/testing/selftests/net/lib/py/ksft.py:198:0: R0903: Too few public methods (0/2) (too-few-public-methods) +tools/testing/selftests/net/lib/py/ksft.py:248:12: W0707: Consider explicitly re-raising using 'except Exception as exc' and 'raise Exception(f'failed to parse {name}') from exc' (raise-missing-from) +tools/testing/selftests/net/lib/py/ksft.py:248:12: W0719: Raising too general exception: Exception (broad-exception-raised) +tools/testing/selftests/net/lib/py/ksft.py:251:8: W0603: Using the global statement (global-statement) +tools/testing/selftests/net/lib/py/ksft.py:260:4: W0601: Global variable 'term_cnt' undefined at the module level (global-variable-undefined) +tools/testing/selftests/net/lib/py/ksft.py:261:4: E0602: Undefined variable 'term_cnt' (undefined-variable) +tools/testing/selftests/net/lib/py/ksft.py:262:4: R1720: Unnecessary "else" after "raise", remove the "else" and de-indent the code inside it (no-else-raise) +tools/testing/selftests/net/lib/py/ksft.py:257:15: W0613: Unused argument 'signum' (unused-argument) +tools/testing/selftests/net/lib/py/ksft.py:257:23: W0613: Unused argument 'frame' (unused-argument) +tools/testing/selftests/net/lib/py/ksft.py:302:0: C0116: Missing function or method docstring (missing-function-docstring) +tools/testing/selftests/net/lib/py/ksft.py:302:0: R0914: Too many local variables (16/15) (too-many-locals) +tools/testing/selftests/net/lib/py/ksft.py:305:4: W0601: Global variable 'term_cnt' undefined at the module level (global-variable-undefined) +tools/testing/selftests/net/lib/py/ksft.py:314:4: W0603: Using the global statement (global-statement) +tools/testing/selftests/net/lib/py/ksft.py:317:14: R1704: Redefining argument with the local name 'args' (redefined-argument-from-local) +tools/testing/selftests/net/lib/py/ksft.py:332:15: W0718: Catching too general exception BaseException (broad-exception-caught) +tools/testing/selftests/net/lib/py/ksft.py:345:15: W0718: Catching too general exception BaseException (broad-exception-caught) +tools/testing/selftests/net/lib/py/ksft.py:302:0: R0915: Too many statements (56/50) (too-many-statements) +tools/testing/selftests/net/lib/py/ksft.py:375:0: C0116: Missing function or method docstring (missing-function-docstring) +tools/testing/selftests/net/lib/py/ksft.py:376:4: W0602: Using global for 'KSFT_RESULT_ALL' but no assignment is done (global-variable-not-assigned) @@ -52 +52 @@ -Your code has been rated at 7.76/10 (previous run: 7.76/10, +0.00) +Your code has been rated at 7.80/10 (previous run: 7.76/10, +0.04) @@ -55 +55 @@ -tools/testing/selftests/net/lib/py/utils.py:150:0: C0301: Line too long (124/100) (line-too-long) +tools/testing/selftests/net/lib/py/utils.py:151:0: C0301: Line too long (124/100) (line-too-long) @@ -71,4 +71,4 @@ -tools/testing/selftests/net/lib/py/utils.py:147:0: C0115: Missing class docstring (missing-class-docstring) -tools/testing/selftests/net/lib/py/utils.py:147:0: C0103: Class name "defer" doesn't conform to PascalCase naming style (invalid-name) -tools/testing/selftests/net/lib/py/utils.py:150:12: W0719: Raising too general exception: Exception (broad-exception-raised) -tools/testing/selftests/net/lib/py/utils.py:165:4: C0116: Missing function or method docstring (missing-function-docstring) +tools/testing/selftests/net/lib/py/utils.py:148:0: C0115: Missing class docstring (missing-class-docstring) +tools/testing/selftests/net/lib/py/utils.py:148:0: C0103: Class name "defer" doesn't conform to PascalCase naming style (invalid-name) +tools/testing/selftests/net/lib/py/utils.py:151:12: W0719: Raising too general exception: Exception (broad-exception-raised) +tools/testing/selftests/net/lib/py/utils.py:158:12: W0719: Raising too general exception: Exception (broad-exception-raised) @@ -77,8 +77,9 @@ -tools/testing/selftests/net/lib/py/utils.py:176:0: C0116: Missing function or method docstring (missing-function-docstring) -tools/testing/selftests/net/lib/py/utils.py:187:0: C0116: Missing function or method docstring (missing-function-docstring) -tools/testing/selftests/net/lib/py/utils.py:191:0: C0116: Missing function or method docstring (missing-function-docstring) -tools/testing/selftests/net/lib/py/utils.py:197:0: C0116: Missing function or method docstring (missing-function-docstring) -tools/testing/selftests/net/lib/py/utils.py:245:0: C0116: Missing function or method docstring (missing-function-docstring) -tools/testing/selftests/net/lib/py/utils.py:245:0: R0913: Too many arguments (6/5) (too-many-arguments) -tools/testing/selftests/net/lib/py/utils.py:245:0: R0917: Too many positional arguments (6/5) (too-many-positional-arguments) -tools/testing/selftests/net/lib/py/utils.py:259:12: W0719: Raising too general exception: Exception (broad-exception-raised) +tools/testing/selftests/net/lib/py/utils.py:174:4: C0116: Missing function or method docstring (missing-function-docstring) +tools/testing/selftests/net/lib/py/utils.py:179:0: C0116: Missing function or method docstring (missing-function-docstring) +tools/testing/selftests/net/lib/py/utils.py:190:0: C0116: Missing function or method docstring (missing-function-docstring) +tools/testing/selftests/net/lib/py/utils.py:194:0: C0116: Missing function or method docstring (missing-function-docstring) +tools/testing/selftests/net/lib/py/utils.py:200:0: C0116: Missing function or method docstring (missing-function-docstring) +tools/testing/selftests/net/lib/py/utils.py:248:0: C0116: Missing function or method docstring (missing-function-docstring) +tools/testing/selftests/net/lib/py/utils.py:248:0: R0913: Too many arguments (6/5) (too-many-arguments) +tools/testing/selftests/net/lib/py/utils.py:248:0: R0917: Too many positional arguments (6/5) (too-many-positional-arguments) +tools/testing/selftests/net/lib/py/utils.py:262:12: W0719: Raising too general exception: Exception (broad-exception-raised) @@ -87 +88 @@ -Your code has been rated at 8.24/10 (previous run: 8.24/10, +0.00) +Your code has been rated at 8.21/10 (previous run: 8.24/10, -0.03)