pylint 3.3.9 astroid 3.3.8 Python 3.14.2 (main, Dec 5 2025, 00:00:00) [GCC 15.2.1 20251111 (Red Hat 15.2.1-4)] Redirect to /tmp/tmp.tJekJaq4d1 and /tmp/tmp.UEN1Hx7ueE Tree base: 432077f4b480 ("tools: ynl: fix logic errors reported by pylint") Now at: 75737bfcc57f ("tools: ynl: ethtool: fix pylint issues") ====== Checking before the patch ====== ************* Module pyynl.ethtool tools/net/ynl/pyynl/ethtool.py:148:5: W0511: TODO: --show-tunnels tunnel-info-get (fixme) tools/net/ynl/pyynl/ethtool.py:149:5: W0511: TODO: --show-module module-get (fixme) tools/net/ynl/pyynl/ethtool.py:150:5: W0511: TODO: --get-plca-cfg plca-get (fixme) tools/net/ynl/pyynl/ethtool.py:151:5: W0511: TODO: --get-plca-status plca-get-status (fixme) tools/net/ynl/pyynl/ethtool.py:152:5: W0511: TODO: --show-mm mm-get (fixme) tools/net/ynl/pyynl/ethtool.py:153:5: W0511: TODO: --show-fec fec-get (fixme) tools/net/ynl/pyynl/ethtool.py:154:5: W0511: TODO: --dump-module-eerpom module-eeprom-get (fixme) tools/net/ynl/pyynl/ethtool.py:155:5: W0511: TODO: pse-get (fixme) tools/net/ynl/pyynl/ethtool.py:156:5: W0511: TODO: rss-get (fixme) tools/net/ynl/pyynl/ethtool.py:168:9: W0511: TODO: parse the bitmask (fixme) tools/net/ynl/pyynl/ethtool.py:182:9: W0511: TODO: parse the bitmask (fixme) tools/net/ynl/pyynl/ethtool.py:305:9: W0511: TODO: pass id? (fixme) tools/net/ynl/pyynl/ethtool.py:314:17: W0511: TODO: support passing the bitmask (fixme) tools/net/ynl/pyynl/ethtool.py:443:5: W0511: TODO: wol-get (fixme) tools/net/ynl/pyynl/ethtool.py:1:0: C0114: Missing module docstring (missing-module-docstring) tools/net/ynl/pyynl/ethtool.py:14:0: E0401: Unable to import 'cli' (import-error) tools/net/ynl/pyynl/ethtool.py:16:30: W0621: Redefining name 'args' from outer scope (line 160) (redefined-outer-name) tools/net/ynl/pyynl/ethtool.py:43:0: R1710: Either all return statements in a function should return an expression, or none of them should. (inconsistent-return-statements) tools/net/ynl/pyynl/ethtool.py:79:14: W0621: Redefining name 'args' from outer scope (line 160) (redefined-outer-name) tools/net/ynl/pyynl/ethtool.py:92:0: W0102: Dangerous default value {} as argument (dangerous-default-value) tools/net/ynl/pyynl/ethtool.py:92:16: W0621: Redefining name 'args' from outer scope (line 160) (redefined-outer-name) tools/net/ynl/pyynl/ethtool.py:118:15: R1735: Consider using '{}' instead of a call to 'dict'. (use-dict-literal) tools/net/ynl/pyynl/ethtool.py:120:15: R1735: Consider using '{}' instead of a call to 'dict'. (use-dict-literal) tools/net/ynl/pyynl/ethtool.py:129:0: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/ethtool.py:129:0: R0914: Too many local variables (40/15) (too-many-locals) tools/net/ynl/pyynl/ethtool.py:159:4: W0601: Global variable 'args' undefined at the module level (global-variable-undefined) tools/net/ynl/pyynl/ethtool.py:341:8: W0106: Expression "[print(f'\t{v}') for v in bits_to_dict(tsinfo['timestamping'])]" is assigned to nothing (expression-not-assigned) tools/net/ynl/pyynl/ethtool.py:347:12: W0106: Expression "[print(f'\t{v}') for v in bits_to_dict(tsinfo['tx-types'])]" is assigned to nothing (expression-not-assigned) tools/net/ynl/pyynl/ethtool.py:353:12: W0106: Expression "[print(f'\t{v}') for v in bits_to_dict(tsinfo['rx-filters'])]" is assigned to nothing (expression-not-assigned) tools/net/ynl/pyynl/ethtool.py:359:12: W0106: Expression "[print(f'\t{k}: {v}') for (k, v) in tsinfo['stats'].items()]" is assigned to nothing (expression-not-assigned) tools/net/ynl/pyynl/ethtool.py:129:0: R0911: Too many return statements (16/6) (too-many-return-statements) tools/net/ynl/pyynl/ethtool.py:129:0: R0912: Too many branches (37/12) (too-many-branches) tools/net/ynl/pyynl/ethtool.py:129:0: R0915: Too many statements (167/50) (too-many-statements) tools/net/ynl/pyynl/ethtool.py:129:0: R1710: Either all return statements in a function should return an expression, or none of them should. (inconsistent-return-statements) tools/net/ynl/pyynl/ethtool.py:14:0: C0411: third party import "cli.schema_dir" should be placed before first party import "lib.YnlFamily" (wrong-import-order) ------------------------------------------------------------------ Your code has been rated at 8.49/10 (previous run: 8.49/10, +0.00) ====== Checking the tree with the patch ====== ************* Module pyynl.ethtool tools/net/ynl/pyynl/ethtool.py:159:5: W0511: TODO: --show-tunnels tunnel-info-get (fixme) tools/net/ynl/pyynl/ethtool.py:160:5: W0511: TODO: --show-module module-get (fixme) tools/net/ynl/pyynl/ethtool.py:161:5: W0511: TODO: --get-plca-cfg plca-get (fixme) tools/net/ynl/pyynl/ethtool.py:162:5: W0511: TODO: --get-plca-status plca-get-status (fixme) tools/net/ynl/pyynl/ethtool.py:163:5: W0511: TODO: --show-mm mm-get (fixme) tools/net/ynl/pyynl/ethtool.py:164:5: W0511: TODO: --show-fec fec-get (fixme) tools/net/ynl/pyynl/ethtool.py:165:5: W0511: TODO: --dump-module-eerpom module-eeprom-get (fixme) tools/net/ynl/pyynl/ethtool.py:166:5: W0511: TODO: pse-get (fixme) tools/net/ynl/pyynl/ethtool.py:167:5: W0511: TODO: rss-get (fixme) tools/net/ynl/pyynl/ethtool.py:179:9: W0511: TODO: parse the bitmask (fixme) tools/net/ynl/pyynl/ethtool.py:196:9: W0511: TODO: parse the bitmask (fixme) tools/net/ynl/pyynl/ethtool.py:321:9: W0511: TODO: pass id? (fixme) tools/net/ynl/pyynl/ethtool.py:330:17: W0511: TODO: support passing the bitmask (fixme) tools/net/ynl/pyynl/ethtool.py:459:5: W0511: TODO: wol-get (fixme) ------------------------------------------------------------------ Your code has been rated at 9.47/10 (previous run: 8.49/10, +0.98)