ERROR: spaces required around that ':' (ctx:VxW) #39: FILE: tools/testing/selftests/bpf/progs/verifier_linked_scalars.c:35: +__description("scalars: linked scalars with negative offset") ^ WARNING: Avoid unnecessary line continuations #43: FILE: tools/testing/selftests/bpf/progs/verifier_linked_scalars.c:39: + asm volatile (" \ WARNING: Avoid line continuations in quoted strings #43: FILE: tools/testing/selftests/bpf/progs/verifier_linked_scalars.c:39: + asm volatile (" \ CHECK: spaces preferred around that '%' (ctx:WxV) #44: FILE: tools/testing/selftests/bpf/progs/verifier_linked_scalars.c:40: + call %[bpf_get_prandom_u32]; \ ^ ERROR: spaces required around that '<' (ctx:VxW) #48: FILE: tools/testing/selftests/bpf/progs/verifier_linked_scalars.c:44: + if r1 s< 0 goto l2; \ ^ ERROR: spaces required around that ':' (ctx:VxW) #61: FILE: tools/testing/selftests/bpf/progs/verifier_linked_scalars.c:57: +__description("scalars: linked scalars with SUB") ^ WARNING: Avoid unnecessary line continuations #65: FILE: tools/testing/selftests/bpf/progs/verifier_linked_scalars.c:61: + asm volatile (" \ WARNING: Avoid line continuations in quoted strings #65: FILE: tools/testing/selftests/bpf/progs/verifier_linked_scalars.c:61: + asm volatile (" \ CHECK: spaces preferred around that '%' (ctx:WxV) #66: FILE: tools/testing/selftests/bpf/progs/verifier_linked_scalars.c:62: + call %[bpf_get_prandom_u32]; \ ^ ERROR: spaces required around that '<' (ctx:VxW) #70: FILE: tools/testing/selftests/bpf/progs/verifier_linked_scalars.c:66: + if r1 s< 0 goto l2_sub; \ ^ ERROR: spaces required around that ':' (ctx:VxW) #83: FILE: tools/testing/selftests/bpf/progs/verifier_linked_scalars.c:79: +__description("scalars: linked scalars 32-bit ADD not tracked") ^ CHECK: spaces preferred around that '-' (ctx:VxV) #83: FILE: tools/testing/selftests/bpf/progs/verifier_linked_scalars.c:79: +__description("scalars: linked scalars 32-bit ADD not tracked") ^ WARNING: Avoid unnecessary line continuations #88: FILE: tools/testing/selftests/bpf/progs/verifier_linked_scalars.c:84: + asm volatile (" \ WARNING: Avoid line continuations in quoted strings #88: FILE: tools/testing/selftests/bpf/progs/verifier_linked_scalars.c:84: + asm volatile (" \ CHECK: spaces preferred around that '%' (ctx:WxV) #89: FILE: tools/testing/selftests/bpf/progs/verifier_linked_scalars.c:85: + call %[bpf_get_prandom_u32]; \ ^ ERROR: spaces required around that '<' (ctx:VxW) #93: FILE: tools/testing/selftests/bpf/progs/verifier_linked_scalars.c:89: + if w1 s< 0 goto l2_alu32_add; \ ^ ERROR: spaces required around that ':' (ctx:VxW) #106: FILE: tools/testing/selftests/bpf/progs/verifier_linked_scalars.c:102: +__description("scalars: linked scalars 32-bit SUB not tracked") ^ CHECK: spaces preferred around that '-' (ctx:VxV) #106: FILE: tools/testing/selftests/bpf/progs/verifier_linked_scalars.c:102: +__description("scalars: linked scalars 32-bit SUB not tracked") ^ WARNING: Avoid unnecessary line continuations #111: FILE: tools/testing/selftests/bpf/progs/verifier_linked_scalars.c:107: + asm volatile (" \ WARNING: Avoid line continuations in quoted strings #111: FILE: tools/testing/selftests/bpf/progs/verifier_linked_scalars.c:107: + asm volatile (" \ CHECK: spaces preferred around that '%' (ctx:WxV) #112: FILE: tools/testing/selftests/bpf/progs/verifier_linked_scalars.c:108: + call %[bpf_get_prandom_u32]; \ ^ ERROR: spaces required around that '<' (ctx:VxW) #116: FILE: tools/testing/selftests/bpf/progs/verifier_linked_scalars.c:112: + if w1 s< 0 goto l2_alu32_sub; \ ^ ERROR: spaces required around that ':' (ctx:VxW) #129: FILE: tools/testing/selftests/bpf/progs/verifier_linked_scalars.c:125: +__description("scalars: linked scalars positive offset") ^ WARNING: Avoid unnecessary line continuations #133: FILE: tools/testing/selftests/bpf/progs/verifier_linked_scalars.c:129: + asm volatile (" \ WARNING: Avoid line continuations in quoted strings #133: FILE: tools/testing/selftests/bpf/progs/verifier_linked_scalars.c:129: + asm volatile (" \ CHECK: spaces preferred around that '%' (ctx:WxV) #134: FILE: tools/testing/selftests/bpf/progs/verifier_linked_scalars.c:130: + call %[bpf_get_prandom_u32]; \ ^ ERROR: spaces required around that ':' (ctx:VxW) #151: FILE: tools/testing/selftests/bpf/progs/verifier_linked_scalars.c:147: +__description("scalars: linked scalars SUB negative immediate") ^ WARNING: Avoid unnecessary line continuations #155: FILE: tools/testing/selftests/bpf/progs/verifier_linked_scalars.c:151: + asm volatile (" \ WARNING: Avoid line continuations in quoted strings #155: FILE: tools/testing/selftests/bpf/progs/verifier_linked_scalars.c:151: + asm volatile (" \ CHECK: spaces preferred around that '%' (ctx:WxV) #156: FILE: tools/testing/selftests/bpf/progs/verifier_linked_scalars.c:152: + call %[bpf_get_prandom_u32]; \ ^ ERROR: spaces required around that ':' (ctx:VxW) #173: FILE: tools/testing/selftests/bpf/progs/verifier_linked_scalars.c:169: +__description("scalars: linked scalars double ADD clears ID") ^ WARNING: Avoid unnecessary line continuations #178: FILE: tools/testing/selftests/bpf/progs/verifier_linked_scalars.c:174: + asm volatile (" \ WARNING: Avoid line continuations in quoted strings #178: FILE: tools/testing/selftests/bpf/progs/verifier_linked_scalars.c:174: + asm volatile (" \ CHECK: spaces preferred around that '%' (ctx:WxV) #179: FILE: tools/testing/selftests/bpf/progs/verifier_linked_scalars.c:175: + call %[bpf_get_prandom_u32]; \ ^ WARNING: please, no spaces at the start of a line #196: FILE: tools/testing/selftests/bpf/progs/verifier_linked_scalars.c:192: + * Test that sync_linked_regs() correctly handles large offset differences.$ WARNING: please, no spaces at the start of a line #197: FILE: tools/testing/selftests/bpf/progs/verifier_linked_scalars.c:193: + * r1.off = S32_MIN, r2.off = 1, delta = S32_MIN - 1 requires 64-bit math.$ WARNING: please, no spaces at the start of a line #198: FILE: tools/testing/selftests/bpf/progs/verifier_linked_scalars.c:194: + */$ WARNING: space prohibited between function name and open parenthesis '(' #200: FILE: tools/testing/selftests/bpf/progs/verifier_linked_scalars.c:196: +__description("scalars: linked regs sync with large delta (S32_MIN offset)") ERROR: spaces required around that ':' (ctx:VxW) #200: FILE: tools/testing/selftests/bpf/progs/verifier_linked_scalars.c:196: +__description("scalars: linked regs sync with large delta (S32_MIN offset)") ^ WARNING: Avoid unnecessary line continuations #204: FILE: tools/testing/selftests/bpf/progs/verifier_linked_scalars.c:200: + asm volatile (" \ WARNING: Avoid line continuations in quoted strings #204: FILE: tools/testing/selftests/bpf/progs/verifier_linked_scalars.c:200: + asm volatile (" \ CHECK: spaces preferred around that '%' (ctx:WxV) #205: FILE: tools/testing/selftests/bpf/progs/verifier_linked_scalars.c:201: + call %[bpf_get_prandom_u32]; \ ^ CHECK: spaces preferred around that '%' (ctx:WxV) #209: FILE: tools/testing/selftests/bpf/progs/verifier_linked_scalars.c:205: + r1 += %[s32_min]; \ ^ ERROR: spaces required around that '<' (ctx:VxW) #211: FILE: tools/testing/selftests/bpf/progs/verifier_linked_scalars.c:207: + if r2 s< 100 goto l2_overflow; \ ^ ERROR: spaces required around that '<' (ctx:VxW) #212: FILE: tools/testing/selftests/bpf/progs/verifier_linked_scalars.c:208: + if r1 s< 0 goto l2_overflow; \ ^ WARNING: please, no spaces at the start of a line #224: FILE: tools/testing/selftests/bpf/progs/verifier_linked_scalars.c:220: + * Another large delta case: r1.off = S32_MAX, r2.off = -1.$ WARNING: please, no spaces at the start of a line #225: FILE: tools/testing/selftests/bpf/progs/verifier_linked_scalars.c:221: + * delta = S32_MAX - (-1) = S32_MAX + 1 requires 64-bit math.$ WARNING: please, no spaces at the start of a line #226: FILE: tools/testing/selftests/bpf/progs/verifier_linked_scalars.c:222: + */$ WARNING: space prohibited between function name and open parenthesis '(' #228: FILE: tools/testing/selftests/bpf/progs/verifier_linked_scalars.c:224: +__description("scalars: linked regs sync with large delta (S32_MAX offset)") ERROR: spaces required around that ':' (ctx:VxW) #228: FILE: tools/testing/selftests/bpf/progs/verifier_linked_scalars.c:224: +__description("scalars: linked regs sync with large delta (S32_MAX offset)") ^ WARNING: Avoid unnecessary line continuations #232: FILE: tools/testing/selftests/bpf/progs/verifier_linked_scalars.c:228: + asm volatile (" \ WARNING: Avoid line continuations in quoted strings #232: FILE: tools/testing/selftests/bpf/progs/verifier_linked_scalars.c:228: + asm volatile (" \ CHECK: spaces preferred around that '%' (ctx:WxV) #233: FILE: tools/testing/selftests/bpf/progs/verifier_linked_scalars.c:229: + call %[bpf_get_prandom_u32]; \ ^ CHECK: spaces preferred around that '%' (ctx:WxV) #237: FILE: tools/testing/selftests/bpf/progs/verifier_linked_scalars.c:233: + r1 += %[s32_max]; \ ^ ERROR: spaces required around that '<' (ctx:VxW) #239: FILE: tools/testing/selftests/bpf/progs/verifier_linked_scalars.c:235: + if r2 s< 0 goto l2_large; \ ^ ERROR: spaces required around that '>=' (ctx:VxW) #240: FILE: tools/testing/selftests/bpf/progs/verifier_linked_scalars.c:236: + if r1 s>= 0 goto l2_large; \ ^ total: 17 errors, 26 warnings, 13 checks, 217 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Commit 244e7087d831 ("selftests/bpf: Add tests for linked register tracking with negative offsets") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE FILE_PATH_CHANGES GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS.