WARNING: line length of 84 exceeds 80 columns #41: FILE: tools/testing/selftests/bpf/prog_tests/htab_update.c:154: +static void test_lru_hash_map_update_elem(enum bpf_map_type map_type, u64 map_flags) WARNING: Missing a blank line after declarations #47: FILE: tools/testing/selftests/bpf/prog_tests/htab_update.c:160: + cpu_set_t cpus; + LIBBPF_OPTS(bpf_map_create_opts, opts, WARNING: line length of 100 exceeds 80 columns #61: FILE: tools/testing/selftests/bpf/prog_tests/htab_update.c:174: + map_fd = bpf_map_create(map_type, "test_lru", sizeof(int), sizeof(u64), max_entries, &opts); CHECK: spaces preferred around that '%' (ctx:VxV) #69: FILE: tools/testing/selftests/bpf/prog_tests/htab_update.c:182: + __setaffinity(&cpus, key%nr_cpus); ^ WARNING: line length of 89 exceeds 80 columns #77: FILE: tools/testing/selftests/bpf/prog_tests/htab_update.c:190: +#define CHECK_OTHER_CPUS_VALUES(__val) \ WARNING: Macros with flow control statements should be avoided #77: FILE: tools/testing/selftests/bpf/prog_tests/htab_update.c:190: +#define CHECK_OTHER_CPUS_VALUES(__val) \ + do { \ + if (!percpu) \ + break; \ + for (i = 1; i < nr_cpus; i++) \ + if (!ASSERT_EQ(values[i], __val, "bpf_map_lookup_elem value")) \ + goto out; \ + } while (0) WARNING: line length of 89 exceeds 80 columns #78: FILE: tools/testing/selftests/bpf/prog_tests/htab_update.c:191: + do { \ WARNING: line length of 89 exceeds 80 columns #79: FILE: tools/testing/selftests/bpf/prog_tests/htab_update.c:192: + if (!percpu) \ WARNING: line length of 89 exceeds 80 columns #80: FILE: tools/testing/selftests/bpf/prog_tests/htab_update.c:193: + break; \ WARNING: line length of 89 exceeds 80 columns #81: FILE: tools/testing/selftests/bpf/prog_tests/htab_update.c:194: + for (i = 1; i < nr_cpus; i++) \ WARNING: line length of 89 exceeds 80 columns #82: FILE: tools/testing/selftests/bpf/prog_tests/htab_update.c:195: + if (!ASSERT_EQ(values[i], __val, "bpf_map_lookup_elem value")) \ WARNING: line length of 89 exceeds 80 columns #83: FILE: tools/testing/selftests/bpf/prog_tests/htab_update.c:196: + goto out; \ WARNING: line length of 82 exceeds 80 columns #138: FILE: tools/testing/selftests/bpf/prog_tests/htab_update.c:251: + test_lru_hash_map_update_elem(BPF_MAP_TYPE_LRU_HASH, BPF_F_NO_COMMON_LRU); WARNING: line length of 89 exceeds 80 columns #148: FILE: tools/testing/selftests/bpf/prog_tests/htab_update.c:261: + test_lru_hash_map_update_elem(BPF_MAP_TYPE_LRU_PERCPU_HASH, BPF_F_NO_COMMON_LRU); total: 0 errors, 13 warnings, 1 checks, 132 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Commit a5c654cb8f50 ("selftests/bpf: Add tests to verify no unintended eviction when updating lru_[percpu_,]hash maps") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE FILE_PATH_CHANGES GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. total: 0 errors, 13 warnings, 1 checks, 132 lines checked