WARNING: Missing a blank line after declarations #173: FILE: kernel/bpf/tnum.c:228: + u64 max_res = a_max / b_min; + return TNUM(0, __get_mask(max_res)); WARNING: line length of 94 exceeds 80 columns #195: FILE: kernel/bpf/tnum.c:250: + return TNUM(x.value | (1ULL << (width - 1)), x.mask & ~(1ULL << (width - 1))); WARNING: line length of 81 exceeds 80 columns #211: FILE: kernel/bpf/tnum.c:266: + * This function reuses tnum_udiv by operating on the absolute values of a and b, WARNING: line length of 93 exceeds 80 columns #240: FILE: kernel/bpf/tnum.c:295: + if (alu32 && (u32)a.value == (u32)S32_MIN && (u32)b.value == (u32)-1) WARNING: Missing a blank line after declarations #246: FILE: kernel/bpf/tnum.c:301: + s64 sval = (s64)a.value / (s64)b.value; + return TNUM((u64)sval, 0); WARNING: line length of 85 exceeds 80 columns #290: FILE: kernel/bpf/verifier.c:15079: +static void __scalar32_min_max_join(s32 *res_min, s32 *res_max, s32 x_min, s32 x_max) WARNING: line length of 83 exceeds 80 columns #296: FILE: kernel/bpf/verifier.c:15085: +static void __scalar_min_max_join(s64 *res_min, s64 *res_max, s64 x_min, s64 x_max) CHECK: Alignment should match open parenthesis #303: FILE: kernel/bpf/verifier.c:15092: +static void scalar32_min_max_udiv(struct bpf_reg_state *dst_reg, + struct bpf_reg_state *src_reg) WARNING: line length of 83 exceeds 80 columns #314: FILE: kernel/bpf/verifier.c:15103: + * 2. If umin_val == 0 && umax_val != 0, then dst_umin = x / 0 = 0, WARNING: line length of 85 exceeds 80 columns #315: FILE: kernel/bpf/verifier.c:15104: + * dst_umax = dst_umax / 1, remains unchanged, [a,b] / [0,x] = [0,b]. WARNING: line length of 83 exceeds 80 columns #342: FILE: kernel/bpf/verifier.c:15131: + * 2. If umin_val == 0 && umax_val != 0, then dst_umin = x / 0 = 0, WARNING: line length of 85 exceeds 80 columns #343: FILE: kernel/bpf/verifier.c:15132: + * dst_umax = dst_umax / 1, remains unchanged, [a,b] / [0,x] = [0,b]. CHECK: Alignment should match open parenthesis #373: FILE: kernel/bpf/verifier.c:15162: +static void __sdiv32_range(s32 dst_min, s32 dst_max, s32 src_min, s32 src_max, + s32 *res_min, s32 *res_max) CHECK: Alignment should match open parenthesis #387: FILE: kernel/bpf/verifier.c:15176: +static void scalar32_min_max_sdiv(struct bpf_reg_state *dst_reg, + struct bpf_reg_state *src_reg) CHECK: Alignment should match open parenthesis #404: FILE: kernel/bpf/verifier.c:15193: + __sdiv32_range(*dst_smin, *dst_smax, smin_val, -1, + &tmp_min, &tmp_max); WARNING: line length of 86 exceeds 80 columns #405: FILE: kernel/bpf/verifier.c:15194: + __scalar32_min_max_join(&res_min, &res_max, tmp_min, tmp_max); CHECK: Alignment should match open parenthesis #410: FILE: kernel/bpf/verifier.c:15199: + __sdiv32_range(*dst_smin, *dst_smax, 1, smax_val, + &tmp_min, &tmp_max); WARNING: line length of 86 exceeds 80 columns #411: FILE: kernel/bpf/verifier.c:15200: + __scalar32_min_max_join(&res_min, &res_max, tmp_min, tmp_max); CHECK: Alignment should match open parenthesis #415: FILE: kernel/bpf/verifier.c:15204: + __sdiv32_range(*dst_smin, *dst_smax, smin_val, smax_val, + &res_min, &res_max); CHECK: Alignment should match open parenthesis #445: FILE: kernel/bpf/verifier.c:15234: +static void __sdiv_range(s64 dst_min, s64 dst_max, s64 src_min, s64 src_max, + s64 *res_min, s64 *res_max) CHECK: Alignment should match open parenthesis #476: FILE: kernel/bpf/verifier.c:15265: + __sdiv_range(*dst_smin, *dst_smax, smin_val, -1, + &tmp_min, &tmp_max); WARNING: line length of 84 exceeds 80 columns #477: FILE: kernel/bpf/verifier.c:15266: + __scalar_min_max_join(&res_min, &res_max, tmp_min, tmp_max); CHECK: Alignment should match open parenthesis #482: FILE: kernel/bpf/verifier.c:15271: + __sdiv_range(*dst_smin, *dst_smax, 1, smax_val, + &tmp_min, &tmp_max); WARNING: line length of 84 exceeds 80 columns #483: FILE: kernel/bpf/verifier.c:15272: + __scalar_min_max_join(&res_min, &res_max, tmp_min, tmp_max); CHECK: Alignment should match open parenthesis #487: FILE: kernel/bpf/verifier.c:15276: + __sdiv_range(*dst_smin, *dst_smax, smin_val, smax_val, + &res_min, &res_max); WARNING: line length of 95 exceeds 80 columns #527: FILE: kernel/bpf/verifier.c:15774: + dst_reg->var_off = tnum_sdiv(dst_reg->var_off, src_reg.var_off, alu32); WARNING: line length of 88 exceeds 80 columns #531: FILE: kernel/bpf/verifier.c:15778: + dst_reg->var_off = tnum_udiv(dst_reg->var_off, src_reg.var_off); total: 0 errors, 17 warnings, 10 checks, 462 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Commit 109bb0dddcb6 ("bpf: Add interval and tnum analysis for signed and unsigned BPF_DIV") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE FILE_PATH_CHANGES GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. total: 0 errors, 17 warnings, 10 checks, 462 lines checked