ERROR: Remove Gerrit Change-Id's before submitting upstream #17: Change-Id: Ia8ed1f1f3f24c25cb1c3795af1bb2852e8ea952a WARNING: line length of 86 exceeds 80 columns #79: FILE: drivers/net/ethernet/nebula-matrix/nbl/nbl_hw/nbl_hw_leonis/nbl_hw_leonis.c:49: + nbl_hw_read_regs(hw_mgt, NBL_FEM_INT_MASK, (u8 *)&fem_mask, sizeof(fem_mask)); WARNING: line length of 87 exceeds 80 columns #81: FILE: drivers/net/ethernet/nebula-matrix/nbl/nbl_hw/nbl_hw_leonis/nbl_hw_leonis.c:51: + nbl_hw_write_regs(hw_mgt, NBL_FEM_INT_MASK, (u8 *)&fem_mask, sizeof(fem_mask)); WARNING: line length of 89 exceeds 80 columns #85: FILE: drivers/net/ethernet/nebula-matrix/nbl/nbl_hw/nbl_hw_leonis/nbl_hw_leonis.c:55: + nbl_hw_write_regs(hw_mgt, NBL_FEM_INT_STATUS, (u8 *)&fem_mask, sizeof(fem_mask)); WARNING: line length of 86 exceeds 80 columns #87: FILE: drivers/net/ethernet/nebula-matrix/nbl/nbl_hw/nbl_hw_leonis/nbl_hw_leonis.c:57: + nbl_hw_read_regs(hw_mgt, NBL_FEM_INT_MASK, (u8 *)&fem_mask, sizeof(fem_mask)); WARNING: line length of 89 exceeds 80 columns #90: FILE: drivers/net/ethernet/nebula-matrix/nbl/nbl_hw/nbl_hw_leonis/nbl_hw_leonis.c:60: + nbl_hw_read_regs(hw_mgt, NBL_EPRO_INT_MASK, (u8 *)&epro_mask, sizeof(epro_mask)); WARNING: line length of 90 exceeds 80 columns #92: FILE: drivers/net/ethernet/nebula-matrix/nbl/nbl_hw/nbl_hw_leonis/nbl_hw_leonis.c:62: + nbl_hw_write_regs(hw_mgt, NBL_EPRO_INT_MASK, (u8 *)&epro_mask, sizeof(epro_mask)); WARNING: line length of 92 exceeds 80 columns #96: FILE: drivers/net/ethernet/nebula-matrix/nbl/nbl_hw/nbl_hw_leonis/nbl_hw_leonis.c:66: + nbl_hw_write_regs(hw_mgt, NBL_EPRO_INT_STATUS, (u8 *)&epro_mask, sizeof(epro_mask)); WARNING: line length of 85 exceeds 80 columns #129: FILE: drivers/net/ethernet/nebula-matrix/nbl/nbl_hw/nbl_hw_leonis/nbl_hw_leonis.c:99: + (u8 *)&abnormal_msix_vetcor, sizeof(abnormal_msix_vetcor)); WARNING: line length of 91 exceeds 80 columns #144: FILE: drivers/net/ethernet/nebula-matrix/nbl/nbl_hw/nbl_hw_leonis/nbl_hw_leonis.c:114: +static u8 *nbl_hw_get_msix_irq_enable_info(void *priv, u16 global_vector_id, u32 *irq_data) WARNING: line length of 89 exceeds 80 columns #156: FILE: drivers/net/ethernet/nebula-matrix/nbl/nbl_hw/nbl_hw_leonis/nbl_hw_leonis.c:126: + dma_addr_t dma_addr, u8 bus, u8 devid, u8 function) WARNING: line length of 82 exceeds 80 columns #169: FILE: drivers/net/ethernet/nebula-matrix/nbl/nbl_hw/nbl_hw_leonis/nbl_hw_leonis.c:139: + nbl_hw_write_regs(priv, NBL_PCOMPLETER_FUNCTION_MSIX_MAP_REG_ARR(func_id), WARNING: line length of 93 exceeds 80 columns #173: FILE: drivers/net/ethernet/nebula-matrix/nbl/nbl_hw/nbl_hw_leonis/nbl_hw_leonis.c:143: +static void nbl_hw_configure_msix_info(void *priv, u16 func_id, bool valid, u16 interrupt_id, WARNING: line length of 88 exceeds 80 columns #174: FILE: drivers/net/ethernet/nebula-matrix/nbl/nbl_hw/nbl_hw_leonis/nbl_hw_leonis.c:144: + u8 bus, u8 devid, u8 function, bool msix_mask_en) WARNING: line length of 81 exceeds 80 columns #195: FILE: drivers/net/ethernet/nebula-matrix/nbl/nbl_hw/nbl_hw_leonis/nbl_hw_leonis.c:165: + nbl_hw_write_regs(priv, NBL_PCOMPLETER_HOST_MSIX_FID_TABLE(interrupt_id), WARNING: line length of 83 exceeds 80 columns #196: FILE: drivers/net/ethernet/nebula-matrix/nbl/nbl_hw/nbl_hw_leonis/nbl_hw_leonis.c:166: + (u8 *)&host_msix_fid_table, sizeof(host_msix_fid_table)); WARNING: line length of 81 exceeds 80 columns #206: FILE: drivers/net/ethernet/nebula-matrix/nbl/nbl_hw/nbl_hw_leonis/nbl_hw_leonis.c:336: +static void nbl_hw_set_coalesce(void *priv, u16 interrupt_id, u16 pnum, u16 rate) WARNING: line length of 88 exceeds 80 columns #226: FILE: drivers/net/ethernet/nebula-matrix/nbl/nbl_hw/nbl_hw_leonis/nbl_hw_leonis.c:413: +static void nbl_hw_enable_adminq_irq(void *priv, bool enable_msix, u16 global_vector_id) WARNING: line length of 81 exceeds 80 columns #245: FILE: drivers/net/ethernet/nebula-matrix/nbl/nbl_hw/nbl_hw_leonis/nbl_hw_leonis.c:432: + (u8 *)&adminq_qinfo_map, sizeof(adminq_qinfo_map)); WARNING: line length of 83 exceeds 80 columns #385: FILE: drivers/net/ethernet/nebula-matrix/nbl/nbl_hw/nbl_interrupt.c:30: + hw_ops->configure_msix_map(NBL_RES_MGT_TO_HW_PRIV(res_mgt), func_id, false, WARNING: line length of 84 exceeds 80 columns #397: FILE: drivers/net/ethernet/nebula-matrix/nbl/nbl_hw/nbl_interrupt.c:42: + clear_bit(interrupts[i], intr_mgt->interrupt_others_bitmap); WARNING: line length of 92 exceeds 80 columns #399: FILE: drivers/net/ethernet/nebula-matrix/nbl/nbl_hw/nbl_interrupt.c:44: + hw_ops->configure_msix_info(NBL_RES_MGT_TO_HW_PRIV(res_mgt), func_id, false, WARNING: line length of 83 exceeds 80 columns #408: FILE: drivers/net/ethernet/nebula-matrix/nbl/nbl_hw/nbl_interrupt.c:53: + dma_free_coherent(dma_dev, msix_map_table->size, msix_map_table->base_addr, WARNING: line length of 85 exceeds 80 columns #417: FILE: drivers/net/ethernet/nebula-matrix/nbl/nbl_hw/nbl_interrupt.c:62: +static int nbl_res_intr_configure_msix_map(void *priv, u16 func_id, u16 num_net_msix, WARNING: line length of 86 exceeds 80 columns #418: FILE: drivers/net/ethernet/nebula-matrix/nbl/nbl_hw/nbl_interrupt.c:63: + u16 num_others_msix, bool net_msix_mask_en) WARNING: line length of 92 exceeds 80 columns #451: FILE: drivers/net/ethernet/nebula-matrix/nbl/nbl_hw/nbl_interrupt.c:96: + msix_map_table->size = sizeof(struct nbl_msix_map) * NBL_MSIX_MAP_TABLE_MAX_ENTRIES; WARNING: line length of 85 exceeds 80 columns #452: FILE: drivers/net/ethernet/nebula-matrix/nbl/nbl_hw/nbl_interrupt.c:97: + msix_map_table->base_addr = dma_alloc_coherent(dma_dev, msix_map_table->size, WARNING: line length of 83 exceeds 80 columns #486: FILE: drivers/net/ethernet/nebula-matrix/nbl/nbl_hw/nbl_interrupt.c:131: + intr_index = find_first_zero_bit(intr_mgt->interrupt_others_bitmap, WARNING: line length of 91 exceeds 80 columns #506: FILE: drivers/net/ethernet/nebula-matrix/nbl/nbl_hw/nbl_interrupt.c:151: + hw_ops->configure_msix_info(NBL_RES_MGT_TO_HW_PRIV(res_mgt), func_id, true, WARNING: line length of 96 exceeds 80 columns #507: FILE: drivers/net/ethernet/nebula-matrix/nbl/nbl_hw/nbl_interrupt.c:152: + interrupts[i], bus, devid, function, msix_mask_en); WARNING: line length of 82 exceeds 80 columns #514: FILE: drivers/net/ethernet/nebula-matrix/nbl/nbl_hw/nbl_interrupt.c:159: + hw_ops->configure_msix_map(NBL_RES_MGT_TO_HW_PRIV(res_mgt), func_id, true, WARNING: line length of 87 exceeds 80 columns #515: FILE: drivers/net/ethernet/nebula-matrix/nbl/nbl_hw/nbl_interrupt.c:160: + msix_map_table->dma, common->hw_bus, common->devid, WARNING: line length of 81 exceeds 80 columns #527: FILE: drivers/net/ethernet/nebula-matrix/nbl/nbl_hw/nbl_interrupt.c:172: + clear_bit(intr_index, intr_mgt->interrupt_others_bitmap); WARNING: line length of 83 exceeds 80 columns #534: FILE: drivers/net/ethernet/nebula-matrix/nbl/nbl_hw/nbl_interrupt.c:179: + dma_free_coherent(dma_dev, msix_map_table->size, msix_map_table->base_addr, WARNING: line length of 88 exceeds 80 columns #554: FILE: drivers/net/ethernet/nebula-matrix/nbl/nbl_hw/nbl_interrupt.c:199: + &tx_queue_num, &rx_queue_num); WARNING: line length of 93 exceeds 80 columns #558: FILE: drivers/net/ethernet/nebula-matrix/nbl/nbl_hw/nbl_interrupt.c:203: + return nbl_res_intr_configure_msix_map(priv, func_id, net_msix_num, 1, true); WARNING: line length of 100 exceeds 80 columns #579: FILE: drivers/net/ethernet/nebula-matrix/nbl/nbl_hw/nbl_interrupt.c:224: +static int nbl_res_intr_enable_mailbox_irq(void *priv, u16 func_id, u16 vector_id, bool enable_msix) WARNING: line length of 82 exceeds 80 columns #589: FILE: drivers/net/ethernet/nebula-matrix/nbl/nbl_hw/nbl_interrupt.c:234: + global_vector_id = intr_mgt->func_intr_res[func_id].interrupts[vector_id]; WARNING: line length of 89 exceeds 80 columns #590: FILE: drivers/net/ethernet/nebula-matrix/nbl/nbl_hw/nbl_interrupt.c:235: + hw_ops->enable_mailbox_irq(NBL_RES_MGT_TO_HW_PRIV(res_mgt), func_id, enable_msix, WARNING: line length of 88 exceeds 80 columns #596: FILE: drivers/net/ethernet/nebula-matrix/nbl/nbl_hw/nbl_interrupt.c:241: +static int nbl_res_intr_enable_abnormal_irq(void *priv, u16 vector_id, bool enable_msix) WARNING: line length of 81 exceeds 80 columns #607: FILE: drivers/net/ethernet/nebula-matrix/nbl/nbl_hw/nbl_interrupt.c:252: + hw_ops->enable_abnormal_irq(NBL_RES_MGT_TO_HW_PRIV(res_mgt), enable_msix, WARNING: line length of 92 exceeds 80 columns #612: FILE: drivers/net/ethernet/nebula-matrix/nbl/nbl_hw/nbl_interrupt.c:257: +static u8 *nbl_res_get_msix_irq_enable_info(void *priv, u16 global_vector_id, u32 *irq_data) WARNING: line length of 98 exceeds 80 columns #619: FILE: drivers/net/ethernet/nebula-matrix/nbl/nbl_hw/nbl_interrupt.c:264: + return hw_ops->get_msix_irq_enable_info(NBL_RES_MGT_TO_HW_PRIV(res_mgt), global_vector_id, WARNING: line length of 86 exceeds 80 columns #623: FILE: drivers/net/ethernet/nebula-matrix/nbl/nbl_hw/nbl_interrupt.c:268: +static u16 nbl_res_intr_get_global_vector(void *priv, u16 vsi_id, u16 local_vector_id) WARNING: line length of 86 exceeds 80 columns #632: FILE: drivers/net/ethernet/nebula-matrix/nbl/nbl_hw/nbl_interrupt.c:277: +static u16 nbl_res_intr_get_msix_entry_id(void *priv, u16 vsi_id, u16 local_vector_id) WARNING: line length of 86 exceeds 80 columns #637: FILE: drivers/net/ethernet/nebula-matrix/nbl/nbl_hw/nbl_interrupt.c:282: +static int nbl_res_intr_enable_adminq_irq(void *priv, u16 vector_id, bool enable_msix) WARNING: line length of 84 exceeds 80 columns #672: FILE: drivers/net/ethernet/nebula-matrix/nbl/nbl_hw/nbl_interrupt.c:317: +static void nbl_res_intr_unmask(struct nbl_resource_mgt *res_mgt, u16 interrupts_id) WARNING: line length of 87 exceeds 80 columns #687: FILE: drivers/net/ethernet/nebula-matrix/nbl/nbl_hw/nbl_interrupt.c:332: + for (j = 0; j < intr_mgt->func_intr_res[i].num_interrupts; j++) WARNING: line length of 94 exceeds 80 columns #689: FILE: drivers/net/ethernet/nebula-matrix/nbl/nbl_hw/nbl_interrupt.c:334: + intr_mgt->func_intr_res[i].interrupts[j]); WARNING: line length of 89 exceeds 80 columns #698: FILE: drivers/net/ethernet/nebula-matrix/nbl/nbl_hw/nbl_interrupt.c:343: +#define NBL_INTR_OPS_TBL \ WARNING: line length of 89 exceeds 80 columns #699: FILE: drivers/net/ethernet/nebula-matrix/nbl/nbl_hw/nbl_interrupt.c:344: +do { \ WARNING: line length of 89 exceeds 80 columns #700: FILE: drivers/net/ethernet/nebula-matrix/nbl/nbl_hw/nbl_interrupt.c:345: + NBL_INTR_SET_OPS(init_vf_msix_map, nbl_res_init_vf_msix_map); \ WARNING: line length of 89 exceeds 80 columns #701: FILE: drivers/net/ethernet/nebula-matrix/nbl/nbl_hw/nbl_interrupt.c:346: + NBL_INTR_SET_OPS(configure_msix_map, nbl_res_intr_configure_msix_map); \ WARNING: line length of 89 exceeds 80 columns #702: FILE: drivers/net/ethernet/nebula-matrix/nbl/nbl_hw/nbl_interrupt.c:347: + NBL_INTR_SET_OPS(destroy_msix_map, nbl_res_intr_destroy_msix_map_export); \ WARNING: line length of 89 exceeds 80 columns #703: FILE: drivers/net/ethernet/nebula-matrix/nbl/nbl_hw/nbl_interrupt.c:348: + NBL_INTR_SET_OPS(enable_mailbox_irq, nbl_res_intr_enable_mailbox_irq); \ WARNING: line length of 89 exceeds 80 columns #704: FILE: drivers/net/ethernet/nebula-matrix/nbl/nbl_hw/nbl_interrupt.c:349: + NBL_INTR_SET_OPS(enable_abnormal_irq, nbl_res_intr_enable_abnormal_irq); \ WARNING: line length of 89 exceeds 80 columns #705: FILE: drivers/net/ethernet/nebula-matrix/nbl/nbl_hw/nbl_interrupt.c:350: + NBL_INTR_SET_OPS(enable_adminq_irq, nbl_res_intr_enable_adminq_irq); \ WARNING: line length of 89 exceeds 80 columns #706: FILE: drivers/net/ethernet/nebula-matrix/nbl/nbl_hw/nbl_interrupt.c:351: + NBL_INTR_SET_OPS(get_msix_irq_enable_info, nbl_res_get_msix_irq_enable_info); \ WARNING: line length of 89 exceeds 80 columns #707: FILE: drivers/net/ethernet/nebula-matrix/nbl/nbl_hw/nbl_interrupt.c:352: + NBL_INTR_SET_OPS(get_global_vector, nbl_res_intr_get_global_vector); \ WARNING: line length of 89 exceeds 80 columns #708: FILE: drivers/net/ethernet/nebula-matrix/nbl/nbl_hw/nbl_interrupt.c:353: + NBL_INTR_SET_OPS(get_msix_entry_id, nbl_res_intr_get_msix_entry_id); \ WARNING: line length of 89 exceeds 80 columns #709: FILE: drivers/net/ethernet/nebula-matrix/nbl/nbl_hw/nbl_interrupt.c:354: + NBL_INTR_SET_OPS(get_mbx_irq_num, nbl_res_intr_get_mbx_irq_num); \ WARNING: line length of 89 exceeds 80 columns #710: FILE: drivers/net/ethernet/nebula-matrix/nbl/nbl_hw/nbl_interrupt.c:355: + NBL_INTR_SET_OPS(get_adminq_irq_num, nbl_res_intr_get_adminq_irq_num); \ WARNING: line length of 89 exceeds 80 columns #711: FILE: drivers/net/ethernet/nebula-matrix/nbl/nbl_hw/nbl_interrupt.c:356: + NBL_INTR_SET_OPS(get_abnormal_irq_num, nbl_res_intr_get_abnormal_irq_num); \ WARNING: line length of 89 exceeds 80 columns #712: FILE: drivers/net/ethernet/nebula-matrix/nbl/nbl_hw/nbl_interrupt.c:357: + NBL_INTR_SET_OPS(flr_clear_interrupt, nbl_res_flr_clear_interrupt); \ WARNING: line length of 89 exceeds 80 columns #713: FILE: drivers/net/ethernet/nebula-matrix/nbl/nbl_hw/nbl_interrupt.c:358: + NBL_INTR_SET_OPS(unmask_all_interrupts, nbl_res_unmask_all_interrupts); \ WARNING: line length of 86 exceeds 80 columns #717: FILE: drivers/net/ethernet/nebula-matrix/nbl/nbl_hw/nbl_interrupt.c:362: +static int nbl_intr_setup_mgt(struct device *dev, struct nbl_interrupt_mgt **intr_mgt) WARNING: line length of 84 exceeds 80 columns #719: FILE: drivers/net/ethernet/nebula-matrix/nbl/nbl_hw/nbl_interrupt.c:364: + *intr_mgt = devm_kzalloc(dev, sizeof(struct nbl_interrupt_mgt), GFP_KERNEL); WARNING: line length of 88 exceeds 80 columns #726: FILE: drivers/net/ethernet/nebula-matrix/nbl/nbl_hw/nbl_interrupt.c:371: +static void nbl_intr_remove_mgt(struct device *dev, struct nbl_interrupt_mgt **intr_mgt) WARNING: line length of 86 exceeds 80 columns #759: FILE: drivers/net/ethernet/nebula-matrix/nbl/nbl_hw/nbl_interrupt.c:404: +#define NBL_INTR_SET_OPS(name, func) do {res_ops->NBL_NAME(name) = func; ; } while (0) WARNING: line length of 92 exceeds 80 columns #807: FILE: drivers/net/ethernet/nebula-matrix/nbl/nbl_include/nbl_def_hw.h:16: + void (*configure_msix_map)(void *priv, u16 func_id, bool valid, dma_addr_t dma_addr, WARNING: line length of 90 exceeds 80 columns #809: FILE: drivers/net/ethernet/nebula-matrix/nbl/nbl_include/nbl_def_hw.h:18: + void (*configure_msix_info)(void *priv, u16 func_id, bool valid, u16 interrupt_id, WARNING: line length of 90 exceeds 80 columns #810: FILE: drivers/net/ethernet/nebula-matrix/nbl/nbl_include/nbl_def_hw.h:19: + u8 bus, u8 devid, u8 function, bool net_msix_mask_en); WARNING: line length of 100 exceeds 80 columns #820: FILE: drivers/net/ethernet/nebula-matrix/nbl/nbl_include/nbl_def_hw.h:35: + void (*enable_mailbox_irq)(void *priv, u16 func_id, bool enable_msix, u16 global_vector_id); WARNING: line length of 88 exceeds 80 columns #821: FILE: drivers/net/ethernet/nebula-matrix/nbl/nbl_include/nbl_def_hw.h:36: + void (*enable_abnormal_irq)(void *priv, bool enable_msix, u16 global_vector_id); WARNING: line length of 89 exceeds 80 columns #823: FILE: drivers/net/ethernet/nebula-matrix/nbl/nbl_include/nbl_def_hw.h:38: + u8 *(*get_msix_irq_enable_info)(void *priv, u16 global_vector_id, u32 *irq_data); WARNING: line length of 86 exceeds 80 columns #829: FILE: drivers/net/ethernet/nebula-matrix/nbl/nbl_include/nbl_def_hw.h:44: + void (*enable_adminq_irq)(void *priv, bool enable_msix, u16 global_vector_id); total: 1 errors, 75 warnings, 0 checks, 761 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Commit 47a2cb075221 ("net/nebula-matrix: add intr resource definitions and implementation") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE FILE_PATH_CHANGES GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS.