ERROR: Remove Gerrit Change-Id's before submitting upstream
#19: 
Change-Id: I8655cefee2167e85069d5f0897e03e18c429c2b0

WARNING: line length of 81 exceeds 80 columns
#67: FILE: drivers/net/ethernet/nebula-matrix/nbl/nbl_core.h:31:
+#define NBL_ADAPTER_TO_SERV_OPS_TBL(adapter)	((adapter)->intf.service_ops_tbl)

WARNING: line length of 82 exceeds 80 columns
#132: FILE: drivers/net/ethernet/nebula-matrix/nbl/nbl_core/nbl_service.c:29:
+	*serv_mgt = devm_kzalloc(dev, sizeof(struct nbl_service_mgt), GFP_KERNEL);

WARNING: line length of 81 exceeds 80 columns
#146: FILE: drivers/net/ethernet/nebula-matrix/nbl/nbl_core/nbl_service.c:43:
+	struct nbl_serv_ring_mgt *ring_mgt = NBL_SERV_MGT_TO_RING_MGT(*serv_mgt);

WARNING: line length of 94 exceeds 80 columns
#154: FILE: drivers/net/ethernet/nebula-matrix/nbl/nbl_core/nbl_service.c:51:
+static void nbl_serv_remove_ops(struct device *dev, struct nbl_service_ops_tbl **serv_ops_tbl)

WARNING: line length of 92 exceeds 80 columns
#160: FILE: drivers/net/ethernet/nebula-matrix/nbl/nbl_core/nbl_service.c:57:
+static int nbl_serv_setup_ops(struct device *dev, struct nbl_service_ops_tbl **serv_ops_tbl,

WARNING: line length of 90 exceeds 80 columns
#163: FILE: drivers/net/ethernet/nebula-matrix/nbl/nbl_core/nbl_service.c:60:
+	*serv_ops_tbl = devm_kzalloc(dev, sizeof(struct nbl_service_ops_tbl), GFP_KERNEL);

WARNING: line length of 84 exceeds 80 columns
#203: FILE: drivers/net/ethernet/nebula-matrix/nbl/nbl_core/nbl_service.c:100:
+	disp_ops->get_resource_pt_ops(disp_ops_tbl->priv, &(*serv_ops_tbl)->pt_ops);

WARNING: line length of 99 exceeds 80 columns
#252: FILE: drivers/net/ethernet/nebula-matrix/nbl/nbl_core/nbl_service.h:15:
+#define NBL_SERV_MGT_TO_DEV(serv_mgt)		NBL_COMMON_TO_DEV(NBL_SERV_MGT_TO_COMMON(serv_mgt))

WARNING: line length of 93 exceeds 80 columns
#259: FILE: drivers/net/ethernet/nebula-matrix/nbl/nbl_core/nbl_service.h:22:
+#define NBL_SERV_MGT_TO_DISP_OPS(serv_mgt)	(NBL_SERV_MGT_TO_DISP_OPS_TBL(serv_mgt)->ops)

WARNING: line length of 94 exceeds 80 columns
#260: FILE: drivers/net/ethernet/nebula-matrix/nbl/nbl_core/nbl_service.h:23:
+#define NBL_SERV_MGT_TO_DISP_PRIV(serv_mgt)	(NBL_SERV_MGT_TO_DISP_OPS_TBL(serv_mgt)->priv)

WARNING: line length of 93 exceeds 80 columns
#263: FILE: drivers/net/ethernet/nebula-matrix/nbl/nbl_core/nbl_service.h:26:
+#define NBL_SERV_MGT_TO_CHAN_OPS(serv_mgt)	(NBL_SERV_MGT_TO_CHAN_OPS_TBL(serv_mgt)->ops)

WARNING: line length of 94 exceeds 80 columns
#264: FILE: drivers/net/ethernet/nebula-matrix/nbl/nbl_core/nbl_service.h:27:
+#define NBL_SERV_MGT_TO_CHAN_PRIV(serv_mgt)	(NBL_SERV_MGT_TO_CHAN_OPS_TBL(serv_mgt)->priv)

total: 1 errors, 12 warnings, 0 checks, 568 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

Commit 980474cc6724 ("net/nebula-matrix: add Service layer definitions and implementation") has style problems, please review.

NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE FILE_PATH_CHANGES GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.