ERROR: Remove Gerrit Change-Id's before submitting upstream #9: Change-Id: Icb1ed852da1d28f563efdf2b6431ff7bc80f58e3 WARNING: line length of 82 exceeds 80 columns #59: FILE: drivers/net/ethernet/nebula-matrix/nbl/nbl_core/nbl_dev.c:1448: +nbl_dev_netdev_set_features(struct net_device *netdev, netdev_features_t features) WARNING: line length of 89 exceeds 80 columns #98: FILE: drivers/net/ethernet/nebula-matrix/nbl/nbl_core/nbl_dev.c:1487: +static int nbl_dev_netdev_bridge_setlink(struct net_device *netdev, struct nlmsghdr *nlh, WARNING: line length of 83 exceeds 80 columns #99: FILE: drivers/net/ethernet/nebula-matrix/nbl/nbl_core/nbl_dev.c:1488: + u16 flags, struct netlink_ext_ack *extack) WARNING: line length of 97 exceeds 80 columns #109: FILE: drivers/net/ethernet/nebula-matrix/nbl/nbl_core/nbl_dev.c:1498: + struct net_device *netdev, u32 filter_mask, int nlflags) WARNING: line length of 85 exceeds 80 columns #115: FILE: drivers/net/ethernet/nebula-matrix/nbl/nbl_core/nbl_dev.c:1504: + return serv_ops->bridge_getlink(skb, pid, seq, netdev, filter_mask, nlflags); WARNING: line length of 97 exceeds 80 columns #118: FILE: drivers/net/ethernet/nebula-matrix/nbl/nbl_core/nbl_dev.c:1507: +static int nbl_dev_netdev_set_vf_link_state(struct net_device *netdev, int vf_id, int link_state) WARNING: line length of 83 exceeds 80 columns #127: FILE: drivers/net/ethernet/nebula-matrix/nbl/nbl_core/nbl_dev.c:1516: +static int nbl_dev_netdev_set_vf_mac(struct net_device *netdev, int vf_id, u8 *mac) WARNING: line length of 92 exceeds 80 columns #137: FILE: drivers/net/ethernet/nebula-matrix/nbl/nbl_core/nbl_dev.c:1526: +nbl_dev_netdev_set_vf_rate(struct net_device *netdev, int vf_id, int min_rate, int max_rate) WARNING: line length of 96 exceeds 80 columns #147: FILE: drivers/net/ethernet/nebula-matrix/nbl/nbl_core/nbl_dev.c:1536: +nbl_dev_netdev_set_vf_vlan(struct net_device *netdev, int vf_id, u16 vlan, u8 pri, __be16 proto) WARNING: line length of 92 exceeds 80 columns #167: FILE: drivers/net/ethernet/nebula-matrix/nbl/nbl_core/nbl_dev.c:1556: +nbl_dev_netdev_get_vf_config(struct net_device *netdev, int vf_id, struct ifla_vf_info *ivi) WARNING: line length of 97 exceeds 80 columns #177: FILE: drivers/net/ethernet/nebula-matrix/nbl/nbl_core/nbl_dev.c:1566: +nbl_dev_netdev_get_vf_stats(struct net_device *netdev, int vf_id, struct ifla_vf_stats *vf_stats) WARNING: line length of 92 exceeds 80 columns #206: FILE: drivers/net/ethernet/nebula-matrix/nbl/nbl_core/nbl_dev.c:1595: +static int nbl_dev_ndo_get_phys_port_name(struct net_device *netdev, char *name, size_t len) WARNING: line length of 93 exceeds 80 columns #320: FILE: drivers/net/ethernet/nebula-matrix/nbl/nbl_core/nbl_service.c:1456: + netdev_err(dev, "Temp to change a invalid mac address %pM\n", addr->sa_data); WARNING: line length of 89 exceeds 80 columns #330: FILE: drivers/net/ethernet/nebula-matrix/nbl/nbl_core/nbl_service.c:1466: + disp_ops->del_macvlan(NBL_SERV_MGT_TO_DISP_PRIV(serv_mgt), flow_mgt->mac, WARNING: line length of 95 exceeds 80 columns #332: FILE: drivers/net/ethernet/nebula-matrix/nbl/nbl_core/nbl_service.c:1468: + ret = disp_ops->add_macvlan(NBL_SERV_MGT_TO_DISP_PRIV(serv_mgt), addr->sa_data, WARNING: line length of 89 exceeds 80 columns #335: FILE: drivers/net/ethernet/nebula-matrix/nbl/nbl_core/nbl_service.c:1471: + netdev_err(dev, "Fail to cfg macvlan on vid %u", vlan_node->vid); WARNING: line length of 89 exceeds 80 columns #341: FILE: drivers/net/ethernet/nebula-matrix/nbl/nbl_core/nbl_service.c:1477: + disp_ops->del_macvlan(NBL_SERV_MGT_TO_DISP_PRIV(serv_mgt), flow_mgt->mac, WARNING: line length of 95 exceeds 80 columns #343: FILE: drivers/net/ethernet/nebula-matrix/nbl/nbl_core/nbl_service.c:1479: + ret = disp_ops->add_macvlan(NBL_SERV_MGT_TO_DISP_PRIV(serv_mgt), addr->sa_data, WARNING: line length of 85 exceeds 80 columns #346: FILE: drivers/net/ethernet/nebula-matrix/nbl/nbl_core/nbl_service.c:1482: + netdev_err(dev, "Fail to cfg macvlan on vid %u for user", 0); WARNING: line length of 88 exceeds 80 columns #359: FILE: drivers/net/ethernet/nebula-matrix/nbl/nbl_core/nbl_service.c:1495: + addr->sa_data, NBL_COMMON_TO_ETH_ID(common)); WARNING: line length of 89 exceeds 80 columns #366: FILE: drivers/net/ethernet/nebula-matrix/nbl/nbl_core/nbl_service.c:1502: + disp_ops->del_macvlan(NBL_SERV_MGT_TO_DISP_PRIV(serv_mgt), addr->sa_data, WARNING: line length of 89 exceeds 80 columns #368: FILE: drivers/net/ethernet/nebula-matrix/nbl/nbl_core/nbl_service.c:1504: + disp_ops->add_macvlan(NBL_SERV_MGT_TO_DISP_PRIV(serv_mgt), flow_mgt->mac, WARNING: line length of 96 exceeds 80 columns #408: FILE: drivers/net/ethernet/nebula-matrix/nbl/nbl_core/nbl_service.c:1879: +nbl_serv_features_check(struct sk_buff *skb, struct net_device *dev, netdev_features_t features) WARNING: line length of 95 exceeds 80 columns #437: FILE: drivers/net/ethernet/nebula-matrix/nbl/nbl_core/nbl_service.c:1908: + * 256 bytes or bigger than 16383 bytes. If it is then we need to drop support for GSO. WARNING: line length of 81 exceeds 80 columns #439: FILE: drivers/net/ethernet/nebula-matrix/nbl/nbl_core/nbl_service.c:1910: + if (skb_is_gso(skb) && (skb_shinfo(skb)->gso_size < NBL_TX_TSO_MSS_MIN || WARNING: line length of 94 exceeds 80 columns #455: FILE: drivers/net/ethernet/nebula-matrix/nbl/nbl_core/nbl_service.c:1926: + ret = ipv6_skip_exthdr(skb, exthdr - skb->data, &l4_proto, &frag_off); WARNING: line length of 83 exceeds 80 columns #464: FILE: drivers/net/ethernet/nebula-matrix/nbl/nbl_core/nbl_service.c:1935: + nexthdr = ipv6_find_hdr(skb, &offset, NEXTHDR_ROUTING, NULL, NULL); WARNING: line length of 95 exceeds 80 columns #476: FILE: drivers/net/ethernet/nebula-matrix/nbl/nbl_core/nbl_service.c:1947: + exthdr_num = nbl_serv_ipv6_exthdr_num(skb, exthdr - skb->data, ip.v6->nexthdr); WARNING: line length of 81 exceeds 80 columns #478: FILE: drivers/net/ethernet/nebula-matrix/nbl/nbl_core/nbl_service.c:1949: + netdev_info(dev, "skb ipv6 exthdr_num:%d\n", exthdr_num); WARNING: line length of 84 exceeds 80 columns #529: FILE: drivers/net/ethernet/nebula-matrix/nbl/nbl_core/nbl_service.c:2000: + struct nbl_serv_ring_vsi_info *vsi_info = &ring_mgt->vsi_info[NBL_VSI_DATA]; WARNING: line length of 95 exceeds 80 columns #541: FILE: drivers/net/ethernet/nebula-matrix/nbl/nbl_core/nbl_service.c:2012: + memcpy(indir, ring_mgt->rss_indir_user, rxfh_indir_size * sizeof(u32)); WARNING: line length of 87 exceeds 80 columns #554: FILE: drivers/net/ethernet/nebula-matrix/nbl/nbl_core/nbl_service.c:2025: +static int nbl_serv_set_features(struct net_device *netdev, netdev_features_t features) WARNING: line length of 94 exceeds 80 columns #577: FILE: drivers/net/ethernet/nebula-matrix/nbl/nbl_core/nbl_service.c:2276: +static int nbl_serv_get_vf_config(struct net_device *dev, int vf_id, struct ifla_vf_info *ivi) WARNING: line length of 81 exceeds 80 columns #627: FILE: drivers/net/ethernet/nebula-matrix/nbl/nbl_core/nbl_service.c:2353: + ring_mgt->tx_rings[vsi_info->ring_offset + txqueue].need_recovery = true; WARNING: line length of 89 exceeds 80 columns #632: FILE: drivers/net/ethernet/nebula-matrix/nbl/nbl_core/nbl_service.c:2358: + nbl_common_queue_work(&NBL_SERV_MGT_TO_NET_RES_MGT(serv_mgt)->tx_timeout, false); WARNING: line length of 91 exceeds 80 columns #636: FILE: drivers/net/ethernet/nebula-matrix/nbl/nbl_core/nbl_service.c:2362: + struct net_device *netdev, u32 filter_mask, int nlflags) WARNING: line length of 88 exceeds 80 columns #641: FILE: drivers/net/ethernet/nebula-matrix/nbl/nbl_core/nbl_service.c:2367: + struct nbl_serv_net_resource_mgt *net_resource_mgt = serv_mgt->net_resource_mgt; WARNING: line length of 83 exceeds 80 columns #646: FILE: drivers/net/ethernet/nebula-matrix/nbl/nbl_core/nbl_service.c:2372: + return ndo_dflt_bridge_getlink(skb, pid, seq, netdev, bmode, 0, 0, nlflags, WARNING: line length of 83 exceeds 80 columns #650: FILE: drivers/net/ethernet/nebula-matrix/nbl/nbl_core/nbl_service.c:2376: +static int nbl_serv_bridge_setlink(struct net_device *netdev, struct nlmsghdr *nlh, WARNING: line length of 88 exceeds 80 columns #656: FILE: drivers/net/ethernet/nebula-matrix/nbl/nbl_core/nbl_service.c:2382: + struct nbl_serv_net_resource_mgt *net_resource_mgt = serv_mgt->net_resource_mgt; WARNING: line length of 91 exceeds 80 columns #675: FILE: drivers/net/ethernet/nebula-matrix/nbl/nbl_core/nbl_service.c:2401: + ret = disp_ops->set_bridge_mode(NBL_SERV_MGT_TO_DISP_PRIV(serv_mgt), mode); WARNING: line length of 86 exceeds 80 columns #687: FILE: drivers/net/ethernet/nebula-matrix/nbl/nbl_core/nbl_service.c:2413: +static int nbl_serv_get_phys_port_name(struct net_device *dev, char *name, size_t len) WARNING: line length of 93 exceeds 80 columns #693: FILE: drivers/net/ethernet/nebula-matrix/nbl/nbl_core/nbl_service.c:2419: + if ((NBL_COMMON_TO_ETH_MODE(common) == NBL_TWO_ETHERNET_PORT) && common->eth_id == 2) total: 1 errors, 43 warnings, 0 checks, 701 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Commit 7633a5bfe5dc ("net/nebula-matrix: fully support ndo operations") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE FILE_PATH_CHANGES GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS.