ERROR: Remove Gerrit Change-Id's before submitting upstream #13: Change-Id: I6cbc439505e82e993dd87ad91d9242d6f05840bb WARNING: line length of 91 exceeds 80 columns #241: FILE: drivers/net/ethernet/nebula-matrix/nbl/nbl_core.h:13: +#define NBL_CAP_IS_CTRL(val) NBL_CAP_TEST_BIT(val, NBL_CAP_HAS_CTRL_BIT) WARNING: line length of 90 exceeds 80 columns #242: FILE: drivers/net/ethernet/nebula-matrix/nbl/nbl_core.h:14: +#define NBL_CAP_IS_NET(val) NBL_CAP_TEST_BIT(val, NBL_CAP_HAS_NET_BIT) WARNING: line length of 88 exceeds 80 columns #243: FILE: drivers/net/ethernet/nebula-matrix/nbl/nbl_core.h:15: +#define NBL_CAP_IS_VF(val) NBL_CAP_TEST_BIT(val, NBL_CAP_IS_VF_BIT) WARNING: line length of 89 exceeds 80 columns #244: FILE: drivers/net/ethernet/nebula-matrix/nbl/nbl_core.h:16: +#define NBL_CAP_IS_NIC(val) NBL_CAP_TEST_BIT(val, NBL_CAP_IS_NIC_BIT) WARNING: line length of 91 exceeds 80 columns #245: FILE: drivers/net/ethernet/nebula-matrix/nbl/nbl_core.h:17: +#define NBL_CAP_IS_USER(val) NBL_CAP_TEST_BIT(val, NBL_CAP_HAS_USER_BIT) WARNING: line length of 89 exceeds 80 columns #246: FILE: drivers/net/ethernet/nebula-matrix/nbl/nbl_core.h:18: +#define NBL_CAP_IS_OCP(val) NBL_CAP_TEST_BIT(val, NBL_CAP_IS_OCP_BIT) WARNING: line length of 92 exceeds 80 columns #247: FILE: drivers/net/ethernet/nebula-matrix/nbl/nbl_core.h:19: +#define NBL_CAP_IS_LEONIS(val) NBL_CAP_TEST_BIT(val, NBL_CAP_IS_LEONIS_BIT) WARNING: line length of 94 exceeds 80 columns #309: FILE: drivers/net/ethernet/nebula-matrix/nbl/nbl_include/nbl_include.h:45: +#define NBL_NEXT_ID(id, max) ({ typeof(id) _id = (id); ((_id) == (max) ? 0 : (_id) + 1); }) WARNING: line length of 90 exceeds 80 columns #379: FILE: drivers/net/ethernet/nebula-matrix/nbl/nbl_main.c:10: +static int nbl_probe(struct pci_dev *pdev, const struct pci_device_id __always_unused *id) WARNING: line length of 86 exceeds 80 columns #422: FILE: drivers/net/ethernet/nebula-matrix/nbl/nbl_main.c:53: + NBL_CAP_SET_BIT(NBL_CAP_HAS_NET_BIT) | NBL_CAP_SET_BIT(NBL_CAP_IS_NIC_BIT) | WARNING: line length of 91 exceeds 80 columns #423: FILE: drivers/net/ethernet/nebula-matrix/nbl/nbl_main.c:54: + NBL_CAP_SET_BIT(NBL_CAP_IS_LEONIS_BIT) | NBL_CAP_SET_BIT(NBL_CAP_HAS_USER_BIT) }, WARNING: line length of 86 exceeds 80 columns #425: FILE: drivers/net/ethernet/nebula-matrix/nbl/nbl_main.c:56: + NBL_CAP_SET_BIT(NBL_CAP_HAS_NET_BIT) | NBL_CAP_SET_BIT(NBL_CAP_IS_NIC_BIT) | WARNING: line length of 91 exceeds 80 columns #426: FILE: drivers/net/ethernet/nebula-matrix/nbl/nbl_main.c:57: + NBL_CAP_SET_BIT(NBL_CAP_IS_LEONIS_BIT) | NBL_CAP_SET_BIT(NBL_CAP_HAS_USER_BIT) }, WARNING: line length of 86 exceeds 80 columns #428: FILE: drivers/net/ethernet/nebula-matrix/nbl/nbl_main.c:59: + NBL_CAP_SET_BIT(NBL_CAP_HAS_NET_BIT) | NBL_CAP_SET_BIT(NBL_CAP_IS_NIC_BIT) | WARNING: line length of 91 exceeds 80 columns #429: FILE: drivers/net/ethernet/nebula-matrix/nbl/nbl_main.c:60: + NBL_CAP_SET_BIT(NBL_CAP_IS_LEONIS_BIT) | NBL_CAP_SET_BIT(NBL_CAP_HAS_USER_BIT) }, WARNING: line length of 83 exceeds 80 columns #430: FILE: drivers/net/ethernet/nebula-matrix/nbl/nbl_main.c:61: + { PCI_DEVICE(NBL_VENDOR_ID, NBL_DEVICE_ID_M18110_LX_BASE_T), .driver_data = WARNING: line length of 86 exceeds 80 columns #431: FILE: drivers/net/ethernet/nebula-matrix/nbl/nbl_main.c:62: + NBL_CAP_SET_BIT(NBL_CAP_HAS_NET_BIT) | NBL_CAP_SET_BIT(NBL_CAP_IS_NIC_BIT) | WARNING: line length of 91 exceeds 80 columns #432: FILE: drivers/net/ethernet/nebula-matrix/nbl/nbl_main.c:63: + NBL_CAP_SET_BIT(NBL_CAP_IS_LEONIS_BIT) | NBL_CAP_SET_BIT(NBL_CAP_HAS_USER_BIT) }, WARNING: line length of 86 exceeds 80 columns #434: FILE: drivers/net/ethernet/nebula-matrix/nbl/nbl_main.c:65: + NBL_CAP_SET_BIT(NBL_CAP_HAS_NET_BIT) | NBL_CAP_SET_BIT(NBL_CAP_IS_NIC_BIT) | WARNING: line length of 90 exceeds 80 columns #435: FILE: drivers/net/ethernet/nebula-matrix/nbl/nbl_main.c:66: + NBL_CAP_SET_BIT(NBL_CAP_IS_LEONIS_BIT) | NBL_CAP_SET_BIT(NBL_CAP_HAS_USER_BIT) | WARNING: line length of 86 exceeds 80 columns #438: FILE: drivers/net/ethernet/nebula-matrix/nbl/nbl_main.c:69: + NBL_CAP_SET_BIT(NBL_CAP_HAS_NET_BIT) | NBL_CAP_SET_BIT(NBL_CAP_IS_NIC_BIT) | WARNING: line length of 90 exceeds 80 columns #439: FILE: drivers/net/ethernet/nebula-matrix/nbl/nbl_main.c:70: + NBL_CAP_SET_BIT(NBL_CAP_IS_LEONIS_BIT) | NBL_CAP_SET_BIT(NBL_CAP_HAS_USER_BIT) | WARNING: line length of 84 exceeds 80 columns #441: FILE: drivers/net/ethernet/nebula-matrix/nbl/nbl_main.c:72: + { PCI_DEVICE(NBL_VENDOR_ID, NBL_DEVICE_ID_M18110_BASE_T_OCP), .driver_data = WARNING: line length of 86 exceeds 80 columns #442: FILE: drivers/net/ethernet/nebula-matrix/nbl/nbl_main.c:73: + NBL_CAP_SET_BIT(NBL_CAP_HAS_NET_BIT) | NBL_CAP_SET_BIT(NBL_CAP_IS_NIC_BIT) | WARNING: line length of 90 exceeds 80 columns #443: FILE: drivers/net/ethernet/nebula-matrix/nbl/nbl_main.c:74: + NBL_CAP_SET_BIT(NBL_CAP_IS_LEONIS_BIT) | NBL_CAP_SET_BIT(NBL_CAP_HAS_USER_BIT) | WARNING: line length of 87 exceeds 80 columns #445: FILE: drivers/net/ethernet/nebula-matrix/nbl/nbl_main.c:76: + { PCI_DEVICE(NBL_VENDOR_ID, NBL_DEVICE_ID_M18110_LX_BASE_T_OCP), .driver_data = WARNING: line length of 86 exceeds 80 columns #446: FILE: drivers/net/ethernet/nebula-matrix/nbl/nbl_main.c:77: + NBL_CAP_SET_BIT(NBL_CAP_HAS_NET_BIT) | NBL_CAP_SET_BIT(NBL_CAP_IS_NIC_BIT) | WARNING: line length of 90 exceeds 80 columns #447: FILE: drivers/net/ethernet/nebula-matrix/nbl/nbl_main.c:78: + NBL_CAP_SET_BIT(NBL_CAP_IS_LEONIS_BIT) | NBL_CAP_SET_BIT(NBL_CAP_HAS_USER_BIT) | WARNING: line length of 86 exceeds 80 columns #450: FILE: drivers/net/ethernet/nebula-matrix/nbl/nbl_main.c:81: + NBL_CAP_SET_BIT(NBL_CAP_HAS_NET_BIT) | NBL_CAP_SET_BIT(NBL_CAP_IS_NIC_BIT) | WARNING: line length of 91 exceeds 80 columns #451: FILE: drivers/net/ethernet/nebula-matrix/nbl/nbl_main.c:82: + NBL_CAP_SET_BIT(NBL_CAP_IS_LEONIS_BIT) | NBL_CAP_SET_BIT(NBL_CAP_HAS_USER_BIT) }, WARNING: line length of 86 exceeds 80 columns #453: FILE: drivers/net/ethernet/nebula-matrix/nbl/nbl_main.c:84: + NBL_CAP_SET_BIT(NBL_CAP_HAS_NET_BIT) | NBL_CAP_SET_BIT(NBL_CAP_IS_NIC_BIT) | WARNING: line length of 91 exceeds 80 columns #454: FILE: drivers/net/ethernet/nebula-matrix/nbl/nbl_main.c:85: + NBL_CAP_SET_BIT(NBL_CAP_IS_LEONIS_BIT) | NBL_CAP_SET_BIT(NBL_CAP_HAS_USER_BIT) }, WARNING: line length of 86 exceeds 80 columns #456: FILE: drivers/net/ethernet/nebula-matrix/nbl/nbl_main.c:87: + NBL_CAP_SET_BIT(NBL_CAP_HAS_NET_BIT) | NBL_CAP_SET_BIT(NBL_CAP_IS_NIC_BIT) | WARNING: line length of 91 exceeds 80 columns #457: FILE: drivers/net/ethernet/nebula-matrix/nbl/nbl_main.c:88: + NBL_CAP_SET_BIT(NBL_CAP_IS_LEONIS_BIT) | NBL_CAP_SET_BIT(NBL_CAP_HAS_USER_BIT) }, WARNING: line length of 83 exceeds 80 columns #458: FILE: drivers/net/ethernet/nebula-matrix/nbl/nbl_main.c:89: + { PCI_DEVICE(NBL_VENDOR_ID, NBL_DEVICE_ID_M18000_LX_BASE_T), .driver_data = WARNING: line length of 86 exceeds 80 columns #459: FILE: drivers/net/ethernet/nebula-matrix/nbl/nbl_main.c:90: + NBL_CAP_SET_BIT(NBL_CAP_HAS_NET_BIT) | NBL_CAP_SET_BIT(NBL_CAP_IS_NIC_BIT) | WARNING: line length of 91 exceeds 80 columns #460: FILE: drivers/net/ethernet/nebula-matrix/nbl/nbl_main.c:91: + NBL_CAP_SET_BIT(NBL_CAP_IS_LEONIS_BIT) | NBL_CAP_SET_BIT(NBL_CAP_HAS_USER_BIT) }, WARNING: line length of 86 exceeds 80 columns #462: FILE: drivers/net/ethernet/nebula-matrix/nbl/nbl_main.c:93: + NBL_CAP_SET_BIT(NBL_CAP_HAS_NET_BIT) | NBL_CAP_SET_BIT(NBL_CAP_IS_NIC_BIT) | WARNING: line length of 90 exceeds 80 columns #463: FILE: drivers/net/ethernet/nebula-matrix/nbl/nbl_main.c:94: + NBL_CAP_SET_BIT(NBL_CAP_IS_LEONIS_BIT) | NBL_CAP_SET_BIT(NBL_CAP_HAS_USER_BIT) | WARNING: line length of 86 exceeds 80 columns #466: FILE: drivers/net/ethernet/nebula-matrix/nbl/nbl_main.c:97: + NBL_CAP_SET_BIT(NBL_CAP_HAS_NET_BIT) | NBL_CAP_SET_BIT(NBL_CAP_IS_NIC_BIT) | WARNING: line length of 90 exceeds 80 columns #467: FILE: drivers/net/ethernet/nebula-matrix/nbl/nbl_main.c:98: + NBL_CAP_SET_BIT(NBL_CAP_IS_LEONIS_BIT) | NBL_CAP_SET_BIT(NBL_CAP_HAS_USER_BIT) | WARNING: line length of 84 exceeds 80 columns #469: FILE: drivers/net/ethernet/nebula-matrix/nbl/nbl_main.c:100: + { PCI_DEVICE(NBL_VENDOR_ID, NBL_DEVICE_ID_M18000_BASE_T_OCP), .driver_data = WARNING: line length of 86 exceeds 80 columns #470: FILE: drivers/net/ethernet/nebula-matrix/nbl/nbl_main.c:101: + NBL_CAP_SET_BIT(NBL_CAP_HAS_NET_BIT) | NBL_CAP_SET_BIT(NBL_CAP_IS_NIC_BIT) | WARNING: line length of 90 exceeds 80 columns #471: FILE: drivers/net/ethernet/nebula-matrix/nbl/nbl_main.c:102: + NBL_CAP_SET_BIT(NBL_CAP_IS_LEONIS_BIT) | NBL_CAP_SET_BIT(NBL_CAP_HAS_USER_BIT) | WARNING: line length of 87 exceeds 80 columns #473: FILE: drivers/net/ethernet/nebula-matrix/nbl/nbl_main.c:104: + { PCI_DEVICE(NBL_VENDOR_ID, NBL_DEVICE_ID_M18000_LX_BASE_T_OCP), .driver_data = WARNING: line length of 86 exceeds 80 columns #474: FILE: drivers/net/ethernet/nebula-matrix/nbl/nbl_main.c:105: + NBL_CAP_SET_BIT(NBL_CAP_HAS_NET_BIT) | NBL_CAP_SET_BIT(NBL_CAP_IS_NIC_BIT) | WARNING: line length of 90 exceeds 80 columns #475: FILE: drivers/net/ethernet/nebula-matrix/nbl/nbl_main.c:106: + NBL_CAP_SET_BIT(NBL_CAP_IS_LEONIS_BIT) | NBL_CAP_SET_BIT(NBL_CAP_HAS_USER_BIT) | WARNING: line length of 85 exceeds 80 columns #478: FILE: drivers/net/ethernet/nebula-matrix/nbl/nbl_main.c:109: + NBL_CAP_SET_BIT(NBL_CAP_HAS_NET_BIT) | NBL_CAP_SET_BIT(NBL_CAP_IS_VF_BIT) | WARNING: line length of 89 exceeds 80 columns #479: FILE: drivers/net/ethernet/nebula-matrix/nbl/nbl_main.c:110: + NBL_CAP_SET_BIT(NBL_CAP_IS_NIC_BIT) | NBL_CAP_SET_BIT(NBL_CAP_IS_LEONIS_BIT) }, WARNING: Prefer "GPL" over "GPL v2" - see commit bf7fbeeae6db ("module: Cure the MODULE_LICENSE "GPL" vs. "GPL v2" bogosity") #523: FILE: drivers/net/ethernet/nebula-matrix/nbl/nbl_main.c:154: +MODULE_LICENSE("GPL v2"); total: 1 errors, 50 warnings, 0 checks, 425 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Commit 2402162cfee1 ("net/nebula-matrix: add minimum nbl build framework") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE FILE_PATH_CHANGES GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS.