ShellCheck - shell script analysis tool
version: 0.11.0
license: GNU General Public License, version 3
website: https://www.shellcheck.net
Redirect to /tmp/tmp.6vlzOL4On5 and /tmp/tmp.1MRQ4ehDc6
Tree base:
dd1157ebec22 ("selftests: hsr: Add tests for faulty links")
Now at:
ae526a270e6b ("selftests: hsr: Add tests for more link faults with PRP")
 ====== Checking before the patch ======
Checking tools/testing/selftests/net/hsr/link_faults.sh - 77a351b1f35657858e31b0b6867e4b13a5f8a4ee9b8ea2061f02159dca6f12c9


In link_faults.sh line 18:
setup_hsr_topo()
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In link_faults.sh line 39:
	ip link add vethA netns "$node1" type veth peer name vethB netns "$node2"
                                 ^----^ SC2154 (warning): node1 is referenced but not assigned (did you mean 'node'?).
                                                                          ^----^ SC2154 (warning): node2 is referenced but not assigned (did you mean 'node'?).


In link_faults.sh line 40:
	ip link add vethA netns "$node2" type veth peer name vethB netns "$node3"
                                                                          ^----^ SC2154 (warning): node3 is referenced but not assigned (did you mean 'node'?).


In link_faults.sh line 54:
	ip -net "$node1" link add name hsr1 type hsr proto 0 version $ver slave1 vethA slave2 vethB supervision 45
                                                                     ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	ip -net "$node1" link add name hsr1 type hsr proto 0 version "$ver" slave1 vethA slave2 vethB supervision 45


In link_faults.sh line 55:
	ip -net "$node2" link add name hsr2 type hsr proto 0 version $ver slave1 vethA slave2 vethB supervision 45
                                                                     ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	ip -net "$node2" link add name hsr2 type hsr proto 0 version "$ver" slave1 vethA slave2 vethB supervision 45


In link_faults.sh line 56:
	ip -net "$node3" link add name hsr3 type hsr proto 0 version $ver slave1 vethA slave2 vethB supervision 45
                                                                     ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	ip -net "$node3" link add name hsr3 type hsr proto 0 version "$ver" slave1 vethA slave2 vethB supervision 45


In link_faults.sh line 77:
setup_prp_topo()
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In link_faults.sh line 115:
wait_for_hsr_node_table()
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In link_faults.sh line 119:
	while [ ${WAIT} -gt 0 ]; do
                ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	while [ "${WAIT}" -gt 0 ]; do


In link_faults.sh line 124:
		    !(echo "$nts" | grep -q "00:00:00:00:00:00"); then
                     ^-- SC1035 (error): You are missing a required space after the !.


In link_faults.sh line 134:
setup_topo()
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In link_faults.sh line 151:
check_ping()
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In link_faults.sh line 158:
	output=$(LANG=C ip netns exec "$node" ping $ping_args "$dst" | grep "packets transmitted")
                                                   ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	output=$(LANG=C ip netns exec "$node" ping "$ping_args" "$dst" | grep "packets transmitted")


In link_faults.sh line 167:
		tx="${BASH_REMATCH[1]}"
                ^-- SC2034 (warning): tx appears unused. Verify use (or export if used externally).


In link_faults.sh line 170:
		rx="${BASH_REMATCH[1]}"
                ^-- SC2034 (warning): rx appears unused. Verify use (or export if used externally).


In link_faults.sh line 185:
test_clean()
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In link_faults.sh line 190:
	tname="${FUNCNAME} - ${proto}"
               ^---------^ SC2128 (warning): Expanding an array without an index only gives the first element.


In link_faults.sh line 203:
test_clean_hsrv0()
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In link_faults.sh line 208:
test_clean_hsrv1()
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In link_faults.sh line 213:
test_clean_prp()
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In link_faults.sh line 218:
test_cut_link()
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In link_faults.sh line 223:
	tname="${FUNCNAME} - ${proto}"
               ^---------^ SC2128 (warning): Expanding an array without an index only gives the first element.


In link_faults.sh line 245:
test_cut_link_hsrv0()
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In link_faults.sh line 250:
test_cut_link_hsrv1()
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In link_faults.sh line 255:
test_cut_link_prp()
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In link_faults.sh line 260:
cleanup()
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).

For more information:
  https://www.shellcheck.net/wiki/SC1035 -- You are missing a required space ...
  https://www.shellcheck.net/wiki/SC2034 -- rx appears unused. Verify use (or...
  https://www.shellcheck.net/wiki/SC2128 -- Expanding an array without an ind...

 ====== Checking the tree with the patch ======
Checking tools/testing/selftests/net/hsr/link_faults.sh - 77a351b1f35657858e31b0b6867e4b13a5f8a4ee9b8ea2061f02159dca6f12c9


In link_faults.sh line 24:
setup_hsr_topo()
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In link_faults.sh line 45:
	ip link add vethA netns "$node1" type veth peer name vethB netns "$node2"
                                 ^----^ SC2154 (warning): node1 is referenced but not assigned (did you mean 'node'?).
                                                                          ^----^ SC2154 (warning): node2 is referenced but not assigned (did you mean 'node'?).


In link_faults.sh line 46:
	ip link add vethA netns "$node2" type veth peer name vethB netns "$node3"
                                                                          ^----^ SC2154 (warning): node3 is referenced but not assigned (did you mean 'node'?).


In link_faults.sh line 60:
	ip -net "$node1" link add name hsr1 type hsr proto 0 version $ver slave1 vethA slave2 vethB supervision 45
                                                                     ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	ip -net "$node1" link add name hsr1 type hsr proto 0 version "$ver" slave1 vethA slave2 vethB supervision 45


In link_faults.sh line 61:
	ip -net "$node2" link add name hsr2 type hsr proto 0 version $ver slave1 vethA slave2 vethB supervision 45
                                                                     ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	ip -net "$node2" link add name hsr2 type hsr proto 0 version "$ver" slave1 vethA slave2 vethB supervision 45


In link_faults.sh line 62:
	ip -net "$node3" link add name hsr3 type hsr proto 0 version $ver slave1 vethA slave2 vethB supervision 45
                                                                     ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	ip -net "$node3" link add name hsr3 type hsr proto 0 version "$ver" slave1 vethA slave2 vethB supervision 45


In link_faults.sh line 83:
setup_prp_topo()
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In link_faults.sh line 121:
wait_for_hsr_node_table()
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In link_faults.sh line 125:
	while [ ${WAIT} -gt 0 ]; do
                ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	while [ "${WAIT}" -gt 0 ]; do


In link_faults.sh line 130:
		    !(echo "$nts" | grep -q "00:00:00:00:00:00"); then
                     ^-- SC1035 (error): You are missing a required space after the !.


In link_faults.sh line 140:
setup_topo()
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In link_faults.sh line 157:
check_ping()
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In link_faults.sh line 165:
	output=$(LANG=C ip netns exec "$node" ping $ping_args "$dst" | grep "packets transmitted")
                                                   ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	output=$(LANG=C ip netns exec "$node" ping "$ping_args" "$dst" | grep "packets transmitted")


In link_faults.sh line 174:
		tx="${BASH_REMATCH[1]}"
                ^-- SC2034 (warning): tx appears unused. Verify use (or export if used externally).


In link_faults.sh line 177:
		rx="${BASH_REMATCH[1]}"
                ^-- SC2034 (warning): rx appears unused. Verify use (or export if used externally).


In link_faults.sh line 194:
test_clean()
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In link_faults.sh line 199:
	tname="${FUNCNAME} - ${proto}"
               ^---------^ SC2128 (warning): Expanding an array without an index only gives the first element.


In link_faults.sh line 212:
test_clean_hsrv0()
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In link_faults.sh line 217:
test_clean_hsrv1()
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In link_faults.sh line 222:
test_clean_prp()
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In link_faults.sh line 227:
test_cut_link()
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In link_faults.sh line 232:
	tname="${FUNCNAME} - ${proto}"
               ^---------^ SC2128 (warning): Expanding an array without an index only gives the first element.


In link_faults.sh line 254:
test_cut_link_hsrv0()
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In link_faults.sh line 259:
test_cut_link_hsrv1()
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In link_faults.sh line 264:
test_cut_link_prp()
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In link_faults.sh line 269:
test_packet_loss()
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In link_faults.sh line 275:
	tname="${FUNCNAME} - ${proto}, ${loss}"
               ^---------^ SC2128 (warning): Expanding an array without an index only gives the first element.


In link_faults.sh line 293:
test_packet_loss_prp()
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In link_faults.sh line 298:
test_high_packet_loss_prp()
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In link_faults.sh line 303:
test_reordering()
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In link_faults.sh line 308:
	tname="${FUNCNAME} - ${proto}"
               ^---------^ SC2128 (warning): Expanding an array without an index only gives the first element.


In link_faults.sh line 324:
test_reordering_prp()
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In link_faults.sh line 329:
cleanup()
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).

For more information:
  https://www.shellcheck.net/wiki/SC1035 -- You are missing a required space ...
  https://www.shellcheck.net/wiki/SC2034 -- rx appears unused. Verify use (or...
  https://www.shellcheck.net/wiki/SC2128 -- Expanding an array without an ind...