==========
shellcheck - FAILED


 ====== Checking before the patch ======
 ====== Checking the tree with the patch ======
tools/testing/selftests/net/hsr/link_faults.sh is a new file, but not shellcheck compliant
New errors added
--- /tmp/tmp.6nX543RHix	2025-12-22 16:32:00.235243455 -0500
+++ /tmp/tmp.HTP2WmOiWP	2025-12-22 16:32:00.750239894 -0500
@@ -223 +223 @@
-In hsr_ping.sh line 146:
+In hsr_ping.sh line 135:
@@ -231 +231 @@
-In hsr_ping.sh line 147:
+In hsr_ping.sh line 136:
@@ -239 +239 @@
-In hsr_ping.sh line 148:
+In hsr_ping.sh line 137:
@@ -249,0 +250,150 @@
+
+In link_faults.sh line 18:
+setup_hsr_topo()
+^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).
+
+
+In link_faults.sh line 39:
+	ip link add vethA netns "$node1" type veth peer name vethB netns "$node2"
+                                 ^----^ SC2154 (warning): node1 is referenced but not assigned (did you mean 'node'?).
+                                                                          ^----^ SC2154 (warning): node2 is referenced but not assigned (did you mean 'node'?).
+
+
+In link_faults.sh line 40:
+	ip link add vethA netns "$node2" type veth peer name vethB netns "$node3"
+                                                                          ^----^ SC2154 (warning): node3 is referenced but not assigned (did you mean 'node'?).
+
+
+In link_faults.sh line 54:
+	ip -net "$node1" link add name hsr1 type hsr proto 0 version $ver slave1 vethA slave2 vethB supervision 45
+                                                                     ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.
+
+Did you mean:
+	ip -net "$node1" link add name hsr1 type hsr proto 0 version "$ver" slave1 vethA slave2 vethB supervision 45
+
+
+In link_faults.sh line 55:
+	ip -net "$node2" link add name hsr2 type hsr proto 0 version $ver slave1 vethA slave2 vethB supervision 45
+                                                                     ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.
+
+Did you mean:
+	ip -net "$node2" link add name hsr2 type hsr proto 0 version "$ver" slave1 vethA slave2 vethB supervision 45
+
+
+In link_faults.sh line 56:
+	ip -net "$node3" link add name hsr3 type hsr proto 0 version $ver slave1 vethA slave2 vethB supervision 45
+                                                                     ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.
+
+Did you mean:
+	ip -net "$node3" link add name hsr3 type hsr proto 0 version "$ver" slave1 vethA slave2 vethB supervision 45
+
+
+In link_faults.sh line 77:
+setup_prp_topo()
+^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).
+
+
+In link_faults.sh line 115:
+wait_for_hsr_node_table()
+^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).
+
+
+In link_faults.sh line 119:
+	while [ ${WAIT} -gt 0 ]; do
+                ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting.
+
+Did you mean:
+	while [ "${WAIT}" -gt 0 ]; do
+
+
+In link_faults.sh line 124:
+		    !(echo "$nts" | grep -q "00:00:00:00:00:00"); then
+                     ^-- SC1035 (error): You are missing a required space after the !.
+
+
+In link_faults.sh line 134:
+setup_topo()
+^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).
+
+
+In link_faults.sh line 151:
+check_ping()
+^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).
+
+
+In link_faults.sh line 158:
+	output=$(LANG=C ip netns exec "$node" ping $ping_args "$dst" | grep "packets transmitted")
+                                                   ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting.
+
+Did you mean:
+	output=$(LANG=C ip netns exec "$node" ping "$ping_args" "$dst" | grep "packets transmitted")
+
+
+In link_faults.sh line 167:
+		tx="${BASH_REMATCH[1]}"
+                ^-- SC2034 (warning): tx appears unused. Verify use (or export if used externally).
+
+
+In link_faults.sh line 170:
+		rx="${BASH_REMATCH[1]}"
+                ^-- SC2034 (warning): rx appears unused. Verify use (or export if used externally).
+
+
+In link_faults.sh line 185:
+test_clean()
+^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).
+
+
+In link_faults.sh line 190:
+	tname="${FUNCNAME} - ${proto}"
+               ^---------^ SC2128 (warning): Expanding an array without an index only gives the first element.
+
+
+In link_faults.sh line 203:
+test_clean_hsrv0()
+^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).
+
+
+In link_faults.sh line 208:
+test_clean_hsrv1()
+^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).
+
+
+In link_faults.sh line 213:
+test_clean_prp()
+^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).
+
+
+In link_faults.sh line 218:
+test_cut_link()
+^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).
+
+
+In link_faults.sh line 223:
+	tname="${FUNCNAME} - ${proto}"
+               ^---------^ SC2128 (warning): Expanding an array without an index only gives the first element.
+
+
+In link_faults.sh line 245:
+test_cut_link_hsrv0()
+^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).
+
+
+In link_faults.sh line 250:
+test_cut_link_hsrv1()
+^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).
+
+
+In link_faults.sh line 255:
+test_cut_link_prp()
+^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).
+
+
+In link_faults.sh line 260:
+cleanup()
+^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).
+
+For more information:
+  https://www.shellcheck.net/wiki/SC1035 -- You are missing a required space ...
+  https://www.shellcheck.net/wiki/SC2034 -- rx appears unused. Verify use (or...
+  https://www.shellcheck.net/wiki/SC2128 -- Expanding an array without an ind...