========== shellcheck - FAILED ====== Checking before the patch ====== ====== Checking the tree with the patch ====== tools/testing/selftests/net/hsr/prp_ping.sh is a new file, but not shellcheck compliant New errors added --- /tmp/tmp.yYGflesnAq 2025-12-22 16:31:58.759253658 -0500 +++ /tmp/tmp.K7HBdGGIIV 2025-12-22 16:31:59.088251384 -0500 @@ -0,0 +1,89 @@ + +In prp_ping.sh line 17: + usage $0 + ^-- SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + usage "$0" + + +In prp_ping.sh line 24: + usage $0 + ^-- SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + usage "$0" + + +In prp_ping.sh line 42: + ip link add vethA netns "$node1" type veth peer name vethA netns "$node2" + ^----^ SC2154 (warning): node1 is referenced but not assigned. + ^----^ SC2154 (warning): node2 is referenced but not assigned. + + +In prp_ping.sh line 93: + do_ping "$node1" 100.64.$netid.2 + ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + do_ping "$node1" 100.64."$netid".2 + + +In prp_ping.sh line 94: + do_ping "$node2" 100.64.$netid.1 + ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + do_ping "$node2" 100.64."$netid".1 + + +In prp_ping.sh line 97: + do_ping "$node1" dead:beef:$netid::2 + ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + do_ping "$node1" dead:beef:"$netid"::2 + + +In prp_ping.sh line 98: + do_ping "$node2" dead:beef:$netid::1 + ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + do_ping "$node2" dead:beef:"$netid"::1 + + +In prp_ping.sh line 103: + do_ping_long "$node1" 100.64.$netid.2 + ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + do_ping_long "$node1" 100.64."$netid".2 + + +In prp_ping.sh line 104: + do_ping_long "$node2" 100.64.$netid.1 + ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + do_ping_long "$node2" 100.64."$netid".1 + + +In prp_ping.sh line 107: + do_ping_long "$node1" dead:beef:$netid::2 + ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + do_ping_long "$node1" dead:beef:"$netid"::2 + + +In prp_ping.sh line 108: + do_ping_long "$node2" dead:beef:$netid::1 + ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + do_ping_long "$node2" dead:beef:"$netid"::1 + +For more information: + https://www.shellcheck.net/wiki/SC2154 -- node1 is referenced but not assig... + https://www.shellcheck.net/wiki/SC2086 -- Double quote to prevent globbing ...