ShellCheck - shell script analysis tool
version: 0.11.0
license: GNU General Public License, version 3
website: https://www.shellcheck.net
Redirect to /tmp/tmp.PhrN5tflnm and /tmp/tmp.QjfcrWEGkx
Tree base:
bfcd7cad7cd5 ("arp: discard sha bcast/null (bcast ARP poison)")
Now at:
0f3533384f12 ("selftests/net: add no ARP bcast/null poison test")
 ====== Checking before the patch ======
 ====== Checking the tree with the patch ======
Checking tools/testing/selftests/net/arp_no_bcastnull_poision.sh - 26b4abcc1dbd0c7c560da1e8c3c14d4536214e554e95ce01995f11f5b1a00348


In arp_no_bcastnull_poision.sh line 17:
nsid=100
^--^ SC2034 (warning): nsid appears unused. Verify use (or export if used externally).


In arp_no_bcastnull_poision.sh line 27:
	ip link set dev veth1 netns ${PEER_NS}
                                    ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	ip link set dev veth1 netns "${PEER_NS}"


In arp_no_bcastnull_poision.sh line 28:
	ip netns exec ${PEER_NS} ip link set dev veth1 up
                      ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	ip netns exec "${PEER_NS}" ip link set dev veth1 up


In arp_no_bcastnull_poision.sh line 30:
	ip netns exec ${PEER_NS} ip addr add ${V4_ADDR1}/24 dev veth1
                      ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	ip netns exec "${PEER_NS}" ip addr add ${V4_ADDR1}/24 dev veth1


In arp_no_bcastnull_poision.sh line 31:
	ip netns exec ${PEER_NS} ip route add default via ${V4_ADDR0} dev veth1
                      ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	ip netns exec "${PEER_NS}" ip route add default via ${V4_ADDR0} dev veth1


In arp_no_bcastnull_poision.sh line 36:
	ip netns exec ${PEER_NS} \
                      ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	ip netns exec "${PEER_NS}" \


In arp_no_bcastnull_poision.sh line 39:
	ip netns exec ${PEER_NS} \
                      ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	ip netns exec "${PEER_NS}" \


In arp_no_bcastnull_poision.sh line 44:
	veth1_mac="$(ip netns exec ${PEER_NS} ip -j link show veth1 | \
                                   ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	veth1_mac="$(ip netns exec "${PEER_NS}" ip -j link show veth1 | \


In arp_no_bcastnull_poision.sh line 51:
	cleanup_ns ${PEER_NS}
                   ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	cleanup_ns "${PEER_NS}"


In arp_no_bcastnull_poision.sh line 62:
	ip netns exec ${PEER_NS} ip neigh flush dev veth1 >/dev/null 2>&1
                      ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	ip netns exec "${PEER_NS}" ip neigh flush dev veth1 >/dev/null 2>&1


In arp_no_bcastnull_poision.sh line 63:
	ip netns exec ${PEER_NS} ping -c 1 ${V4_ADDR0} >/dev/null 2>&1
                      ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	ip netns exec "${PEER_NS}" ping -c 1 ${V4_ADDR0} >/dev/null 2>&1


In arp_no_bcastnull_poision.sh line 66:
	./arp_send ${veth0_ifindex} ${BCAST_MAC} ${VALID_MAC} ${op} \
                   ^--------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                                              ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	./arp_send "${veth0_ifindex}" ${BCAST_MAC} ${VALID_MAC} "${op}" \


In arp_no_bcastnull_poision.sh line 69:
	neigh=$(ip netns exec ${PEER_NS} ip neigh show ${V4_ADDR0} | \
                              ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	neigh=$(ip netns exec "${PEER_NS}" ip neigh show ${V4_ADDR0} | \


In arp_no_bcastnull_poision.sh line 73:
		ip netns exec ${PEER_NS} ip neigh show ${V4_ADDR0}
                              ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
		ip netns exec "${PEER_NS}" ip neigh show ${V4_ADDR0}


In arp_no_bcastnull_poision.sh line 79:
	./arp_send ${veth0_ifindex} ${l2_dmac} ${VALID_MAC} ${op} \
                   ^--------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                    ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                                            ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	./arp_send "${veth0_ifindex}" "${l2_dmac}" ${VALID_MAC} "${op}" \


In arp_no_bcastnull_poision.sh line 80:
		${V4_ADDR0} ${tmac} ${V4_ADDR0} ${tmac}
                            ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                                ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
		${V4_ADDR0} "${tmac}" ${V4_ADDR0} "${tmac}"


In arp_no_bcastnull_poision.sh line 82:
	neigh=$(ip netns exec ${PEER_NS} ip neigh show ${V4_ADDR0} | \
                              ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	neigh=$(ip netns exec "${PEER_NS}" ip neigh show ${V4_ADDR0} | \


In arp_no_bcastnull_poision.sh line 83:
		grep ${tmac})
                     ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
		grep "${tmac}")


In arp_no_bcastnull_poision.sh line 86:
		ip netns exec ${PEER_NS} ip neigh show ${V4_ADDR0}
                              ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
		ip netns exec "${PEER_NS}" ip neigh show ${V4_ADDR0}


In arp_no_bcastnull_poision.sh line 96:
	if [ ${rc} == 0 ]; then
             ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	if [ "${rc}" == 0 ]; then


In arp_no_bcastnull_poision.sh line 128:
	run_no_arp_poisoning ${veth1_mac} ${BCAST_MAC} ${ARP_REPLY}
                             ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	run_no_arp_poisoning "${veth1_mac}" ${BCAST_MAC} ${ARP_REPLY}


In arp_no_bcastnull_poision.sh line 132:
	run_no_arp_poisoning ${veth1_mac} ${NULL_MAC} ${ARP_REPLY}
                             ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	run_no_arp_poisoning "${veth1_mac}" ${NULL_MAC} ${ARP_REPLY}


In arp_no_bcastnull_poision.sh line 136:
	run_no_arp_poisoning ${veth1_mac} ${BCAST_MAC} ${ARP_REQ}
                             ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	run_no_arp_poisoning "${veth1_mac}" ${BCAST_MAC} ${ARP_REQ}


In arp_no_bcastnull_poision.sh line 140:
	run_no_arp_poisoning ${veth1_mac} ${NULL_MAC} ${ARP_REQ}
                             ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	run_no_arp_poisoning "${veth1_mac}" ${NULL_MAC} ${ARP_REQ}

For more information:
  https://www.shellcheck.net/wiki/SC2034 -- nsid appears unused. Verify use (...
  https://www.shellcheck.net/wiki/SC2086 -- Double quote to prevent globbing ...