WARNING: line length of 89 exceeds 80 columns #239: FILE: drivers/net/ethernet/mediatek/mtk_eth_soc.c:3028: + mtk_w32(eth, (reg_val & ~MTK_RING_MYIP_VLD), MTK_LRO_CTRL_DW2_CFG(reg_map, idx)); WARNING: line length of 88 exceeds 80 columns #245: FILE: drivers/net/ethernet/mediatek/mtk_eth_soc.c:3033: + mtk_w32(eth, (reg_val | MTK_RING_MYIP_VLD), MTK_LRO_CTRL_DW2_CFG(reg_map, idx)); WARNING: line length of 89 exceeds 80 columns #258: FILE: drivers/net/ethernet/mediatek/mtk_eth_soc.c:3044: + mtk_w32(eth, (reg_val & ~MTK_RING_MYIP_VLD), MTK_LRO_CTRL_DW2_CFG(reg_map, idx)); WARNING: line length of 100 exceeds 80 columns #288: FILE: drivers/net/ethernet/mediatek/mtk_eth_soc.c:3196: + rss_params->indirection_table[i] = ethtool_rxfh_indir_default(i, eth->soc->rss_num); WARNING: line length of 87 exceeds 80 columns #316: FILE: drivers/net/ethernet/mediatek/mtk_eth_soc.c:3224: + mtk_w32(eth, rss_params->hash_key[i], MTK_RSS_HASH_KEY_DW(reg_map, i)); WARNING: line length of 84 exceeds 80 columns #339: FILE: drivers/net/ethernet/mediatek/mtk_eth_soc.c:3247: + MTK_RX_DONE_INT(eth, MTK_RSS_RING(2)), reg_map->pdma.int_grp + 0x4); WARNING: line length of 86 exceeds 80 columns #374: FILE: drivers/net/ethernet/mediatek/mtk_eth_soc.c:3365: + err = mtk_rx_alloc(eth, MTK_RSS_RING(i), MTK_RX_FLAGS_NORMAL); WARNING: line length of 83 exceeds 80 columns #412: FILE: drivers/net/ethernet/mediatek/mtk_eth_soc.c:3463: + eth->irq_fe[MTK_FE_IRQ_TX] = platform_get_irq_byname_optional(pdev, "fe1"); WARNING: line length of 83 exceeds 80 columns #413: FILE: drivers/net/ethernet/mediatek/mtk_eth_soc.c:3464: + eth->irq_fe[MTK_FE_IRQ_RX] = platform_get_irq_byname_optional(pdev, "fe2"); WARNING: line length of 91 exceeds 80 columns #436: FILE: drivers/net/ethernet/mediatek/mtk_eth_soc.c:3489: + eth->irq_fe[MTK_FE_IRQ_SHARED] = platform_get_irq(pdev, i); WARNING: line length of 81 exceeds 80 columns #532: FILE: drivers/net/ethernet/mediatek/mtk_eth_soc.c:3760: + napi_enable(ð->rx_napi[MTK_RSS_RING(i)].napi); WARNING: line length of 94 exceeds 80 columns #533: FILE: drivers/net/ethernet/mediatek/mtk_eth_soc.c:3761: + mtk_rx_irq_enable(eth, MTK_RX_DONE_INT(eth, MTK_RSS_RING(i))); WARNING: line length of 87 exceeds 80 columns #552: FILE: drivers/net/ethernet/mediatek/mtk_eth_soc.c:3855: + mtk_rx_irq_disable(eth, MTK_RX_DONE_INT(eth, MTK_RSS_RING(i))); WARNING: line length of 87 exceeds 80 columns #578: FILE: drivers/net/ethernet/mediatek/mtk_eth_soc.c:3979: + val << MTK_PDMA_DELAY_TX_PTIME_SHIFT, reg_map->qdma.delay_irq); WARNING: line length of 83 exceeds 80 columns #581: FILE: drivers/net/ethernet/mediatek/mtk_eth_soc.c:3982: + mtk_m32(eth, MTK_PDMA_DELAY_RX_MASK, val, reg_map->pdma.delay_irq); WARNING: line length of 87 exceeds 80 columns #611: FILE: drivers/net/ethernet/mediatek/mtk_eth_soc.c:4018: + val >> MTK_PDMA_DELAY_TX_PTIME_SHIFT, reg_map->qdma.delay_irq); WARNING: line length of 83 exceeds 80 columns #614: FILE: drivers/net/ethernet/mediatek/mtk_eth_soc.c:4021: + mtk_m32(eth, MTK_PDMA_DELAY_TX_MASK, val, reg_map->pdma.delay_irq); WARNING: line length of 81 exceeds 80 columns #680: FILE: drivers/net/ethernet/mediatek/mtk_eth_soc.c:4374: + mtk_w32(eth, MTK_RX_DONE_INT(eth, 0), reg_map->pdma.int_grp + 4); WARNING: line length of 87 exceeds 80 columns #850: FILE: drivers/net/ethernet/mediatek/mtk_eth_soc.c:5504: + irqname = devm_kasprintf(eth->dev, GFP_KERNEL, "%s PDMA RX %d", WARNING: line length of 86 exceeds 80 columns #860: FILE: drivers/net/ethernet/mediatek/mtk_eth_soc.c:5514: + irqname = devm_kasprintf(eth->dev, GFP_KERNEL, WARNING: line length of 88 exceeds 80 columns #862: FILE: drivers/net/ethernet/mediatek/mtk_eth_soc.c:5516: + dev_name(eth->dev), i); WARNING: line length of 94 exceeds 80 columns #864: FILE: drivers/net/ethernet/mediatek/mtk_eth_soc.c:5518: + eth->irq_pdma[MTK_RSS_RING(i)], WARNING: line length of 94 exceeds 80 columns #865: FILE: drivers/net/ethernet/mediatek/mtk_eth_soc.c:5519: + mtk_handle_irq_rx, IRQF_SHARED, WARNING: line length of 95 exceeds 80 columns #867: FILE: drivers/net/ethernet/mediatek/mtk_eth_soc.c:5521: + ð->rx_napi[MTK_RSS_RING(i)]); WARNING: line length of 84 exceeds 80 columns #875: FILE: drivers/net/ethernet/mediatek/mtk_eth_soc.c:5529: + err = devm_request_irq(eth->dev, eth->irq_fe[MTK_FE_IRQ_RX], WARNING: line length of 94 exceeds 80 columns #892: FILE: drivers/net/ethernet/mediatek/mtk_eth_soc.c:5576: + eth->netdev[i]->base_addr, eth->irq_fe[MTK_FE_IRQ_SHARED]); WARNING: line length of 91 exceeds 80 columns #905: FILE: drivers/net/ethernet/mediatek/mtk_eth_soc.c:5593: + netif_napi_add(eth->dummy_dev, ð->rx_napi[MTK_RSS_RING(i)].napi, WARNING: line length of 90 exceeds 80 columns #1106: FILE: drivers/net/ethernet/mediatek/mtk_eth_soc.h:186: +#define MTK_HW_LRO_RING_NUM(eth) (mtk_is_netsys_v3_or_greater(eth) ? 4 : 3) CHECK: Macro argument 'eth' may be better as '(eth)' to avoid precedence issues #1119: FILE: drivers/net/ethernet/mediatek/mtk_eth_soc.h:210: +#define MTK_RX_RSS_NUM(eth) (eth->soc->rss_num) CHECK: Macro argument 'reg_map' may be better as '(reg_map)' to avoid precedence issues #1125: FILE: drivers/net/ethernet/mediatek/mtk_eth_soc.h:216: +#define MTK_RSS_HASH_KEY_DW(reg_map, x) (reg_map->pdma.rss_glo_cfg + \ + 0x20 + ((x) * 0x4)) CHECK: Macro argument 'reg_map' may be better as '(reg_map)' to avoid precedence issues #1127: FILE: drivers/net/ethernet/mediatek/mtk_eth_soc.h:218: +#define MTK_RSS_INDR_TABLE_DW(reg_map, x) (reg_map->pdma.rss_glo_cfg + \ + 0x50 + ((x) * 0x4)) WARNING: line length of 84 exceeds 80 columns #1151: FILE: drivers/net/ethernet/mediatek/mtk_eth_soc.h:253: +#define MTK_LRO_CTRL_DW1_CFG(reg_map, x) (reg_map->pdma.lro_ring_ctrl_dw1 + \ CHECK: Macro argument 'reg_map' may be better as '(reg_map)' to avoid precedence issues #1151: FILE: drivers/net/ethernet/mediatek/mtk_eth_soc.h:253: +#define MTK_LRO_CTRL_DW1_CFG(reg_map, x) (reg_map->pdma.lro_ring_ctrl_dw1 + \ + ((x) * 0x40)) WARNING: line length of 84 exceeds 80 columns #1153: FILE: drivers/net/ethernet/mediatek/mtk_eth_soc.h:255: +#define MTK_LRO_CTRL_DW2_CFG(reg_map, x) (reg_map->pdma.lro_ring_ctrl_dw1 + \ CHECK: Macro argument 'reg_map' may be better as '(reg_map)' to avoid precedence issues #1153: FILE: drivers/net/ethernet/mediatek/mtk_eth_soc.h:255: +#define MTK_LRO_CTRL_DW2_CFG(reg_map, x) (reg_map->pdma.lro_ring_ctrl_dw1 + \ + 0x4 + ((x) * 0x40)) WARNING: line length of 84 exceeds 80 columns #1155: FILE: drivers/net/ethernet/mediatek/mtk_eth_soc.h:257: +#define MTK_LRO_CTRL_DW3_CFG(reg_map, x) (reg_map->pdma.lro_ring_ctrl_dw1 + \ CHECK: Macro argument 'reg_map' may be better as '(reg_map)' to avoid precedence issues #1155: FILE: drivers/net/ethernet/mediatek/mtk_eth_soc.h:257: +#define MTK_LRO_CTRL_DW3_CFG(reg_map, x) (reg_map->pdma.lro_ring_ctrl_dw1 + \ + 0x8 + ((x) * 0x40)) total: 0 errors, 31 warnings, 6 checks, 1199 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Commit ea6fb4103a05 ("net: ethernet: mtk_eth_soc: Add RSS support") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE FILE_PATH_CHANGES GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. total: 0 errors, 31 warnings, 6 checks, 1199 lines checked