ShellCheck - shell script analysis tool version: 0.11.0 license: GNU General Public License, version 3 website: https://www.shellcheck.net Redirect to /tmp/tmp.7sVFTalQvC and /tmp/tmp.CZqlsoBZjl Tree base: 8f7aa3d3c732 ("Merge tag 'net-next-6.19' of git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next") Now at: cf36516d949c ("selftests: net: fib-onlink-tests: Set high metric for default IPv6 route") ====== Checking before the patch ====== Checking tools/testing/selftests/net/fib-onlink-tests.sh - 2c720dc02a7809746577379379fabbf6fab8c126d384b5821147572f689b088b In fib-onlink-tests.sh line 71: declare -A TEST_NET4IN6IN6 ^-------------^ SC2034 (warning): TEST_NET4IN6IN6 appears unused. Verify use (or export if used externally). In fib-onlink-tests.sh line 91: if [ ${rc} -eq ${expected} ]; then ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "${rc}" -eq "${expected}" ]; then In fib-onlink-tests.sh line 100: read a ^--^ SC2162 (info): read without -r will mangle backslashes. In fib-onlink-tests.sh line 128: printf " COMMAND: $cmd\n" ^-------------------^ SC2059 (info): Don't use variables in the printf format string. Use printf '..%s..' "$foo". In fib-onlink-tests.sh line 131: out=$(eval $cmd 2>&1) ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: out=$(eval "$cmd" 2>&1) In fib-onlink-tests.sh line 133: if [ "$VERBOSE" = "1" -a -n "$out" ]; then ^-- SC2166 (warning): Prefer [ p ] && [ q ] as [ p -a q ] is not well defined. In fib-onlink-tests.sh line 148: addr=$(${pfx} ip -6 -br addr show dev ${dev} | \ ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: addr=$(${pfx} ip -6 -br addr show dev "${dev}" | \ In fib-onlink-tests.sh line 160: echo $addr ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: echo "$addr" In fib-onlink-tests.sh line 186: ip li add ${NETIFS[p1]} type veth peer name ${NETIFS[p2]} ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip li add "${NETIFS[p1]}" type veth peer name "${NETIFS[p2]}" In fib-onlink-tests.sh line 187: ip li add ${NETIFS[p3]} type veth peer name ${NETIFS[p4]} ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip li add "${NETIFS[p3]}" type veth peer name "${NETIFS[p4]}" In fib-onlink-tests.sh line 188: ip li add ${NETIFS[p5]} type veth peer name ${NETIFS[p6]} ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip li add "${NETIFS[p5]}" type veth peer name "${NETIFS[p6]}" In fib-onlink-tests.sh line 189: ip li add ${NETIFS[p7]} type veth peer name ${NETIFS[p8]} ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip li add "${NETIFS[p7]}" type veth peer name "${NETIFS[p8]}" In fib-onlink-tests.sh line 193: ip li set ${NETIFS[p${n}]} vrf ${VRF} ^--------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip li set "${NETIFS[p${n}]}" vrf ${VRF} In fib-onlink-tests.sh line 198: ip li set ${NETIFS[p${n}]} up ^--------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip li set "${NETIFS[p${n}]}" up In fib-onlink-tests.sh line 199: ip addr add ${V4ADDRS[p${n}]}/24 dev ${NETIFS[p${n}]} ^---------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip addr add "${V4ADDRS[p${n}]}"/24 dev "${NETIFS[p${n}]}" In fib-onlink-tests.sh line 200: ip addr add ${V6ADDRS[p${n}]}/64 dev ${NETIFS[p${n}]} nodad ^---------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip addr add "${V6ADDRS[p${n}]}"/64 dev "${NETIFS[p${n}]}" nodad In fib-onlink-tests.sh line 205: ip li set ${NETIFS[p${n}]} netns ${PEER_NS} up ^--------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip li set "${NETIFS[p${n}]}" netns "${PEER_NS}" up In fib-onlink-tests.sh line 206: ip -netns ${PEER_NS} addr add ${V4ADDRS[p${n}]}/24 dev ${NETIFS[p${n}]} ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -netns "${PEER_NS}" addr add "${V4ADDRS[p${n}]}"/24 dev "${NETIFS[p${n}]}" In fib-onlink-tests.sh line 207: ip -netns ${PEER_NS} addr add ${V6ADDRS[p${n}]}/64 dev ${NETIFS[p${n}]} nodad ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -netns "${PEER_NS}" addr add "${V6ADDRS[p${n}]}"/64 dev "${NETIFS[p${n}]}" nodad In fib-onlink-tests.sh line 210: ip -6 ro add default via ${V6ADDRS[p3]/::[0-9]/::64} ^-------------------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -6 ro add default via "${V6ADDRS[p3]/::[0-9]/::64}" In fib-onlink-tests.sh line 211: ip -6 ro add table ${VRF_TABLE} default via ${V6ADDRS[p7]/::[0-9]/::64} ^-------------------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -6 ro add table ${VRF_TABLE} default via "${V6ADDRS[p7]/::[0-9]/::64}" In fib-onlink-tests.sh line 219: cleanup_ns ${PEER_NS} 2>/dev/null ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: cleanup_ns "${PEER_NS}" 2>/dev/null In fib-onlink-tests.sh line 221: ip link del ${NETIFS[p${n}]} 2>/dev/null ^--------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link del "${NETIFS[p${n}]}" 2>/dev/null In fib-onlink-tests.sh line 245: log_test $? ${exp_rc} "${desc}" ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: log_test $? "${exp_rc}" "${desc}" In fib-onlink-tests.sh line 261: nexthop via ${nh1} nexthop via ${nh2} ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: nexthop via "${nh1}" nexthop via "${nh2}" In fib-onlink-tests.sh line 262: log_test $? ${exp_rc} "${desc}" ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: log_test $? "${exp_rc}" "${desc}" In fib-onlink-tests.sh line 271: run_ip 254 ${TEST_NET4[1]}.1 ${CONGW[1]} ${NETIFS[p1]} 0 "unicast connected" ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_ip 254 "${TEST_NET4[1]}".1 "${CONGW[1]}" "${NETIFS[p1]}" 0 "unicast connected" In fib-onlink-tests.sh line 272: run_ip 254 ${TEST_NET4[1]}.2 ${RECGW4[1]} ${NETIFS[p1]} 0 "unicast recursive" ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_ip 254 "${TEST_NET4[1]}".2 "${RECGW4[1]}" "${NETIFS[p1]}" 0 "unicast recursive" In fib-onlink-tests.sh line 276: run_ip ${VRF_TABLE} ${TEST_NET4[2]}.1 ${CONGW[3]} ${NETIFS[p5]} 0 "unicast connected" ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_ip ${VRF_TABLE} "${TEST_NET4[2]}".1 "${CONGW[3]}" "${NETIFS[p5]}" 0 "unicast connected" In fib-onlink-tests.sh line 277: run_ip ${VRF_TABLE} ${TEST_NET4[2]}.2 ${RECGW4[2]} ${NETIFS[p5]} 0 "unicast recursive" ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_ip ${VRF_TABLE} "${TEST_NET4[2]}".2 "${RECGW4[2]}" "${NETIFS[p5]}" 0 "unicast recursive" In fib-onlink-tests.sh line 281: run_ip ${PBR_TABLE} ${TEST_NET4[2]}.3 ${CONGW[3]} ${NETIFS[p5]} 0 "unicast connected" ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_ip ${PBR_TABLE} "${TEST_NET4[2]}".3 "${CONGW[3]}" "${NETIFS[p5]}" 0 "unicast connected" In fib-onlink-tests.sh line 282: run_ip ${PBR_TABLE} ${TEST_NET4[2]}.4 ${RECGW4[2]} ${NETIFS[p5]} 0 "unicast recursive" ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_ip ${PBR_TABLE} "${TEST_NET4[2]}".4 "${RECGW4[2]}" "${NETIFS[p5]}" 0 "unicast recursive" In fib-onlink-tests.sh line 288: run_ip_mpath 254 ${TEST_NET4[1]}.5 \ ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_ip_mpath 254 "${TEST_NET4[1]}".5 \ In fib-onlink-tests.sh line 293: run_ip_mpath 254 ${TEST_NET4[1]}.6 \ ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_ip_mpath 254 "${TEST_NET4[1]}".6 \ In fib-onlink-tests.sh line 298: run_ip_mpath 254 ${TEST_NET4[1]}.7 \ ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_ip_mpath 254 "${TEST_NET4[1]}".7 \ In fib-onlink-tests.sh line 303: run_ip_mpath 254 ${TEST_NET4[1]}.8 \ ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_ip_mpath 254 "${TEST_NET4[1]}".8 \ In fib-onlink-tests.sh line 311: run_ip 254 ${TEST_NET4[1]}.11 ${V4ADDRS[p1]} ${NETIFS[p1]} 2 \ ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_ip 254 "${TEST_NET4[1]}".11 "${V4ADDRS[p1]}" "${NETIFS[p1]}" 2 \ In fib-onlink-tests.sh line 314: run_ip ${VRF_TABLE} ${TEST_NET4[2]}.11 ${V4ADDRS[p5]} ${NETIFS[p5]} 2 \ ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_ip ${VRF_TABLE} "${TEST_NET4[2]}".11 "${V4ADDRS[p5]}" "${NETIFS[p5]}" 2 \ In fib-onlink-tests.sh line 317: run_ip 254 ${TEST_NET4[1]}.101 ${V4ADDRS[p1]} "" 2 "No nexthop device given" ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_ip 254 "${TEST_NET4[1]}".101 "${V4ADDRS[p1]}" "" 2 "No nexthop device given" In fib-onlink-tests.sh line 319: run_ip 254 ${TEST_NET4[1]}.102 ${V4ADDRS[p3]} ${NETIFS[p1]} 2 \ ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_ip 254 "${TEST_NET4[1]}".102 "${V4ADDRS[p3]}" "${NETIFS[p1]}" 2 \ In fib-onlink-tests.sh line 322: run_ip ${VRF_TABLE} ${TEST_NET4[2]}.103 ${V4ADDRS[p7]} ${NETIFS[p5]} 2 \ ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_ip ${VRF_TABLE} "${TEST_NET4[2]}".103 "${V4ADDRS[p7]}" "${NETIFS[p5]}" 2 \ In fib-onlink-tests.sh line 343: log_test $? ${exp_rc} "${desc}" ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: log_test $? "${exp_rc}" "${desc}" In fib-onlink-tests.sh line 357: nexthop via ${nh1} nexthop via ${nh2} ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: nexthop via "${nh1}" nexthop via "${nh2}" In fib-onlink-tests.sh line 358: log_test $? ${exp_rc} "${desc}" ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: log_test $? "${exp_rc}" "${desc}" In fib-onlink-tests.sh line 367: run_ip6 254 ${TEST_NET6[1]}::1 ${V6ADDRS[p1]/::*}::64 ${NETIFS[p1]} 0 "unicast connected" ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_ip6 254 "${TEST_NET6[1]}"::1 "${V6ADDRS[p1]/::*}"::64 "${NETIFS[p1]}" 0 "unicast connected" In fib-onlink-tests.sh line 368: run_ip6 254 ${TEST_NET6[1]}::2 ${RECGW6[1]} ${NETIFS[p1]} 0 "unicast recursive" ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_ip6 254 "${TEST_NET6[1]}"::2 "${RECGW6[1]}" "${NETIFS[p1]}" 0 "unicast recursive" In fib-onlink-tests.sh line 369: run_ip6 254 ${TEST_NET6[1]}::3 ::ffff:${TEST_NET4IN6[1]} ${NETIFS[p1]} 0 "v4-mapped" ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_ip6 254 "${TEST_NET6[1]}"::3 ::ffff:"${TEST_NET4IN6[1]}" "${NETIFS[p1]}" 0 "v4-mapped" In fib-onlink-tests.sh line 373: run_ip6 ${VRF_TABLE} ${TEST_NET6[2]}::1 ${V6ADDRS[p5]/::*}::64 ${NETIFS[p5]} 0 "unicast connected" ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_ip6 ${VRF_TABLE} "${TEST_NET6[2]}"::1 "${V6ADDRS[p5]/::*}"::64 "${NETIFS[p5]}" 0 "unicast connected" In fib-onlink-tests.sh line 374: run_ip6 ${VRF_TABLE} ${TEST_NET6[2]}::2 ${RECGW6[2]} ${NETIFS[p5]} 0 "unicast recursive" ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_ip6 ${VRF_TABLE} "${TEST_NET6[2]}"::2 "${RECGW6[2]}" "${NETIFS[p5]}" 0 "unicast recursive" In fib-onlink-tests.sh line 375: run_ip6 ${VRF_TABLE} ${TEST_NET6[2]}::3 ::ffff:${TEST_NET4IN6[2]} ${NETIFS[p5]} 0 "v4-mapped" ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_ip6 ${VRF_TABLE} "${TEST_NET6[2]}"::3 ::ffff:"${TEST_NET4IN6[2]}" "${NETIFS[p5]}" 0 "v4-mapped" In fib-onlink-tests.sh line 379: run_ip6 ${PBR_TABLE} ${TEST_NET6[2]}::4 ${V6ADDRS[p5]/::*}::64 ${NETIFS[p5]} 0 "unicast connected" ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_ip6 ${PBR_TABLE} "${TEST_NET6[2]}"::4 "${V6ADDRS[p5]/::*}"::64 "${NETIFS[p5]}" 0 "unicast connected" In fib-onlink-tests.sh line 380: run_ip6 ${PBR_TABLE} ${TEST_NET6[2]}::5 ${RECGW6[2]} ${NETIFS[p5]} 0 "unicast recursive" ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_ip6 ${PBR_TABLE} "${TEST_NET6[2]}"::5 "${RECGW6[2]}" "${NETIFS[p5]}" 0 "unicast recursive" In fib-onlink-tests.sh line 381: run_ip6 ${PBR_TABLE} ${TEST_NET6[2]}::6 ::ffff:${TEST_NET4IN6[2]} ${NETIFS[p5]} 0 "v4-mapped" ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_ip6 ${PBR_TABLE} "${TEST_NET6[2]}"::6 ::ffff:"${TEST_NET4IN6[2]}" "${NETIFS[p5]}" 0 "v4-mapped" In fib-onlink-tests.sh line 387: run_ip6_mpath 254 ${TEST_NET6[1]}::4 "onlink" \ ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_ip6_mpath 254 "${TEST_NET6[1]}"::4 "onlink" \ In fib-onlink-tests.sh line 392: run_ip6_mpath 254 ${TEST_NET6[1]}::5 "onlink" \ ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_ip6_mpath 254 "${TEST_NET6[1]}"::5 "onlink" \ In fib-onlink-tests.sh line 397: run_ip6_mpath 254 ${TEST_NET6[1]}::6 "onlink" \ ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_ip6_mpath 254 "${TEST_NET6[1]}"::6 "onlink" \ In fib-onlink-tests.sh line 402: run_ip6_mpath 254 ${TEST_NET6[1]}::7 "" \ ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_ip6_mpath 254 "${TEST_NET6[1]}"::7 "" \ In fib-onlink-tests.sh line 407: run_ip6_mpath 254 ${TEST_NET6[1]}::8 "" \ ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_ip6_mpath 254 "${TEST_NET6[1]}"::8 "" \ In fib-onlink-tests.sh line 412: run_ip6_mpath 254 ${TEST_NET6[1]}::9 "" \ ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_ip6_mpath 254 "${TEST_NET6[1]}"::9 "" \ In fib-onlink-tests.sh line 422: lladdr=$(get_linklocal ${NETIFS[p1]}) || return 1 ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: lladdr=$(get_linklocal "${NETIFS[p1]}") || return 1 In fib-onlink-tests.sh line 424: run_ip6 254 ${TEST_NET6[1]}::11 ${V6ADDRS[p1]} ${NETIFS[p1]} 2 \ ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_ip6 254 "${TEST_NET6[1]}"::11 "${V6ADDRS[p1]}" "${NETIFS[p1]}" 2 \ In fib-onlink-tests.sh line 426: run_ip6 254 ${TEST_NET6[1]}::12 ${lladdr} ${NETIFS[p1]} 2 \ ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_ip6 254 "${TEST_NET6[1]}"::12 "${lladdr}" "${NETIFS[p1]}" 2 \ In fib-onlink-tests.sh line 428: run_ip6 254 ${TEST_NET6[1]}::12 ${MCAST6} ${NETIFS[p1]} 2 \ ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_ip6 254 "${TEST_NET6[1]}"::12 ${MCAST6} "${NETIFS[p1]}" 2 \ In fib-onlink-tests.sh line 431: lladdr=$(get_linklocal ${NETIFS[p5]}) || return 1 ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: lladdr=$(get_linklocal "${NETIFS[p5]}") || return 1 In fib-onlink-tests.sh line 432: run_ip6 ${VRF_TABLE} ${TEST_NET6[2]}::11 ${V6ADDRS[p5]} ${NETIFS[p5]} 2 \ ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_ip6 ${VRF_TABLE} "${TEST_NET6[2]}"::11 "${V6ADDRS[p5]}" "${NETIFS[p5]}" 2 \ In fib-onlink-tests.sh line 434: run_ip6 ${VRF_TABLE} ${TEST_NET6[2]}::12 ${lladdr} ${NETIFS[p5]} 2 \ ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_ip6 ${VRF_TABLE} "${TEST_NET6[2]}"::12 "${lladdr}" "${NETIFS[p5]}" 2 \ In fib-onlink-tests.sh line 436: run_ip6 ${VRF_TABLE} ${TEST_NET6[2]}::12 ${MCAST6} ${NETIFS[p5]} 2 \ ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_ip6 ${VRF_TABLE} "${TEST_NET6[2]}"::12 ${MCAST6} "${NETIFS[p5]}" 2 \ In fib-onlink-tests.sh line 439: run_ip6 254 ${TEST_NET6[1]}::101 ${V6ADDRS[p1]} "" 2 \ ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_ip6 254 "${TEST_NET6[1]}"::101 "${V6ADDRS[p1]}" "" 2 \ In fib-onlink-tests.sh line 446: run_ip6 ${VRF_TABLE} ${TEST_NET6[2]}::103 ${V6ADDRS[p7]/::[0-9]/::64} ${NETIFS[p5]} 2 \ ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------------------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_ip6 ${VRF_TABLE} "${TEST_NET6[2]}"::103 "${V6ADDRS[p7]/::[0-9]/::64}" "${NETIFS[p5]}" 2 \ In fib-onlink-tests.sh line 488: v) VERBOSE=$(($VERBOSE + 1));; ^------^ SC2004 (style): $/${} is unnecessary on arithmetic variables. For more information: https://www.shellcheck.net/wiki/SC2034 -- TEST_NET4IN6IN6 appears unused. V... https://www.shellcheck.net/wiki/SC2166 -- Prefer [ p ] && [ q ] as [ p -a q... https://www.shellcheck.net/wiki/SC2059 -- Don't use variables in the printf... ====== Checking the tree with the patch ====== Checking tools/testing/selftests/net/fib-onlink-tests.sh - 2c720dc02a7809746577379379fabbf6fab8c126d384b5821147572f689b088b In fib-onlink-tests.sh line 71: declare -A TEST_NET4IN6IN6 ^-------------^ SC2034 (warning): TEST_NET4IN6IN6 appears unused. Verify use (or export if used externally). In fib-onlink-tests.sh line 91: if [ ${rc} -eq ${expected} ]; then ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "${rc}" -eq "${expected}" ]; then In fib-onlink-tests.sh line 100: read a ^--^ SC2162 (info): read without -r will mangle backslashes. In fib-onlink-tests.sh line 128: printf " COMMAND: $cmd\n" ^-------------------^ SC2059 (info): Don't use variables in the printf format string. Use printf '..%s..' "$foo". In fib-onlink-tests.sh line 131: out=$(eval $cmd 2>&1) ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: out=$(eval "$cmd" 2>&1) In fib-onlink-tests.sh line 133: if [ "$VERBOSE" = "1" -a -n "$out" ]; then ^-- SC2166 (warning): Prefer [ p ] && [ q ] as [ p -a q ] is not well defined. In fib-onlink-tests.sh line 148: addr=$(${pfx} ip -6 -br addr show dev ${dev} | \ ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: addr=$(${pfx} ip -6 -br addr show dev "${dev}" | \ In fib-onlink-tests.sh line 160: echo $addr ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: echo "$addr" In fib-onlink-tests.sh line 186: ip li add ${NETIFS[p1]} type veth peer name ${NETIFS[p2]} ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip li add "${NETIFS[p1]}" type veth peer name "${NETIFS[p2]}" In fib-onlink-tests.sh line 187: ip li add ${NETIFS[p3]} type veth peer name ${NETIFS[p4]} ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip li add "${NETIFS[p3]}" type veth peer name "${NETIFS[p4]}" In fib-onlink-tests.sh line 188: ip li add ${NETIFS[p5]} type veth peer name ${NETIFS[p6]} ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip li add "${NETIFS[p5]}" type veth peer name "${NETIFS[p6]}" In fib-onlink-tests.sh line 189: ip li add ${NETIFS[p7]} type veth peer name ${NETIFS[p8]} ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip li add "${NETIFS[p7]}" type veth peer name "${NETIFS[p8]}" In fib-onlink-tests.sh line 193: ip li set ${NETIFS[p${n}]} vrf ${VRF} ^--------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip li set "${NETIFS[p${n}]}" vrf ${VRF} In fib-onlink-tests.sh line 198: ip li set ${NETIFS[p${n}]} up ^--------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip li set "${NETIFS[p${n}]}" up In fib-onlink-tests.sh line 199: ip addr add ${V4ADDRS[p${n}]}/24 dev ${NETIFS[p${n}]} ^---------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip addr add "${V4ADDRS[p${n}]}"/24 dev "${NETIFS[p${n}]}" In fib-onlink-tests.sh line 200: ip addr add ${V6ADDRS[p${n}]}/64 dev ${NETIFS[p${n}]} nodad ^---------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip addr add "${V6ADDRS[p${n}]}"/64 dev "${NETIFS[p${n}]}" nodad In fib-onlink-tests.sh line 205: ip li set ${NETIFS[p${n}]} netns ${PEER_NS} up ^--------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip li set "${NETIFS[p${n}]}" netns "${PEER_NS}" up In fib-onlink-tests.sh line 206: ip -netns ${PEER_NS} addr add ${V4ADDRS[p${n}]}/24 dev ${NETIFS[p${n}]} ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -netns "${PEER_NS}" addr add "${V4ADDRS[p${n}]}"/24 dev "${NETIFS[p${n}]}" In fib-onlink-tests.sh line 207: ip -netns ${PEER_NS} addr add ${V6ADDRS[p${n}]}/64 dev ${NETIFS[p${n}]} nodad ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -netns "${PEER_NS}" addr add "${V6ADDRS[p${n}]}"/64 dev "${NETIFS[p${n}]}" nodad In fib-onlink-tests.sh line 210: ip -6 ro add default via ${V6ADDRS[p3]/::[0-9]/::64} metric 9999 ^-------------------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -6 ro add default via "${V6ADDRS[p3]/::[0-9]/::64}" metric 9999 In fib-onlink-tests.sh line 211: ip -6 ro add table ${VRF_TABLE} default via ${V6ADDRS[p7]/::[0-9]/::64} ^-------------------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -6 ro add table ${VRF_TABLE} default via "${V6ADDRS[p7]/::[0-9]/::64}" In fib-onlink-tests.sh line 219: cleanup_ns ${PEER_NS} 2>/dev/null ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: cleanup_ns "${PEER_NS}" 2>/dev/null In fib-onlink-tests.sh line 221: ip link del ${NETIFS[p${n}]} 2>/dev/null ^--------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link del "${NETIFS[p${n}]}" 2>/dev/null In fib-onlink-tests.sh line 245: log_test $? ${exp_rc} "${desc}" ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: log_test $? "${exp_rc}" "${desc}" In fib-onlink-tests.sh line 261: nexthop via ${nh1} nexthop via ${nh2} ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: nexthop via "${nh1}" nexthop via "${nh2}" In fib-onlink-tests.sh line 262: log_test $? ${exp_rc} "${desc}" ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: log_test $? "${exp_rc}" "${desc}" In fib-onlink-tests.sh line 271: run_ip 254 ${TEST_NET4[1]}.1 ${CONGW[1]} ${NETIFS[p1]} 0 "unicast connected" ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_ip 254 "${TEST_NET4[1]}".1 "${CONGW[1]}" "${NETIFS[p1]}" 0 "unicast connected" In fib-onlink-tests.sh line 272: run_ip 254 ${TEST_NET4[1]}.2 ${RECGW4[1]} ${NETIFS[p1]} 0 "unicast recursive" ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_ip 254 "${TEST_NET4[1]}".2 "${RECGW4[1]}" "${NETIFS[p1]}" 0 "unicast recursive" In fib-onlink-tests.sh line 276: run_ip ${VRF_TABLE} ${TEST_NET4[2]}.1 ${CONGW[3]} ${NETIFS[p5]} 0 "unicast connected" ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_ip ${VRF_TABLE} "${TEST_NET4[2]}".1 "${CONGW[3]}" "${NETIFS[p5]}" 0 "unicast connected" In fib-onlink-tests.sh line 277: run_ip ${VRF_TABLE} ${TEST_NET4[2]}.2 ${RECGW4[2]} ${NETIFS[p5]} 0 "unicast recursive" ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_ip ${VRF_TABLE} "${TEST_NET4[2]}".2 "${RECGW4[2]}" "${NETIFS[p5]}" 0 "unicast recursive" In fib-onlink-tests.sh line 281: run_ip ${PBR_TABLE} ${TEST_NET4[2]}.3 ${CONGW[3]} ${NETIFS[p5]} 0 "unicast connected" ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_ip ${PBR_TABLE} "${TEST_NET4[2]}".3 "${CONGW[3]}" "${NETIFS[p5]}" 0 "unicast connected" In fib-onlink-tests.sh line 282: run_ip ${PBR_TABLE} ${TEST_NET4[2]}.4 ${RECGW4[2]} ${NETIFS[p5]} 0 "unicast recursive" ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_ip ${PBR_TABLE} "${TEST_NET4[2]}".4 "${RECGW4[2]}" "${NETIFS[p5]}" 0 "unicast recursive" In fib-onlink-tests.sh line 288: run_ip_mpath 254 ${TEST_NET4[1]}.5 \ ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_ip_mpath 254 "${TEST_NET4[1]}".5 \ In fib-onlink-tests.sh line 293: run_ip_mpath 254 ${TEST_NET4[1]}.6 \ ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_ip_mpath 254 "${TEST_NET4[1]}".6 \ In fib-onlink-tests.sh line 298: run_ip_mpath 254 ${TEST_NET4[1]}.7 \ ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_ip_mpath 254 "${TEST_NET4[1]}".7 \ In fib-onlink-tests.sh line 303: run_ip_mpath 254 ${TEST_NET4[1]}.8 \ ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_ip_mpath 254 "${TEST_NET4[1]}".8 \ In fib-onlink-tests.sh line 311: run_ip 254 ${TEST_NET4[1]}.11 ${V4ADDRS[p1]} ${NETIFS[p1]} 2 \ ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_ip 254 "${TEST_NET4[1]}".11 "${V4ADDRS[p1]}" "${NETIFS[p1]}" 2 \ In fib-onlink-tests.sh line 314: run_ip ${VRF_TABLE} ${TEST_NET4[2]}.11 ${V4ADDRS[p5]} ${NETIFS[p5]} 2 \ ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_ip ${VRF_TABLE} "${TEST_NET4[2]}".11 "${V4ADDRS[p5]}" "${NETIFS[p5]}" 2 \ In fib-onlink-tests.sh line 317: run_ip 254 ${TEST_NET4[1]}.101 ${V4ADDRS[p1]} "" 2 "No nexthop device given" ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_ip 254 "${TEST_NET4[1]}".101 "${V4ADDRS[p1]}" "" 2 "No nexthop device given" In fib-onlink-tests.sh line 319: run_ip 254 ${TEST_NET4[1]}.102 ${V4ADDRS[p3]} ${NETIFS[p1]} 2 \ ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_ip 254 "${TEST_NET4[1]}".102 "${V4ADDRS[p3]}" "${NETIFS[p1]}" 2 \ In fib-onlink-tests.sh line 322: run_ip ${VRF_TABLE} ${TEST_NET4[2]}.103 ${V4ADDRS[p7]} ${NETIFS[p5]} 2 \ ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_ip ${VRF_TABLE} "${TEST_NET4[2]}".103 "${V4ADDRS[p7]}" "${NETIFS[p5]}" 2 \ In fib-onlink-tests.sh line 343: log_test $? ${exp_rc} "${desc}" ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: log_test $? "${exp_rc}" "${desc}" In fib-onlink-tests.sh line 357: nexthop via ${nh1} nexthop via ${nh2} ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: nexthop via "${nh1}" nexthop via "${nh2}" In fib-onlink-tests.sh line 358: log_test $? ${exp_rc} "${desc}" ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: log_test $? "${exp_rc}" "${desc}" In fib-onlink-tests.sh line 367: run_ip6 254 ${TEST_NET6[1]}::1 ${V6ADDRS[p1]/::*}::64 ${NETIFS[p1]} 0 "unicast connected" ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_ip6 254 "${TEST_NET6[1]}"::1 "${V6ADDRS[p1]/::*}"::64 "${NETIFS[p1]}" 0 "unicast connected" In fib-onlink-tests.sh line 368: run_ip6 254 ${TEST_NET6[1]}::2 ${RECGW6[1]} ${NETIFS[p1]} 0 "unicast recursive" ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_ip6 254 "${TEST_NET6[1]}"::2 "${RECGW6[1]}" "${NETIFS[p1]}" 0 "unicast recursive" In fib-onlink-tests.sh line 369: run_ip6 254 ${TEST_NET6[1]}::3 ::ffff:${TEST_NET4IN6[1]} ${NETIFS[p1]} 0 "v4-mapped" ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_ip6 254 "${TEST_NET6[1]}"::3 ::ffff:"${TEST_NET4IN6[1]}" "${NETIFS[p1]}" 0 "v4-mapped" In fib-onlink-tests.sh line 373: run_ip6 ${VRF_TABLE} ${TEST_NET6[2]}::1 ${V6ADDRS[p5]/::*}::64 ${NETIFS[p5]} 0 "unicast connected" ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_ip6 ${VRF_TABLE} "${TEST_NET6[2]}"::1 "${V6ADDRS[p5]/::*}"::64 "${NETIFS[p5]}" 0 "unicast connected" In fib-onlink-tests.sh line 374: run_ip6 ${VRF_TABLE} ${TEST_NET6[2]}::2 ${RECGW6[2]} ${NETIFS[p5]} 0 "unicast recursive" ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_ip6 ${VRF_TABLE} "${TEST_NET6[2]}"::2 "${RECGW6[2]}" "${NETIFS[p5]}" 0 "unicast recursive" In fib-onlink-tests.sh line 375: run_ip6 ${VRF_TABLE} ${TEST_NET6[2]}::3 ::ffff:${TEST_NET4IN6[2]} ${NETIFS[p5]} 0 "v4-mapped" ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_ip6 ${VRF_TABLE} "${TEST_NET6[2]}"::3 ::ffff:"${TEST_NET4IN6[2]}" "${NETIFS[p5]}" 0 "v4-mapped" In fib-onlink-tests.sh line 379: run_ip6 ${PBR_TABLE} ${TEST_NET6[2]}::4 ${V6ADDRS[p5]/::*}::64 ${NETIFS[p5]} 0 "unicast connected" ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_ip6 ${PBR_TABLE} "${TEST_NET6[2]}"::4 "${V6ADDRS[p5]/::*}"::64 "${NETIFS[p5]}" 0 "unicast connected" In fib-onlink-tests.sh line 380: run_ip6 ${PBR_TABLE} ${TEST_NET6[2]}::5 ${RECGW6[2]} ${NETIFS[p5]} 0 "unicast recursive" ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_ip6 ${PBR_TABLE} "${TEST_NET6[2]}"::5 "${RECGW6[2]}" "${NETIFS[p5]}" 0 "unicast recursive" In fib-onlink-tests.sh line 381: run_ip6 ${PBR_TABLE} ${TEST_NET6[2]}::6 ::ffff:${TEST_NET4IN6[2]} ${NETIFS[p5]} 0 "v4-mapped" ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_ip6 ${PBR_TABLE} "${TEST_NET6[2]}"::6 ::ffff:"${TEST_NET4IN6[2]}" "${NETIFS[p5]}" 0 "v4-mapped" In fib-onlink-tests.sh line 387: run_ip6_mpath 254 ${TEST_NET6[1]}::4 "onlink" \ ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_ip6_mpath 254 "${TEST_NET6[1]}"::4 "onlink" \ In fib-onlink-tests.sh line 392: run_ip6_mpath 254 ${TEST_NET6[1]}::5 "onlink" \ ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_ip6_mpath 254 "${TEST_NET6[1]}"::5 "onlink" \ In fib-onlink-tests.sh line 397: run_ip6_mpath 254 ${TEST_NET6[1]}::6 "onlink" \ ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_ip6_mpath 254 "${TEST_NET6[1]}"::6 "onlink" \ In fib-onlink-tests.sh line 402: run_ip6_mpath 254 ${TEST_NET6[1]}::7 "" \ ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_ip6_mpath 254 "${TEST_NET6[1]}"::7 "" \ In fib-onlink-tests.sh line 407: run_ip6_mpath 254 ${TEST_NET6[1]}::8 "" \ ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_ip6_mpath 254 "${TEST_NET6[1]}"::8 "" \ In fib-onlink-tests.sh line 412: run_ip6_mpath 254 ${TEST_NET6[1]}::9 "" \ ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_ip6_mpath 254 "${TEST_NET6[1]}"::9 "" \ In fib-onlink-tests.sh line 422: lladdr=$(get_linklocal ${NETIFS[p1]}) || return 1 ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: lladdr=$(get_linklocal "${NETIFS[p1]}") || return 1 In fib-onlink-tests.sh line 424: run_ip6 254 ${TEST_NET6[1]}::11 ${V6ADDRS[p1]} ${NETIFS[p1]} 2 \ ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_ip6 254 "${TEST_NET6[1]}"::11 "${V6ADDRS[p1]}" "${NETIFS[p1]}" 2 \ In fib-onlink-tests.sh line 426: run_ip6 254 ${TEST_NET6[1]}::12 ${lladdr} ${NETIFS[p1]} 2 \ ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_ip6 254 "${TEST_NET6[1]}"::12 "${lladdr}" "${NETIFS[p1]}" 2 \ In fib-onlink-tests.sh line 428: run_ip6 254 ${TEST_NET6[1]}::12 ${MCAST6} ${NETIFS[p1]} 2 \ ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_ip6 254 "${TEST_NET6[1]}"::12 ${MCAST6} "${NETIFS[p1]}" 2 \ In fib-onlink-tests.sh line 431: lladdr=$(get_linklocal ${NETIFS[p5]}) || return 1 ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: lladdr=$(get_linklocal "${NETIFS[p5]}") || return 1 In fib-onlink-tests.sh line 432: run_ip6 ${VRF_TABLE} ${TEST_NET6[2]}::11 ${V6ADDRS[p5]} ${NETIFS[p5]} 2 \ ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_ip6 ${VRF_TABLE} "${TEST_NET6[2]}"::11 "${V6ADDRS[p5]}" "${NETIFS[p5]}" 2 \ In fib-onlink-tests.sh line 434: run_ip6 ${VRF_TABLE} ${TEST_NET6[2]}::12 ${lladdr} ${NETIFS[p5]} 2 \ ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_ip6 ${VRF_TABLE} "${TEST_NET6[2]}"::12 "${lladdr}" "${NETIFS[p5]}" 2 \ In fib-onlink-tests.sh line 436: run_ip6 ${VRF_TABLE} ${TEST_NET6[2]}::12 ${MCAST6} ${NETIFS[p5]} 2 \ ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_ip6 ${VRF_TABLE} "${TEST_NET6[2]}"::12 ${MCAST6} "${NETIFS[p5]}" 2 \ In fib-onlink-tests.sh line 439: run_ip6 254 ${TEST_NET6[1]}::101 ${V6ADDRS[p1]} "" 2 \ ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_ip6 254 "${TEST_NET6[1]}"::101 "${V6ADDRS[p1]}" "" 2 \ In fib-onlink-tests.sh line 446: run_ip6 ${VRF_TABLE} ${TEST_NET6[2]}::103 ${V6ADDRS[p7]/::[0-9]/::64} ${NETIFS[p5]} 2 \ ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------------------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_ip6 ${VRF_TABLE} "${TEST_NET6[2]}"::103 "${V6ADDRS[p7]/::[0-9]/::64}" "${NETIFS[p5]}" 2 \ In fib-onlink-tests.sh line 488: v) VERBOSE=$(($VERBOSE + 1));; ^------^ SC2004 (style): $/${} is unnecessary on arithmetic variables. For more information: https://www.shellcheck.net/wiki/SC2034 -- TEST_NET4IN6IN6 appears unused. V... https://www.shellcheck.net/wiki/SC2166 -- Prefer [ p ] && [ q ] as [ p -a q... https://www.shellcheck.net/wiki/SC2059 -- Don't use variables in the printf...