WARNING: line length of 86 exceeds 80 columns #77: FILE: drivers/net/ethernet/mediatek/mtk_eth_soc.c:2973: + mtk_w32(eth, MTK_HW_LRO_REPLACE_DELTA, MTK_PDMA_LRO_ALT_SCORE_DELTA(reg_map)); WARNING: line length of 94 exceeds 80 columns #116: FILE: drivers/net/ethernet/mediatek/mtk_eth_soc.c:3008: + MTK_RX_DONE_INT(eth, MTK_HW_LRO_RING(eth, i)), reg_map->pdma.int_grp); WARNING: line length of 99 exceeds 80 columns #121: FILE: drivers/net/ethernet/mediatek/mtk_eth_soc.c:3013: + MTK_RX_DONE_INT(eth, MTK_HW_LRO_RING(eth, i + 2)), reg_map->pdma.int_grp3); WARNING: line length of 87 exceeds 80 columns #136: FILE: drivers/net/ethernet/mediatek/mtk_eth_soc.c:3026: + mtk_w32(eth, MTK_LRO_RING_RELINQUISH_REQ(eth), MTK_PDMA_LRO_CTRL_DW0(reg_map)); WARNING: line length of 82 exceeds 80 columns #229: FILE: drivers/net/ethernet/mediatek/mtk_eth_soc.c:3134: + reg_val = mtk_r32(eth, MTK_LRO_DIP_DW0_CFG(eth->soc->reg_map, i)); WARNING: line length of 93 exceeds 80 columns #344: FILE: drivers/net/ethernet/mediatek/mtk_eth_soc.c:3473: + err = mtk_rx_alloc(eth, MTK_HW_LRO_RING(eth, i), MTK_RX_FLAGS_HWLRO); WARNING: line length of 89 exceeds 80 columns #355: FILE: drivers/net/ethernet/mediatek/mtk_eth_soc.c:3536: + mtk_rx_clean(eth, ð->rx_ring[MTK_HW_LRO_RING(eth, i)], false); WARNING: line length of 89 exceeds 80 columns #391: FILE: drivers/net/ethernet/mediatek/mtk_eth_soc.c:3891: + napi_enable(ð->rx_napi[MTK_HW_LRO_RING(eth, i)].napi); WARNING: line length of 97 exceeds 80 columns #393: FILE: drivers/net/ethernet/mediatek/mtk_eth_soc.c:3893: + MTK_HW_LRO_RING(eth, i))); WARNING: line length of 95 exceeds 80 columns #406: FILE: drivers/net/ethernet/mediatek/mtk_eth_soc.c:3994: + mtk_rx_irq_disable(eth, MTK_RX_DONE_INT(eth, MTK_HW_LRO_RING(eth, i))); WARNING: line length of 86 exceeds 80 columns #407: FILE: drivers/net/ethernet/mediatek/mtk_eth_soc.c:3995: + napi_synchronize(ð->rx_napi[MTK_HW_LRO_RING(eth, i)].napi); WARNING: line length of 82 exceeds 80 columns #408: FILE: drivers/net/ethernet/mediatek/mtk_eth_soc.c:3996: + napi_disable(ð->rx_napi[MTK_HW_LRO_RING(eth, i)].napi); WARNING: line length of 82 exceeds 80 columns #423: FILE: drivers/net/ethernet/mediatek/mtk_eth_soc.c:4403: + rx_napi->rx_ring = ð->rx_ring[MTK_HW_LRO_RING(eth, i)]; WARNING: line length of 86 exceeds 80 columns #446: FILE: drivers/net/ethernet/mediatek/mtk_eth_soc.c:5677: + irqname = devm_kasprintf(eth->dev, GFP_KERNEL, WARNING: line length of 88 exceeds 80 columns #448: FILE: drivers/net/ethernet/mediatek/mtk_eth_soc.c:5679: + dev_name(eth->dev), i); WARNING: line length of 101 exceeds 80 columns #450: FILE: drivers/net/ethernet/mediatek/mtk_eth_soc.c:5681: + eth->irq_pdma[MTK_HW_LRO_IRQ(eth, i)], WARNING: line length of 94 exceeds 80 columns #451: FILE: drivers/net/ethernet/mediatek/mtk_eth_soc.c:5682: + mtk_handle_irq_rx, IRQF_SHARED, WARNING: line length of 103 exceeds 80 columns #453: FILE: drivers/net/ethernet/mediatek/mtk_eth_soc.c:5684: + ð->rx_napi[MTK_HW_LRO_RING(eth, i)]); WARNING: line length of 99 exceeds 80 columns #467: FILE: drivers/net/ethernet/mediatek/mtk_eth_soc.c:5762: + netif_napi_add(eth->dummy_dev, ð->rx_napi[MTK_HW_LRO_RING(eth, i)].napi, WARNING: line length of 84 exceeds 80 columns #482: FILE: drivers/net/ethernet/mediatek/mtk_eth_soc.c:5818: + netif_napi_del(ð->rx_napi[MTK_HW_LRO_RING(eth, i)].napi); WARNING: line length of 83 exceeds 80 columns #510: FILE: drivers/net/ethernet/mediatek/mtk_eth_soc.h:67: +#define MTK_HW_LRO_DMA_SIZE(eth) (mtk_is_netsys_v3_or_greater(eth) ? 64 : 8) WARNING: line length of 82 exceeds 80 columns #521: FILE: drivers/net/ethernet/mediatek/mtk_eth_soc.h:184: +#define MTK_HW_LRO_DIP_NUM(eth) (mtk_is_netsys_v3_or_greater(eth) ? 4 : 3) WARNING: line length of 82 exceeds 80 columns #522: FILE: drivers/net/ethernet/mediatek/mtk_eth_soc.h:185: +#define MTK_HW_LRO_RING_NUM(eth) (mtk_is_netsys_v3_or_greater(eth) ? 4 : 3) WARNING: line length of 90 exceeds 80 columns #523: FILE: drivers/net/ethernet/mediatek/mtk_eth_soc.h:186: +#define MTK_HW_LRO_RING(eth, x) ((x) + (mtk_is_netsys_v3_or_greater(eth) ? 4 : 1)) WARNING: line length of 90 exceeds 80 columns #524: FILE: drivers/net/ethernet/mediatek/mtk_eth_soc.h:187: +#define MTK_HW_LRO_IRQ(eth, x) ((x) + (mtk_is_netsys_v3_or_greater(eth) ? 0 : 1)) WARNING: line length of 88 exceeds 80 columns #525: FILE: drivers/net/ethernet/mediatek/mtk_eth_soc.h:188: +#define MTK_LRO_CRSN_BNW(eth) BIT((mtk_is_netsys_v3_or_greater(eth) ? 22 : 6)) WARNING: line length of 86 exceeds 80 columns #531: FILE: drivers/net/ethernet/mediatek/mtk_eth_soc.h:192: +#define MTK_L3_CKS_UPD_EN(eth) BIT(mtk_is_netsys_v3_or_greater(eth) ? 19 : 7) WARNING: line length of 106 exceeds 80 columns #541: FILE: drivers/net/ethernet/mediatek/mtk_eth_soc.h:194: +#define MTK_LRO_RING_RELINQUISH_REQ(eth) (mtk_is_netsys_v3_or_greater(eth) ? 0xf << 24 : 0x7 << 26) WARNING: line length of 106 exceeds 80 columns #542: FILE: drivers/net/ethernet/mediatek/mtk_eth_soc.h:195: +#define MTK_LRO_RING_RELINQUISH_DONE(eth) (mtk_is_netsys_v3_or_greater(eth) ? 0xf << 28 : 0x7 << 29) CHECK: Macro argument 'reg_map' may be better as '(reg_map)' to avoid precedence issues #544: FILE: drivers/net/ethernet/mediatek/mtk_eth_soc.h:197: +#define MTK_PDMA_LRO_CTRL_DW0(reg_map) (reg_map->pdma.lro_ctrl_dw0) CHECK: Macro argument 'reg_map' may be better as '(reg_map)' to avoid precedence issues #545: FILE: drivers/net/ethernet/mediatek/mtk_eth_soc.h:198: +#define MTK_PDMA_LRO_CTRL_DW1(reg_map) (reg_map->pdma.lro_ctrl_dw0 + 0x04) CHECK: Macro argument 'reg_map' may be better as '(reg_map)' to avoid precedence issues #546: FILE: drivers/net/ethernet/mediatek/mtk_eth_soc.h:199: +#define MTK_PDMA_LRO_CTRL_DW2(reg_map) (reg_map->pdma.lro_ctrl_dw0 + 0x08) CHECK: Macro argument 'reg_map' may be better as '(reg_map)' to avoid precedence issues #547: FILE: drivers/net/ethernet/mediatek/mtk_eth_soc.h:200: +#define MTK_PDMA_LRO_CTRL_DW3(reg_map) (reg_map->pdma.lro_ctrl_dw0 + 0x0c) WARNING: line length of 83 exceeds 80 columns #569: FILE: drivers/net/ethernet/mediatek/mtk_eth_soc.h:248: +#define MTK_PDMA_LRO_ALT_SCORE_DELTA(reg_map) (reg_map->pdma.lro_alt_score_delta) CHECK: Macro argument 'reg_map' may be better as '(reg_map)' to avoid precedence issues #569: FILE: drivers/net/ethernet/mediatek/mtk_eth_soc.h:248: +#define MTK_PDMA_LRO_ALT_SCORE_DELTA(reg_map) (reg_map->pdma.lro_alt_score_delta) WARNING: line length of 87 exceeds 80 columns #574: FILE: drivers/net/ethernet/mediatek/mtk_eth_soc.h:251: +#define MTK_LRO_DIP_DW0_CFG(reg_map, x) (reg_map->pdma.lro_ring_dip_dw0 + ((x) * 0x40)) CHECK: Macro argument 'reg_map' may be better as '(reg_map)' to avoid precedence issues #574: FILE: drivers/net/ethernet/mediatek/mtk_eth_soc.h:251: +#define MTK_LRO_DIP_DW0_CFG(reg_map, x) (reg_map->pdma.lro_ring_dip_dw0 + ((x) * 0x40)) total: 0 errors, 31 warnings, 6 checks, 533 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Commit d4783ac0d1f0 ("net: ethernet: mtk_eth_soc: Add LRO support") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE FILE_PATH_CHANGES GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. total: 0 errors, 31 warnings, 6 checks, 533 lines checked