CHECK: Comparison to NULL could be written "ctx.data" #156: FILE: crypto/asymmetric_keys/pkcs7_parser.c:273: + if (ret < 0 || ctx.data != NULL) CHECK: extern prototypes should be avoided in .h files #181: FILE: include/crypto/pkcs7.h:28: +extern int pkcs7_get_authattr(const struct pkcs7_message *pkcs7, total: 0 errors, 0 warnings, 2 checks, 142 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Commit f4ede4f1725f ("crypto: pkcs7: add ability to extract signed attributes by OID") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE FILE_PATH_CHANGES GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. total: 0 errors, 0 warnings, 2 checks, 142 lines checked