ShellCheck - shell script analysis tool
version: 0.11.0
license: GNU General Public License, version 3
website: https://www.shellcheck.net
Redirect to /tmp/tmp.J5oXXjSmaO and /tmp/tmp.H03Vk4C092
Tree base:
c602be706ddd ("net: dsa: deny multiple 8021q uppers on bridged ports for the same VLAN")
Now at:
25635e00503c ("selftests: no_forwarding: test VLAN uppers on VLAN aware bridged ports")
 ====== Checking before the patch ======
Checking tools/testing/selftests/net/forwarding/no_forwarding.sh - 78783e3dd9876a5e27ba2f3d8033bb2ca4665dce660a7fb23bd4c0de1dd95f63


In no_forwarding.sh line 31:
send_non_ip()
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In no_forwarding.sh line 37:
	$MZ -q $if_name "$dmac $smac $NON_IP_PKT"
               ^------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	$MZ -q "$if_name" "$dmac $smac $NON_IP_PKT"


In no_forwarding.sh line 40:
send_uc_ipv4()
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In no_forwarding.sh line 45:
	ip neigh add $H2_IPV4 lladdr $dmac dev $if_name
                     ^------^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                     ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                               ^------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	ip neigh add "$H2_IPV4" lladdr "$dmac" dev "$if_name"


In no_forwarding.sh line 46:
	ping_do $if_name $H2_IPV4
                ^------^ SC2086 (info): Double quote to prevent globbing and word splitting.
                         ^------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	ping_do "$if_name" "$H2_IPV4"


In no_forwarding.sh line 47:
	ip neigh del $H2_IPV4 dev $if_name
                     ^------^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                  ^------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	ip neigh del "$H2_IPV4" dev "$if_name"


In no_forwarding.sh line 50:
send_mc_ipv4()
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In no_forwarding.sh line 54:
	ping_do $if_name $IPV4_ALLNODES "-I $if_name"
                ^------^ SC2086 (info): Double quote to prevent globbing and word splitting.
                         ^------------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	ping_do "$if_name" "$IPV4_ALLNODES" "-I $if_name"


In no_forwarding.sh line 57:
send_uc_ipv6()
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In no_forwarding.sh line 62:
	ip -6 neigh add $H2_IPV6 lladdr $dmac dev $if_name
                        ^------^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                        ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                                  ^------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	ip -6 neigh add "$H2_IPV6" lladdr "$dmac" dev "$if_name"


In no_forwarding.sh line 63:
	ping6_do $if_name $H2_IPV6
                 ^------^ SC2086 (info): Double quote to prevent globbing and word splitting.
                          ^------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	ping6_do "$if_name" "$H2_IPV6"


In no_forwarding.sh line 64:
	ip -6 neigh del $H2_IPV6 dev $if_name
                        ^------^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                     ^------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	ip -6 neigh del "$H2_IPV6" dev "$if_name"


In no_forwarding.sh line 67:
send_mc_ipv6()
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In no_forwarding.sh line 71:
	ping6_do $if_name $IPV6_ALLNODES%$if_name
                 ^------^ SC2086 (info): Double quote to prevent globbing and word splitting.
                          ^------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                         ^------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	ping6_do "$if_name" "$IPV6_ALLNODES"%"$if_name"


In no_forwarding.sh line 74:
check_rcv()
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In no_forwarding.sh line 83:
	tcpdump_show $if_name | grep -q "$pattern"
                     ^------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	tcpdump_show "$if_name" | grep -q "$pattern"


In no_forwarding.sh line 90:
run_test()
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In no_forwarding.sh line 93:
	local smac=$(mac_get $h1)
              ^--^ SC2155 (warning): Declare and assign separately to avoid masking return values.
                             ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	local smac=$(mac_get "$h1")


In no_forwarding.sh line 94:
	local dmac=$(mac_get $h2)
              ^--^ SC2155 (warning): Declare and assign separately to avoid masking return values.
                             ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	local dmac=$(mac_get "$h2")


In no_forwarding.sh line 95:
	local h1_ipv6_lladdr=$(ipv6_lladdr_get $h1)
              ^------------^ SC2155 (warning): Declare and assign separately to avoid masking return values.
                                               ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	local h1_ipv6_lladdr=$(ipv6_lladdr_get "$h1")


In no_forwarding.sh line 100:
	tcpdump_start $h2
                      ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	tcpdump_start "$h2"


In no_forwarding.sh line 102:
	send_non_ip $h1 $smac $dmac
                    ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.
                        ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.
                              ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	send_non_ip "$h1" "$smac" "$dmac"


In no_forwarding.sh line 103:
	send_non_ip $h1 $smac $NON_IP_MC
                    ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.
                        ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.
                              ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	send_non_ip "$h1" "$smac" "$NON_IP_MC"


In no_forwarding.sh line 104:
	send_non_ip $h1 $smac $BC
                    ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.
                        ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.
                              ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	send_non_ip "$h1" "$smac" "$BC"


In no_forwarding.sh line 105:
	send_uc_ipv4 $h1 $dmac
                     ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.
                         ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	send_uc_ipv4 "$h1" "$dmac"


In no_forwarding.sh line 106:
	send_mc_ipv4 $h1
                     ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	send_mc_ipv4 "$h1"


In no_forwarding.sh line 107:
	send_uc_ipv6 $h1 $dmac
                     ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.
                         ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	send_uc_ipv6 "$h1" "$dmac"


In no_forwarding.sh line 108:
	send_mc_ipv6 $h1
                     ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	send_mc_ipv6 "$h1"


In no_forwarding.sh line 111:
		vlan_create $h1 $vid
                            ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
		vlan_create "$h1" "$vid"


In no_forwarding.sh line 112:
		simple_if_init $h1.$vid $H1_IPV4/24 $H1_IPV6/64
                               ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                   ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                        ^------^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                                    ^------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
		simple_if_init "$h1"."$vid" "$H1_IPV4"/24 "$H1_IPV6"/64


In no_forwarding.sh line 114:
		send_non_ip $h1.$vid $smac $dmac
                            ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                     ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                           ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
		send_non_ip "$h1"."$vid" "$smac" "$dmac"


In no_forwarding.sh line 115:
		send_non_ip $h1.$vid $smac $NON_IP_MC
                            ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                     ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                           ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
		send_non_ip "$h1"."$vid" "$smac" "$NON_IP_MC"


In no_forwarding.sh line 116:
		send_non_ip $h1.$vid $smac $BC
                            ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                     ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                           ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
		send_non_ip "$h1"."$vid" "$smac" "$BC"


In no_forwarding.sh line 117:
		send_uc_ipv4 $h1.$vid $dmac
                             ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                      ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
		send_uc_ipv4 "$h1"."$vid" "$dmac"


In no_forwarding.sh line 118:
		send_mc_ipv4 $h1.$vid
                             ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
		send_mc_ipv4 "$h1"."$vid"


In no_forwarding.sh line 119:
		send_uc_ipv6 $h1.$vid $dmac
                             ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                      ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
		send_uc_ipv6 "$h1"."$vid" "$dmac"


In no_forwarding.sh line 120:
		send_mc_ipv6 $h1.$vid
                             ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
		send_mc_ipv6 "$h1"."$vid"


In no_forwarding.sh line 122:
		simple_if_fini $h1.$vid $H1_IPV4/24 $H1_IPV6/64
                               ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                   ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                        ^------^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                                    ^------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
		simple_if_fini "$h1"."$vid" "$H1_IPV4"/24 "$H1_IPV6"/64


In no_forwarding.sh line 123:
		vlan_destroy $h1 $vid
                             ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
		vlan_destroy "$h1" "$vid"


In no_forwarding.sh line 130:
	tcpdump_stop $h2
                     ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	tcpdump_stop "$h2"


In no_forwarding.sh line 132:
	check_rcv $h2 "$test_name: Unicast non-IP untagged" \
                  ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	check_rcv "$h2" "$test_name: Unicast non-IP untagged" \


In no_forwarding.sh line 135:
	check_rcv $h2 "$test_name: Multicast non-IP untagged" \
                  ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	check_rcv "$h2" "$test_name: Multicast non-IP untagged" \


In no_forwarding.sh line 138:
	check_rcv $h2 "$test_name: Broadcast non-IP untagged" \
                  ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	check_rcv "$h2" "$test_name: Broadcast non-IP untagged" \


In no_forwarding.sh line 141:
	check_rcv $h2 "$test_name: Unicast IPv4 untagged" \
                  ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	check_rcv "$h2" "$test_name: Unicast IPv4 untagged" \


In no_forwarding.sh line 144:
	check_rcv $h2 "$test_name: Multicast IPv4 untagged" \
                  ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	check_rcv "$h2" "$test_name: Multicast IPv4 untagged" \


In no_forwarding.sh line 147:
	check_rcv $h2 "$test_name: Unicast IPv6 untagged" \
                  ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	check_rcv "$h2" "$test_name: Unicast IPv6 untagged" \


In no_forwarding.sh line 150:
	check_rcv $h2 "$test_name: Multicast IPv6 untagged" \
                  ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	check_rcv "$h2" "$test_name: Multicast IPv6 untagged" \


In no_forwarding.sh line 154:
		check_rcv $h2 "$test_name: Unicast non-IP VID $vid" \
                          ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
		check_rcv "$h2" "$test_name: Unicast non-IP VID $vid" \


In no_forwarding.sh line 157:
		check_rcv $h2 "$test_name: Multicast non-IP VID $vid" \
                          ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
		check_rcv "$h2" "$test_name: Multicast non-IP VID $vid" \


In no_forwarding.sh line 160:
		check_rcv $h2 "$test_name: Broadcast non-IP VID $vid" \
                          ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
		check_rcv "$h2" "$test_name: Broadcast non-IP VID $vid" \


In no_forwarding.sh line 163:
		check_rcv $h2 "$test_name: Unicast IPv4 VID $vid" \
                          ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
		check_rcv "$h2" "$test_name: Unicast IPv4 VID $vid" \


In no_forwarding.sh line 166:
		check_rcv $h2 "$test_name: Multicast IPv4 VID $vid" \
                          ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
		check_rcv "$h2" "$test_name: Multicast IPv4 VID $vid" \


In no_forwarding.sh line 169:
		check_rcv $h2 "$test_name: Unicast IPv6 VID $vid" \
                          ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
		check_rcv "$h2" "$test_name: Unicast IPv6 VID $vid" \


In no_forwarding.sh line 172:
		check_rcv $h2 "$test_name: Multicast IPv6 VID $vid" \
                          ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
		check_rcv "$h2" "$test_name: Multicast IPv6 VID $vid" \


In no_forwarding.sh line 176:
	tcpdump_cleanup $h2
                        ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	tcpdump_cleanup "$h2"


In no_forwarding.sh line 179:
standalone()
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In no_forwarding.sh line 184:
two_bridges()
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In no_forwarding.sh line 188:
	ip link set $swp1 master br0
                    ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	ip link set "$swp1" master br0


In no_forwarding.sh line 189:
	ip link set $swp2 master br1
                    ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	ip link set "$swp2" master br1


In no_forwarding.sh line 197:
one_bridge_two_pvids()
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In no_forwarding.sh line 201:
	ip link set $swp1 master br0
                    ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	ip link set "$swp1" master br0


In no_forwarding.sh line 202:
	ip link set $swp2 master br0
                    ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	ip link set "$swp2" master br0


In no_forwarding.sh line 204:
	bridge vlan add dev $swp1 vid 1 pvid untagged
                            ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	bridge vlan add dev "$swp1" vid 1 pvid untagged


In no_forwarding.sh line 205:
	bridge vlan add dev $swp2 vid 2 pvid untagged
                            ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	bridge vlan add dev "$swp2" vid 2 pvid untagged


In no_forwarding.sh line 214:
	simple_if_init $h1 $H1_IPV4/24 $H1_IPV6/64
                       ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	simple_if_init "$h1" $H1_IPV4/24 $H1_IPV6/64


In no_forwarding.sh line 217:
h1_destroy()
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In no_forwarding.sh line 219:
	simple_if_fini $h1 $H1_IPV4/24 $H1_IPV6/64
                       ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.
                           ^------^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                       ^------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	simple_if_fini "$h1" "$H1_IPV4"/24 "$H1_IPV6"/64


In no_forwarding.sh line 224:
	simple_if_init $h2 $H2_IPV4/24 $H2_IPV6/64
                       ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	simple_if_init "$h2" $H2_IPV4/24 $H2_IPV6/64


In no_forwarding.sh line 227:
h2_destroy()
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In no_forwarding.sh line 229:
	simple_if_fini $h2 $H2_IPV4/24 $H2_IPV6/64
                       ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.
                           ^------^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                       ^------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	simple_if_fini "$h2" "$H2_IPV4"/24 "$H2_IPV6"/64


In no_forwarding.sh line 232:
cleanup()
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In no_forwarding.sh line 236:
	ip link set dev $swp2 down
                        ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	ip link set dev "$swp2" down


In no_forwarding.sh line 237:
	ip link set dev $swp1 down
                        ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	ip link set dev "$swp1" down


In no_forwarding.sh line 253:
	ip link set dev $swp1 up
                        ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	ip link set dev "$swp1" up


In no_forwarding.sh line 254:
	ip link set dev $swp2 up
                        ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	ip link set dev "$swp2" up


In no_forwarding.sh line 264:
exit $EXIT_STATUS
     ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
exit "$EXIT_STATUS"

For more information:
  https://www.shellcheck.net/wiki/SC2155 -- Declare and assign separately to ...
  https://www.shellcheck.net/wiki/SC2086 -- Double quote to prevent globbing ...
  https://www.shellcheck.net/wiki/SC2329 -- This function is never invoked. C...

 ====== Checking the tree with the patch ======
Checking tools/testing/selftests/net/forwarding/no_forwarding.sh - 78783e3dd9876a5e27ba2f3d8033bb2ca4665dce660a7fb23bd4c0de1dd95f63


In no_forwarding.sh line 31:
send_non_ip()
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In no_forwarding.sh line 37:
	$MZ -q $if_name "$dmac $smac $NON_IP_PKT"
               ^------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	$MZ -q "$if_name" "$dmac $smac $NON_IP_PKT"


In no_forwarding.sh line 40:
send_uc_ipv4()
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In no_forwarding.sh line 45:
	ip neigh add $H2_IPV4 lladdr $dmac dev $if_name
                     ^------^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                     ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                               ^------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	ip neigh add "$H2_IPV4" lladdr "$dmac" dev "$if_name"


In no_forwarding.sh line 46:
	ping_do $if_name $H2_IPV4
                ^------^ SC2086 (info): Double quote to prevent globbing and word splitting.
                         ^------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	ping_do "$if_name" "$H2_IPV4"


In no_forwarding.sh line 47:
	ip neigh del $H2_IPV4 dev $if_name
                     ^------^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                  ^------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	ip neigh del "$H2_IPV4" dev "$if_name"


In no_forwarding.sh line 50:
send_mc_ipv4()
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In no_forwarding.sh line 54:
	ping_do $if_name $IPV4_ALLNODES "-I $if_name"
                ^------^ SC2086 (info): Double quote to prevent globbing and word splitting.
                         ^------------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	ping_do "$if_name" "$IPV4_ALLNODES" "-I $if_name"


In no_forwarding.sh line 57:
send_uc_ipv6()
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In no_forwarding.sh line 62:
	ip -6 neigh add $H2_IPV6 lladdr $dmac dev $if_name
                        ^------^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                        ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                                  ^------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	ip -6 neigh add "$H2_IPV6" lladdr "$dmac" dev "$if_name"


In no_forwarding.sh line 63:
	ping6_do $if_name $H2_IPV6
                 ^------^ SC2086 (info): Double quote to prevent globbing and word splitting.
                          ^------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	ping6_do "$if_name" "$H2_IPV6"


In no_forwarding.sh line 64:
	ip -6 neigh del $H2_IPV6 dev $if_name
                        ^------^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                     ^------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	ip -6 neigh del "$H2_IPV6" dev "$if_name"


In no_forwarding.sh line 67:
send_mc_ipv6()
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In no_forwarding.sh line 71:
	ping6_do $if_name $IPV6_ALLNODES%$if_name
                 ^------^ SC2086 (info): Double quote to prevent globbing and word splitting.
                          ^------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                         ^------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	ping6_do "$if_name" "$IPV6_ALLNODES"%"$if_name"


In no_forwarding.sh line 74:
check_rcv()
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In no_forwarding.sh line 83:
	tcpdump_show $if_name | grep -q "$pattern"
                     ^------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	tcpdump_show "$if_name" | grep -q "$pattern"


In no_forwarding.sh line 90:
run_test()
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In no_forwarding.sh line 94:
	local smac=$(mac_get $h1)
              ^--^ SC2155 (warning): Declare and assign separately to avoid masking return values.
                             ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	local smac=$(mac_get "$h1")


In no_forwarding.sh line 95:
	local dmac=$(mac_get $h2)
              ^--^ SC2155 (warning): Declare and assign separately to avoid masking return values.
                             ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	local dmac=$(mac_get "$h2")


In no_forwarding.sh line 96:
	local h1_ipv6_lladdr=$(ipv6_lladdr_get $h1)
              ^------------^ SC2155 (warning): Declare and assign separately to avoid masking return values.
                                               ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	local h1_ipv6_lladdr=$(ipv6_lladdr_get "$h1")


In no_forwarding.sh line 101:
	tcpdump_start $h2
                      ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	tcpdump_start "$h2"


In no_forwarding.sh line 104:
		send_non_ip $h1 $smac $dmac
                            ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                      ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
		send_non_ip "$h1" "$smac" "$dmac"


In no_forwarding.sh line 105:
		send_non_ip $h1 $smac $NON_IP_MC
                            ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                      ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
		send_non_ip "$h1" "$smac" "$NON_IP_MC"


In no_forwarding.sh line 106:
		send_non_ip $h1 $smac $BC
                            ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                      ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
		send_non_ip "$h1" "$smac" "$BC"


In no_forwarding.sh line 107:
		send_uc_ipv4 $h1 $dmac
                             ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                 ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
		send_uc_ipv4 "$h1" "$dmac"


In no_forwarding.sh line 108:
		send_mc_ipv4 $h1
                             ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
		send_mc_ipv4 "$h1"


In no_forwarding.sh line 109:
		send_uc_ipv6 $h1 $dmac
                             ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                 ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
		send_uc_ipv6 "$h1" "$dmac"


In no_forwarding.sh line 110:
		send_mc_ipv6 $h1
                             ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
		send_mc_ipv6 "$h1"


In no_forwarding.sh line 114:
		vlan_create $h1 $vid
                            ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
		vlan_create "$h1" "$vid"


In no_forwarding.sh line 116:
			vlan_create $swp1 $vid
                                    ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                          ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
			vlan_create "$swp1" "$vid"


In no_forwarding.sh line 119:
			vlan_create $swp2 $vid
                                    ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                          ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
			vlan_create "$swp2" "$vid"


In no_forwarding.sh line 121:
		simple_if_init $h1.$vid $H1_IPV4/24 $H1_IPV6/64
                               ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                   ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                        ^------^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                                    ^------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
		simple_if_init "$h1"."$vid" "$H1_IPV4"/24 "$H1_IPV6"/64


In no_forwarding.sh line 123:
		send_non_ip $h1.$vid $smac $dmac
                            ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                     ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                           ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
		send_non_ip "$h1"."$vid" "$smac" "$dmac"


In no_forwarding.sh line 124:
		send_non_ip $h1.$vid $smac $NON_IP_MC
                            ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                     ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                           ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
		send_non_ip "$h1"."$vid" "$smac" "$NON_IP_MC"


In no_forwarding.sh line 125:
		send_non_ip $h1.$vid $smac $BC
                            ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                     ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                           ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
		send_non_ip "$h1"."$vid" "$smac" "$BC"


In no_forwarding.sh line 126:
		send_uc_ipv4 $h1.$vid $dmac
                             ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                      ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
		send_uc_ipv4 "$h1"."$vid" "$dmac"


In no_forwarding.sh line 127:
		send_mc_ipv4 $h1.$vid
                             ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
		send_mc_ipv4 "$h1"."$vid"


In no_forwarding.sh line 128:
		send_uc_ipv6 $h1.$vid $dmac
                             ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                      ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
		send_uc_ipv6 "$h1"."$vid" "$dmac"


In no_forwarding.sh line 129:
		send_mc_ipv6 $h1.$vid
                             ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
		send_mc_ipv6 "$h1"."$vid"


In no_forwarding.sh line 131:
		simple_if_fini $h1.$vid $H1_IPV4/24 $H1_IPV6/64
                               ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                   ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                        ^------^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                                    ^------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
		simple_if_fini "$h1"."$vid" "$H1_IPV4"/24 "$H1_IPV6"/64


In no_forwarding.sh line 133:
			vlan_destroy $swp2 $vid
                                     ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                           ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
			vlan_destroy "$swp2" "$vid"


In no_forwarding.sh line 136:
			vlan_destroy $swp1 $vid
                                     ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                           ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
			vlan_destroy "$swp1" "$vid"


In no_forwarding.sh line 138:
		vlan_destroy $h1 $vid
                             ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
		vlan_destroy "$h1" "$vid"


In no_forwarding.sh line 145:
	tcpdump_stop $h2
                     ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	tcpdump_stop "$h2"


In no_forwarding.sh line 148:
		check_rcv $h2 "$test_name: Unicast non-IP untagged" \
                          ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
		check_rcv "$h2" "$test_name: Unicast non-IP untagged" \


In no_forwarding.sh line 151:
		check_rcv $h2 "$test_name: Multicast non-IP untagged" \
                          ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
		check_rcv "$h2" "$test_name: Multicast non-IP untagged" \


In no_forwarding.sh line 154:
		check_rcv $h2 "$test_name: Broadcast non-IP untagged" \
                          ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
		check_rcv "$h2" "$test_name: Broadcast non-IP untagged" \


In no_forwarding.sh line 157:
		check_rcv $h2 "$test_name: Unicast IPv4 untagged" \
                          ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
		check_rcv "$h2" "$test_name: Unicast IPv4 untagged" \


In no_forwarding.sh line 160:
		check_rcv $h2 "$test_name: Multicast IPv4 untagged" \
                          ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
		check_rcv "$h2" "$test_name: Multicast IPv4 untagged" \


In no_forwarding.sh line 163:
		check_rcv $h2 "$test_name: Unicast IPv6 untagged" \
                          ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
		check_rcv "$h2" "$test_name: Unicast IPv6 untagged" \


In no_forwarding.sh line 166:
		check_rcv $h2 "$test_name: Multicast IPv6 untagged" \
                          ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
		check_rcv "$h2" "$test_name: Multicast IPv6 untagged" \


In no_forwarding.sh line 171:
		check_rcv $h2 "$test_name: Unicast non-IP VID $vid" \
                          ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
		check_rcv "$h2" "$test_name: Unicast non-IP VID $vid" \


In no_forwarding.sh line 174:
		check_rcv $h2 "$test_name: Multicast non-IP VID $vid" \
                          ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
		check_rcv "$h2" "$test_name: Multicast non-IP VID $vid" \


In no_forwarding.sh line 177:
		check_rcv $h2 "$test_name: Broadcast non-IP VID $vid" \
                          ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
		check_rcv "$h2" "$test_name: Broadcast non-IP VID $vid" \


In no_forwarding.sh line 180:
		check_rcv $h2 "$test_name: Unicast IPv4 VID $vid" \
                          ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
		check_rcv "$h2" "$test_name: Unicast IPv4 VID $vid" \


In no_forwarding.sh line 183:
		check_rcv $h2 "$test_name: Multicast IPv4 VID $vid" \
                          ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
		check_rcv "$h2" "$test_name: Multicast IPv4 VID $vid" \


In no_forwarding.sh line 186:
		check_rcv $h2 "$test_name: Unicast IPv6 VID $vid" \
                          ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
		check_rcv "$h2" "$test_name: Unicast IPv6 VID $vid" \


In no_forwarding.sh line 189:
		check_rcv $h2 "$test_name: Multicast IPv6 VID $vid" \
                          ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
		check_rcv "$h2" "$test_name: Multicast IPv6 VID $vid" \


In no_forwarding.sh line 193:
	tcpdump_cleanup $h2
                        ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	tcpdump_cleanup "$h2"


In no_forwarding.sh line 196:
standalone()
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In no_forwarding.sh line 201:
two_bridges()
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In no_forwarding.sh line 205:
	ip link set $swp1 master br0
                    ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	ip link set "$swp1" master br0


In no_forwarding.sh line 206:
	ip link set $swp2 master br1
                    ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	ip link set "$swp2" master br1


In no_forwarding.sh line 214:
one_bridge_two_pvids()
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In no_forwarding.sh line 218:
	ip link set $swp1 master br0
                    ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	ip link set "$swp1" master br0


In no_forwarding.sh line 219:
	ip link set $swp2 master br0
                    ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	ip link set "$swp2" master br0


In no_forwarding.sh line 221:
	bridge vlan add dev $swp1 vid 1 pvid untagged
                            ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	bridge vlan add dev "$swp1" vid 1 pvid untagged


In no_forwarding.sh line 222:
	bridge vlan add dev $swp2 vid 2 pvid untagged
                            ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	bridge vlan add dev "$swp2" vid 2 pvid untagged


In no_forwarding.sh line 229:
bridge_aware_vlan_uppers()
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In no_forwarding.sh line 233:
	ip link set $swp1 master br0
                    ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	ip link set "$swp1" master br0


In no_forwarding.sh line 234:
	ip link set $swp2 master br0
                    ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	ip link set "$swp2" master br0


In no_forwarding.sh line 236:
	if ! ip link add name $swp1.10 link $swp1 type vlan id 10 2>/dev/null; then
                              ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                            ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	if ! ip link add name "$swp1".10 link "$swp1" type vlan id 10 2>/dev/null; then


In no_forwarding.sh line 242:
	if ! ip link add name $swp2.10 link $swp2 type vlan id 10 2>/dev/null; then
                              ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                            ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	if ! ip link add name "$swp2".10 link "$swp2" type vlan id 10 2>/dev/null; then


In no_forwarding.sh line 243:
		vlan_destroy $swp1 10
                             ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
		vlan_destroy "$swp1" 10


In no_forwarding.sh line 249:
	vlan_destroy $swp1 10
                     ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	vlan_destroy "$swp1" 10


In no_forwarding.sh line 250:
	vlan_destroy $swp2 10
                     ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	vlan_destroy "$swp2" 10


In no_forwarding.sh line 259:
	simple_if_init $h1 $H1_IPV4/24 $H1_IPV6/64
                       ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	simple_if_init "$h1" $H1_IPV4/24 $H1_IPV6/64


In no_forwarding.sh line 262:
h1_destroy()
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In no_forwarding.sh line 264:
	simple_if_fini $h1 $H1_IPV4/24 $H1_IPV6/64
                       ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.
                           ^------^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                       ^------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	simple_if_fini "$h1" "$H1_IPV4"/24 "$H1_IPV6"/64


In no_forwarding.sh line 269:
	simple_if_init $h2 $H2_IPV4/24 $H2_IPV6/64
                       ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	simple_if_init "$h2" $H2_IPV4/24 $H2_IPV6/64


In no_forwarding.sh line 272:
h2_destroy()
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In no_forwarding.sh line 274:
	simple_if_fini $h2 $H2_IPV4/24 $H2_IPV6/64
                       ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.
                           ^------^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                       ^------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	simple_if_fini "$h2" "$H2_IPV4"/24 "$H2_IPV6"/64


In no_forwarding.sh line 277:
cleanup()
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In no_forwarding.sh line 281:
	ip link set dev $swp2 down
                        ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	ip link set dev "$swp2" down


In no_forwarding.sh line 282:
	ip link set dev $swp1 down
                        ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	ip link set dev "$swp1" down


In no_forwarding.sh line 298:
	ip link set dev $swp1 up
                        ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	ip link set dev "$swp1" up


In no_forwarding.sh line 299:
	ip link set dev $swp2 up
                        ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	ip link set dev "$swp2" up


In no_forwarding.sh line 309:
exit $EXIT_STATUS
     ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
exit "$EXIT_STATUS"

For more information:
  https://www.shellcheck.net/wiki/SC2155 -- Declare and assign separately to ...
  https://www.shellcheck.net/wiki/SC2086 -- Double quote to prevent globbing ...
  https://www.shellcheck.net/wiki/SC2329 -- This function is never invoked. C...