ShellCheck - shell script analysis tool
version: 0.11.0
license: GNU General Public License, version 3
website: https://www.shellcheck.net
Redirect to /tmp/tmp.PxzD6DSbBX and /tmp/tmp.NoDGKrIkZd
Tree base:
73f784b2c938 ("Merge tag 'linux-can-next-for-6.19-20251126' of git://git.kernel.org/pub/scm/linux/kernel/git/mkl/linux-can-next")
Now at:
b690f8bb519c ("selftests: net: add a hint about MACAddressPolicy=persistent")
 ====== Checking before the patch ======
Checking tools/testing/selftests/net/arp_ndisc_evict_nocarrier.sh - db26dded31a6e4f28ff106d587a94833ff7dcfd7b9e1ccf3b91fda52a54e003d


In arp_ndisc_evict_nocarrier.sh line 21:
nsid=100
^--^ SC2034 (warning): nsid appears unused. Verify use (or export if used externally).


In arp_ndisc_evict_nocarrier.sh line 26:
    cleanup_ns ${me} ${peer}
               ^---^ SC2154 (warning): me is referenced but not assigned.
               ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.
                     ^-----^ SC2154 (warning): peer is referenced but not assigned.
                     ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
    cleanup_ns "${me}" "${peer}"


In arp_ndisc_evict_nocarrier.sh line 40:
    $IP li set veth2 netns ${peer} up
                           ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
    $IP li set veth2 netns "${peer}" up


In arp_ndisc_evict_nocarrier.sh line 41:
    ip -netns ${peer} -6 addr add $V6_ADDR1/64 dev veth2 nodad
              ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
    ip -netns "${peer}" -6 addr add $V6_ADDR1/64 dev veth2 nodad


In arp_ndisc_evict_nocarrier.sh line 43:
    ip netns exec ${me} sysctl -w $1 >/dev/null 2>&1
                  ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                  ^-- SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
    ip netns exec "${me}" sysctl -w "$1" >/dev/null 2>&1


In arp_ndisc_evict_nocarrier.sh line 46:
    ip netns exec ${me} ping -6 -c1 -Iveth1 $V6_ADDR1 >/dev/null 2>&1
                  ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
    ip netns exec "${me}" ping -6 -c1 -Iveth1 $V6_ADDR1 >/dev/null 2>&1


In arp_ndisc_evict_nocarrier.sh line 48:
    ip netns exec ${me} ip -6 neigh get $V6_ADDR1 dev veth1 >/dev/null 2>&1
                  ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
    ip netns exec "${me}" ip -6 neigh get $V6_ADDR1 dev veth1 >/dev/null 2>&1


In arp_ndisc_evict_nocarrier.sh line 49:
    if [ $? -ne 0 ]; then
         ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.


In arp_ndisc_evict_nocarrier.sh line 56:
    ip netns exec ${peer} ip link set veth2 down
                  ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
    ip netns exec "${peer}" ip link set veth2 down


In arp_ndisc_evict_nocarrier.sh line 67:
    ip netns exec ${PEER_NS} ip route add default via $V4_ADDR1 dev veth1
                  ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
    ip netns exec "${PEER_NS}" ip route add default via $V4_ADDR1 dev veth1


In arp_ndisc_evict_nocarrier.sh line 76:
    if [ $? -ne 0 ]; then
         ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.


In arp_ndisc_evict_nocarrier.sh line 89:
    cleanup_ns $PEER_NS
               ^------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
    cleanup_ns "$PEER_NS"


In arp_ndisc_evict_nocarrier.sh line 103:
    if [ $? -eq 0 ];then
         ^-- SC2181 (style): Check exit code directly with e.g. 'if mycmd;', not indirectly with $?.


In arp_ndisc_evict_nocarrier.sh line 121:
    if [ $? -eq 0 ];then
         ^-- SC2181 (style): Check exit code directly with e.g. 'if mycmd;', not indirectly with $?.


In arp_ndisc_evict_nocarrier.sh line 138:
    if [ $? -eq 0 ];then
         ^-- SC2181 (style): Check exit code directly with e.g. 'if mycmd;', not indirectly with $?.


In arp_ndisc_evict_nocarrier.sh line 152:
    ip netns exec ${me} ip -6 neigh get $V6_ADDR1 dev veth1 >/dev/null 2>&1
                  ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
    ip netns exec "${me}" ip -6 neigh get $V6_ADDR1 dev veth1 >/dev/null 2>&1


In arp_ndisc_evict_nocarrier.sh line 154:
    if [ $? -eq 0 ];then
         ^-- SC2181 (style): Check exit code directly with e.g. 'if mycmd;', not indirectly with $?.


In arp_ndisc_evict_nocarrier.sh line 169:
    ip netns exec ${me} ip -6 neigh get $V6_ADDR1 dev veth1 >/dev/null 2>&1
                  ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
    ip netns exec "${me}" ip -6 neigh get $V6_ADDR1 dev veth1 >/dev/null 2>&1


In arp_ndisc_evict_nocarrier.sh line 171:
    if [ $? -eq 0 ];then
         ^-- SC2181 (style): Check exit code directly with e.g. 'if mycmd;', not indirectly with $?.


In arp_ndisc_evict_nocarrier.sh line 186:
    ip netns exec ${me} ip -6 neigh get $V6_ADDR1 dev veth1 >/dev/null 2>&1
                  ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
    ip netns exec "${me}" ip -6 neigh get $V6_ADDR1 dev veth1 >/dev/null 2>&1


In arp_ndisc_evict_nocarrier.sh line 188:
    if [ $? -eq 0 ];then
         ^-- SC2181 (style): Check exit code directly with e.g. 'if mycmd;', not indirectly with $?.

For more information:
  https://www.shellcheck.net/wiki/SC2034 -- nsid appears unused. Verify use (...
  https://www.shellcheck.net/wiki/SC2154 -- me is referenced but not assigned.
  https://www.shellcheck.net/wiki/SC2086 -- Double quote to prevent globbing ...

 ====== Checking the tree with the patch ======
Checking tools/testing/selftests/net/arp_ndisc_evict_nocarrier.sh - db26dded31a6e4f28ff106d587a94833ff7dcfd7b9e1ccf3b91fda52a54e003d


In arp_ndisc_evict_nocarrier.sh line 21:
nsid=100
^--^ SC2034 (warning): nsid appears unused. Verify use (or export if used externally).


In arp_ndisc_evict_nocarrier.sh line 26:
    cleanup_ns ${me} ${peer}
               ^---^ SC2154 (warning): me is referenced but not assigned.
               ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.
                     ^-----^ SC2154 (warning): peer is referenced but not assigned.
                     ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
    cleanup_ns "${me}" "${peer}"


In arp_ndisc_evict_nocarrier.sh line 40:
    $IP li set veth2 netns ${peer} up
                           ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
    $IP li set veth2 netns "${peer}" up


In arp_ndisc_evict_nocarrier.sh line 41:
    ip -netns ${peer} -6 addr add $V6_ADDR1/64 dev veth2 nodad
              ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
    ip -netns "${peer}" -6 addr add $V6_ADDR1/64 dev veth2 nodad


In arp_ndisc_evict_nocarrier.sh line 43:
    ip netns exec ${me} sysctl -w $1 >/dev/null 2>&1
                  ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                  ^-- SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
    ip netns exec "${me}" sysctl -w "$1" >/dev/null 2>&1


In arp_ndisc_evict_nocarrier.sh line 46:
    ip netns exec ${me} ping -6 -c1 -Iveth1 $V6_ADDR1 >/dev/null 2>&1
                  ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
    ip netns exec "${me}" ping -6 -c1 -Iveth1 $V6_ADDR1 >/dev/null 2>&1


In arp_ndisc_evict_nocarrier.sh line 48:
    ip netns exec ${me} ip -6 neigh get $V6_ADDR1 dev veth1 >/dev/null 2>&1
                  ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
    ip netns exec "${me}" ip -6 neigh get $V6_ADDR1 dev veth1 >/dev/null 2>&1


In arp_ndisc_evict_nocarrier.sh line 49:
    if [ $? -ne 0 ]; then
         ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.


In arp_ndisc_evict_nocarrier.sh line 56:
    ip netns exec ${peer} ip link set veth2 down
                  ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
    ip netns exec "${peer}" ip link set veth2 down


In arp_ndisc_evict_nocarrier.sh line 67:
    ip netns exec ${PEER_NS} ip route add default via $V4_ADDR1 dev veth1
                  ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
    ip netns exec "${PEER_NS}" ip route add default via $V4_ADDR1 dev veth1


In arp_ndisc_evict_nocarrier.sh line 76:
    if [ $? -ne 0 ]; then
         ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.


In arp_ndisc_evict_nocarrier.sh line 89:
    cleanup_ns $PEER_NS
               ^------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
    cleanup_ns "$PEER_NS"


In arp_ndisc_evict_nocarrier.sh line 103:
    if [ $? -eq 0 ];then
         ^-- SC2181 (style): Check exit code directly with e.g. 'if mycmd;', not indirectly with $?.


In arp_ndisc_evict_nocarrier.sh line 121:
    if [ $? -eq 0 ];then
         ^-- SC2181 (style): Check exit code directly with e.g. 'if mycmd;', not indirectly with $?.


In arp_ndisc_evict_nocarrier.sh line 138:
    if [ $? -eq 0 ];then
         ^-- SC2181 (style): Check exit code directly with e.g. 'if mycmd;', not indirectly with $?.


In arp_ndisc_evict_nocarrier.sh line 152:
    ip netns exec ${me} ip -6 neigh get $V6_ADDR1 dev veth1 >/dev/null 2>&1
                  ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
    ip netns exec "${me}" ip -6 neigh get $V6_ADDR1 dev veth1 >/dev/null 2>&1


In arp_ndisc_evict_nocarrier.sh line 154:
    if [ $? -eq 0 ];then
         ^-- SC2181 (style): Check exit code directly with e.g. 'if mycmd;', not indirectly with $?.


In arp_ndisc_evict_nocarrier.sh line 169:
    ip netns exec ${me} ip -6 neigh get $V6_ADDR1 dev veth1 >/dev/null 2>&1
                  ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
    ip netns exec "${me}" ip -6 neigh get $V6_ADDR1 dev veth1 >/dev/null 2>&1


In arp_ndisc_evict_nocarrier.sh line 171:
    if [ $? -eq 0 ];then
         ^-- SC2181 (style): Check exit code directly with e.g. 'if mycmd;', not indirectly with $?.


In arp_ndisc_evict_nocarrier.sh line 186:
    ip netns exec ${me} ip -6 neigh get $V6_ADDR1 dev veth1 >/dev/null 2>&1
                  ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
    ip netns exec "${me}" ip -6 neigh get $V6_ADDR1 dev veth1 >/dev/null 2>&1


In arp_ndisc_evict_nocarrier.sh line 188:
    if [ $? -eq 0 ];then
         ^-- SC2181 (style): Check exit code directly with e.g. 'if mycmd;', not indirectly with $?.

For more information:
  https://www.shellcheck.net/wiki/SC2034 -- nsid appears unused. Verify use (...
  https://www.shellcheck.net/wiki/SC2154 -- me is referenced but not assigned.
  https://www.shellcheck.net/wiki/SC2086 -- Double quote to prevent globbing ...