ShellCheck - shell script analysis tool
version: 0.11.0
license: GNU General Public License, version 3
website: https://www.shellcheck.net
Redirect to /tmp/tmp.Arl9repp5F and /tmp/tmp.a9YjLaKkao
Tree base:
f07f4ea53e22 ("mptcp: Initialise rcv_mss before calling tcp_send_active_reset() in mptcp_do_fastclose().")
Now at:
47d35033e506 ("selftests: bonding: add delay before each xvlan_over_bond connectivity check")
 ====== Checking before the patch ======
Checking tools/testing/selftests/drivers/net/bonding/bond_macvlan_ipvlan.sh - d4d5d2dc5e510ed565c962bcd6b17f1a530e9a7a11894f94603c9416df1302ef


In bond_macvlan_ipvlan.sh line 7:
source ${lib_dir}/bond_topo_2d1c.sh
       ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
source "${lib_dir}"/bond_topo_2d1c.sh


In bond_macvlan_ipvlan.sh line 16:
cleanup()
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In bond_macvlan_ipvlan.sh line 22:
	ip netns del ${xvlan1_ns}
                     ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	ip netns del "${xvlan1_ns}"


In bond_macvlan_ipvlan.sh line 23:
	ip netns del ${xvlan2_ns}
                     ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	ip netns del "${xvlan2_ns}"


In bond_macvlan_ipvlan.sh line 33:
	ip netns exec ${ns} ping ${target} -c 4 -i 0.1 &>/dev/null
                      ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                 ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	ip netns exec "${ns}" ping "${target}" -c 4 -i 0.1 &>/dev/null


In bond_macvlan_ipvlan.sh line 43:
	RET=0
        ^-^ SC2034 (warning): RET appears unused. Verify use (or export if used externally).


In bond_macvlan_ipvlan.sh line 48:
	ip -n ${s_ns} link add link bond0 name ${xvlan_type}0 type ${xvlan_type} mode ${xvlan_mode}
              ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                               ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                                                   ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                                                                      ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	ip -n "${s_ns}" link add link bond0 name "${xvlan_type}"0 type "${xvlan_type}" mode "${xvlan_mode}"


In bond_macvlan_ipvlan.sh line 49:
	ip -n ${s_ns} link set ${xvlan_type}0 netns ${xvlan1_ns}
              ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting.
                               ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                                    ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	ip -n "${s_ns}" link set "${xvlan_type}"0 netns "${xvlan1_ns}"


In bond_macvlan_ipvlan.sh line 50:
	ip -n ${xvlan1_ns} link set dev ${xvlan_type}0 up
              ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                        ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	ip -n "${xvlan1_ns}" link set dev "${xvlan_type}"0 up


In bond_macvlan_ipvlan.sh line 51:
	ip -n ${xvlan1_ns} addr add ${xvlan1_ip4}/24 dev ${xvlan_type}0
              ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                                         ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	ip -n "${xvlan1_ns}" addr add ${xvlan1_ip4}/24 dev "${xvlan_type}"0


In bond_macvlan_ipvlan.sh line 52:
	ip -n ${xvlan1_ns} addr add ${xvlan1_ip6}/24 dev ${xvlan_type}0
              ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                                         ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	ip -n "${xvlan1_ns}" addr add ${xvlan1_ip6}/24 dev "${xvlan_type}"0


In bond_macvlan_ipvlan.sh line 54:
	ip -n ${s_ns} link add link bond0 name ${xvlan_type}0 type ${xvlan_type} mode ${xvlan_mode}
              ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                               ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                                                   ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                                                                      ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	ip -n "${s_ns}" link add link bond0 name "${xvlan_type}"0 type "${xvlan_type}" mode "${xvlan_mode}"


In bond_macvlan_ipvlan.sh line 55:
	ip -n ${s_ns} link set ${xvlan_type}0 netns ${xvlan2_ns}
              ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting.
                               ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                                    ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	ip -n "${s_ns}" link set "${xvlan_type}"0 netns "${xvlan2_ns}"


In bond_macvlan_ipvlan.sh line 56:
	ip -n ${xvlan2_ns} link set dev ${xvlan_type}0 up
              ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                        ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	ip -n "${xvlan2_ns}" link set dev "${xvlan_type}"0 up


In bond_macvlan_ipvlan.sh line 57:
	ip -n ${xvlan2_ns} addr add ${xvlan2_ip4}/24 dev ${xvlan_type}0
              ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                                         ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	ip -n "${xvlan2_ns}" addr add ${xvlan2_ip4}/24 dev "${xvlan_type}"0


In bond_macvlan_ipvlan.sh line 58:
	ip -n ${xvlan2_ns} addr add ${xvlan2_ip6}/24 dev ${xvlan_type}0
              ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                                         ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	ip -n "${xvlan2_ns}" addr add ${xvlan2_ip6}/24 dev "${xvlan_type}"0


In bond_macvlan_ipvlan.sh line 80:
	ip -n ${c_ns} neigh flush dev eth0
              ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	ip -n "${c_ns}" neigh flush dev eth0


In bond_macvlan_ipvlan.sh line 86:
ip netns add ${xvlan1_ns}
             ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
ip netns add "${xvlan1_ns}"


In bond_macvlan_ipvlan.sh line 87:
ip netns add ${xvlan2_ns}
             ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
ip netns add "${xvlan2_ns}"


In bond_macvlan_ipvlan.sh line 96:
exit $EXIT_STATUS
     ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
exit "$EXIT_STATUS"

For more information:
  https://www.shellcheck.net/wiki/SC2034 -- RET appears unused. Verify use (o...
  https://www.shellcheck.net/wiki/SC2086 -- Double quote to prevent globbing ...
  https://www.shellcheck.net/wiki/SC2329 -- This function is never invoked. C...

 ====== Checking the tree with the patch ======
Checking tools/testing/selftests/drivers/net/bonding/bond_macvlan_ipvlan.sh - d4d5d2dc5e510ed565c962bcd6b17f1a530e9a7a11894f94603c9416df1302ef


In bond_macvlan_ipvlan.sh line 7:
source ${lib_dir}/bond_topo_2d1c.sh
       ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
source "${lib_dir}"/bond_topo_2d1c.sh


In bond_macvlan_ipvlan.sh line 16:
cleanup()
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In bond_macvlan_ipvlan.sh line 22:
	ip netns del ${xvlan1_ns}
                     ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	ip netns del "${xvlan1_ns}"


In bond_macvlan_ipvlan.sh line 23:
	ip netns del ${xvlan2_ns}
                     ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	ip netns del "${xvlan2_ns}"


In bond_macvlan_ipvlan.sh line 34:
	ip netns exec ${ns} ping ${target} -c 4 -i 0.1 &>/dev/null
                      ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                 ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	ip netns exec "${ns}" ping "${target}" -c 4 -i 0.1 &>/dev/null


In bond_macvlan_ipvlan.sh line 44:
	RET=0
        ^-^ SC2034 (warning): RET appears unused. Verify use (or export if used externally).


In bond_macvlan_ipvlan.sh line 49:
	ip -n ${s_ns} link add link bond0 name ${xvlan_type}0 type ${xvlan_type} mode ${xvlan_mode}
              ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                               ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                                                   ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                                                                      ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	ip -n "${s_ns}" link add link bond0 name "${xvlan_type}"0 type "${xvlan_type}" mode "${xvlan_mode}"


In bond_macvlan_ipvlan.sh line 50:
	ip -n ${s_ns} link set ${xvlan_type}0 netns ${xvlan1_ns}
              ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting.
                               ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                                    ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	ip -n "${s_ns}" link set "${xvlan_type}"0 netns "${xvlan1_ns}"


In bond_macvlan_ipvlan.sh line 51:
	ip -n ${xvlan1_ns} link set dev ${xvlan_type}0 up
              ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                        ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	ip -n "${xvlan1_ns}" link set dev "${xvlan_type}"0 up


In bond_macvlan_ipvlan.sh line 52:
	ip -n ${xvlan1_ns} addr add ${xvlan1_ip4}/24 dev ${xvlan_type}0
              ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                                         ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	ip -n "${xvlan1_ns}" addr add ${xvlan1_ip4}/24 dev "${xvlan_type}"0


In bond_macvlan_ipvlan.sh line 53:
	ip -n ${xvlan1_ns} addr add ${xvlan1_ip6}/24 dev ${xvlan_type}0
              ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                                         ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	ip -n "${xvlan1_ns}" addr add ${xvlan1_ip6}/24 dev "${xvlan_type}"0


In bond_macvlan_ipvlan.sh line 55:
	ip -n ${s_ns} link add link bond0 name ${xvlan_type}0 type ${xvlan_type} mode ${xvlan_mode}
              ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                               ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                                                   ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                                                                      ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	ip -n "${s_ns}" link add link bond0 name "${xvlan_type}"0 type "${xvlan_type}" mode "${xvlan_mode}"


In bond_macvlan_ipvlan.sh line 56:
	ip -n ${s_ns} link set ${xvlan_type}0 netns ${xvlan2_ns}
              ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting.
                               ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                                    ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	ip -n "${s_ns}" link set "${xvlan_type}"0 netns "${xvlan2_ns}"


In bond_macvlan_ipvlan.sh line 57:
	ip -n ${xvlan2_ns} link set dev ${xvlan_type}0 up
              ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                        ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	ip -n "${xvlan2_ns}" link set dev "${xvlan_type}"0 up


In bond_macvlan_ipvlan.sh line 58:
	ip -n ${xvlan2_ns} addr add ${xvlan2_ip4}/24 dev ${xvlan_type}0
              ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                                         ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	ip -n "${xvlan2_ns}" addr add ${xvlan2_ip4}/24 dev "${xvlan_type}"0


In bond_macvlan_ipvlan.sh line 59:
	ip -n ${xvlan2_ns} addr add ${xvlan2_ip6}/24 dev ${xvlan_type}0
              ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                                         ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	ip -n "${xvlan2_ns}" addr add ${xvlan2_ip6}/24 dev "${xvlan_type}"0


In bond_macvlan_ipvlan.sh line 81:
	ip -n ${c_ns} neigh flush dev eth0
              ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	ip -n "${c_ns}" neigh flush dev eth0


In bond_macvlan_ipvlan.sh line 87:
ip netns add ${xvlan1_ns}
             ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
ip netns add "${xvlan1_ns}"


In bond_macvlan_ipvlan.sh line 88:
ip netns add ${xvlan2_ns}
             ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
ip netns add "${xvlan2_ns}"


In bond_macvlan_ipvlan.sh line 97:
exit $EXIT_STATUS
     ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
exit "$EXIT_STATUS"

For more information:
  https://www.shellcheck.net/wiki/SC2034 -- RET appears unused. Verify use (o...
  https://www.shellcheck.net/wiki/SC2086 -- Double quote to prevent globbing ...
  https://www.shellcheck.net/wiki/SC2329 -- This function is never invoked. C...