ShellCheck - shell script analysis tool version: 0.11.0 license: GNU General Public License, version 3 website: https://www.shellcheck.net Redirect to /tmp/tmp.IEB6a67bkW and /tmp/tmp.IlWRa3RZ8I Tree base: 7b09a3195417 ("ipv6: remove IP6SKB_FAKEJUMBO flag") Now at: 217bf240c820 ("selftests/net: remove unnecessary MTU config in big_tcp.sh") ====== Checking before the patch ====== Checking tools/testing/selftests/net/big_tcp.sh - 87118834283d9199934d01e25013850ef0f84a4a193e6f3978066a00a0bb0629 In big_tcp.sh line 28: ip netns add $CLIENT_NS ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip netns add "$CLIENT_NS" In big_tcp.sh line 29: ip netns add $SERVER_NS ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip netns add "$SERVER_NS" In big_tcp.sh line 30: ip netns add $ROUTER_NS ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip netns add "$ROUTER_NS" In big_tcp.sh line 31: ip -net $ROUTER_NS link add link1 type veth peer name link0 netns $CLIENT_NS ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -net "$ROUTER_NS" link add link1 type veth peer name link0 netns "$CLIENT_NS" In big_tcp.sh line 32: ip -net $ROUTER_NS link add link2 type veth peer name link3 netns $SERVER_NS ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -net "$ROUTER_NS" link add link2 type veth peer name link3 netns "$SERVER_NS" In big_tcp.sh line 34: ip -net $CLIENT_NS link set link0 up ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -net "$CLIENT_NS" link set link0 up In big_tcp.sh line 35: ip -net $CLIENT_NS link set link0 mtu 1442 ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -net "$CLIENT_NS" link set link0 mtu 1442 In big_tcp.sh line 36: ip -net $CLIENT_NS addr add $CLIENT_IP4/24 dev link0 ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -net "$CLIENT_NS" addr add $CLIENT_IP4/24 dev link0 In big_tcp.sh line 37: ip -net $CLIENT_NS addr add $CLIENT_IP6/64 dev link0 nodad ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -net "$CLIENT_NS" addr add $CLIENT_IP6/64 dev link0 nodad In big_tcp.sh line 38: ip -net $CLIENT_NS route add $SERVER_IP4 dev link0 via $CLIENT_GW4 ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -net "$CLIENT_NS" route add $SERVER_IP4 dev link0 via $CLIENT_GW4 In big_tcp.sh line 39: ip -net $CLIENT_NS route add $SERVER_IP6 dev link0 via $CLIENT_GW6 ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -net "$CLIENT_NS" route add $SERVER_IP6 dev link0 via $CLIENT_GW6 In big_tcp.sh line 40: ip -net $CLIENT_NS link set dev link0 \ ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -net "$CLIENT_NS" link set dev link0 \ In big_tcp.sh line 42: ip -net $CLIENT_NS link set dev link0 \ ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -net "$CLIENT_NS" link set dev link0 \ In big_tcp.sh line 44: ip net exec $CLIENT_NS sysctl -wq net.ipv4.tcp_window_scaling=10 ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip net exec "$CLIENT_NS" sysctl -wq net.ipv4.tcp_window_scaling=10 In big_tcp.sh line 46: ip -net $ROUTER_NS link set link1 up ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -net "$ROUTER_NS" link set link1 up In big_tcp.sh line 47: ip -net $ROUTER_NS link set link2 up ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -net "$ROUTER_NS" link set link2 up In big_tcp.sh line 48: ip -net $ROUTER_NS addr add $CLIENT_GW4/24 dev link1 ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -net "$ROUTER_NS" addr add $CLIENT_GW4/24 dev link1 In big_tcp.sh line 49: ip -net $ROUTER_NS addr add $CLIENT_GW6/64 dev link1 nodad ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -net "$ROUTER_NS" addr add $CLIENT_GW6/64 dev link1 nodad In big_tcp.sh line 50: ip -net $ROUTER_NS addr add $SERVER_GW4/24 dev link2 ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -net "$ROUTER_NS" addr add $SERVER_GW4/24 dev link2 In big_tcp.sh line 51: ip -net $ROUTER_NS addr add $SERVER_GW6/64 dev link2 nodad ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -net "$ROUTER_NS" addr add $SERVER_GW6/64 dev link2 nodad In big_tcp.sh line 52: ip -net $ROUTER_NS link set dev link1 \ ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -net "$ROUTER_NS" link set dev link1 \ In big_tcp.sh line 54: ip -net $ROUTER_NS link set dev link2 \ ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -net "$ROUTER_NS" link set dev link2 \ In big_tcp.sh line 56: ip -net $ROUTER_NS link set dev link1 \ ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -net "$ROUTER_NS" link set dev link1 \ In big_tcp.sh line 58: ip -net $ROUTER_NS link set dev link2 \ ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -net "$ROUTER_NS" link set dev link2 \ In big_tcp.sh line 61: ip net exec $ROUTER_NS tc qdisc add dev link1 ingress ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip net exec "$ROUTER_NS" tc qdisc add dev link1 ingress In big_tcp.sh line 62: ip net exec $ROUTER_NS tc filter add dev link1 ingress \ ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip net exec "$ROUTER_NS" tc filter add dev link1 ingress \ In big_tcp.sh line 64: ip net exec $ROUTER_NS tc filter add dev link1 ingress \ ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip net exec "$ROUTER_NS" tc filter add dev link1 ingress \ In big_tcp.sh line 66: ip net exec $ROUTER_NS sysctl -wq net.ipv4.ip_forward=1 ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip net exec "$ROUTER_NS" sysctl -wq net.ipv4.ip_forward=1 In big_tcp.sh line 67: ip net exec $ROUTER_NS sysctl -wq net.ipv6.conf.all.forwarding=1 ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip net exec "$ROUTER_NS" sysctl -wq net.ipv6.conf.all.forwarding=1 In big_tcp.sh line 69: ip -net $SERVER_NS link set link3 up ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -net "$SERVER_NS" link set link3 up In big_tcp.sh line 70: ip -net $SERVER_NS addr add $SERVER_IP4/24 dev link3 ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -net "$SERVER_NS" addr add $SERVER_IP4/24 dev link3 In big_tcp.sh line 71: ip -net $SERVER_NS addr add $SERVER_IP6/64 dev link3 nodad ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -net "$SERVER_NS" addr add $SERVER_IP6/64 dev link3 nodad In big_tcp.sh line 72: ip -net $SERVER_NS route add $CLIENT_IP4 dev link3 via $SERVER_GW4 ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -net "$SERVER_NS" route add $CLIENT_IP4 dev link3 via $SERVER_GW4 In big_tcp.sh line 73: ip -net $SERVER_NS route add $CLIENT_IP6 dev link3 via $SERVER_GW6 ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -net "$SERVER_NS" route add $CLIENT_IP6 dev link3 via $SERVER_GW6 In big_tcp.sh line 74: ip -net $SERVER_NS link set dev link3 \ ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -net "$SERVER_NS" link set dev link3 \ In big_tcp.sh line 76: ip -net $SERVER_NS link set dev link3 \ ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -net "$SERVER_NS" link set dev link3 \ In big_tcp.sh line 78: ip net exec $SERVER_NS sysctl -wq net.ipv4.tcp_window_scaling=10 ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip net exec "$SERVER_NS" sysctl -wq net.ipv4.tcp_window_scaling=10 In big_tcp.sh line 79: ip net exec $SERVER_NS netserver 2>&1 >/dev/null ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2069 (warning): To redirect stdout+stderr, 2>&1 must be last (or use '{ cmd > file; } 2>&1' to clarify). Did you mean: ip net exec "$SERVER_NS" netserver 2>&1 >/dev/null In big_tcp.sh line 82: cleanup() { ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In big_tcp.sh line 83: ip net exec $SERVER_NS pkill netserver ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip net exec "$SERVER_NS" pkill netserver In big_tcp.sh line 84: ip -net $ROUTER_NS link del link1 ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -net "$ROUTER_NS" link del link1 In big_tcp.sh line 85: ip -net $ROUTER_NS link del link2 ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -net "$ROUTER_NS" link del link2 In big_tcp.sh line 97: ip net exec $netns $ipt -t raw -A PREROUTING -i $iface \ ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip net exec "$netns" $ipt -t raw -A PREROUTING -i "$iface" \ In big_tcp.sh line 107: test `ip net exec $netns $ipt -t raw -L -v |grep $iface | awk '{print $1}'` != "0" ^-- SC2046 (warning): Quote this to prevent word splitting. ^-- SC2006 (style): Use $(...) notation instead of legacy backticks `...`. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: test $(ip net exec "$netns" $ipt -t raw -L -v |grep "$iface" | awk '{print $1}') != "0" In big_tcp.sh line 116: ip net exec $netns $ipt -t raw -D PREROUTING -i $iface \ ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip net exec "$netns" $ipt -t raw -D PREROUTING -i "$iface" \ In big_tcp.sh line 127: ip net exec $netns netperf -$NF -t TCP_STREAM -l 1 -H $serip -- -m 262144 2>&1 >/dev/null ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2069 (warning): To redirect stdout+stderr, 2>&1 must be last (or use '{ cmd > file; } 2>&1' to clarify). Did you mean: ip net exec "$netns" netperf -$NF -t TCP_STREAM -l 1 -H $serip -- -m 262144 2>&1 >/dev/null In big_tcp.sh line 137: ip net exec $CLIENT_NS ethtool -K link0 tso $cli_tso ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip net exec "$CLIENT_NS" ethtool -K link0 tso "$cli_tso" In big_tcp.sh line 138: ip net exec $ROUTER_NS ethtool -K link1 gro $gw_gro ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip net exec "$ROUTER_NS" ethtool -K link1 gro "$gw_gro" In big_tcp.sh line 139: ip net exec $ROUTER_NS ethtool -K link2 tso $gw_tso ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip net exec "$ROUTER_NS" ethtool -K link2 tso "$gw_tso" In big_tcp.sh line 140: ip net exec $SERVER_NS ethtool -K link3 gro $ser_gro ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip net exec "$SERVER_NS" ethtool -K link3 gro "$ser_gro" In big_tcp.sh line 142: start_counter link1 $ROUTER_NS ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: start_counter link1 "$ROUTER_NS" In big_tcp.sh line 143: start_counter link3 $SERVER_NS ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: start_counter link3 "$SERVER_NS" In big_tcp.sh line 144: do_netperf $CLIENT_NS ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: do_netperf "$CLIENT_NS" In big_tcp.sh line 146: if check_counter link1 $ROUTER_NS; then ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if check_counter link1 "$ROUTER_NS"; then In big_tcp.sh line 147: check_counter link3 $SERVER_NS || ret="FAIL_on_link3" ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: check_counter link3 "$SERVER_NS" || ret="FAIL_on_link3" In big_tcp.sh line 152: stop_counter link1 $ROUTER_NS ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: stop_counter link1 "$ROUTER_NS" In big_tcp.sh line 153: stop_counter link3 $SERVER_NS ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: stop_counter link3 "$SERVER_NS" In big_tcp.sh line 155: $cli_tso $gw_gro $gw_tso $ser_gro $ret ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: "$cli_tso" "$gw_gro" "$gw_tso" "$ser_gro" $ret For more information: https://www.shellcheck.net/wiki/SC2046 -- Quote this to prevent word splitt... https://www.shellcheck.net/wiki/SC2069 -- To redirect stdout+stderr, 2>&1 m... https://www.shellcheck.net/wiki/SC2086 -- Double quote to prevent globbing ... ====== Checking the tree with the patch ====== Checking tools/testing/selftests/net/big_tcp.sh - 87118834283d9199934d01e25013850ef0f84a4a193e6f3978066a00a0bb0629 In big_tcp.sh line 28: ip netns add $CLIENT_NS ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip netns add "$CLIENT_NS" In big_tcp.sh line 29: ip netns add $SERVER_NS ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip netns add "$SERVER_NS" In big_tcp.sh line 30: ip netns add $ROUTER_NS ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip netns add "$ROUTER_NS" In big_tcp.sh line 31: ip -net $ROUTER_NS link add link1 type veth peer name link0 netns $CLIENT_NS ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -net "$ROUTER_NS" link add link1 type veth peer name link0 netns "$CLIENT_NS" In big_tcp.sh line 32: ip -net $ROUTER_NS link add link2 type veth peer name link3 netns $SERVER_NS ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -net "$ROUTER_NS" link add link2 type veth peer name link3 netns "$SERVER_NS" In big_tcp.sh line 34: ip -net $CLIENT_NS link set link0 up ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -net "$CLIENT_NS" link set link0 up In big_tcp.sh line 35: ip -net $CLIENT_NS addr add $CLIENT_IP4/24 dev link0 ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -net "$CLIENT_NS" addr add $CLIENT_IP4/24 dev link0 In big_tcp.sh line 36: ip -net $CLIENT_NS addr add $CLIENT_IP6/64 dev link0 nodad ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -net "$CLIENT_NS" addr add $CLIENT_IP6/64 dev link0 nodad In big_tcp.sh line 37: ip -net $CLIENT_NS route add $SERVER_IP4 dev link0 via $CLIENT_GW4 ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -net "$CLIENT_NS" route add $SERVER_IP4 dev link0 via $CLIENT_GW4 In big_tcp.sh line 38: ip -net $CLIENT_NS route add $SERVER_IP6 dev link0 via $CLIENT_GW6 ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -net "$CLIENT_NS" route add $SERVER_IP6 dev link0 via $CLIENT_GW6 In big_tcp.sh line 39: ip -net $CLIENT_NS link set dev link0 \ ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -net "$CLIENT_NS" link set dev link0 \ In big_tcp.sh line 41: ip -net $CLIENT_NS link set dev link0 \ ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -net "$CLIENT_NS" link set dev link0 \ In big_tcp.sh line 43: ip net exec $CLIENT_NS sysctl -wq net.ipv4.tcp_window_scaling=10 ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip net exec "$CLIENT_NS" sysctl -wq net.ipv4.tcp_window_scaling=10 In big_tcp.sh line 45: ip -net $ROUTER_NS link set link1 up ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -net "$ROUTER_NS" link set link1 up In big_tcp.sh line 46: ip -net $ROUTER_NS link set link2 up ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -net "$ROUTER_NS" link set link2 up In big_tcp.sh line 47: ip -net $ROUTER_NS addr add $CLIENT_GW4/24 dev link1 ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -net "$ROUTER_NS" addr add $CLIENT_GW4/24 dev link1 In big_tcp.sh line 48: ip -net $ROUTER_NS addr add $CLIENT_GW6/64 dev link1 nodad ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -net "$ROUTER_NS" addr add $CLIENT_GW6/64 dev link1 nodad In big_tcp.sh line 49: ip -net $ROUTER_NS addr add $SERVER_GW4/24 dev link2 ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -net "$ROUTER_NS" addr add $SERVER_GW4/24 dev link2 In big_tcp.sh line 50: ip -net $ROUTER_NS addr add $SERVER_GW6/64 dev link2 nodad ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -net "$ROUTER_NS" addr add $SERVER_GW6/64 dev link2 nodad In big_tcp.sh line 51: ip -net $ROUTER_NS link set dev link1 \ ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -net "$ROUTER_NS" link set dev link1 \ In big_tcp.sh line 53: ip -net $ROUTER_NS link set dev link2 \ ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -net "$ROUTER_NS" link set dev link2 \ In big_tcp.sh line 55: ip -net $ROUTER_NS link set dev link1 \ ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -net "$ROUTER_NS" link set dev link1 \ In big_tcp.sh line 57: ip -net $ROUTER_NS link set dev link2 \ ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -net "$ROUTER_NS" link set dev link2 \ In big_tcp.sh line 60: ip net exec $ROUTER_NS tc qdisc add dev link1 ingress ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip net exec "$ROUTER_NS" tc qdisc add dev link1 ingress In big_tcp.sh line 61: ip net exec $ROUTER_NS tc filter add dev link1 ingress \ ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip net exec "$ROUTER_NS" tc filter add dev link1 ingress \ In big_tcp.sh line 63: ip net exec $ROUTER_NS tc filter add dev link1 ingress \ ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip net exec "$ROUTER_NS" tc filter add dev link1 ingress \ In big_tcp.sh line 65: ip net exec $ROUTER_NS sysctl -wq net.ipv4.ip_forward=1 ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip net exec "$ROUTER_NS" sysctl -wq net.ipv4.ip_forward=1 In big_tcp.sh line 66: ip net exec $ROUTER_NS sysctl -wq net.ipv6.conf.all.forwarding=1 ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip net exec "$ROUTER_NS" sysctl -wq net.ipv6.conf.all.forwarding=1 In big_tcp.sh line 68: ip -net $SERVER_NS link set link3 up ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -net "$SERVER_NS" link set link3 up In big_tcp.sh line 69: ip -net $SERVER_NS addr add $SERVER_IP4/24 dev link3 ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -net "$SERVER_NS" addr add $SERVER_IP4/24 dev link3 In big_tcp.sh line 70: ip -net $SERVER_NS addr add $SERVER_IP6/64 dev link3 nodad ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -net "$SERVER_NS" addr add $SERVER_IP6/64 dev link3 nodad In big_tcp.sh line 71: ip -net $SERVER_NS route add $CLIENT_IP4 dev link3 via $SERVER_GW4 ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -net "$SERVER_NS" route add $CLIENT_IP4 dev link3 via $SERVER_GW4 In big_tcp.sh line 72: ip -net $SERVER_NS route add $CLIENT_IP6 dev link3 via $SERVER_GW6 ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -net "$SERVER_NS" route add $CLIENT_IP6 dev link3 via $SERVER_GW6 In big_tcp.sh line 73: ip -net $SERVER_NS link set dev link3 \ ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -net "$SERVER_NS" link set dev link3 \ In big_tcp.sh line 75: ip -net $SERVER_NS link set dev link3 \ ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -net "$SERVER_NS" link set dev link3 \ In big_tcp.sh line 77: ip net exec $SERVER_NS sysctl -wq net.ipv4.tcp_window_scaling=10 ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip net exec "$SERVER_NS" sysctl -wq net.ipv4.tcp_window_scaling=10 In big_tcp.sh line 78: ip net exec $SERVER_NS netserver 2>&1 >/dev/null ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2069 (warning): To redirect stdout+stderr, 2>&1 must be last (or use '{ cmd > file; } 2>&1' to clarify). Did you mean: ip net exec "$SERVER_NS" netserver 2>&1 >/dev/null In big_tcp.sh line 81: cleanup() { ^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). In big_tcp.sh line 82: ip net exec $SERVER_NS pkill netserver ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip net exec "$SERVER_NS" pkill netserver In big_tcp.sh line 83: ip -net $ROUTER_NS link del link1 ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -net "$ROUTER_NS" link del link1 In big_tcp.sh line 84: ip -net $ROUTER_NS link del link2 ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -net "$ROUTER_NS" link del link2 In big_tcp.sh line 96: ip net exec $netns $ipt -t raw -A PREROUTING -i $iface \ ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip net exec "$netns" $ipt -t raw -A PREROUTING -i "$iface" \ In big_tcp.sh line 106: test `ip net exec $netns $ipt -t raw -L -v |grep $iface | awk '{print $1}'` != "0" ^-- SC2046 (warning): Quote this to prevent word splitting. ^-- SC2006 (style): Use $(...) notation instead of legacy backticks `...`. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: test $(ip net exec "$netns" $ipt -t raw -L -v |grep "$iface" | awk '{print $1}') != "0" In big_tcp.sh line 115: ip net exec $netns $ipt -t raw -D PREROUTING -i $iface \ ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip net exec "$netns" $ipt -t raw -D PREROUTING -i "$iface" \ In big_tcp.sh line 126: ip net exec $netns netperf -$NF -t TCP_STREAM -l 1 -H $serip -- -m 262144 2>&1 >/dev/null ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2069 (warning): To redirect stdout+stderr, 2>&1 must be last (or use '{ cmd > file; } 2>&1' to clarify). Did you mean: ip net exec "$netns" netperf -$NF -t TCP_STREAM -l 1 -H $serip -- -m 262144 2>&1 >/dev/null In big_tcp.sh line 136: ip net exec $CLIENT_NS ethtool -K link0 tso $cli_tso ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip net exec "$CLIENT_NS" ethtool -K link0 tso "$cli_tso" In big_tcp.sh line 137: ip net exec $ROUTER_NS ethtool -K link1 gro $gw_gro ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip net exec "$ROUTER_NS" ethtool -K link1 gro "$gw_gro" In big_tcp.sh line 138: ip net exec $ROUTER_NS ethtool -K link2 tso $gw_tso ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip net exec "$ROUTER_NS" ethtool -K link2 tso "$gw_tso" In big_tcp.sh line 139: ip net exec $SERVER_NS ethtool -K link3 gro $ser_gro ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip net exec "$SERVER_NS" ethtool -K link3 gro "$ser_gro" In big_tcp.sh line 141: start_counter link1 $ROUTER_NS ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: start_counter link1 "$ROUTER_NS" In big_tcp.sh line 142: start_counter link3 $SERVER_NS ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: start_counter link3 "$SERVER_NS" In big_tcp.sh line 143: do_netperf $CLIENT_NS ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: do_netperf "$CLIENT_NS" In big_tcp.sh line 145: if check_counter link1 $ROUTER_NS; then ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if check_counter link1 "$ROUTER_NS"; then In big_tcp.sh line 146: check_counter link3 $SERVER_NS || ret="FAIL_on_link3" ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: check_counter link3 "$SERVER_NS" || ret="FAIL_on_link3" In big_tcp.sh line 151: stop_counter link1 $ROUTER_NS ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: stop_counter link1 "$ROUTER_NS" In big_tcp.sh line 152: stop_counter link3 $SERVER_NS ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: stop_counter link3 "$SERVER_NS" In big_tcp.sh line 154: $cli_tso $gw_gro $gw_tso $ser_gro $ret ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: "$cli_tso" "$gw_gro" "$gw_tso" "$ser_gro" $ret For more information: https://www.shellcheck.net/wiki/SC2046 -- Quote this to prevent word splitt... https://www.shellcheck.net/wiki/SC2069 -- To redirect stdout+stderr, 2>&1 m... https://www.shellcheck.net/wiki/SC2086 -- Double quote to prevent globbing ...