ShellCheck - shell script analysis tool
version: 0.11.0
license: GNU General Public License, version 3
website: https://www.shellcheck.net
Redirect to /tmp/tmp.GzVpBwayy9 and /tmp/tmp.3JGm2sJghe
Tree base:
d097af0fd5c3 ("selftests/vsock: add tests for host <-> vm connectivity with namespaces")
Now at:
0262dfe32ea1 ("selftests/vsock: add tests for namespace deletion and mode changes")
 ====== Checking before the patch ======
Checking tools/testing/selftests/vsock/vmtest.sh - 3bbe24ed85577bc751e7e913126d8b44bb8554cc21519ace46c3118b1749f848


In vmtest.sh line 14:
readonly SCRIPT_DIR="$(cd -P -- "$(dirname -- "${BASH_SOURCE[0]}")" && pwd -P)"
         ^--------^ SC2155 (warning): Declare and assign separately to avoid masking return values.


In vmtest.sh line 15:
readonly KERNEL_CHECKOUT=$(realpath "${SCRIPT_DIR}"/../../../../)
         ^-------------^ SC2155 (warning): Declare and assign separately to avoid masking return values.


In vmtest.sh line 44:
readonly LOG=$(mktemp /tmp/vsock_vmtest_XXXX.log)
         ^-^ SC2155 (warning): Declare and assign separately to avoid masking return values.


In vmtest.sh line 213:
init_namespaces() {
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In vmtest.sh line 236:
ns_set_mode() {
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In vmtest.sh line 260:
cleanup() {
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In vmtest.sh line 367:
	pushd "${KERNEL_CHECKOUT}" &>/dev/null
        ^-- SC2164 (warning): Use 'pushd ... || exit' or 'pushd ... || return' in case pushd fails.

Did you mean:
	pushd "${KERNEL_CHECKOUT}" &>/dev/null || exit


In vmtest.sh line 373:
	if ! make -j$(nproc); then
                    ^------^ SC2046 (warning): Quote this to prevent word splitting.


In vmtest.sh line 377:
	popd &>/dev/null
        ^--------------^ SC2164 (warning): Use 'popd ... || exit' or 'popd ... || return' in case popd fails.

Did you mean:
	popd &>/dev/null || exit


In vmtest.sh line 405:
terminate_pids() {
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In vmtest.sh line 447:
		${kernel_opt} \
                ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
		"${kernel_opt}" \


In vmtest.sh line 478:
wait_for_listener()
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In vmtest.sh line 513:
vm_wait_for_listener() {
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In vmtest.sh line 524:
host_wait_for_listener() {
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In vmtest.sh line 551:
vm_dmesg_check() {
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In vmtest.sh line 573:
vm_vsock_test() {
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In vmtest.sh line 600:
			return $rc
                               ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
			return "$rc"


In vmtest.sh line 608:
	return $rc
               ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	return "$rc"


In vmtest.sh line 611:
host_vsock_test() {
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In vmtest.sh line 641:
			return $rc
                               ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
			return "$rc"


In vmtest.sh line 649:
	return $rc
               ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	return "$rc"


In vmtest.sh line 683:
log_guest() {
^-- SC2120 (warning): log_guest references arguments, but none are ever passed.
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In vmtest.sh line 687:
test_ns_host_vsock_ns_mode_ok() {
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In vmtest.sh line 697:
test_ns_diff_global_host_connect_to_global_vm_ok() {
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In vmtest.sh line 750:
test_ns_diff_global_host_connect_to_local_vm_fails() {
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In vmtest.sh line 793:
test_ns_diff_global_vm_connect_to_global_host_ok() {
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In vmtest.sh line 856:
test_ns_diff_global_vm_connect_to_local_host_fails() {
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In vmtest.sh line 907:
test_ns_diff_local_host_connect_to_local_vm_fails() {
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In vmtest.sh line 952:
test_ns_diff_local_vm_connect_to_local_host_fails() {
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In vmtest.sh line 1000:
__test_loopback_two_netns() {
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In vmtest.sh line 1030:
test_ns_diff_global_to_local_loopback_local_fails() {
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In vmtest.sh line 1040:
test_ns_diff_local_to_global_loopback_fails() {
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In vmtest.sh line 1050:
test_ns_diff_local_to_local_loopback_fails() {
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In vmtest.sh line 1060:
test_ns_diff_global_to_global_loopback_ok() {
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In vmtest.sh line 1070:
test_ns_same_local_loopback_ok() {
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In vmtest.sh line 1080:
test_ns_same_local_host_connect_to_local_vm_ok() {
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In vmtest.sh line 1116:
test_ns_same_local_vm_connect_to_local_host_ok() {
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In vmtest.sh line 1152:
namespaces_can_boot_same_cid() {
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In vmtest.sh line 1174:
test_ns_global_same_cid_fails() {
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In vmtest.sh line 1184:
test_ns_local_global_same_cid_ok() {
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In vmtest.sh line 1194:
test_ns_global_local_same_cid_ok() {
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In vmtest.sh line 1204:
test_ns_local_same_cid_ok() {
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In vmtest.sh line 1214:
test_ns_host_vsock_ns_mode_write_once_ok() {
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In vmtest.sh line 1230:
test_vm_server_host_client() {
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In vmtest.sh line 1242:
test_vm_client_host_server() {
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In vmtest.sh line 1254:
test_vm_loopback() {
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In vmtest.sh line 1271:
test_ns_vm_local_mode_rejected() {
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In vmtest.sh line 1354:
	host_oops_cnt_after=$(dmesg | grep -i 'Oops' | wc -l)
                                      ^------------^ SC2126 (style): Consider using 'grep -c' instead of 'grep|wc -l'.

For more information:
  https://www.shellcheck.net/wiki/SC2046 -- Quote this to prevent word splitt...
  https://www.shellcheck.net/wiki/SC2120 -- log_guest references arguments, b...
  https://www.shellcheck.net/wiki/SC2155 -- Declare and assign separately to ...

 ====== Checking the tree with the patch ======
Checking tools/testing/selftests/vsock/vmtest.sh - 3bbe24ed85577bc751e7e913126d8b44bb8554cc21519ace46c3118b1749f848


In vmtest.sh line 14:
readonly SCRIPT_DIR="$(cd -P -- "$(dirname -- "${BASH_SOURCE[0]}")" && pwd -P)"
         ^--------^ SC2155 (warning): Declare and assign separately to avoid masking return values.


In vmtest.sh line 15:
readonly KERNEL_CHECKOUT=$(realpath "${SCRIPT_DIR}"/../../../../)
         ^-------------^ SC2155 (warning): Declare and assign separately to avoid masking return values.


In vmtest.sh line 44:
readonly LOG=$(mktemp /tmp/vsock_vmtest_XXXX.log)
         ^-^ SC2155 (warning): Declare and assign separately to avoid masking return values.


In vmtest.sh line 237:
init_namespaces() {
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In vmtest.sh line 260:
ns_set_mode() {
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In vmtest.sh line 284:
cleanup() {
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In vmtest.sh line 391:
	pushd "${KERNEL_CHECKOUT}" &>/dev/null
        ^-- SC2164 (warning): Use 'pushd ... || exit' or 'pushd ... || return' in case pushd fails.

Did you mean:
	pushd "${KERNEL_CHECKOUT}" &>/dev/null || exit


In vmtest.sh line 397:
	if ! make -j$(nproc); then
                    ^------^ SC2046 (warning): Quote this to prevent word splitting.


In vmtest.sh line 401:
	popd &>/dev/null
        ^--------------^ SC2164 (warning): Use 'popd ... || exit' or 'popd ... || return' in case popd fails.

Did you mean:
	popd &>/dev/null || exit


In vmtest.sh line 429:
terminate_pids() {
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In vmtest.sh line 471:
		${kernel_opt} \
                ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
		"${kernel_opt}" \


In vmtest.sh line 502:
wait_for_listener()
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In vmtest.sh line 537:
vm_wait_for_listener() {
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In vmtest.sh line 548:
host_wait_for_listener() {
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In vmtest.sh line 575:
vm_dmesg_check() {
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In vmtest.sh line 597:
vm_vsock_test() {
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In vmtest.sh line 624:
			return $rc
                               ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
			return "$rc"


In vmtest.sh line 632:
	return $rc
               ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	return "$rc"


In vmtest.sh line 635:
host_vsock_test() {
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In vmtest.sh line 665:
			return $rc
                               ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
			return "$rc"


In vmtest.sh line 673:
	return $rc
               ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	return "$rc"


In vmtest.sh line 707:
log_guest() {
^-- SC2120 (warning): log_guest references arguments, but none are ever passed.
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In vmtest.sh line 711:
test_ns_host_vsock_ns_mode_ok() {
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In vmtest.sh line 721:
test_ns_diff_global_host_connect_to_global_vm_ok() {
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In vmtest.sh line 774:
test_ns_diff_global_host_connect_to_local_vm_fails() {
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In vmtest.sh line 817:
test_ns_diff_global_vm_connect_to_global_host_ok() {
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In vmtest.sh line 880:
test_ns_diff_global_vm_connect_to_local_host_fails() {
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In vmtest.sh line 931:
test_ns_diff_local_host_connect_to_local_vm_fails() {
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In vmtest.sh line 976:
test_ns_diff_local_vm_connect_to_local_host_fails() {
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In vmtest.sh line 1024:
__test_loopback_two_netns() {
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In vmtest.sh line 1054:
test_ns_diff_global_to_local_loopback_local_fails() {
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In vmtest.sh line 1064:
test_ns_diff_local_to_global_loopback_fails() {
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In vmtest.sh line 1074:
test_ns_diff_local_to_local_loopback_fails() {
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In vmtest.sh line 1084:
test_ns_diff_global_to_global_loopback_ok() {
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In vmtest.sh line 1094:
test_ns_same_local_loopback_ok() {
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In vmtest.sh line 1104:
test_ns_same_local_host_connect_to_local_vm_ok() {
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In vmtest.sh line 1140:
test_ns_same_local_vm_connect_to_local_host_ok() {
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In vmtest.sh line 1176:
namespaces_can_boot_same_cid() {
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In vmtest.sh line 1198:
test_ns_global_same_cid_fails() {
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In vmtest.sh line 1208:
test_ns_local_global_same_cid_ok() {
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In vmtest.sh line 1218:
test_ns_global_local_same_cid_ok() {
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In vmtest.sh line 1228:
test_ns_local_same_cid_ok() {
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In vmtest.sh line 1238:
test_ns_host_vsock_ns_mode_write_once_ok() {
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In vmtest.sh line 1254:
test_vm_server_host_client() {
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In vmtest.sh line 1266:
test_vm_client_host_server() {
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In vmtest.sh line 1278:
test_vm_loopback() {
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In vmtest.sh line 1295:
test_ns_vm_local_mode_rejected() {
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In vmtest.sh line 1315:
check_ns_changes_dont_break_connection() {
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In vmtest.sh line 1386:
test_ns_mode_change_connection_continue_vm_ok() {
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In vmtest.sh line 1390:
test_ns_mode_change_connection_continue_host_ok() {
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In vmtest.sh line 1394:
test_ns_mode_change_connection_continue_both_ok() {
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In vmtest.sh line 1398:
test_ns_delete_vm_ok() {
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In vmtest.sh line 1402:
test_ns_delete_host_ok() {
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In vmtest.sh line 1406:
test_ns_delete_both_ok() {
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In vmtest.sh line 1473:
	host_oops_cnt_after=$(dmesg | grep -i 'Oops' | wc -l)
                                      ^------------^ SC2126 (style): Consider using 'grep -c' instead of 'grep|wc -l'.

For more information:
  https://www.shellcheck.net/wiki/SC2046 -- Quote this to prevent word splitt...
  https://www.shellcheck.net/wiki/SC2120 -- log_guest references arguments, b...
  https://www.shellcheck.net/wiki/SC2155 -- Declare and assign separately to ...