====== Checking before the patch ======
 ====== Checking the tree with the patch ======
tools/testing/selftests/net/ipvtap_macnat_test.sh is a new file, but not shellcheck compliant
New errors added
--- /tmp/tmp.ng022KtS4t	2025-11-18 08:12:20.547128704 -0500
+++ /tmp/tmp.h6H3HTELUb	2025-11-18 08:12:20.770127000 -0500
@@ -0,0 +1,306 @@
+
+In ipvtap_macnat_test.sh line 74:
+	ns_run $ns ip link set lo up
+               ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.
+
+Did you mean:
+	ns_run "$ns" ip link set lo up
+
+
+In ipvtap_macnat_test.sh line 76:
+	if ! ip link add netns $ns name ipvtap0.$n link $VETH_HOST \
+                               ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.
+                                                ^-- SC2086 (info): Double quote to prevent globbing and word splitting.
+
+Did you mean:
+	if ! ip link add netns "$ns" name ipvtap0."$n" link $VETH_HOST \
+
+
+In ipvtap_macnat_test.sh line 80:
+	ns_run $ns ip link set ipvtap0.$n up
+               ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.
+                                       ^-- SC2086 (info): Double quote to prevent globbing and word splitting.
+
+Did you mean:
+	ns_run "$ns" ip link set ipvtap0."$n" up
+
+
+In ipvtap_macnat_test.sh line 82:
+	ns_run $ns ip tuntap add mode tap tap0.$n
+               ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.
+                                               ^-- SC2086 (info): Double quote to prevent globbing and word splitting.
+
+Did you mean:
+	ns_run "$ns" ip tuntap add mode tap tap0."$n"
+
+
+In ipvtap_macnat_test.sh line 83:
+	ns_run $ns ip link set dev tap0.$n address $mac
+               ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.
+                                        ^-- SC2086 (info): Double quote to prevent globbing and word splitting.
+                                                   ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.
+
+Did you mean:
+	ns_run "$ns" ip link set dev tap0."$n" address "$mac"
+
+
+In ipvtap_macnat_test.sh line 85:
+	ns_run $ns sysctl -w net/ipv6/conf/tap0.$n/accept_dad=0
+               ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.
+                                                ^-- SC2086 (info): Double quote to prevent globbing and word splitting.
+
+Did you mean:
+	ns_run "$ns" sysctl -w net/ipv6/conf/tap0."$n"/accept_dad=0
+
+
+In ipvtap_macnat_test.sh line 86:
+	ns_run $ns ip link set tap0.$n up
+               ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.
+                                    ^-- SC2086 (info): Double quote to prevent globbing and word splitting.
+
+Did you mean:
+	ns_run "$ns" ip link set tap0."$n" up
+
+
+In ipvtap_macnat_test.sh line 87:
+	ns_run $ns ip a a $ip/24 dev tap0.$n
+               ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.
+                          ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.
+                                          ^-- SC2086 (info): Double quote to prevent globbing and word splitting.
+
+Did you mean:
+	ns_run "$ns" ip a a "$ip"/24 dev tap0."$n"
+
+
+In ipvtap_macnat_test.sh line 88:
+	ns_run $ns ip a a $ip6/64 dev tap0.$n
+               ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.
+                          ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.
+                                           ^-- SC2086 (info): Double quote to prevent globbing and word splitting.
+
+Did you mean:
+	ns_run "$ns" ip a a "$ip6"/64 dev tap0."$n"
+
+
+In ipvtap_macnat_test.sh line 94:
+	ip netns exec $ns python3 ipvtap_macnat_bridge.py tap0.$n ipvtap0.$n &
+                      ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.
+                                                               ^-- SC2086 (info): Double quote to prevent globbing and word splitting.
+                                                                          ^-- SC2086 (info): Double quote to prevent globbing and word splitting.
+
+Did you mean:
+	ip netns exec "$ns" python3 ipvtap_macnat_bridge.py tap0."$n" ipvtap0."$n" &
+
+
+In ipvtap_macnat_test.sh line 104:
+	ns_run $ns ip link set lo up
+               ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.
+
+Did you mean:
+	ns_run "$ns" ip link set lo up
+
+
+In ipvtap_macnat_test.sh line 105:
+	ns_run $ns ethtool -K $veth tx off rx off
+               ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.
+                              ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.
+
+Did you mean:
+	ns_run "$ns" ethtool -K "$veth" tx off rx off
+
+
+In ipvtap_macnat_test.sh line 106:
+	ns_run $ns ip link set dev $veth address $mac
+               ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.
+                                   ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.
+                                                 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.
+
+Did you mean:
+	ns_run "$ns" ip link set dev "$veth" address "$mac"
+
+
+In ipvtap_macnat_test.sh line 107:
+	ns_run $ns ip link set $veth up
+               ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.
+                               ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.
+
+Did you mean:
+	ns_run "$ns" ip link set "$veth" up
+
+
+In ipvtap_macnat_test.sh line 108:
+	ns_run $ns ip a a $ip/24 dev $veth
+               ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.
+                          ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.
+                                     ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.
+
+Did you mean:
+	ns_run "$ns" ip a a "$ip"/24 dev "$veth"
+
+
+In ipvtap_macnat_test.sh line 109:
+	ns_run $ns ip a a $ip6/64 dev $veth
+               ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.
+                          ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.
+                                      ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.
+
+Did you mean:
+	ns_run "$ns" ip a a "$ip6"/64 dev "$veth"
+
+
+In ipvtap_macnat_test.sh line 134:
+	ns_run $ns ping -c 1 $IP_TST0
+               ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.
+
+Did you mean:
+	ns_run "$ns" ping -c 1 $IP_TST0
+
+
+In ipvtap_macnat_test.sh line 135:
+	ns_run $ns ping -c 1 $IP6_TST0
+               ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.
+
+Did you mean:
+	ns_run "$ns" ping -c 1 $IP6_TST0
+
+
+In ipvtap_macnat_test.sh line 137:
+	ns_run $ns ping -c 1 $IP_TST1
+               ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.
+
+Did you mean:
+	ns_run "$ns" ping -c 1 $IP_TST1
+
+
+In ipvtap_macnat_test.sh line 138:
+	ns_run $ns ping -c 1 $IP6_TST1
+               ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.
+
+Did you mean:
+	ns_run "$ns" ping -c 1 $IP6_TST1
+
+
+In ipvtap_macnat_test.sh line 140:
+	ns_run $ns ping -c 1 $IP_HOST
+               ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.
+
+Did you mean:
+	ns_run "$ns" ping -c 1 $IP_HOST
+
+
+In ipvtap_macnat_test.sh line 141:
+	ns_run $ns ping -c 1 $IP6_HOST
+               ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.
+
+Did you mean:
+	ns_run "$ns" ping -c 1 $IP6_HOST
+
+
+In ipvtap_macnat_test.sh line 143:
+	ns_run $ns ping -c 1 $IP_PHY
+               ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.
+
+Did you mean:
+	ns_run "$ns" ping -c 1 $IP_PHY
+
+
+In ipvtap_macnat_test.sh line 144:
+	ns_run $ns ping -c 1 $IP6_PHY
+               ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.
+
+Did you mean:
+	ns_run "$ns" ping -c 1 $IP6_PHY
+
+
+In ipvtap_macnat_test.sh line 156:
+			ip neigh show $ip dev $dev \
+                                      ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.
+                                              ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.
+
+Did you mean:
+			ip neigh show "$ip" dev "$dev" \
+
+
+In ipvtap_macnat_test.sh line 162:
+			ip netns exec $ns \
+                                      ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.
+
+Did you mean:
+			ip netns exec "$ns" \
+
+
+In ipvtap_macnat_test.sh line 163:
+			ip neigh show $ip dev $dev \
+                                      ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.
+                                              ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.
+
+Did you mean:
+			ip neigh show "$ip" dev "$dev" \
+
+
+In ipvtap_macnat_test.sh line 169:
+	if [[ 'X'$out'X' == "XX" ]]; then
+              ^--------^ SC2268 (style): Avoid x-prefix in comparisons as it no longer serves a purpose.
+
+Did you mean:
+	if [[ ''$out'X' == "X" ]]; then
+
+
+In ipvtap_macnat_test.sh line 182:
+	echo $1
+             ^-- SC2086 (info): Double quote to prevent globbing and word splitting.
+
+Did you mean:
+	echo "$1"
+
+
+In ipvtap_macnat_test.sh line 231:
+		ns_run $NS_TST0 ip a a $ip/24 dev tap0.0
+                                       ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.
+
+Did you mean:
+		ns_run $NS_TST0 ip a a "$ip"/24 dev tap0.0
+
+
+In ipvtap_macnat_test.sh line 232:
+		ns_run $NS_TST0 ping -c 1 $IP_HOST -I $ip
+                                                      ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.
+
+Did you mean:
+		ns_run $NS_TST0 ping -c 1 $IP_HOST -I "$ip"
+
+
+In ipvtap_macnat_test.sh line 266:
+		ns_run $NS_TST0 ip a a $ip6/64 dev tap0.0
+                                       ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.
+
+Did you mean:
+		ns_run $NS_TST0 ip a a "$ip6"/64 dev tap0.0
+
+
+In ipvtap_macnat_test.sh line 267:
+		ns_run $NS_TST0 ping -c 1 $IP6_HOST -I $ip6
+                                                       ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.
+
+Did you mean:
+		ns_run $NS_TST0 ping -c 1 $IP6_HOST -I "$ip6"
+
+
+In ipvtap_macnat_test.sh line 293:
+	echo "TEST: "$2
+                     ^-- SC2086 (info): Double quote to prevent globbing and word splitting.
+
+Did you mean:
+	echo "TEST: ""$2"
+
+
+In ipvtap_macnat_test.sh line 295:
+	echo "PASSED: "$2
+                       ^-- SC2086 (info): Double quote to prevent globbing and word splitting.
+
+Did you mean:
+	echo "PASSED: ""$2"
+
+For more information:
+  https://www.shellcheck.net/wiki/SC2086 -- Double quote to prevent globbing ...
+  https://www.shellcheck.net/wiki/SC2268 -- Avoid x-prefix in comparisons as ...