ShellCheck - shell script analysis tool
version: 0.11.0
license: GNU General Public License, version 3
website: https://www.shellcheck.net
Redirect to /tmp/tmp.1gw43t75Gp and /tmp/tmp.EMZdWn82O2
Tree base:
26fb5c2e9cc5 ("selftests/vsock: add namespace tests for CID collisions")
Now at:
1e64dd15d480 ("selftests/vsock: add tests for host <-> vm connectivity with namespaces")
 ====== Checking before the patch ======
Checking tools/testing/selftests/vsock/vmtest.sh - 3bbe24ed85577bc751e7e913126d8b44bb8554cc21519ace46c3118b1749f848


In vmtest.sh line 13:
readonly SCRIPT_DIR="$(cd -P -- "$(dirname -- "${BASH_SOURCE[0]}")" && pwd -P)"
         ^--------^ SC2155 (warning): Declare and assign separately to avoid masking return values.


In vmtest.sh line 14:
readonly KERNEL_CHECKOUT=$(realpath "${SCRIPT_DIR}"/../../../../)
         ^-------------^ SC2155 (warning): Declare and assign separately to avoid masking return values.


In vmtest.sh line 43:
readonly LOG=$(mktemp /tmp/vsock_vmtest_XXXX.log)
         ^-^ SC2155 (warning): Declare and assign separately to avoid masking return values.


In vmtest.sh line 156:
init_namespaces() {
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In vmtest.sh line 179:
ns_set_mode() {
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In vmtest.sh line 203:
cleanup() {
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In vmtest.sh line 296:
	pushd "${KERNEL_CHECKOUT}" &>/dev/null
        ^-- SC2164 (warning): Use 'pushd ... || exit' or 'pushd ... || return' in case pushd fails.

Did you mean:
	pushd "${KERNEL_CHECKOUT}" &>/dev/null || exit


In vmtest.sh line 302:
	if ! make -j$(nproc); then
                    ^------^ SC2046 (warning): Quote this to prevent word splitting.


In vmtest.sh line 306:
	popd &>/dev/null
        ^--------------^ SC2164 (warning): Use 'popd ... || exit' or 'popd ... || return' in case popd fails.

Did you mean:
	popd &>/dev/null || exit


In vmtest.sh line 368:
		${kernel_opt} \
                ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
		"${kernel_opt}" \


In vmtest.sh line 399:
wait_for_listener()
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In vmtest.sh line 423:
vm_wait_for_listener() {
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In vmtest.sh line 433:
host_wait_for_listener() {
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In vmtest.sh line 447:
vm_vsock_test() {
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In vmtest.sh line 474:
			return $rc
                               ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
			return "$rc"


In vmtest.sh line 482:
	return $rc
               ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	return "$rc"


In vmtest.sh line 485:
host_vsock_test() {
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In vmtest.sh line 515:
			return $rc
                               ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
			return "$rc"


In vmtest.sh line 523:
	return $rc
               ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	return "$rc"


In vmtest.sh line 557:
log_guest() {
^-- SC2120 (warning): log_guest references arguments, but none are ever passed.
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In vmtest.sh line 561:
test_ns_host_vsock_ns_mode_ok() {
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In vmtest.sh line 571:
namespaces_can_boot_same_cid() {
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In vmtest.sh line 589:
test_ns_global_same_cid_fails() {
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In vmtest.sh line 599:
test_ns_local_global_same_cid_ok() {
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In vmtest.sh line 609:
test_ns_global_local_same_cid_ok() {
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In vmtest.sh line 619:
test_ns_local_same_cid_ok() {
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In vmtest.sh line 629:
test_ns_host_vsock_ns_mode_write_once_ok() {
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In vmtest.sh line 645:
test_vm_server_host_client() {
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In vmtest.sh line 657:
test_vm_client_host_server() {
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In vmtest.sh line 669:
test_vm_loopback() {
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In vmtest.sh line 686:
test_ns_vm_local_mode_rejected() {
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In vmtest.sh line 769:
	host_oops_cnt_after=$(dmesg | grep -i 'Oops' | wc -l)
                                      ^------------^ SC2126 (style): Consider using 'grep -c' instead of 'grep|wc -l'.


In vmtest.sh line 781:
	vm_oops_cnt_after=$(vm_ssh "init_ns" -- dmesg | grep -i 'Oops' | wc -l)
                                                        ^------------^ SC2126 (style): Consider using 'grep -c' instead of 'grep|wc -l'.

For more information:
  https://www.shellcheck.net/wiki/SC2046 -- Quote this to prevent word splitt...
  https://www.shellcheck.net/wiki/SC2120 -- log_guest references arguments, b...
  https://www.shellcheck.net/wiki/SC2155 -- Declare and assign separately to ...

 ====== Checking the tree with the patch ======
Checking tools/testing/selftests/vsock/vmtest.sh - 3bbe24ed85577bc751e7e913126d8b44bb8554cc21519ace46c3118b1749f848


In vmtest.sh line 14:
readonly SCRIPT_DIR="$(cd -P -- "$(dirname -- "${BASH_SOURCE[0]}")" && pwd -P)"
         ^--------^ SC2155 (warning): Declare and assign separately to avoid masking return values.


In vmtest.sh line 15:
readonly KERNEL_CHECKOUT=$(realpath "${SCRIPT_DIR}"/../../../../)
         ^-------------^ SC2155 (warning): Declare and assign separately to avoid masking return values.


In vmtest.sh line 44:
readonly LOG=$(mktemp /tmp/vsock_vmtest_XXXX.log)
         ^-^ SC2155 (warning): Declare and assign separately to avoid masking return values.


In vmtest.sh line 209:
init_namespaces() {
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In vmtest.sh line 232:
ns_set_mode() {
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In vmtest.sh line 256:
cleanup() {
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In vmtest.sh line 363:
	pushd "${KERNEL_CHECKOUT}" &>/dev/null
        ^-- SC2164 (warning): Use 'pushd ... || exit' or 'pushd ... || return' in case pushd fails.

Did you mean:
	pushd "${KERNEL_CHECKOUT}" &>/dev/null || exit


In vmtest.sh line 369:
	if ! make -j$(nproc); then
                    ^------^ SC2046 (warning): Quote this to prevent word splitting.


In vmtest.sh line 373:
	popd &>/dev/null
        ^--------------^ SC2164 (warning): Use 'popd ... || exit' or 'popd ... || return' in case popd fails.

Did you mean:
	popd &>/dev/null || exit


In vmtest.sh line 401:
terminate_pids() {
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In vmtest.sh line 443:
		${kernel_opt} \
                ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
		"${kernel_opt}" \


In vmtest.sh line 474:
wait_for_listener()
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In vmtest.sh line 498:
vm_wait_for_listener() {
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In vmtest.sh line 508:
host_wait_for_listener() {
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In vmtest.sh line 522:
vm_dmesg_oops_count() {
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In vmtest.sh line 528:
vm_dmesg_warn_count() {
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In vmtest.sh line 534:
vm_dmesg_check() {
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In vmtest.sh line 556:
vm_vsock_test() {
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In vmtest.sh line 583:
			return $rc
                               ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
			return "$rc"


In vmtest.sh line 591:
	return $rc
               ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	return "$rc"


In vmtest.sh line 594:
host_vsock_test() {
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In vmtest.sh line 624:
			return $rc
                               ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
			return "$rc"


In vmtest.sh line 632:
	return $rc
               ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
	return "$rc"


In vmtest.sh line 666:
log_guest() {
^-- SC2120 (warning): log_guest references arguments, but none are ever passed.
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In vmtest.sh line 670:
test_ns_host_vsock_ns_mode_ok() {
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In vmtest.sh line 680:
test_ns_diff_global_host_connect_to_global_vm_ok() {
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In vmtest.sh line 732:
test_ns_diff_global_host_connect_to_local_vm_fails() {
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In vmtest.sh line 774:
test_ns_diff_global_vm_connect_to_global_host_ok() {
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In vmtest.sh line 835:
test_ns_diff_global_vm_connect_to_local_host_fails() {
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In vmtest.sh line 884:
test_ns_diff_local_host_connect_to_local_vm_fails() {
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In vmtest.sh line 927:
test_ns_diff_local_vm_connect_to_local_host_fails() {
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In vmtest.sh line 974:
__test_loopback_two_netns() {
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In vmtest.sh line 1002:
test_ns_diff_global_to_local_loopback_local_fails() {
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In vmtest.sh line 1012:
test_ns_diff_local_to_global_loopback_fails() {
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In vmtest.sh line 1022:
test_ns_diff_local_to_local_loopback_fails() {
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In vmtest.sh line 1032:
test_ns_diff_global_to_global_loopback_ok() {
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In vmtest.sh line 1042:
test_ns_same_local_loopback_ok() {
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In vmtest.sh line 1052:
test_ns_same_local_host_connect_to_local_vm_ok() {
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In vmtest.sh line 1088:
test_ns_same_local_vm_connect_to_local_host_ok() {
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In vmtest.sh line 1124:
namespaces_can_boot_same_cid() {
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In vmtest.sh line 1142:
test_ns_global_same_cid_fails() {
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In vmtest.sh line 1152:
test_ns_local_global_same_cid_ok() {
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In vmtest.sh line 1162:
test_ns_global_local_same_cid_ok() {
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In vmtest.sh line 1172:
test_ns_local_same_cid_ok() {
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In vmtest.sh line 1182:
test_ns_host_vsock_ns_mode_write_once_ok() {
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In vmtest.sh line 1198:
test_vm_server_host_client() {
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In vmtest.sh line 1210:
test_vm_client_host_server() {
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In vmtest.sh line 1222:
test_vm_loopback() {
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In vmtest.sh line 1239:
test_ns_vm_local_mode_rejected() {
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).


In vmtest.sh line 1322:
	host_oops_cnt_after=$(dmesg | grep -i 'Oops' | wc -l)
                                      ^------------^ SC2126 (style): Consider using 'grep -c' instead of 'grep|wc -l'.


In vmtest.sh line 1334:
	vm_oops_cnt_after=$(vm_ssh "init_ns" -- dmesg | grep -i 'Oops' | wc -l)
                                                        ^------------^ SC2126 (style): Consider using 'grep -c' instead of 'grep|wc -l'.

For more information:
  https://www.shellcheck.net/wiki/SC2046 -- Quote this to prevent word splitt...
  https://www.shellcheck.net/wiki/SC2120 -- log_guest references arguments, b...
  https://www.shellcheck.net/wiki/SC2155 -- Declare and assign separately to ...