====== Checking before the patch ====== ====== Checking the tree with the patch ====== New warnings added --- /tmp/tmp.nAzu1vv0jM 2025-11-17 20:05:17.695142952 -0500 +++ /tmp/tmp.RuQCMSnzFl 2025-11-17 20:05:18.288997631 -0500 @@ -11 +11 @@ -ALL_TESTS="fw_flash_test params_test regions_test reload_test \ +ALL_TESTS="fw_flash_test params_test \ @@ -15 +15 @@ -In devlink.sh line 9: +In devlink.sh line 10: @@ -20 +20 @@ -In devlink.sh line 10: +In devlink.sh line 11: @@ -29 +29 @@ -In devlink.sh line 20: +In devlink.sh line 21: @@ -34 +34 @@ -In devlink.sh line 22: +In devlink.sh line 23: @@ -42 +42 @@ -In devlink.sh line 25: +In devlink.sh line 26: @@ -47 +47 @@ -In devlink.sh line 32: +In devlink.sh line 33: @@ -52 +52 @@ -In devlink.sh line 43: +In devlink.sh line 44: @@ -60 +60 @@ -In devlink.sh line 45: +In devlink.sh line 46: @@ -69 +69 @@ -In devlink.sh line 48: +In devlink.sh line 49: @@ -78 +78 @@ -In devlink.sh line 51: +In devlink.sh line 52: @@ -87 +87 @@ -In devlink.sh line 54: +In devlink.sh line 55: @@ -95 +95 @@ -In devlink.sh line 57: +In devlink.sh line 58: @@ -104 +104 @@ -In devlink.sh line 60: +In devlink.sh line 61: @@ -113 +113 @@ -In devlink.sh line 63: +In devlink.sh line 64: @@ -121 +121 @@ -In devlink.sh line 66: +In devlink.sh line 67: @@ -130 +130 @@ -In devlink.sh line 69: +In devlink.sh line 70: @@ -138 +138 @@ -In devlink.sh line 72: +In devlink.sh line 73: @@ -147 +147 @@ -In devlink.sh line 78: +In devlink.sh line 79: @@ -152 +152 @@ -In devlink.sh line 86: +In devlink.sh line 89: @@ -157,2 +157,18 @@ -In devlink.sh line 91: - devlink dev param set $DL_HANDLE name $name cmode driverinit value $value +In devlink.sh line 95: + devlink dev param set $DL_HANDLE name $name cmode $cmode value $value + ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. + ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. + ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. + ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + devlink dev param set "$DL_HANDLE" name "$name" cmode "$cmode" value "$value" + + +In devlink.sh line 98: +param_set_default() +^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). + + +In devlink.sh line 103: + devlink dev param set $DL_HANDLE name $name default cmode $cmode @@ -161 +177 @@ - ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. + ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. @@ -164 +180 @@ - devlink dev param set "$DL_HANDLE" name "$name" cmode driverinit value "$value" + devlink dev param set "$DL_HANDLE" name "$name" default cmode "$cmode" @@ -167 +183 @@ -In devlink.sh line 94: +In devlink.sh line 106: @@ -172,2 +188,2 @@ -In devlink.sh line 102: - value=$(param_get $name) +In devlink.sh line 120: + value=$(param_get $name $attr $cmode) @@ -174,0 +191,2 @@ + ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. + ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. @@ -177 +195 @@ - value=$(param_get "$name") + value=$(param_get "$name" "$attr" "$cmode") @@ -180 +198 @@ -In devlink.sh line 106: +In devlink.sh line 124: @@ -189 +207 @@ -In devlink.sh line 112: +In devlink.sh line 130: @@ -194 +212 @@ -In devlink.sh line 116: +In devlink.sh line 134: @@ -199 +217 @@ -In devlink.sh line 117: +In devlink.sh line 135: @@ -204 +222 @@ -In devlink.sh line 130: +In devlink.sh line 148: @@ -212 +230,132 @@ -In devlink.sh line 138: +In devlink.sh line 156: +value_to_debugfs() +^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). + + +In devlink.sh line 173: +test_default() +^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). + + +In devlink.sh line 179: + local default_debugfs=$(value_to_debugfs $expected_default) + ^-------------^ SC2155 (warning): Declare and assign separately to avoid masking return values. + ^---------------^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + local default_debugfs=$(value_to_debugfs "$expected_default") + + +In devlink.sh line 180: + local new_debugfs=$(value_to_debugfs $new_value) + ^---------^ SC2155 (warning): Declare and assign separately to avoid masking return values. + ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + local new_debugfs=$(value_to_debugfs "$new_value") + + +In devlink.sh line 184: + check_value $param_name initial-default $expected_default $expected_debugfs $cmode + ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. + ^---------------^ SC2086 (info): Double quote to prevent globbing and word splitting. + ^---------------^ SC2086 (info): Double quote to prevent globbing and word splitting. + ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + check_value "$param_name" initial-default "$expected_default" "$expected_debugfs" "$cmode" + + +In devlink.sh line 186: + param_set $param_name $new_value $cmode + ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. + ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. + ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + param_set "$param_name" "$new_value" "$cmode" + + +In devlink.sh line 190: + check_value $param_name post-set $new_value $expected_debugfs $cmode + ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. + ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. + ^---------------^ SC2086 (info): Double quote to prevent globbing and word splitting. + ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + check_value "$param_name" post-set "$new_value" "$expected_debugfs" "$cmode" + + +In devlink.sh line 192: + devlink dev reload $DL_HANDLE + ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + devlink dev reload "$DL_HANDLE" + + +In devlink.sh line 196: + check_value $param_name post-reload-new-value $new_value $expected_debugfs $cmode + ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. + ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. + ^---------------^ SC2086 (info): Double quote to prevent globbing and word splitting. + ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + check_value "$param_name" post-reload-new-value "$new_value" "$expected_debugfs" "$cmode" + + +In devlink.sh line 198: + param_set_default $param_name $cmode + ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. + ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + param_set_default "$param_name" "$cmode" + + +In devlink.sh line 202: + check_value $param_name post-set-default $expected_default $expected_debugfs $cmode + ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. + ^---------------^ SC2086 (info): Double quote to prevent globbing and word splitting. + ^---------------^ SC2086 (info): Double quote to prevent globbing and word splitting. + ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + check_value "$param_name" post-set-default "$expected_default" "$expected_debugfs" "$cmode" + + +In devlink.sh line 204: + devlink dev reload $DL_HANDLE + ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + devlink dev reload "$DL_HANDLE" + + +In devlink.sh line 208: + check_value $param_name post-reload-default $expected_default $expected_debugfs $cmode + ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. + ^---------------^ SC2086 (info): Double quote to prevent globbing and word splitting. + ^---------------^ SC2086 (info): Double quote to prevent globbing and word splitting. + ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + check_value "$param_name" post-reload-default "$expected_default" "$expected_debugfs" "$cmode" + + +In devlink.sh line 211: +params_default_test() +^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly). + + +In devlink.sh line 229: + devlink dev reload $DL_HANDLE + ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + devlink dev reload "$DL_HANDLE" + + +In devlink.sh line 239: @@ -217 +366 @@ -In devlink.sh line 143: +In devlink.sh line 244: @@ -226 +375 @@ -In devlink.sh line 145: +In devlink.sh line 246: @@ -234 +383 @@ -In devlink.sh line 149: +In devlink.sh line 250: @@ -239 +388 @@ -In devlink.sh line 156: +In devlink.sh line 257: @@ -248 +397 @@ -In devlink.sh line 157: +In devlink.sh line 258: @@ -257 +406 @@ -In devlink.sh line 161: +In devlink.sh line 262: @@ -262 +411 @@ -In devlink.sh line 170: +In devlink.sh line 271: @@ -270 +419 @@ -In devlink.sh line 174: +In devlink.sh line 275: @@ -278 +427 @@ -In devlink.sh line 178: +In devlink.sh line 279: @@ -286 +435 @@ -In devlink.sh line 182: +In devlink.sh line 283: @@ -294 +443 @@ -In devlink.sh line 187: +In devlink.sh line 288: @@ -302 +451 @@ -In devlink.sh line 192: +In devlink.sh line 293: @@ -310 +459 @@ -In devlink.sh line 195: +In devlink.sh line 296: @@ -318 +467 @@ -In devlink.sh line 198: +In devlink.sh line 299: @@ -326 +475 @@ -In devlink.sh line 201: +In devlink.sh line 302: @@ -334 +483 @@ -In devlink.sh line 204: +In devlink.sh line 305: @@ -342 +491 @@ -In devlink.sh line 207: +In devlink.sh line 308: @@ -350 +499 @@ -In devlink.sh line 212: +In devlink.sh line 313: @@ -358 +507 @@ -In devlink.sh line 217: +In devlink.sh line 318: @@ -367 +516 @@ -In devlink.sh line 220: +In devlink.sh line 321: @@ -376 +525 @@ -In devlink.sh line 228: +In devlink.sh line 329: @@ -381 +530 @@ -In devlink.sh line 232: +In devlink.sh line 333: @@ -389 +538 @@ -In devlink.sh line 235: +In devlink.sh line 336: @@ -397 +546 @@ -In devlink.sh line 238: +In devlink.sh line 339: @@ -405 +554 @@ -In devlink.sh line 241: +In devlink.sh line 342: @@ -413 +562 @@ -In devlink.sh line 244: +In devlink.sh line 345: @@ -421 +570 @@ -In devlink.sh line 247: +In devlink.sh line 348: @@ -429 +578 @@ -In devlink.sh line 250: +In devlink.sh line 351: @@ -437 +586 @@ -In devlink.sh line 253: +In devlink.sh line 354: @@ -445 +594 @@ -In devlink.sh line 256: +In devlink.sh line 357: @@ -453 +602 @@ -In devlink.sh line 262: +In devlink.sh line 363: @@ -458 +607 @@ -In devlink.sh line 271: +In devlink.sh line 372: @@ -466 +615 @@ -In devlink.sh line 274: +In devlink.sh line 375: @@ -474 +623 @@ -In devlink.sh line 288: +In devlink.sh line 389: @@ -479 +628 @@ -In devlink.sh line 300: +In devlink.sh line 401: @@ -484 +633 @@ -In devlink.sh line 309: +In devlink.sh line 410: @@ -492 +641 @@ -In devlink.sh line 314: +In devlink.sh line 415: @@ -500 +649 @@ -In devlink.sh line 316: +In devlink.sh line 417: @@ -508 +657 @@ -In devlink.sh line 318: +In devlink.sh line 419: @@ -516 +665 @@ -In devlink.sh line 321: +In devlink.sh line 422: @@ -521 +670 @@ -In devlink.sh line 326: +In devlink.sh line 427: @@ -530 +679 @@ -In devlink.sh line 328: +In devlink.sh line 429: @@ -535 +684 @@ -In devlink.sh line 332: +In devlink.sh line 433: @@ -543 +692 @@ -In devlink.sh line 334: +In devlink.sh line 435: @@ -548 +697 @@ -In devlink.sh line 352: +In devlink.sh line 453: @@ -556 +705 @@ -In devlink.sh line 354: +In devlink.sh line 455: @@ -564 +713 @@ -In devlink.sh line 356: +In devlink.sh line 457: @@ -572 +721 @@ -In devlink.sh line 363: +In devlink.sh line 464: @@ -580 +729 @@ -In devlink.sh line 366: +In devlink.sh line 467: @@ -588 +737 @@ -In devlink.sh line 369: +In devlink.sh line 470: @@ -596 +745 @@ -In devlink.sh line 381: +In devlink.sh line 482: @@ -601 +750 @@ -In devlink.sh line 388: +In devlink.sh line 489: @@ -606 +755 @@ -In devlink.sh line 400: +In devlink.sh line 501: @@ -611 +760 @@ -In devlink.sh line 404: +In devlink.sh line 505: @@ -619 +768 @@ -In devlink.sh line 407: +In devlink.sh line 508: @@ -627 +776 @@ -In devlink.sh line 410: +In devlink.sh line 511: @@ -635 +784 @@ -In devlink.sh line 413: +In devlink.sh line 514: @@ -643 +792 @@ -In devlink.sh line 419: +In devlink.sh line 520: @@ -648 +797 @@ -In devlink.sh line 428: +In devlink.sh line 529: @@ -658 +807 @@ -In devlink.sh line 431: +In devlink.sh line 532: @@ -667 +816 @@ -In devlink.sh line 435: +In devlink.sh line 536: @@ -676 +825 @@ -In devlink.sh line 439: +In devlink.sh line 540: @@ -686 +835 @@ -In devlink.sh line 443: +In devlink.sh line 544: @@ -695 +844 @@ -In devlink.sh line 448: +In devlink.sh line 549: @@ -704 +853 @@ -In devlink.sh line 453: +In devlink.sh line 554: @@ -709 +858 @@ -In devlink.sh line 459: +In devlink.sh line 560: @@ -717 +866 @@ -In devlink.sh line 465: +In devlink.sh line 566: @@ -725 +874 @@ -In devlink.sh line 470: +In devlink.sh line 571: @@ -734 +883 @@ -In devlink.sh line 473: +In devlink.sh line 574: @@ -743 +892 @@ -In devlink.sh line 477: +In devlink.sh line 578: @@ -751 +900 @@ -In devlink.sh line 480: +In devlink.sh line 581: @@ -759 +908 @@ -In devlink.sh line 485: +In devlink.sh line 586: @@ -767 +916 @@ -In devlink.sh line 490: +In devlink.sh line 591: @@ -775 +924 @@ -In devlink.sh line 495: +In devlink.sh line 596: @@ -784 +933 @@ -In devlink.sh line 498: +In devlink.sh line 599: @@ -793 +942 @@ -In devlink.sh line 502: +In devlink.sh line 603: @@ -801 +950 @@ -In devlink.sh line 507: +In devlink.sh line 608: @@ -809 +958 @@ -In devlink.sh line 510: +In devlink.sh line 611: @@ -817 +966 @@ -In devlink.sh line 515: +In devlink.sh line 616: @@ -825 +974 @@ -In devlink.sh line 518: +In devlink.sh line 619: @@ -833 +982 @@ -In devlink.sh line 521: +In devlink.sh line 622: @@ -841 +990 @@ -In devlink.sh line 526: +In devlink.sh line 627: @@ -849 +998 @@ -In devlink.sh line 529: +In devlink.sh line 630: @@ -858 +1007 @@ -In devlink.sh line 532: +In devlink.sh line 633: @@ -866 +1015 @@ -In devlink.sh line 538: +In devlink.sh line 639: @@ -871 +1020 @@ -In devlink.sh line 543: +In devlink.sh line 644: @@ -879 +1028 @@ -In devlink.sh line 546: +In devlink.sh line 647: @@ -884 +1033 @@ -In devlink.sh line 551: +In devlink.sh line 652: @@ -892 +1041 @@ -In devlink.sh line 554: +In devlink.sh line 655: @@ -897 +1046 @@ -In devlink.sh line 561: +In devlink.sh line 662: @@ -908 +1057 @@ -In devlink.sh line 564: +In devlink.sh line 665: @@ -913 +1062 @@ -In devlink.sh line 569: +In devlink.sh line 670: @@ -921 +1070 @@ -In devlink.sh line 572: +In devlink.sh line 673: @@ -926 +1075 @@ -In devlink.sh line 579: +In devlink.sh line 680: @@ -936 +1085 @@ -In devlink.sh line 582: +In devlink.sh line 683: @@ -945 +1094 @@ -In devlink.sh line 587: +In devlink.sh line 688: @@ -954 +1103 @@ -In devlink.sh line 593: +In devlink.sh line 694: @@ -959 +1108 @@ -In devlink.sh line 599: +In devlink.sh line 700: @@ -968 +1117 @@ -In devlink.sh line 602: +In devlink.sh line 703: @@ -976 +1125 @@ -In devlink.sh line 607: +In devlink.sh line 708: @@ -984 +1133 @@ -In devlink.sh line 613: +In devlink.sh line 714: @@ -989 +1138 @@ -In devlink.sh line 653: +In devlink.sh line 754: @@ -994 +1143 @@ -In devlink.sh line 657: +In devlink.sh line 758: @@ -1002 +1151 @@ -In devlink.sh line 660: +In devlink.sh line 761: @@ -1007 +1156 @@ -In devlink.sh line 664: +In devlink.sh line 765: @@ -1015 +1164 @@ -In devlink.sh line 667: +In devlink.sh line 768: @@ -1020 +1169 @@ -In devlink.sh line 669: +In devlink.sh line 770: @@ -1025 +1174 @@ -In devlink.sh line 671: +In devlink.sh line 772: @@ -1034 +1183 @@ -In devlink.sh line 672: +In devlink.sh line 773: @@ -1042 +1191 @@ -In devlink.sh line 673: +In devlink.sh line 774: @@ -1052 +1201 @@ -In devlink.sh line 674: +In devlink.sh line 775: @@ -1062 +1211 @@ -In devlink.sh line 681: +In devlink.sh line 782: @@ -1071 +1220 @@ -In devlink.sh line 682: +In devlink.sh line 783: @@ -1080 +1229 @@ -In devlink.sh line 683: +In devlink.sh line 784: @@ -1085 +1234 @@ -In devlink.sh line 689: +In devlink.sh line 790: @@ -1094 +1243 @@ -In devlink.sh line 690: +In devlink.sh line 791: @@ -1103 +1252 @@ -In devlink.sh line 691: +In devlink.sh line 792: @@ -1108 +1257 @@ -In devlink.sh line 706: +In devlink.sh line 807: @@ -1118 +1267 @@ -In devlink.sh line 707: +In devlink.sh line 808: @@ -1126 +1275 @@ -In devlink.sh line 711: +In devlink.sh line 812: @@ -1135 +1284 @@ -In devlink.sh line 712: +In devlink.sh line 813: @@ -1144 +1293 @@ -In devlink.sh line 715: +In devlink.sh line 816: @@ -1153 +1302 @@ -In devlink.sh line 716: +In devlink.sh line 817: @@ -1162 +1311 @@ -In devlink.sh line 720: +In devlink.sh line 821: @@ -1170 +1319 @@ -In devlink.sh line 726: +In devlink.sh line 827: @@ -1180 +1329 @@ -In devlink.sh line 727: +In devlink.sh line 828: @@ -1188 +1337 @@ -In devlink.sh line 735: +In devlink.sh line 836: @@ -1197 +1346 @@ -In devlink.sh line 736: +In devlink.sh line 837: @@ -1206 +1355 @@ -In devlink.sh line 743: +In devlink.sh line 844: @@ -1215 +1364 @@ -In devlink.sh line 744: +In devlink.sh line 845: @@ -1224 +1373 @@ -In devlink.sh line 762: +In devlink.sh line 863: @@ -1229 +1378 @@ -In devlink.sh line 775: +In devlink.sh line 876: