1: c43ab52fd196 ! 1: b87e3265f929 wifi: rtw89: acpi: check for _DSM function support before evaluating it @@ Commit message AE_BAD_PARAMETER. All callers already treat failure as "no policy provided by the platform", so this is only noise.  - Use acpi_check_dsm() first. It returns false for a NULL handle and for - functions that are not advertised, so absent functions fail quietly at - debug level, as rtw89_acpi_evaluate_method() already does. + Bail out early when there is no ACPI handle, as acpi_check_dsm() would + otherwise hit the same warning while querying function 0. Then use + acpi_check_dsm() so that functions the firmware does not advertise fail + quietly at debug level, as rtw89_acpi_evaluate_method() already does.  Seen on an RTL8852BE in a desktop PCIe slot.  - Fixes: e897b0bef38a ("wifi: rtw89: introduce realtek ACPI DSM method") Signed-off-by: Rosen Penev   ## drivers/net/wireless/realtek/rtw89/acpi.c ## @@ drivers/net/wireless/realtek/rtw89/acpi.c: int rtw89_acpi_evaluate_dsm(struct rt   - obj = acpi_evaluate_dsm(ACPI_HANDLE(rtwdev->dev), &rtw89_guid,  - 0, func, NULL); ++ if (!handle) { ++ rtw89_debug(rtwdev, RTW89_DBG_ACPI, "acpi dsm no handle\n"); ++ return -ENODEV; ++ } ++  + if (!acpi_check_dsm(handle, &rtw89_guid, 0, BIT(func))) {  + rtw89_debug(rtwdev, RTW89_DBG_ACPI,  + "acpi dsm func %d not supported\n", func);