WARNING: line length of 81 exceeds 80 columns #368: FILE: include/net/mac80211.h:2799: +#define for_each_sta_active_link(sta, link_sta, link_id) \ ERROR: Macros with complex values should be enclosed in parentheses #368: FILE: include/net/mac80211.h:2799: +#define for_each_sta_active_link(sta, link_sta, link_id) \ for (link_id = 0; link_id < ARRAY_SIZE((sta)->link); link_id++) \ + if ((!(sta)->active_links || \ + (sta)->active_links & BIT(link_id)) && \ ((link_sta) = link_sta_dereference_check(sta, link_id))) BUT SEE: do {} while (0) advice is over-stated in a few situations: The more obvious case is macros, like MODULE_PARM_DESC, invoked at file-scope, where C disallows code (it must be in functions). See $exceptions if you have one to add by name. More troublesome is declarative macros used at top of new scope, like DECLARE_PER_CPU. These might just compile with a do-while-0 wrapper, but would be incorrect. Most of these are handled by detecting struct,union,etc declaration primitives in $exceptions. Theres also macros called inside an if (block), which "return" an expression. These cannot do-while, and need a ({}) wrapper. Enjoy this qualification while we work to improve our heuristics. WARNING: line length of 81 exceeds 80 columns #372: FILE: include/net/mac80211.h:2801: + if ((!(sta)->active_links || \ ERROR: do not use assignment in if condition #372: FILE: include/net/mac80211.h:2801: + if ((!(sta)->active_links || \ WARNING: line length of 81 exceeds 80 columns #373: FILE: include/net/mac80211.h:2802: + (sta)->active_links & BIT(link_id)) && \ total: 2 errors, 3 warnings, 0 checks, 269 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Commit 0115278b366b ("wifi: mac80211: use sta->active_links in for_each_sta_active_link()") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE FILE_PATH_CHANGES GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS.