CHECK: braces {} should be used on all arms of this statement #65: FILE: fs/proc/proc_sysctl.c:440: + if (!name) { [...] + } else for (node = dir->root.rb_node; node;) { [...] ERROR: trailing statements should be on next line #67: FILE: fs/proc/proc_sysctl.c:442: + } else for (node = dir->root.rb_node; node;) { ERROR: trailing statements should be on next line #67: FILE: fs/proc/proc_sysctl.c:442: + } else for (node = dir->root.rb_node; node;) { WARNING: Prefer kmalloc_obj over kmalloc with sizeof #120: FILE: fs/proc/proc_sysctl.c:746: + cursor = kmalloc(sizeof(*cursor), GFP_KERNEL); WARNING: line length of 81 exceeds 80 columns #140: FILE: fs/proc/proc_sysctl.c:836: + sysctl_cursor_set(file, table->procname, strlen(table->procname), CHECK: From:/Signed-off-by: email comments mismatch: 'From: Christian Brauner ' != 'Signed-off-by: Christian Brauner (Amutable) ' total: 2 errors, 2 warnings, 2 checks, 150 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Commit df40dd41b309 ("proc: sysctl: resume readdir after the last name it returned") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE FILE_PATH_CHANGES GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS.