WARNING: line length of 93 exceeds 80 columns #65: FILE: drivers/net/wireless/broadcom/brcm80211/bcm4323x/bcm4323x_core.c:40: +static int bcm4323x_bulk_transfer(struct bcm4323x *dev, void *buffer, int length, bool *sent) WARNING: line length of 98 exceeds 80 columns #70: FILE: drivers/net/wireless/broadcom/brcm80211/bcm4323x/bcm4323x_core.c:45: + ret = usb_bulk_msg(dev->udev, dev->tx_pipe, buffer, length, &actual, BCM4323X_TIMEOUT_MS); WARNING: line length of 100 exceeds 80 columns #77: FILE: drivers/net/wireless/broadcom/brcm80211/bcm4323x/bcm4323x_core.c:52: + return usb_bulk_msg(dev->udev, dev->tx_pipe, NULL, 0, &actual, BCM4323X_TIMEOUT_MS); WARNING: line length of 81 exceeds 80 columns #87: FILE: drivers/net/wireless/broadcom/brcm80211/bcm4323x/bcm4323x_core.c:62: + /* Unlike brcmfmac's images, this one is not flagged TRX_UNCOMP_IMAGE. */ WARNING: line length of 92 exceeds 80 columns #95: FILE: drivers/net/wireless/broadcom/brcm80211/bcm4323x/bcm4323x_core.c:70: +static int bcm4323x_dl_cmd(struct bcm4323x *dev, u8 cmd, union bcm4323x_dl_response *buffer) WARNING: line length of 92 exceeds 80 columns #97: FILE: drivers/net/wireless/broadcom/brcm80211/bcm4323x/bcm4323x_core.c:72: + return usb_control_msg_recv(dev->udev, 0, cmd, BCM4323X_REQ_TYPE, BCM4323X_DL_VALUE, WARNING: line length of 93 exceeds 80 columns #98: FILE: drivers/net/wireless/broadcom/brcm80211/bcm4323x/bcm4323x_core.c:73: + dev->intf->cur_altsetting->desc.bInterfaceNumber, buffer, WARNING: line length of 86 exceeds 80 columns #99: FILE: drivers/net/wireless/broadcom/brcm80211/bcm4323x/bcm4323x_core.c:74: + sizeof(*buffer), BCM4323X_TIMEOUT_MS, GFP_KERNEL); WARNING: line length of 82 exceeds 80 columns #111: FILE: drivers/net/wireless/broadcom/brcm80211/bcm4323x/bcm4323x_core.c:86: + id.id.chip == cpu_to_le32(BRCMF_POSTBOOT_ID), WARNING: line length of 93 exceeds 80 columns #112: FILE: drivers/net/wireless/broadcom/brcm80211/bcm4323x/bcm4323x_core.c:87: + BCM4323X_BOOT_POLL_US, BCM4323X_BOOT_TIMEOUT_US, true) ?: err; WARNING: line length of 81 exceeds 80 columns #133: FILE: drivers/net/wireless/broadcom/brcm80211/bcm4323x/bcm4323x_core.c:108: + err = bcm4323x_bulk_transfer(dev, dev->io_buffer, sendlen, NULL); WARNING: line length of 83 exceeds 80 columns #143: FILE: drivers/net/wireless/broadcom/brcm80211/bcm4323x/bcm4323x_core.c:118: + * Unlike brcmfmac, expect the bytes to be accepted at once, as the WARNING: line length of 92 exceeds 80 columns #201: FILE: drivers/net/wireless/broadcom/brcm80211/bcm4323x/bcm4323x_core.c:176: +static int bcm4323x_rpc_response_locked(struct bcm4323x *dev, u32 procedure, void *response, WARNING: line length of 97 exceeds 80 columns #213: FILE: drivers/net/wireless/broadcom/brcm80211/bcm4323x/bcm4323x_core.c:188: + BCM4323X_REQ_RPC_RESPONSE, BCM4323X_REQ_TYPE, 0, interface, WARNING: line length of 86 exceeds 80 columns #223: FILE: drivers/net/wireless/broadcom/brcm80211/bcm4323x/bcm4323x_core.c:198: + FIELD_GET(BCM4323X_RPC_CLASS_MASK, le32_to_cpu(rpc->xid_class)) != WARNING: line length of 83 exceeds 80 columns #241: FILE: drivers/net/wireless/broadcom/brcm80211/bcm4323x/bcm4323x_core.c:216: +static int bcm4323x_rpc_transact(struct bcm4323x *dev, u8 rpc_class, u32 procedure, WARNING: line length of 86 exceeds 80 columns #242: FILE: drivers/net/wireless/broadcom/brcm80211/bcm4323x/bcm4323x_core.c:217: + const void *body, size_t body_length, void *response, WARNING: line length of 93 exceeds 80 columns #260: FILE: drivers/net/wireless/broadcom/brcm80211/bcm4323x/bcm4323x_core.c:235: + ret = bcm4323x_bulk_transfer(dev, dev->io_buffer, sizeof(*rpc) + body_length, &sent); WARNING: line length of 94 exceeds 80 columns #264: FILE: drivers/net/wireless/broadcom/brcm80211/bcm4323x/bcm4323x_core.c:239: + ret = bcm4323x_rpc_response_locked(dev, procedure, response, response_length); WARNING: line length of 96 exceeds 80 columns #269: FILE: drivers/net/wireless/broadcom/brcm80211/bcm4323x/bcm4323x_core.c:244: +int bcm4323x_rpc_send(struct bcm4323x *dev, u32 procedure, const void *body, size_t body_length) WARNING: line length of 96 exceeds 80 columns #271: FILE: drivers/net/wireless/broadcom/brcm80211/bcm4323x/bcm4323x_core.c:246: + return bcm4323x_rpc_transact(dev, BCM4323X_RPC_CLASS_DATA, procedure, body, body_length, WARNING: line length of 96 exceeds 80 columns #275: FILE: drivers/net/wireless/broadcom/brcm80211/bcm4323x/bcm4323x_core.c:250: +int bcm4323x_rpc_call(struct bcm4323x *dev, u32 procedure, const void *body, size_t body_length, WARNING: line length of 86 exceeds 80 columns #278: FILE: drivers/net/wireless/broadcom/brcm80211/bcm4323x/bcm4323x_core.c:253: + return bcm4323x_rpc_transact(dev, BCM4323X_RPC_CLASS_CONTROL, procedure, body, WARNING: line length of 84 exceeds 80 columns #282: FILE: drivers/net/wireless/broadcom/brcm80211/bcm4323x/bcm4323x_core.c:257: +static int bcm4323x_handshake_step(struct bcm4323x *dev, u32 procedure, __le32 chip) WARNING: line length of 88 exceeds 80 columns #291: FILE: drivers/net/wireless/broadcom/brcm80211/bcm4323x/bcm4323x_core.c:266: + ret = bcm4323x_rpc_transact(dev, BCM4323X_RPC_CLASS_TRANSPORT, procedure, &body, WARNING: line length of 88 exceeds 80 columns #298: FILE: drivers/net/wireless/broadcom/brcm80211/bcm4323x/bcm4323x_core.c:273: + /* VERSION sends no chip ID, and CHIP the one that the VERSION reply carried. */ WARNING: line length of 96 exceeds 80 columns #314: FILE: drivers/net/wireless/broadcom/brcm80211/bcm4323x/bcm4323x_core.c:289: + ret = bcm4323x_handshake_step(dev, BCM4323X_RPC_PROC_CHIP, dev->handshake_chip); WARNING: line length of 93 exceeds 80 columns #355: FILE: drivers/net/wireless/broadcom/brcm80211/bcm4323x/bcm4323x_core.c:330: + if (usb_find_common_endpoints_reverse(dev->intf->cur_altsetting, &bulk_in, &bulk_out, WARNING: line length of 85 exceeds 80 columns #359: FILE: drivers/net/wireless/broadcom/brcm80211/bcm4323x/bcm4323x_core.c:334: + dev->io_buffer = devm_kmalloc(&dev->intf->dev, BCM4323X_IO_SIZE, GFP_KERNEL); WARNING: line length of 84 exceeds 80 columns #374: FILE: drivers/net/wireless/broadcom/brcm80211/bcm4323x/bcm4323x_core.c:349: + usb_fill_bulk_urb(urb, dev->udev, rx_pipe, buffer, BCM4323X_RX_SIZE, WARNING: line length of 93 exceeds 80 columns #396: FILE: drivers/net/wireless/broadcom/brcm80211/bcm4323x/bcm4323x_core.c:371: + struct bcm4323x_reprobe *reprobe = container_of(work, struct bcm4323x_reprobe, work); WARNING: line length of 85 exceeds 80 columns #432: FILE: drivers/net/wireless/broadcom/brcm80211/bcm4323x/bcm4323x_core.c:407: +static int bcm4323x_probe(struct usb_interface *intf, const struct usb_device_id *id) WARNING: line length of 100 exceeds 80 columns #477: FILE: drivers/net/wireless/broadcom/brcm80211/bcm4323x/bcm4323x_core.c:452: + dev_info(&intf->dev, "BCM4323x RPC mac80211 device ready, MAC %pM\n", hw->wiphy->perm_addr); WARNING: line length of 83 exceeds 80 columns #512: FILE: drivers/net/wireless/broadcom/brcm80211/bcm4323x/bcm4323x_core.c:487: + ret = bcm4323x_rpc_call(dev, BCM4323X_RPC_PROC_WATCHDOG, NULL, 0, NULL, 0); WARNING: line length of 85 exceeds 80 columns #540: FILE: drivers/net/wireless/broadcom/brcm80211/bcm4323x/bcm4323x_core.c:515: + { USB_DEVICE(0x050d, 0x6050), .driver_info = (kernel_ulong_t)&bcm4323_chip }, WARNING: line length of 85 exceeds 80 columns #542: FILE: drivers/net/wireless/broadcom/brcm80211/bcm4323x/bcm4323x_core.c:517: + { USB_DEVICE(0x050d, 0x615a), .driver_info = (kernel_ulong_t)&f9l1101_chip }, WARNING: line length of 85 exceeds 80 columns #544: FILE: drivers/net/wireless/broadcom/brcm80211/bcm4323x/bcm4323x_core.c:519: + { USB_DEVICE(0x050d, 0x825c), .driver_info = (kernel_ulong_t)&bcm4323_chip }, WARNING: line length of 86 exceeds 80 columns #546: FILE: drivers/net/wireless/broadcom/brcm80211/bcm4323x/bcm4323x_core.c:521: + { USB_DEVICE(0x050d, 0xd321), .driver_info = (kernel_ulong_t)&bcm43231_chip }, WARNING: line length of 85 exceeds 80 columns #548: FILE: drivers/net/wireless/broadcom/brcm80211/bcm4323x/bcm4323x_core.c:523: + { USB_DEVICE(0x0846, 0x9011), .driver_info = (kernel_ulong_t)&bcm4323_chip }, WARNING: line length of 85 exceeds 80 columns #550: FILE: drivers/net/wireless/broadcom/brcm80211/bcm4323x/bcm4323x_core.c:525: + { USB_DEVICE(0x0846, 0x9020), .driver_info = (kernel_ulong_t)&wna3100_chip }, total: 0 errors, 40 warnings, 0 checks, 545 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Commit 95a314141a4e ("wifi: bcm4323x: add the USB transport and firmware setup") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE FILE_PATH_CHANGES GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. total: 0 errors, 40 warnings, 0 checks, 545 lines checked