CHECK: No space is necessary after a cast #903: FILE: drivers/net/wireless/broadcom/brcm80211/brcmsmac/rate.c:796: + plcp[1] = (u8) (le | D11B_PLCP_SIGNAL_LOCKED); CHECK: No space is necessary after a cast #915: FILE: drivers/net/wireless/broadcom/brcm80211/brcmsmac/rate.c:808: + u8 mcs = (u8) (rspec & RSPEC_RATE_MASK); WARNING: Missing a blank line after declarations #916: FILE: drivers/net/wireless/broadcom/brcm80211/brcmsmac/rate.c:809: + u8 mcs = (u8) (rspec & RSPEC_RATE_MASK); + plcp[0] = mcs; CHECK: Unnecessary parentheses around 'mcs == 32' #917: FILE: drivers/net/wireless/broadcom/brcm80211/brcmsmac/rate.c:810: + if (rspec_is40mhz(rspec) || (mcs == 32)) CHECK: No space is necessary after a cast #940: FILE: drivers/net/wireless/broadcom/brcm80211/brcmsmac/rate.c:833: + D11A_PHY_HDR_SRATE((struct ofdm_phy_hdr *) plcp, rate_signal); CHECK: No space is necessary after a cast #1108: FILE: drivers/net/wireless/broadcom/brcm80211/brcmsmac/rate.c:1001: + return (u16) len; CHECK: Prefer using the BIT macro #1120: FILE: drivers/net/wireless/broadcom/brcm80211/brcmsmac/rate.h:27: +#define BRCMS_SHORT_PREAMBLE (1 << 0) CHECK: Prefer using the BIT macro #1121: FILE: drivers/net/wireless/broadcom/brcm80211/brcmsmac/rate.h:28: +#define BRCMS_GF_PREAMBLE (1 << 1) CHECK: Prefer using the BIT macro #1122: FILE: drivers/net/wireless/broadcom/brcm80211/brcmsmac/rate.h:29: +#define BRCMS_MM_PREAMBLE (1 << 2) total: 0 errors, 1 warnings, 8 checks, 1126 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Commit 8bd150ba2ab2 ("wifi: brcmsmac: move the PLCP and frame timing helpers to rate.c") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE FILE_PATH_CHANGES GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. total: 0 errors, 1 warnings, 8 checks, 1126 lines checked