1: ca40ff29881c ! 1: 996eb12f1785 wil6210: Remove %pK and %p @@ Metadata Author: Sebastian Andrzej Siewior   ## Commit message ## - wil6210: Remove %pK and %p + wil6210: Replace %pK with %p  Commit 71338aa7d050c ("net: convert %p usage to %pK") which is from 2011 and changed the %p annotation for pointer to %pK. Back then the @@ Commit message Things changed over time. The default behaviour for %p is now to print a hash pointer which does not leak the address but allows to correlate if two pointers are equal. I intend to remove %pK from the library. - The policy on %p is to not introduce new ones. This is somehow in - between since it already exists.  - The driver uses %p to print the address of skb, %p for the address of a - transfer ring and %pK for the address of the status ring. - For the skb it is probably enough to print if there is one mapped. The - address of the ring probably not matter given the physical is address is - shown and it is virtually mapped. - - Remove the %p and %pK line from wil_print_.*() so it does not end in - debugfs' output (debugfs is not ABI so removing does not break - anything). - Replace the skb pointer with yes/ no. + Replace %pK with %pK in order to retain the pointer output for + debugging.  Signed-off-by: Sebastian Andrzej Siewior   ## drivers/net/wireless/ath/wil6210/debugfs.c ## -@@ drivers/net/wireless/ath/wil6210/debugfs.c: static void wil_print_ring(struct seq_file *s, struct wil6210_priv *wil, -  - seq_printf(s, "RING %s = {\n", name); - seq_printf(s, " pa = %pad\n", &ring->pa); -- seq_printf(s, " va = 0x%p\n", ring->va); - seq_printf(s, " size = %d\n", ring->size); - if (wil->use_enhanced_dma_hw && ring->is_rx) - seq_printf(s, " swtail = %u\n", *ring->edma_rx_swtail.va);  @@ drivers/net/wireless/ath/wil6210/debugfs.c: static void wil_print_sring(struct seq_file *s, struct wil6210_priv *wil, seq_printf(s, "Status Ring %s [ %d ] = {\n", sring->is_rx ? "RX" : "TX", sring_idx); seq_printf(s, " pa = %pad\n", &sring->pa);  - seq_printf(s, " va = 0x%pK\n", sring->va); ++ seq_printf(s, " va = 0x%p\n", sring->va); seq_printf(s, " size = %d\n", sring->size); seq_printf(s, " elem_size = %zu\n", sring->elem_size); seq_printf(s, " swhead = %d\n", sring->swhead); -@@ drivers/net/wireless/ath/wil6210/debugfs.c: static int txdesc_show(struct seq_file *s, void *data) - u[0], u[1], u[2], u[3]); - seq_printf(s, " DMA = 0x%08x 0x%08x 0x%08x 0x%08x\n", - u[4], u[5], u[6], u[7]); -- seq_printf(s, " SKB = 0x%p\n", skb); -+ seq_printf(s, " SKB = %s\n", skb ? "yes" : "no"); -  - if (skb) { - skb_get(skb);