ERROR: Macros with complex values should be enclosed in parentheses #57: FILE: drivers/net/wireless/realtek/rtw88/rtw8723b.c:20: +#define TRANS_SEQ_END \ + 0xFFFF, \ + RTW_PWR_CUT_ALL_MSK, \ + RTW_PWR_INTF_ALL_MSK, \ + 0, \ + RTW_PWR_CMD_END, 0, 0 BUT SEE: do {} while (0) advice is over-stated in a few situations: The more obvious case is macros, like MODULE_PARM_DESC, invoked at file-scope, where C disallows code (it must be in functions). See $exceptions if you have one to add by name. More troublesome is declarative macros used at top of new scope, like DECLARE_PER_CPU. These might just compile with a do-while-0 wrapper, but would be incorrect. Most of these are handled by detecting struct,union,etc declaration primitives in $exceptions. Theres also macros called inside an if (block), which "return" an expression. These cannot do-while, and need a ({}) wrapper. Enjoy this qualification while we work to improve our heuristics. WARNING: line length of 81 exceeds 80 columns #195: FILE: drivers/net/wireless/realtek/rtw88/rtw8723b.c:158: + {0x0f, 0x0f, 0x0d, 0x0b, 0x08, 0x05, 0x03, 0x01}, /* 10, -11.0dB */ WARNING: line length of 81 exceeds 80 columns #196: FILE: drivers/net/wireless/realtek/rtw88/rtw8723b.c:159: + {0x10, 0x10, 0x0e, 0x0b, 0x08, 0x05, 0x03, 0x01}, /* 11, -10.5dB */ WARNING: line length of 81 exceeds 80 columns #197: FILE: drivers/net/wireless/realtek/rtw88/rtw8723b.c:160: + {0x11, 0x11, 0x0f, 0x0c, 0x09, 0x06, 0x03, 0x01}, /* 12, -10.0dB */ WARNING: line length of 81 exceeds 80 columns #231: FILE: drivers/net/wireless/realtek/rtw88/rtw8723b.c:194: + {0x0f, 0x0f, 0x0d, 0x08, 0x00, 0x00, 0x00, 0x00}, /* 10, -11.0dB */ WARNING: line length of 81 exceeds 80 columns #232: FILE: drivers/net/wireless/realtek/rtw88/rtw8723b.c:195: + {0x10, 0x10, 0x0e, 0x08, 0x00, 0x00, 0x00, 0x00}, /* 11, -10.5dB */ WARNING: line length of 81 exceeds 80 columns #233: FILE: drivers/net/wireless/realtek/rtw88/rtw8723b.c:196: + {0x11, 0x11, 0x0f, 0x09, 0x00, 0x00, 0x00, 0x00}, /* 12, -10.0dB */ WARNING: line length of 81 exceeds 80 columns #260: FILE: drivers/net/wireless/realtek/rtw88/rtw8723b.c:223: +#define RTW_CCK_SWING_TABLE_SIZE ARRAY_SIZE(rtw8732b_cck_swing_table_ch14) WARNING: line length of 85 exceeds 80 columns #898: FILE: drivers/net/wireless/realtek/rtw88/rtw8723b.c:861: + rtw_write16_set(rtwdev, REG_SYS_CLKR, BIT_LOADER_CLK_EN | BIT_ANA8M); WARNING: line length of 83 exceeds 80 columns #913: FILE: drivers/net/wireless/realtek/rtw88/rtw8723b.c:876: + swing = rtw_read32_mask(rtwdev, REG_OFDM_0_XA_TX_IQ_IMBALANCE, 0xffc00000); WARNING: line length of 98 exceeds 80 columns #1380: FILE: drivers/net/wireless/realtek/rtw88/rtw8723b.c:1343: + rtw_write_rf(rtwdev, RF_PATH_A, RF_AC, MASK12BITS, (rf_mode & 0x8ffff) | 0x10000); WARNING: line length of 81 exceeds 80 columns #1396: FILE: drivers/net/wireless/realtek/rtw88/rtw8723b.c:1359: + rtw_write_rf(rtwdev, RF_PATH_A, 0xb0, RFREG_MASK, 0xdffe0); /* LDO OFF */ WARNING: line length of 81 exceeds 80 columns #1522: FILE: drivers/net/wireless/realtek/rtw88/rtw8723b.c:1485: + * 8723d does these two alongside its cck_pd_set, but chip_ops.cck_pd_set WARNING: line length of 82 exceeds 80 columns #1608: FILE: drivers/net/wireless/realtek/rtw88/rtw8723b.c:1571: + rf_cfgch_b = rtw_read_rf(rtwdev, RF_PATH_B, RF_CFGCH, RFREG_MASK); WARNING: line length of 82 exceeds 80 columns #1638: FILE: drivers/net/wireless/realtek/rtw88/rtw8723b.c:1601: + rtw_write_rf(rtwdev, RF_PATH_B, RF_CFGCH, RFREG_MASK, rf_cfgch_b); WARNING: line length of 82 exceeds 80 columns #1642: FILE: drivers/net/wireless/realtek/rtw88/rtw8723b.c:1605: + rf_cfgch_b = rtw_read_rf(rtwdev, RF_PATH_B, RF_CFGCH, RFREG_MASK); WARNING: line length of 81 exceeds 80 columns #1729: FILE: drivers/net/wireless/realtek/rtw88/rtw8723b.c:1692: + struct phy_status_8703b *phy_status = (struct phy_status_8703b *)phy_raw; WARNING: line length of 81 exceeds 80 columns #1747: FILE: drivers/net/wireless/realtek/rtw88/rtw8723b.c:1710: + struct phy_status_8703b *phy_status = (struct phy_status_8703b *)phy_raw; WARNING: line length of 82 exceeds 80 columns #1761: FILE: drivers/net/wireless/realtek/rtw88/rtw8723b.c:1724: + pkt_stat->rx_snr[RF_PATH_A] = (s8)(phy_status->path_rxsnr[RF_PATH_A] / 2); WARNING: line length of 82 exceeds 80 columns #1963: FILE: drivers/net/wireless/realtek/rtw88/rtw8723b.c:1926: + rtw_write_rf(rtwdev, RF_PATH_A, RF_MODE_TABLE_DATA0, RFREG_MASK, 0x0003f); WARNING: line length of 82 exceeds 80 columns #1964: FILE: drivers/net/wireless/realtek/rtw88/rtw8723b.c:1927: + rtw_write_rf(rtwdev, RF_PATH_A, RF_MODE_TABLE_DATA1, RFREG_MASK, 0xc7f87); WARNING: line length of 82 exceeds 80 columns #2033: FILE: drivers/net/wireless/realtek/rtw88/rtw8723b.c:1996: + rtw_write_rf(rtwdev, RF_PATH_A, RF_MODE_TABLE_DATA0, RFREG_MASK, 0x0001f); WARNING: line length of 82 exceeds 80 columns #2034: FILE: drivers/net/wireless/realtek/rtw88/rtw8723b.c:1997: + rtw_write_rf(rtwdev, RF_PATH_A, RF_MODE_TABLE_DATA1, RFREG_MASK, 0xf7fb7); WARNING: line length of 82 exceeds 80 columns #2100: FILE: drivers/net/wireless/realtek/rtw88/rtw8723b.c:2063: + rtw_write_rf(rtwdev, RF_PATH_A, RF_MODE_TABLE_DATA0, RFREG_MASK, 0x0001f); WARNING: line length of 82 exceeds 80 columns #2101: FILE: drivers/net/wireless/realtek/rtw88/rtw8723b.c:2064: + rtw_write_rf(rtwdev, RF_PATH_A, RF_MODE_TABLE_DATA1, RFREG_MASK, 0xf7d77); WARNING: line length of 81 exceeds 80 columns #2289: FILE: drivers/net/wireless/realtek/rtw88/rtw8723b.c:2252: + rtw_write_rf(rtwdev, RF_PATH_A, RF_MODE_TABLE_ADDR, RFREG_MASK, 0x30000); WARNING: line length of 82 exceeds 80 columns #2290: FILE: drivers/net/wireless/realtek/rtw88/rtw8723b.c:2253: + rtw_write_rf(rtwdev, RF_PATH_A, RF_MODE_TABLE_DATA0, RFREG_MASK, 0x0001f); WARNING: line length of 82 exceeds 80 columns #2291: FILE: drivers/net/wireless/realtek/rtw88/rtw8723b.c:2254: + rtw_write_rf(rtwdev, RF_PATH_A, RF_MODE_TABLE_DATA1, RFREG_MASK, 0xf7fb7); WARNING: line length of 84 exceeds 80 columns #2381: FILE: drivers/net/wireless/realtek/rtw88/rtw8723b.c:2344: + rtw_write32_mask(rtwdev, REG_OFDM0_XAAGC1, MASKBYTE0, 0x50); WARNING: line length of 91 exceeds 80 columns #2382: FILE: drivers/net/wireless/realtek/rtw88/rtw8723b.c:2345: + rtw_write32_mask(rtwdev, REG_OFDM0_XAAGC1, MASKBYTE0, backup.igia); WARNING: line length of 81 exceeds 80 columns #2395: FILE: drivers/net/wireless/realtek/rtw88/rtw8723b.c:2358: + good = rtw8723x_iqk_similarity_cmp(rtwdev, result, j, i); WARNING: line length of 81 exceeds 80 columns #2441: FILE: drivers/net/wireless/realtek/rtw88/rtw8723b.c:2404: + rtw_write_rf(rtwdev, RF_PATH_A, RF_MODE_TABLE_ADDR, RFREG_MASK, 0x18000); WARNING: line length of 82 exceeds 80 columns #2442: FILE: drivers/net/wireless/realtek/rtw88/rtw8723b.c:2405: + rtw_write_rf(rtwdev, RF_PATH_A, RF_MODE_TABLE_DATA0, RFREG_MASK, 0x0001f); WARNING: line length of 82 exceeds 80 columns #2443: FILE: drivers/net/wireless/realtek/rtw88/rtw8723b.c:2406: + rtw_write_rf(rtwdev, RF_PATH_A, RF_MODE_TABLE_DATA1, RFREG_MASK, 0xe6177); WARNING: line length of 84 exceeds 80 columns #2525: FILE: drivers/net/wireless/realtek/rtw88/rtw8723b.c:2488: + final_ofdm_swing_index - limit_ofdm); WARNING: line length of 82 exceeds 80 columns #2530: FILE: drivers/net/wireless/realtek/rtw88/rtw8723b.c:2493: + rtw8723b_pwrtrack_set_ofdm_pwr(rtwdev, final_ofdm_swing_index, 0); WARNING: line length of 81 exceeds 80 columns #2534: FILE: drivers/net/wireless/realtek/rtw88/rtw8723b.c:2497: + final_cck_swing_index - limit_cck); WARNING: line length of 82 exceeds 80 columns #3031: FILE: drivers/net/wireless/realtek/rtw88/rtw8723b.c:2994: + * Setting this to 7 — like the upstream WARNING: line length of 81 exceeds 80 columns #3032: FILE: drivers/net/wireless/realtek/rtw88/rtw8723b.c:2995: + * default — caused every C2H_RA_REPORT WARNING: line length of 81 exceeds 80 columns #3036: FILE: drivers/net/wireless/realtek/rtw88/rtw8723b.c:2999: + * so the firmware-driven rate adaptation WARNING: line length of 81 exceeds 80 columns #3039: FILE: drivers/net/wireless/realtek/rtw88/rtw8723b.c:3002: + * legacy 8051 8723b/8703b/8723d firmware WARNING: line length of 82 exceeds 80 columns #3041: FILE: drivers/net/wireless/realtek/rtw88/rtw8723b.c:3004: + * older 8821a/8812a chips. byte4..bw fall WARNING: line length of 81 exceeds 80 columns #3043: FILE: drivers/net/wireless/realtek/rtw88/rtw8723b.c:3006: + * rtw_fw_ra_report_iter(), which matches WARNING: line length of 87 exceeds 80 columns #3046: FILE: drivers/net/wireless/realtek/rtw88/rtw8723b.c:3009: + .old_datarate_fb_limit = true, /* likely true; see main-line commit c7706b1 */ total: 1 errors, 43 warnings, 0 checks, 4029 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Commit 1de0ddc7caf0 ("wifi: rtw88: 8723b: add RTL8723B chip support") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE FILE_PATH_CHANGES GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS.