WARNING: line length of 84 exceeds 80 columns #133: FILE: drivers/net/wireless/realtek/rtw88/main.h:789: + u64 ra_mask_last; /* 8723BS SDIO: last mask sent, to gate no_update */ WARNING: line length of 82 exceeds 80 columns #141: FILE: drivers/net/wireless/realtek/rtw88/main.h:837: + /* 8723BS SDIO join-state tracking (see mac80211.c mgd_prepare_tx path) */ CHECK: spinlock_t definition without comment #157: FILE: drivers/net/wireless/realtek/rtw88/main.h:2074: + spinlock_t lock; WARNING: line length of 82 exceeds 80 columns #171: FILE: drivers/net/wireless/realtek/rtw88/main.h:2154: + bool initial_rfk_done; /* 8723BS SDIO: run IQK once, not per IPS-leave */ ERROR: Macros with complex values should be enclosed in parentheses #263: FILE: drivers/net/wireless/realtek/rtw88/rtw8723b.c:18: +#define TRANS_SEQ_END \ + 0xFFFF, \ + RTW_PWR_CUT_ALL_MSK, \ + RTW_PWR_INTF_ALL_MSK, \ + 0, \ + RTW_PWR_CMD_END, 0, 0 BUT SEE: do {} while (0) advice is over-stated in a few situations: The more obvious case is macros, like MODULE_PARM_DESC, invoked at file-scope, where C disallows code (it must be in functions). See $exceptions if you have one to add by name. More troublesome is declarative macros used at top of new scope, like DECLARE_PER_CPU. These might just compile with a do-while-0 wrapper, but would be incorrect. Most of these are handled by detecting struct,union,etc declaration primitives in $exceptions. Theres also macros called inside an if (block), which "return" an expression. These cannot do-while, and need a ({}) wrapper. Enjoy this qualification while we work to improve our heuristics. WARNING: line length of 81 exceeds 80 columns #457: FILE: drivers/net/wireless/realtek/rtw88/rtw8723b.c:212: + {0x0f, 0x0f, 0x0d, 0x0b, 0x08, 0x05, 0x03, 0x01}, /* 10, -11.0dB */ WARNING: line length of 81 exceeds 80 columns #458: FILE: drivers/net/wireless/realtek/rtw88/rtw8723b.c:213: + {0x10, 0x10, 0x0e, 0x0b, 0x08, 0x05, 0x03, 0x01}, /* 11, -10.5dB */ WARNING: line length of 81 exceeds 80 columns #459: FILE: drivers/net/wireless/realtek/rtw88/rtw8723b.c:214: + {0x11, 0x11, 0x0f, 0x0c, 0x09, 0x06, 0x03, 0x01}, /* 12, -10.0dB */ WARNING: line length of 81 exceeds 80 columns #496: FILE: drivers/net/wireless/realtek/rtw88/rtw8723b.c:251: + {0x0f, 0x0f, 0x0d, 0x08, 0x00, 0x00, 0x00, 0x00}, /* 10, -11.0dB */ WARNING: line length of 81 exceeds 80 columns #497: FILE: drivers/net/wireless/realtek/rtw88/rtw8723b.c:252: + {0x10, 0x10, 0x0e, 0x08, 0x00, 0x00, 0x00, 0x00}, /* 11, -10.5dB */ WARNING: line length of 81 exceeds 80 columns #498: FILE: drivers/net/wireless/realtek/rtw88/rtw8723b.c:253: + {0x11, 0x11, 0x0f, 0x09, 0x00, 0x00, 0x00, 0x00}, /* 12, -10.0dB */ WARNING: line length of 81 exceeds 80 columns #525: FILE: drivers/net/wireless/realtek/rtw88/rtw8723b.c:280: +#define RTW_CCK_SWING_TABLE_SIZE ARRAY_SIZE(rtw8732b_cck_swing_table_ch14) WARNING: line length of 88 exceeds 80 columns #1032: FILE: drivers/net/wireless/realtek/rtw88/rtw8723b.c:787: + /* used in rtw8723x_pwrtrack_set_xtal which is not done in 8723b vendor driver*/ WARNING: line length of 85 exceeds 80 columns #1184: FILE: drivers/net/wireless/realtek/rtw88/rtw8723b.c:939: + rtw_write16_set(rtwdev, REG_SYS_CLKR, BIT_LOADER_CLK_EN | BIT_ANA8M); WARNING: line length of 83 exceeds 80 columns #1202: FILE: drivers/net/wireless/realtek/rtw88/rtw8723b.c:957: + swing = rtw_read32_mask(rtwdev, REG_OFDM_0_XA_TX_IQ_IMBALANCE, 0xffc00000); WARNING: line length of 85 exceeds 80 columns #1667: FILE: drivers/net/wireless/realtek/rtw88/rtw8723b.c:1422: + /* Suggested by designer timchen. Change beacon AIFS to the largest number */ WARNING: line length of 96 exceeds 80 columns #1668: FILE: drivers/net/wireless/realtek/rtw88/rtw8723b.c:1423: + /* beacause test chip does not contension before sending beacon. by tynli. 2009.11.03 */ WARNING: line length of 98 exceeds 80 columns #1722: FILE: drivers/net/wireless/realtek/rtw88/rtw8723b.c:1477: + rtw_write_rf(rtwdev, RF_PATH_A, RF_AC, MASK12BITS, (rf_mode & 0x8ffff) | 0x10000); WARNING: line length of 81 exceeds 80 columns #1738: FILE: drivers/net/wireless/realtek/rtw88/rtw8723b.c:1493: + rtw_write_rf(rtwdev, RF_PATH_A, 0xb0, RFREG_MASK, 0xdffe0); /* LDO OFF */ WARNING: line length of 81 exceeds 80 columns #1886: FILE: drivers/net/wireless/realtek/rtw88/rtw8723b.c:1641: + * 8723d does these two alongside its cck_pd_set, but chip_ops.cck_pd_set WARNING: line length of 82 exceeds 80 columns #2010: FILE: drivers/net/wireless/realtek/rtw88/rtw8723b.c:1765: + rf_cfgch_b = rtw_read_rf(rtwdev, RF_PATH_B, RF_CFGCH, RFREG_MASK); WARNING: line length of 82 exceeds 80 columns #2040: FILE: drivers/net/wireless/realtek/rtw88/rtw8723b.c:1795: + rtw_write_rf(rtwdev, RF_PATH_B, RF_CFGCH, RFREG_MASK, rf_cfgch_b); WARNING: line length of 82 exceeds 80 columns #2044: FILE: drivers/net/wireless/realtek/rtw88/rtw8723b.c:1799: + rf_cfgch_b = rtw_read_rf(rtwdev, RF_PATH_B, RF_CFGCH, RFREG_MASK); WARNING: line length of 81 exceeds 80 columns #2151: FILE: drivers/net/wireless/realtek/rtw88/rtw8723b.c:1906: + struct phy_status_8703b *phy_status = (struct phy_status_8703b *)phy_raw; WARNING: line length of 81 exceeds 80 columns #2172: FILE: drivers/net/wireless/realtek/rtw88/rtw8723b.c:1927: + struct phy_status_8703b *phy_status = (struct phy_status_8703b *)phy_raw; WARNING: line length of 82 exceeds 80 columns #2186: FILE: drivers/net/wireless/realtek/rtw88/rtw8723b.c:1941: + pkt_stat->rx_snr[RF_PATH_A] = (s8)(phy_status->path_rxsnr[RF_PATH_A] / 2); WARNING: line length of 83 exceeds 80 columns #2793: FILE: drivers/net/wireless/realtek/rtw88/rtw8723b.c:2548: + /* NOTE: the vendor driver does path B only for 2T, but rtl8723b is 1T1R */ WARNING: line length of 84 exceeds 80 columns #2840: FILE: drivers/net/wireless/realtek/rtw88/rtw8723b.c:2595: + rtw_write32_mask(rtwdev, REG_OFDM0_XAAGC1, MASKBYTE0, 0x50); WARNING: line length of 91 exceeds 80 columns #2841: FILE: drivers/net/wireless/realtek/rtw88/rtw8723b.c:2596: + rtw_write32_mask(rtwdev, REG_OFDM0_XAAGC1, MASKBYTE0, backup.igia); WARNING: line length of 81 exceeds 80 columns #2854: FILE: drivers/net/wireless/realtek/rtw88/rtw8723b.c:2609: + good = rtw8723x_iqk_similarity_cmp(rtwdev, result, j, i); WARNING: line length of 84 exceeds 80 columns #3000: FILE: drivers/net/wireless/realtek/rtw88/rtw8723b.c:2755: + final_ofdm_swing_index - limit_ofdm); WARNING: line length of 82 exceeds 80 columns #3005: FILE: drivers/net/wireless/realtek/rtw88/rtw8723b.c:2760: + rtw8723b_pwrtrack_set_ofdm_pwr(rtwdev, final_ofdm_swing_index, 0); WARNING: line length of 81 exceeds 80 columns #3009: FILE: drivers/net/wireless/realtek/rtw88/rtw8723b.c:2764: + final_cck_swing_index - limit_cck); WARNING: line length of 82 exceeds 80 columns #3522: FILE: drivers/net/wireless/realtek/rtw88/rtw8723b.c:3277: + * Setting this to 7 — like the upstream WARNING: line length of 81 exceeds 80 columns #3523: FILE: drivers/net/wireless/realtek/rtw88/rtw8723b.c:3278: + * default — caused every C2H_RA_REPORT WARNING: line length of 81 exceeds 80 columns #3527: FILE: drivers/net/wireless/realtek/rtw88/rtw8723b.c:3282: + * so the firmware-driven rate adaptation WARNING: line length of 81 exceeds 80 columns #3530: FILE: drivers/net/wireless/realtek/rtw88/rtw8723b.c:3285: + * legacy 8051 8723b/8703b/8723d firmware WARNING: line length of 82 exceeds 80 columns #3532: FILE: drivers/net/wireless/realtek/rtw88/rtw8723b.c:3287: + * older 8821a/8812a chips. byte4..bw fall WARNING: line length of 81 exceeds 80 columns #3534: FILE: drivers/net/wireless/realtek/rtw88/rtw8723b.c:3289: + * rtw_fw_ra_report_iter(), which matches WARNING: line length of 87 exceeds 80 columns #3537: FILE: drivers/net/wireless/realtek/rtw88/rtw8723b.c:3292: + .old_datarate_fb_limit = true, /* likely true; see main-line commit c7706b1 */ total: 1 errors, 38 warnings, 1 checks, 4482 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Commit 86f415f90444 ("wifi: rtw88: add RTL8723B chip support") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE FILE_PATH_CHANGES GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS.